From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50A50C28CC5 for ; Wed, 5 Jun 2019 23:58:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 325AA20866 for ; Wed, 5 Jun 2019 23:58:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726825AbfFEX6I (ORCPT ); Wed, 5 Jun 2019 19:58:08 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:42540 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726510AbfFEX6H (ORCPT ); Wed, 5 Jun 2019 19:58:07 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id ADE6D10081D88; Wed, 5 Jun 2019 16:58:06 -0700 (PDT) Date: Wed, 05 Jun 2019 16:58:06 -0700 (PDT) Message-Id: <20190605.165806.1922138006892103132.davem@davemloft.net> To: info@metux.net Cc: linux-kernel@vger.kernel.org, pshelar@ovn.org, netdev@vger.kernel.org, dev@openvswitch.org Subject: Re: [PATCH] net: openvswitch: drop unneeded likely() call around IS_ERR() From: David Miller In-Reply-To: <1559768800-18763-1-git-send-email-info@metux.net> References: <1559768800-18763-1-git-send-email-info@metux.net> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 05 Jun 2019 16:58:07 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Enrico Weigelt, metux IT consult" Date: Wed, 5 Jun 2019 23:06:40 +0200 > From: Enrico Weigelt > > IS_ERR() already calls unlikely(), so this extra likely() call > around the !IS_ERR() is not needed. > > Signed-off-by: Enrico Weigelt Applied.