[cip-dev] porting iwg20m to isar-cip-core

[cip-dev] porting iwg20m to isar-cip-core

[Daniel Sangorrin]

Hi Jan,

I tried to add a recipe for iwg20m's u-boot. That board
only supports version 2013.01 and does not support distro boot.

There were a couple of build errors, one of them I couldn't
easily solve (unrecognized option '-Wl,-z,relro'). 
But for now, I wanted to confirm if the structure of the recipe is OK.

I wanted to use uImage because that's what is used in the
iwg20m manual, and it's known to work on Deby as well. 
Ref: https://gitlab.com/cip-project/cip-core/deby/blob/master/poky/meta-cip-iwg20m/README.IWG20M.txt
Do you suggest that we should use bootz instead of bootm?
Is uImage not recommended or something? I have used uImage in many boards.

As for the kernel image location, since we do not have u-boot
distro support I will move it manually from the root partition
to the boot partition using a postinstall script inside the
customizations recipe. If there is a better option please 
let me know.

[isar-cip-core] iwg20m: temporary patch for review v2

Thanks,
Daniel

[cip-dev] [isar-cip-core] iwg20m: temporary patch for review v2

[Daniel Sangorrin]

I added a revipe for building iwg20m's u-boot.
This u-boot is very old (2013) and had some compile problems.

- u-boot fatal error: linux/compiler-gcc6.h: No such file or directory
- arm-linux-gnueabihf-ld.bfd: unrecognized option '-Wl,-z,relro'

I solved the first one but not the second one.

Other than that, this u-boot version does not have distro boot
so we can't specify boot environment variables on the image.

Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
---
 board-iwg20m.yml                            |  16 ++
 conf/machine/iwg20m.conf                    |  26 +++
 recipes-bsp/u-boot/u-boot_2013.01.bb        |  26 +++
 recipes-kernel/linux/files/iwg20m_defconfig | 230 ++++++++++++++++++++
 wic/iwg20m.wks                              |  24 ++
 5 files changed, 322 insertions(+)
 create mode 100644 board-iwg20m.yml
 create mode 100644 conf/machine/iwg20m.conf
 create mode 100644 recipes-bsp/u-boot/u-boot_2013.01.bb
 create mode 100644 recipes-kernel/linux/files/iwg20m_defconfig
 create mode 100644 wic/iwg20m.wks

diff --git a/board-iwg20m.yml b/board-iwg20m.yml
new file mode 100644
index 0000000..fbb2a2e
--- /dev/null
+++ b/board-iwg20m.yml
@@ -0,0 +1,16 @@
+#
+# CIP Core, generic profile
+#
+# Copyright (c) Toshiba corp., 2019
+#
+# Authors:
+#  Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
+#
+# SPDX-License-Identifier: MIT
+#
+
+header:
+  version: 8
+
+machine: iwg20m
+target: cip-core-image
diff --git a/conf/machine/iwg20m.conf b/conf/machine/iwg20m.conf
new file mode 100644
index 0000000..39b7ed0
--- /dev/null
+++ b/conf/machine/iwg20m.conf
@@ -0,0 +1,26 @@
+#
+# CIP Core, generic profile
+#
+# Copyright (c) Toshiba corp. 2019
+#
+# SPDX-License-Identifier: MIT
+#
+DISTRO_ARCH = "armhf"
+
+# see wic/iwg20m.wks
+IMAGE_TYPE = "wic-img"
+
+# sets serial login getty
+MACHINE_SERIAL = "ttySC0"
+BAUDRATE_TTY = "115200"
+
+# u-boot
+U_BOOT_CONFIG_iwg20m = "iwg20m_q7_config"
+U_BOOT_BIN_iwg20m = "u-boot.bin"
+IMAGER_INSTALL += "u-boot-iwg20m"
+IMAGER_BUILD_DEPS += "u-boot-iwg20m"
+IMAGE_INSTALL += "u-boot-tools"
+
+# Boot partition files
+DTB_FILE = "r8a7743-iwg20d-q7.dtb"
+IMAGE_BOOT_FILES = "${DTB_FILE}"
diff --git a/recipes-bsp/u-boot/u-boot_2013.01.bb b/recipes-bsp/u-boot/u-boot_2013.01.bb
new file mode 100644
index 0000000..557c4a1
--- /dev/null
+++ b/recipes-bsp/u-boot/u-boot_2013.01.bb
@@ -0,0 +1,26 @@
+#
+# CIP Core, generic profile
+#
+# Copyright (c) Toshiba corp., 2019
+#
+# Authors:
+#  Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
+#
+# SPDX-License-Identifier: MIT
+#
+
+require recipes-bsp/u-boot/u-boot-custom.inc
+
+SRC_URI += " \
+    git://github.com/renesas-rz/renesas-u-boot-cip.git;branch=2013.01.01/rzg1-iwave;protocol=https \
+    "
+
+SRCREV = "07690dd532b726752faafa3bdfb70152f820901a"
+
+S = "${WORKDIR}/git"
+
+do_prepare_build_append() {
+    # u-boot fatal error: linux/compiler-gcc6.h: No such file or directory
+    cp ${S}/include/linux/compiler-gcc5.h ${S}/include/linux/compiler-gcc6.h
+    # TODO: arm-linux-gnueabihf-ld.bfd: unrecognized option '-Wl,-z,relro'
+}
diff --git a/recipes-kernel/linux/files/iwg20m_defconfig b/recipes-kernel/linux/files/iwg20m_defconfig
new file mode 100644
index 0000000..56b3c14
--- /dev/null
+++ b/recipes-kernel/linux/files/iwg20m_defconfig
@@ -0,0 +1,230 @@
+# to boot from the SD Card
+CONFIG_EXT4_FS=y
+CONFIG_EXT4_USE_FOR_EXT2=y
+
+# to boot from an initramfs
+CONFIG_BLK_DEV_RAM=y
+CONFIG_BLK_DEV_RAM_COUNT=4
+CONFIG_BLK_DEV_RAM_SIZE=250000
+
+# shmobile_defconfig
+CONFIG_SYSVIPC=y
+CONFIG_NO_HZ=y
+CONFIG_IKCONFIG=y
+CONFIG_IKCONFIG_PROC=y
+CONFIG_LOG_BUF_SHIFT=16
+CONFIG_BLK_DEV_INITRD=y
+CONFIG_CC_OPTIMIZE_FOR_SIZE=y
+CONFIG_SYSCTL_SYSCALL=y
+CONFIG_EMBEDDED=y
+CONFIG_PERF_EVENTS=y
+CONFIG_SLAB=y
+CONFIG_ARCH_SHMOBILE_MULTI=y
+CONFIG_ARCH_EMEV2=y
+CONFIG_ARCH_R7S72100=y
+CONFIG_ARCH_R8A73A4=y
+CONFIG_ARCH_R8A7740=y
+CONFIG_ARCH_R8A7743=y
+CONFIG_ARCH_R8A7745=y
+CONFIG_ARCH_R8A77470=y
+CONFIG_ARCH_R8A7778=y
+CONFIG_ARCH_R8A7779=y
+CONFIG_ARCH_R8A7790=y
+CONFIG_ARCH_R8A7791=y
+CONFIG_ARCH_R8A7793=y
+CONFIG_ARCH_R8A7794=y
+CONFIG_ARCH_SH73A0=y
+CONFIG_CPU_BPREDICT_DISABLE=y
+CONFIG_PL310_ERRATA_588369=y
+CONFIG_ARM_ERRATA_754322=y
+CONFIG_PCI=y
+CONFIG_PCI_RCAR_GEN2=y
+CONFIG_PCI_RCAR_GEN2_PCIE=y
+CONFIG_SMP=y
+CONFIG_SCHED_MC=y
+CONFIG_HAVE_ARM_ARCH_TIMER=y
+CONFIG_NR_CPUS=8
+CONFIG_AEABI=y
+CONFIG_HIGHMEM=y
+CONFIG_CMA=y
+CONFIG_ZBOOT_ROM_TEXT=0x0
+CONFIG_ZBOOT_ROM_BSS=0x0
+CONFIG_ARM_APPENDED_DTB=y
+CONFIG_KEXEC=y
+CONFIG_CPU_FREQ=y
+CONFIG_CPU_FREQ_STAT_DETAILS=y
+CONFIG_CPU_FREQ_GOV_POWERSAVE=y
+CONFIG_CPU_FREQ_GOV_USERSPACE=y
+CONFIG_CPU_FREQ_GOV_ONDEMAND=y
+CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y
+CONFIG_CPUFREQ_DT=y
+CONFIG_VFP=y
+CONFIG_NEON=y
+# CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set
+CONFIG_NET=y
+CONFIG_PACKET=y
+CONFIG_UNIX=y
+CONFIG_INET=y
+CONFIG_IP_PNP=y
+CONFIG_IP_PNP_DHCP=y
+CONFIG_CAN=y
+CONFIG_CAN_RCAR=y
+CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
+CONFIG_DEVTMPFS=y
+CONFIG_DEVTMPFS_MOUNT=y
+CONFIG_DMA_CMA=y
+CONFIG_CMA_SIZE_MBYTES=64
+CONFIG_SIMPLE_PM_BUS=y
+CONFIG_MTD=y
+CONFIG_MTD_BLOCK=y
+CONFIG_MTD_M25P80=y
+CONFIG_MTD_SPI_NOR=y
+CONFIG_EEPROM_AT24=y
+CONFIG_BLK_DEV_SD=y
+CONFIG_ATA=y
+CONFIG_SATA_RCAR=y
+CONFIG_NETDEVICES=y
+# CONFIG_NET_VENDOR_ARC is not set
+# CONFIG_NET_CADENCE is not set
+# CONFIG_NET_VENDOR_BROADCOM is not set
+# CONFIG_NET_VENDOR_CIRRUS is not set
+# CONFIG_NET_VENDOR_FARADAY is not set
+# CONFIG_NET_VENDOR_INTEL is not set
+# CONFIG_NET_VENDOR_MARVELL is not set
+# CONFIG_NET_VENDOR_MICREL is not set
+# CONFIG_NET_VENDOR_NATSEMI is not set
+CONFIG_SH_ETH=y
+CONFIG_RAVB=y
+# CONFIG_NET_VENDOR_SEEQ is not set
+CONFIG_SMSC911X=y
+# CONFIG_NET_VENDOR_STMICRO is not set
+# CONFIG_NET_VENDOR_VIA is not set
+# CONFIG_NET_VENDOR_WIZNET is not set
+CONFIG_SMSC_PHY=y
+CONFIG_MICREL_PHY=y
+# CONFIG_INPUT_MOUSEDEV_PSAUX is not set
+CONFIG_INPUT_EVDEV=y
+CONFIG_KEYBOARD_GPIO=y
+# CONFIG_INPUT_MOUSE is not set
+CONFIG_INPUT_TOUCHSCREEN=y
+CONFIG_TOUCHSCREEN_ST1232=y
+CONFIG_INPUT_MISC=y
+CONFIG_INPUT_ADXL34X=y
+# CONFIG_LEGACY_PTYS is not set
+CONFIG_SERIAL_8250=y
+CONFIG_SERIAL_8250_CONSOLE=y
+CONFIG_SERIAL_8250_EM=y
+CONFIG_SERIAL_SH_SCI=y
+CONFIG_SERIAL_SH_SCI_NR_UARTS=20
+CONFIG_SERIAL_SH_SCI_CONSOLE=y
+CONFIG_I2C_CHARDEV=y
+CONFIG_I2C_GPIO=y
+CONFIG_I2C_RIIC=y
+CONFIG_I2C_SH_MOBILE=y
+CONFIG_I2C_RCAR=y
+CONFIG_SPI=y
+CONFIG_SPI_RSPI=y
+CONFIG_SPI_SH_MSIOF=y
+CONFIG_SPI_SH_HSPI=y
+CONFIG_GPIO_EM=y
+CONFIG_GPIO_RCAR=y
+CONFIG_GPIO_PCF857X=y
+CONFIG_POWER_SUPPLY=y
+CONFIG_POWER_RESET=y
+CONFIG_POWER_RESET_RMOBILE=y
+# CONFIG_HWMON is not set
+CONFIG_THERMAL=y
+CONFIG_CPU_THERMAL=y
+CONFIG_RCAR_THERMAL=y
+CONFIG_WATCHDOG=y
+CONFIG_DA9063_WATCHDOG=y
+CONFIG_RENESAS_WDT=y
+CONFIG_MFD_AS3711=y
+CONFIG_MFD_DA9063=y
+CONFIG_REGULATOR_FIXED_VOLTAGE=y
+CONFIG_REGULATOR_AS3711=y
+CONFIG_REGULATOR_DA9210=y
+CONFIG_REGULATOR_GPIO=y
+CONFIG_REGULATOR_MAX8973=y
+CONFIG_MEDIA_SUPPORT=y
+CONFIG_MEDIA_CAMERA_SUPPORT=y
+CONFIG_MEDIA_CONTROLLER=y
+CONFIG_VIDEO_V4L2_SUBDEV_API=y
+CONFIG_V4L_PLATFORM_DRIVERS=y
+CONFIG_SOC_CAMERA=y
+CONFIG_SOC_CAMERA_PLATFORM=y
+CONFIG_VIDEO_RCAR_VIN=y
+CONFIG_V4L_MEM2MEM_DRIVERS=y
+CONFIG_VIDEO_RENESAS_VSP1=y
+# CONFIG_MEDIA_SUBDRV_AUTOSELECT is not set
+CONFIG_VIDEO_ADV7180=y
+CONFIG_VIDEO_ML86V7667=y
+CONFIG_DRM=y
+CONFIG_DRM_I2C_ADV7511=y
+CONFIG_DRM_RCAR_DU=y
+CONFIG_DRM_RCAR_HDMI=y
+CONFIG_DRM_RCAR_LVDS=y
+CONFIG_FB_SH_MOBILE_LCDC=y
+CONFIG_FB_SH_MOBILE_MERAM=y
+# CONFIG_LCD_CLASS_DEVICE is not set
+# CONFIG_BACKLIGHT_GENERIC is not set
+CONFIG_BACKLIGHT_PWM=y
+CONFIG_BACKLIGHT_AS3711=y
+CONFIG_SOUND=y
+CONFIG_SND=y
+CONFIG_SND_SOC=y
+CONFIG_SND_SOC_SH4_FSI=y
+CONFIG_SND_SOC_RCAR=y
+CONFIG_SND_SOC_RSRC_CARD=y
+CONFIG_SND_SOC_AK4642=y
+CONFIG_SND_SOC_SGTL5000=y
+CONFIG_SND_SOC_WM8978=y
+CONFIG_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_RCAR=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_R8A66597_HCD=y
+CONFIG_USB_RENESAS_USBHS=y
+CONFIG_USB_RCAR_PHY=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_RENESAS_USBHS_UDC=y
+CONFIG_USB_ETH=y
+CONFIG_MMC=y
+CONFIG_MMC_SDHI=y
+CONFIG_MMC_SH_MMCIF=y
+CONFIG_NEW_LEDS=y
+CONFIG_LEDS_CLASS=y
+CONFIG_LEDS_GPIO=y
+CONFIG_RTC_CLASS=y
+CONFIG_RTC_DRV_RS5C372=y
+CONFIG_RTC_DRV_BQ32K=y
+CONFIG_RTC_DRV_S35390A=y
+CONFIG_RTC_DRV_RX8581=y
+CONFIG_DMADEVICES=y
+CONFIG_SH_DMAE=y
+CONFIG_RCAR_DMAC=y
+CONFIG_RENESAS_USB_DMAC=y
+# CONFIG_IOMMU_SUPPORT is not set
+CONFIG_IIO=y
+CONFIG_AK8975=y
+CONFIG_PWM=y
+CONFIG_PWM_RCAR=y
+CONFIG_PWM_RENESAS_TPU=y
+CONFIG_GENERIC_PHY=y
+CONFIG_PHY_RCAR_GEN2=y
+# CONFIG_DNOTIFY is not set
+CONFIG_MSDOS_FS=y
+CONFIG_VFAT_FS=y
+CONFIG_TMPFS=y
+# CONFIG_MISC_FILESYSTEMS is not set
+CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
+CONFIG_NFS_V4=y
+CONFIG_NFS_V4_1=y
+CONFIG_ROOT_NFS=y
+CONFIG_NLS_CODEPAGE_437=y
+CONFIG_NLS_ISO8859_1=y
+# CONFIG_ENABLE_WARN_DEPRECATED is not set
+# CONFIG_ENABLE_MUST_CHECK is not set
+# CONFIG_ARM_UNWIND is not set
diff --git a/wic/iwg20m.wks b/wic/iwg20m.wks
new file mode 100644
index 0000000..107fec9
--- /dev/null
+++ b/wic/iwg20m.wks
@@ -0,0 +1,24 @@
+#
+# CIP Core, generic profile
+#
+# Copyright (c) Toshiba corp., 2019
+#
+# Authors:
+#  Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
+#
+# SPDX-License-Identifier: MIT
+#
+
+# [Note] u-boot is in an SPI flash memory, it can be flashed from Linux
+# but if that fails then you need a JTAG debugger to unbrick it.
+# The u-boot version is too old (2013.01) and does not support
+# "Generic Distro Configuration Concept" (a.k.a. distro boot).
+# For that reason, you need to specify the u-boot variables to boot
+# from the micro SDCard on top of the default variables
+# Ref: https://gitlab.com/cip-project/cip-core/deby/blob/master/poky/meta-cip-iwg20m/README.IWG20M.txt
+
+# SDCard Boot partition (copies files in IMAGE_BOOT_FILES)
+part /boot --source bootimg-partition --ondisk mmcblk0 --fstype vfat --label boot --align 1 --size 32M --extra-space 0
+
+# Rootfs partition
+part / --source rootfs --ondisk mmcblk0 --fstype ext4 --label root --align 1024 --size 2G --active
-- 
2.17.1

[cip-dev] porting iwg20m to isar-cip-core

[daniel.sangorrin at toshiba.co.jp]

> I tried to add a recipe for iwg20m's u-boot. That board
> only supports version 2013.01 and does not support distro boot.
[snip]
> As for the kernel image location, since we do not have u-boot
> distro support I will move it manually from the root partition
> to the boot partition using a postinstall script inside the
> customizations recipe. If there is a better option please
> let me know.

OK, I figured it out. I just had to define KERNEL_IMAGE="zImage" (so that it gets deployed) and then add that variable to IMAGE_BOOT_FILES.

Thanks,
Daniel

[cip-dev] porting iwg20m to isar-cip-core

[Jan Kiszka]

On 05.06.19 07:34, daniel.sangorrin at toshiba.co.jp wrote:
>> I tried to add a recipe for iwg20m's u-boot. That board
>> only supports version 2013.01 and does not support distro boot.
> [snip]
>> As for the kernel image location, since we do not have u-boot
>> distro support I will move it manually from the root partition
>> to the boot partition using a postinstall script inside the
>> customizations recipe. If there is a better option please
>> let me know.
> 
> OK, I figured it out. I just had to define KERNEL_IMAGE="zImage" (so that it gets deployed) and then add that variable to IMAGE_BOOT_FILES.
> 

I would definitely recommend following the pre-existing pattern as they are 
working on a lot of different boards already. Primarily on ARMv8 (where most 
things are much better), but also on quite a few ARMv7 boards. That will avoid 
having to invent too much board-specific things over and over again.

Missing distro boot is a PITA, I know, but the best workaround is specifying 
what missing command the user should inject into the legacy U-Boot so that it 
loads the boot.scr from the rootfs and has the required board-specific env vars 
set. If you can even rebuild the U-Boot, you may also inject those commands into 
the default env, just by enhancing the defconfig.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

[cip-dev] porting iwg20m to isar-cip-core

[Jan Kiszka]

On 05.06.19 04:16, Daniel Sangorrin wrote:
> I wanted to use uImage because that's what is used in the
> iwg20m manual, and it's known to work on Deby as well.
> Ref: https://gitlab.com/cip-project/cip-core/deby/blob/master/poky/meta-cip-iwg20m/README.IWG20M.txt
> Do you suggest that we should use bootz instead of bootm?
> Is uImage not recommended or something? I have used uImage in many boards.

BTW, we chose bootz (and distro boot) in order to be able to boot also stock 
Debian kernels - which work on a (slowly) increasing number of boards. I.e. Isar 
is modeled around the ideal case, not legacy ones.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

[cip-dev] porting iwg20m to isar-cip-core

[daniel.sangorrin at toshiba.co.jp]

Hi Jan,

> From: isar-users at googlegroups.com <isar-users@googlegroups.com> On Behalf Of Jan Kiszka
> On 05.06.19 04:16, Daniel Sangorrin wrote:
> > I wanted to use uImage because that's what is used in the
> > iwg20m manual, and it's known to work on Deby as well.
> > Ref:
> https://gitlab.com/cip-project/cip-core/deby/blob/master/poky/meta-cip-iwg20m/README.IWG20M.txt
> > Do you suggest that we should use bootz instead of bootm?
> > Is uImage not recommended or something? I have used uImage in many boards.
> 
> BTW, we chose bootz (and distro boot) in order to be able to boot also stock
> Debian kernels - which work on a (slowly) increasing number of boards. I.e. Isar
> is modeled around the ideal case, not legacy ones.

I was surprised to see so many u-boot debian packages:
https://packages.debian.org/search?keywords=u-boot

For now, please let me go the legacy way (ask users to 'setenv' things). Do you have an example of how to emulate boot.scr on older u-boot versions. I

Iwamatsu-san is going to upgrade/mainstream the u-boot support for Renesas iwg20m. Once that is done I will modify the recipe.
# One thing though: if the flash process fails, you really need to get a JTAG device to unbrick the board (not sure if OpenOCD JTAG devices would be supported).

Thanks,
Daniel

> --
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux
> 
> --
> You received this message because you are subscribed to the Google Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to
> isar-users+unsubscribe at googlegroups.com.
> To post to this group, send email to isar-users at googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/isar-users/d0acd9f6-2f30-2407-c202-5600b3750352%40siemens.com.
> For more options, visit https://groups.google.com/d/optout.

[cip-dev] [isar-cip-core] iwg20m: temporary patch for review v2

[Ben Hutchings]

On Wed, 2019-06-05 at 11:16 +0900, Daniel Sangorrin wrote:
> I added a revipe for building iwg20m's u-boot.
> This u-boot is very old (2013) and had some compile problems.
> 
> - u-boot fatal error: linux/compiler-gcc6.h: No such file or directory
> - arm-linux-gnueabihf-ld.bfd: unrecognized option '-Wl,-z,relro'
>
> I solved the first one but not the second one.
[...]

"-Wl,-z,relro" is a gcc option which should result in passing
"-z relro" to the linker.  Perhaps a Makefile is invoking $(LD) with
$(LDFLAGS), where it should be invoking $(CC) instead?

In any case, this is a hardening option for dynamically linked binaries
and I don't think it makes any difference to the kernel or u-boot.

Ben.

-- 
Ben Hutchings, Software Developer                ?        Codethink Ltd
https://www.codethink.co.uk/                 Dale House, 35 Dale Street
                                     Manchester, M1 2HF, United Kingdom