From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B068FC282DE for ; Wed, 5 Jun 2019 06:10:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 768A520866 for ; Wed, 5 Jun 2019 06:10:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559715003; bh=wTYwhYyVAwH/37258YCULY4b/DDUHUmOmKJEh2hkUE4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=GfhdvQSoe8EsijxLkoYJ7sYMlppprmx/PAaNUbU4XL/DFLO+fQLIus/7TnCqAtlT5 ZwPTCVJ8FXJyaUdW9PdKiUVJ0y2vFw0NCAOJ9/CwESnPHUEYV0rTOcTOYWx+7c1DWb iHItHGoDlEqRkAqi+zXjEVIPh6YSnvE1+9Jjc0UY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726572AbfFEGKC (ORCPT ); Wed, 5 Jun 2019 02:10:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:53696 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726086AbfFEGKC (ORCPT ); Wed, 5 Jun 2019 02:10:02 -0400 Received: from dragon (li1264-180.members.linode.com [45.79.165.180]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C9D3D2075C; Wed, 5 Jun 2019 06:09:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559715001; bh=wTYwhYyVAwH/37258YCULY4b/DDUHUmOmKJEh2hkUE4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=twASdHOlRFsxs4nkKKw8rd0OyYEdxLC4gTqsSzQ0mLPfAHk84ARn1oy0XSQwuw4H8 Jq+QAgMrqoIaTG1d4aBHc2zX/R4SADoWn50kWf3ZapEh6vmoqqzAuDeXtEgOdiZsYq XLbgypHFHC7Bq+d9YTWOuGC+4tHDU3ZkfMquJAkY= Date: Wed, 5 Jun 2019 14:09:45 +0800 From: Shawn Guo To: Anson.Huang@nxp.com Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, leonard.crestez@nxp.com, abel.vesa@nxp.com, viresh.kumar@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, hyc.nju@gmail.com, Linux-imx@nxp.com Subject: Re: [PATCH RESEND 1/2] soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling Message-ID: <20190605060944.GB29853@dragon> References: <20190524055101.3424-1-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190524055101.3424-1-Anson.Huang@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 24, 2019 at 01:51:00PM +0800, Anson.Huang@nxp.com wrote: > From: Anson Huang > > of_node_put() is called after of_match_node() successfully called, > then in the following error handling, of_node_put() is called again > which is unnecessary, this patch adjusts the location of of_node_put() > to avoid such scenario. > > Signed-off-by: Anson Huang > Reviewed-by: Leonard Crestez Applied both, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51F84C282DE for ; Wed, 5 Jun 2019 06:10:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2761B2075C for ; Wed, 5 Jun 2019 06:10:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A1rrCseR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="twASdHOl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2761B2075C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v84m2jotQ/A9sgs9NxQ+p5a4XePKDmh1c2LN8kBlCwA=; b=A1rrCseRrXkO9D mHvYN6/L8cBzBw0q3MdoSlqyb7QumCqPys/WcpeAUjPOb3BAj1wG8s36eAS+Wyd2xA6rUM9tAfFqX aKwmSFQAyArFKVw6qw8VDVTc5f1SZxCXSREQb11P780dAM+SewsNjs7mZ1A1AWA1rz6jrrd9kSXmu BhpkDTogia42HiQT+MRoUq0uPgnGZKVDaHmGp/xa3cJo5b7QRG9xs8y87UM9Q4vyx2cDaw91IIW/T klv7O1MoGUbCy/yRgTR+IQL7JkqHv82DJWvPflTbm+BArhC5JoxmkRvgAJjga0K5t37+Eapwb7vWw gXn0KGB/PpG+NxFx4mTQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYP7c-0003Zw-LZ; Wed, 05 Jun 2019 06:10:04 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYP7a-00035E-1e for linux-arm-kernel@lists.infradead.org; Wed, 05 Jun 2019 06:10:03 +0000 Received: from dragon (li1264-180.members.linode.com [45.79.165.180]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C9D3D2075C; Wed, 5 Jun 2019 06:09:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559715001; bh=wTYwhYyVAwH/37258YCULY4b/DDUHUmOmKJEh2hkUE4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=twASdHOlRFsxs4nkKKw8rd0OyYEdxLC4gTqsSzQ0mLPfAHk84ARn1oy0XSQwuw4H8 Jq+QAgMrqoIaTG1d4aBHc2zX/R4SADoWn50kWf3ZapEh6vmoqqzAuDeXtEgOdiZsYq XLbgypHFHC7Bq+d9YTWOuGC+4tHDU3ZkfMquJAkY= Date: Wed, 5 Jun 2019 14:09:45 +0800 From: Shawn Guo To: Anson.Huang@nxp.com Subject: Re: [PATCH RESEND 1/2] soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling Message-ID: <20190605060944.GB29853@dragon> References: <20190524055101.3424-1-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190524055101.3424-1-Anson.Huang@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190604_231002_114467_3DB85F8D X-CRM114-Status: UNSURE ( 8.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: abel.vesa@nxp.com, viresh.kumar@linaro.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, hyc.nju@gmail.com, Linux-imx@nxp.com, kernel@pengutronix.de, leonard.crestez@nxp.com, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 24, 2019 at 01:51:00PM +0800, Anson.Huang@nxp.com wrote: > From: Anson Huang > > of_node_put() is called after of_match_node() successfully called, > then in the following error handling, of_node_put() is called again > which is unnecessary, this patch adjusts the location of of_node_put() > to avoid such scenario. > > Signed-off-by: Anson Huang > Reviewed-by: Leonard Crestez Applied both, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel