From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D6B8C28CC5 for ; Wed, 5 Jun 2019 08:20:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F157620866 for ; Wed, 5 Jun 2019 08:20:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EEsoVwHJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726597AbfFEIUw (ORCPT ); Wed, 5 Jun 2019 04:20:52 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:40544 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726556AbfFEIUw (ORCPT ); Wed, 5 Jun 2019 04:20:52 -0400 Received: by mail-wr1-f67.google.com with SMTP id p11so13647429wre.7 for ; Wed, 05 Jun 2019 01:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=4N4wbbPbH5vFPQ02lIzPzQHg+yDqqNmeJgiKq0aKWHQ=; b=EEsoVwHJfcVfB0ReGOh4L2CQa6hWhl7NbcxauHoct4OV4K/eJmfkm8ODRylrWf0538 cFa6Ud53SF9GDxPzTf2QH8ClrklK6SAbghEFIvkPB08cXK8dmhn83Xof+s2ZK+q518Aj 2GSJmz2YyAyeCySlO/be4cLEbL9RVXGU2l/CaV+hYuqsyJZHVcKKnBUKrOw96GNUV40b KNe4oyVp/g92y3oHSnA66Q/gFpFB8Qukzyhelc9SvseBGDW6imI5ONkiObzQkjBsYMub PuXqEPcOMPhEBrpFa02315DvejuZd4l+e3SZjyFqd8VDsFe7rOanchMNtkmv8jUP81la /Ovg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=4N4wbbPbH5vFPQ02lIzPzQHg+yDqqNmeJgiKq0aKWHQ=; b=OXeMk2AXry2P97EVlM0xpqPjJ1qS6PeiTw00GhpTmDxUJVjIkSStT+6fxCFJI5A467 o6DKVzaFV2c1+5jnVRQL+cyS1Di/vEMG1fV387WBMtYAnosUBht1zlTZYJDjOzV1bayI Y/WVVnu39wCNjkqeEo6p8iEbua/2dcoR4LdDczvsc/JFfpgKi1XvFw5lNVt3zZBs3H4P DtTbbcae40uSdNslYqeP4yzN3vrLAXBRScLatquUkhkBuYxpJrI0tSwPPr3uNA0g/KWt 8ZTTNrIMSy/TnryetAZtODXQY53o3cAys78ELihHDDeDVDMQ9ehe3IJQ/3Md0zcQ5YD6 98Hg== X-Gm-Message-State: APjAAAVnjGiWM16Meuszn8IknwmLsUWBFtnt/FXeleeRE8v2z73Qx2Y1 eNdBBsRPQqyN44hkJTxlURy/Gw== X-Google-Smtp-Source: APXvYqx/8oIyrbj4ascfwZpwcyMAKVAvtaBu7KaV63F4l5bAfkhGLPkaQF18jo6DwFQGyXdhimt4dQ== X-Received: by 2002:adf:f38a:: with SMTP id m10mr9150235wro.81.1559722850820; Wed, 05 Jun 2019 01:20:50 -0700 (PDT) Received: from dell ([2.27.167.43]) by smtp.gmail.com with ESMTPSA id a62sm21930094wmf.19.2019.06.05.01.20.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Jun 2019 01:20:49 -0700 (PDT) Date: Wed, 5 Jun 2019 09:20:47 +0100 From: Lee Jones To: Johan Hovold Cc: Bjorn Andersson , balbi@kernel.org, wsa+renesas@sang-engineering.com, gregkh@linuxfoundation.org, linus.walleij@linaro.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, david.brown@linaro.org, alokc@codeaurora.org, kramasub@codeaurora.org, linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, andy.gross@linaro.org, jlhugo@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/8] i2c: i2c-qcom-geni: Signify successful driver probe Message-ID: <20190605082047.GM4797@dell> References: <20190604104455.8877-1-lee.jones@linaro.org> <20190604104455.8877-2-lee.jones@linaro.org> <20190605062020.GL22737@tuxbook-pro> <20190605071625.GK4797@dell> <20190605075656.GC29637@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190605075656.GC29637@localhost> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, 05 Jun 2019, Johan Hovold wrote: > On Wed, Jun 05, 2019 at 08:16:25AM +0100, Lee Jones wrote: > > On Tue, 04 Jun 2019, Bjorn Andersson wrote: > > > > > On Tue 04 Jun 03:44 PDT 2019, Lee Jones wrote: > > > > > > > The Qualcomm Geni I2C driver currently probes silently which can be > > > > confusing when debugging potential issues. Add a low level (INFO) > > > > print when each I2C controller is successfully initially set-up. > > > > > > > > Signed-off-by: Lee Jones > > > > --- > > > > drivers/i2c/busses/i2c-qcom-geni.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > > > > index 0fa93b448e8d..e27466d77767 100644 > > > > --- a/drivers/i2c/busses/i2c-qcom-geni.c > > > > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > > > > @@ -598,6 +598,8 @@ static int geni_i2c_probe(struct platform_device *pdev) > > > > return ret; > > > > } > > > > > > > > + dev_info(&pdev->dev, "Geni-I2C adaptor successfully added\n"); > > > > + > > > > > > I would prefer that we do not add such prints, as it would be to accept > > > the downstream behaviour of spamming the log to the point where no one > > > will ever look through it. > > > > We should be able to find a middle ground. Spamming the log with all > > sorts of device specific information/debug is obviously not > > constructive, but a single liner to advertise that an important > > device/controller has been successfully initialised is more helpful > > than it is hinderous. > > > > This print was added due to the silent initialisation costing me > > several hours of debugging ACPI device/driver code (albeit learning a > > lot about ACPI as I go) just to find out that it was already doing the > > right thing - just very quietly. > > No, we don't add noise like this to the logs just because it may be > useful while debugging. Even one-liners add up. One line per device is should not cause an issue. Problems occur when developers try to print all kinds of device specifics to the boot log. A simple, single line for such an important device/controller has more benefits than drawbacks. > There are plenty of options for debugging already ranging from adding a > temporary dev_info() to the probe function in question to using dynamic > debugging to have driver core log every successful probe. This is what I ended up doing. It was time consuming to parse though a log of that size when you have no paging or keyboard. > And in this case you say the driver was in fact already bound; that can > easily be verified through sysfs too in case things aren't behaving the > way you expect. Not in a non-booting system with no keyboard you can't. ;) -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3827BC282DE for ; Wed, 5 Jun 2019 08:21:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0ECC32075C for ; Wed, 5 Jun 2019 08:21:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N3gVZoUO"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EEsoVwHJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0ECC32075C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FE8lZCPGr8+9c1NvCQLG6BW2eFINRvUSQhLbocooAM0=; b=N3gVZoUOPryR1p DliWIjJm+ho/nIMLwOU5Y63j3WSUbS5mQOOd9g9pkf9psvZQq8EUVY5SF/GaiY9QRYM5HU+5RSGGK 5Zm20w+C8uYXk5g6LCtXUHp7I+/Q2WRMkCaRam4Na/aGH/yrzE/jgcWzLoIv1c0CRYOlP/lNu6Gdy lT559eS0q/MZfMlnyllqT8B5n939+L7hVheCSx1orhF9J09WPLu2yP38cURDD2jYnQKsF8FpMHpZp dDHrt9xIq26wlvToqMdjf5tPD7InnNV5cxM3/7CUoqSfaAY+kBtse7vOSCQhZwPcLtoXmfr7peYbr 5g5w7KAIXzRSETYTekVw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYRAG-00065Q-Cs; Wed, 05 Jun 2019 08:20:56 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYRAD-00064i-1J for linux-arm-kernel@lists.infradead.org; Wed, 05 Jun 2019 08:20:54 +0000 Received: by mail-wr1-x441.google.com with SMTP id r18so9477959wrm.10 for ; Wed, 05 Jun 2019 01:20:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=4N4wbbPbH5vFPQ02lIzPzQHg+yDqqNmeJgiKq0aKWHQ=; b=EEsoVwHJfcVfB0ReGOh4L2CQa6hWhl7NbcxauHoct4OV4K/eJmfkm8ODRylrWf0538 cFa6Ud53SF9GDxPzTf2QH8ClrklK6SAbghEFIvkPB08cXK8dmhn83Xof+s2ZK+q518Aj 2GSJmz2YyAyeCySlO/be4cLEbL9RVXGU2l/CaV+hYuqsyJZHVcKKnBUKrOw96GNUV40b KNe4oyVp/g92y3oHSnA66Q/gFpFB8Qukzyhelc9SvseBGDW6imI5ONkiObzQkjBsYMub PuXqEPcOMPhEBrpFa02315DvejuZd4l+e3SZjyFqd8VDsFe7rOanchMNtkmv8jUP81la /Ovg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=4N4wbbPbH5vFPQ02lIzPzQHg+yDqqNmeJgiKq0aKWHQ=; b=SPtl/yt9RvQq7Owr9SNBvl60SVDdf/0ha9OC8vgNbsGRy7Mc/iPssF4k/K4s59jcQ+ ekMkggfYv5EFB2L5v52+eFx9CrDeOOxaBRUbdhKLI20Tw8hWunzuRHkOBCCSg4Thm+lI p/jaYBTvE3dTpd720egcPStvq8OMEyT2++9/FeUCDF+u7c2rZL34r+h4qTZcjqZTSjA7 jnnpeL/bcfBs7JuV8Ry/XvrHs8IEoaBZZ3g9fG5rz7kYWftgvCbUWuUzRUxtU/jRRSUf tkuEcBFZndVDpfrCTH0SU4aKD32/cMGRLpnG0YKZ8wdDX4BXKYsnmPR46xdccbtZpMTq /uQA== X-Gm-Message-State: APjAAAWxP8Dw2mS09LTSHpd85GvSVU/LimzIiSf5b8cKowakU0a7SKNh qIIipo6DJD13ccAcDB1g9TGMPg== X-Google-Smtp-Source: APXvYqx/8oIyrbj4ascfwZpwcyMAKVAvtaBu7KaV63F4l5bAfkhGLPkaQF18jo6DwFQGyXdhimt4dQ== X-Received: by 2002:adf:f38a:: with SMTP id m10mr9150235wro.81.1559722850820; Wed, 05 Jun 2019 01:20:50 -0700 (PDT) Received: from dell ([2.27.167.43]) by smtp.gmail.com with ESMTPSA id a62sm21930094wmf.19.2019.06.05.01.20.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Jun 2019 01:20:49 -0700 (PDT) Date: Wed, 5 Jun 2019 09:20:47 +0100 From: Lee Jones To: Johan Hovold Subject: Re: [PATCH 2/8] i2c: i2c-qcom-geni: Signify successful driver probe Message-ID: <20190605082047.GM4797@dell> References: <20190604104455.8877-1-lee.jones@linaro.org> <20190604104455.8877-2-lee.jones@linaro.org> <20190605062020.GL22737@tuxbook-pro> <20190605071625.GK4797@dell> <20190605075656.GC29637@localhost> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190605075656.GC29637@localhost> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190605_012053_107665_192CA05B X-CRM114-Status: GOOD ( 26.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: balbi@kernel.org, david.brown@linaro.org, gregkh@linuxfoundation.org, linus.walleij@linaro.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , wsa+renesas@sang-engineering.com, alokc@codeaurora.org, kramasub@codeaurora.org, linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, andy.gross@linaro.org, jlhugo@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAwNSBKdW4gMjAxOSwgSm9oYW4gSG92b2xkIHdyb3RlOgoKPiBPbiBXZWQsIEp1biAw NSwgMjAxOSBhdCAwODoxNjoyNUFNICswMTAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBPbiBUdWUs IDA0IEp1biAyMDE5LCBCam9ybiBBbmRlcnNzb24gd3JvdGU6Cj4gPiAKPiA+ID4gT24gVHVlIDA0 IEp1biAwMzo0NCBQRFQgMjAxOSwgTGVlIEpvbmVzIHdyb3RlOgo+ID4gPiAKPiA+ID4gPiBUaGUg UXVhbGNvbW0gR2VuaSBJMkMgZHJpdmVyIGN1cnJlbnRseSBwcm9iZXMgc2lsZW50bHkgd2hpY2gg Y2FuIGJlCj4gPiA+ID4gY29uZnVzaW5nIHdoZW4gZGVidWdnaW5nIHBvdGVudGlhbCBpc3N1ZXMu ICBBZGQgYSBsb3cgbGV2ZWwgKElORk8pCj4gPiA+ID4gcHJpbnQgd2hlbiBlYWNoIEkyQyBjb250 cm9sbGVyIGlzIHN1Y2Nlc3NmdWxseSBpbml0aWFsbHkgc2V0LXVwLgo+ID4gPiA+IAo+ID4gPiA+ IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4gPiA+ID4g LS0tCj4gPiA+ID4gIGRyaXZlcnMvaTJjL2J1c3Nlcy9pMmMtcWNvbS1nZW5pLmMgfCAyICsrCj4g PiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykKPiA+ID4gPiAKPiA+ID4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9pMmMvYnVzc2VzL2kyYy1xY29tLWdlbmkuYyBiL2RyaXZlcnMv aTJjL2J1c3Nlcy9pMmMtcWNvbS1nZW5pLmMKPiA+ID4gPiBpbmRleCAwZmE5M2I0NDhlOGQuLmUy NzQ2NmQ3Nzc2NyAxMDA2NDQKPiA+ID4gPiAtLS0gYS9kcml2ZXJzL2kyYy9idXNzZXMvaTJjLXFj b20tZ2VuaS5jCj4gPiA+ID4gKysrIGIvZHJpdmVycy9pMmMvYnVzc2VzL2kyYy1xY29tLWdlbmku Ywo+ID4gPiA+IEBAIC01OTgsNiArNTk4LDggQEAgc3RhdGljIGludCBnZW5pX2kyY19wcm9iZShz dHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ID4gPiA+ICAJCXJldHVybiByZXQ7Cj4gPiA+ ID4gIAl9Cj4gPiA+ID4gIAo+ID4gPiA+ICsJZGV2X2luZm8oJnBkZXYtPmRldiwgIkdlbmktSTJD IGFkYXB0b3Igc3VjY2Vzc2Z1bGx5IGFkZGVkXG4iKTsKPiA+ID4gPiArCj4gPiA+IAo+ID4gPiBJ IHdvdWxkIHByZWZlciB0aGF0IHdlIGRvIG5vdCBhZGQgc3VjaCBwcmludHMsIGFzIGl0IHdvdWxk IGJlIHRvIGFjY2VwdAo+ID4gPiB0aGUgZG93bnN0cmVhbSBiZWhhdmlvdXIgb2Ygc3BhbW1pbmcg dGhlIGxvZyB0byB0aGUgcG9pbnQgd2hlcmUgbm8gb25lCj4gPiA+IHdpbGwgZXZlciBsb29rIHRo cm91Z2ggaXQuCj4gPiAKPiA+IFdlIHNob3VsZCBiZSBhYmxlIHRvIGZpbmQgYSBtaWRkbGUgZ3Jv dW5kLiAgU3BhbW1pbmcgdGhlIGxvZyB3aXRoIGFsbAo+ID4gc29ydHMgb2YgZGV2aWNlIHNwZWNp ZmljIGluZm9ybWF0aW9uL2RlYnVnIGlzIG9idmlvdXNseSBub3QKPiA+IGNvbnN0cnVjdGl2ZSwg YnV0IGEgc2luZ2xlIGxpbmVyIHRvIGFkdmVydGlzZSB0aGF0IGFuIGltcG9ydGFudAo+ID4gZGV2 aWNlL2NvbnRyb2xsZXIgaGFzIGJlZW4gc3VjY2Vzc2Z1bGx5IGluaXRpYWxpc2VkIGlzIG1vcmUg aGVscGZ1bAo+ID4gdGhhbiBpdCBpcyBoaW5kZXJvdXMuCj4gPiAKPiA+IFRoaXMgcHJpbnQgd2Fz IGFkZGVkIGR1ZSB0byB0aGUgc2lsZW50IGluaXRpYWxpc2F0aW9uIGNvc3RpbmcgbWUKPiA+IHNl dmVyYWwgaG91cnMgb2YgZGVidWdnaW5nIEFDUEkgZGV2aWNlL2RyaXZlciBjb2RlIChhbGJlaXQg bGVhcm5pbmcgYQo+ID4gbG90IGFib3V0IEFDUEkgYXMgSSBnbykganVzdCB0byBmaW5kIG91dCB0 aGF0IGl0IHdhcyBhbHJlYWR5IGRvaW5nIHRoZQo+ID4gcmlnaHQgdGhpbmcgLSBqdXN0IHZlcnkg cXVpZXRseS4KPiAKPiBObywgd2UgZG9uJ3QgYWRkIG5vaXNlIGxpa2UgdGhpcyB0byB0aGUgbG9n cyBqdXN0IGJlY2F1c2UgaXQgbWF5IGJlCj4gdXNlZnVsIHdoaWxlIGRlYnVnZ2luZy4gRXZlbiBv bmUtbGluZXJzIGFkZCB1cC4KCk9uZSBsaW5lIHBlciBkZXZpY2UgaXMgc2hvdWxkIG5vdCBjYXVz ZSBhbiBpc3N1ZS4KClByb2JsZW1zIG9jY3VyIHdoZW4gZGV2ZWxvcGVycyB0cnkgdG8gcHJpbnQg YWxsIGtpbmRzIG9mIGRldmljZQpzcGVjaWZpY3MgdG8gdGhlIGJvb3QgbG9nLiAgQSBzaW1wbGUs IHNpbmdsZSBsaW5lIGZvciBzdWNoIGFuCmltcG9ydGFudCBkZXZpY2UvY29udHJvbGxlciBoYXMg bW9yZSBiZW5lZml0cyB0aGFuIGRyYXdiYWNrcy4KCj4gVGhlcmUgYXJlIHBsZW50eSBvZiBvcHRp b25zIGZvciBkZWJ1Z2dpbmcgYWxyZWFkeSByYW5naW5nIGZyb20gYWRkaW5nIGEKPiB0ZW1wb3Jh cnkgZGV2X2luZm8oKSB0byB0aGUgcHJvYmUgZnVuY3Rpb24gaW4gcXVlc3Rpb24gdG8gdXNpbmcg ZHluYW1pYwo+IGRlYnVnZ2luZyB0byBoYXZlIGRyaXZlciBjb3JlIGxvZyBldmVyeSBzdWNjZXNz ZnVsIHByb2JlLgoKVGhpcyBpcyB3aGF0IEkgZW5kZWQgdXAgZG9pbmcuICBJdCB3YXMgdGltZSBj b25zdW1pbmcgdG8gcGFyc2UgdGhvdWdoCmEgbG9nIG9mIHRoYXQgc2l6ZSB3aGVuIHlvdSBoYXZl IG5vIHBhZ2luZyBvciBrZXlib2FyZC4KCj4gQW5kIGluIHRoaXMgY2FzZSB5b3Ugc2F5IHRoZSBk cml2ZXIgd2FzIGluIGZhY3QgYWxyZWFkeSBib3VuZDsgdGhhdCBjYW4KPiBlYXNpbHkgYmUgdmVy aWZpZWQgdGhyb3VnaCBzeXNmcyB0b28gaW4gY2FzZSB0aGluZ3MgYXJlbid0IGJlaGF2aW5nIHRo ZQo+IHdheSB5b3UgZXhwZWN0LgoKTm90IGluIGEgbm9uLWJvb3Rpbmcgc3lzdGVtIHdpdGggbm8g a2V5Ym9hcmQgeW91IGNhbid0LiA7KQoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQpMaW5hcm8g U2VydmljZXMgVGVjaG5pY2FsIExlYWQKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdh cmUgZm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFy bS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r ZXJuZWwK