From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] btrfs-progs: Correctly open filesystem on image file
Date: Wed, 5 Jun 2019 18:20:35 +0200 [thread overview]
Message-ID: <20190605162035.GE9896@twin.jikos.cz> (raw)
In-Reply-To: <20190516131250.26621-1-nborisov@suse.com>
On Thu, May 16, 2019 at 04:12:49PM +0300, Nikolay Borisov wrote:
> When btrfs' 'filesystem' subcommand is passed path to an image file it
> currently fails since the code expects the image file is going to be
> recognised by libblkid (called from btrfs_scan_devices()). This is not
> the case since libblkid only scan well-known locations under /dev.
>
> Fix this by explicitly calling open_ctree which will correctly open
> the image and add it to the correct btrfs_fs_devices struct. This allows
> subsequent cmd_filesystem_show logic to correctly show requested
> information.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Applied, thanks.
prev parent reply other threads:[~2019-06-05 16:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 13:12 [PATCH 1/2] btrfs-progs: Correctly open filesystem on image file Nikolay Borisov
2019-05-16 13:12 ` [PATCH 2/2] btrfs-progs: tests: Test fs on image files is correctly recognised Nikolay Borisov
2019-06-05 16:14 ` David Sterba
2019-05-16 13:41 ` [PATCH 1/2] btrfs-progs: Correctly open filesystem on image file Qu Wenruo
2019-05-16 13:45 ` Nikolay Borisov
2019-05-16 13:54 ` Qu Wenruo
2019-05-16 14:01 ` Nikolay Borisov
2019-05-16 14:10 ` Qu Wenruo
2019-06-05 16:20 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605162035.GE9896@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.