From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC16BC28D18 for ; Wed, 5 Jun 2019 18:43:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9717D206B8 for ; Wed, 5 Jun 2019 18:43:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="hN2XUBpq"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="l8+I3l5d" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726731AbfFESnX (ORCPT ); Wed, 5 Jun 2019 14:43:23 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:56579 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726305AbfFESnX (ORCPT ); Wed, 5 Jun 2019 14:43:23 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id AC3432134B; Wed, 5 Jun 2019 14:43:21 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 05 Jun 2019 14:43:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=XjSDSERcX5eVnQvGa2z3d44G6BD UvBbcos/tt2mjxSM=; b=hN2XUBpqh0DmgRGUECsrNmJh3Il4xW8GjeVUV6kiRBT h87B0xa4TWxFbg5hL2/Vqo9bLg1J3ha5R/xfpt4SEqitrqy/MdkQ+YtXd7SZZ7s/ rI5G8C+H79dA4wVlCpDTf8d8B+FHuOuMCHswUlYy8yBYvDpMPBEdnpVfWt1+3QC/ 8L3ymyuEDdznq0M+V5VkIts/Np1qgmgdR5SDnDa1A0pcjrYvQnJHY+i5/yCmnuCF HJeCD61srA+B3UblYoTjQqspXMBPkvYAXvfhp3aBIPrKL3YBtq16bKAS3HO4qpxV DrJ9eqt06c4FlycYPjlqy32SVbWlz6/cUdANkZis80A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=XjSDSE RcX5eVnQvGa2z3d44G6BDUvBbcos/tt2mjxSM=; b=l8+I3l5d+zRU8+VEtUbiDK gSzde79yZKoZOJEGhyRfzNURP4/kiK3/J5ocHoxyfmwgLFjUJaYn4d5qq8QxjVdd 0Xl9p5+dYxUvppzAcUwl/mg1woGLEQfUQAtDnfDGbcg2eNse1lqIGzXb2grN0DaW H5QArcbh+8asMdY0J+onoQOay3e+mIxARGo2PxyoLK247Sit8ohVvXQWdSm1ntGe oK2W0JC8z2Wx5hykMOl5Zltr00BXO3RMyFtsCdfUzgCWMqcej7G1BCyh0AkQnfli 5sKbV/IWcPB6X2/Y8BTo5x/amYRKtxSdrqbDpiZByTvwAWeopMt6KvoiVTAQiMaw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudegvddgudefudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujggfsehttdertddtredvnecuhfhrohhmpefirhgv ghcumffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucfkphepkeefrdekiedrkeelrd dutdejnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomhen ucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id DA8C5380087; Wed, 5 Jun 2019 14:43:20 -0400 (EDT) Date: Wed, 5 Jun 2019 20:43:18 +0200 From: Greg KH To: Kees Cook Cc: Alec Ari , linux-kernel , x86@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] x86/build: Move _etext to actual end of .text Message-ID: <20190605184318.GB32750@kroah.com> References: <201906051114.6DEF834@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201906051114.6DEF834@keescook> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 05, 2019 at 11:16:06AM -0700, Kees Cook wrote: > On Wed, Jun 05, 2019 at 11:08:13AM -0500, Alec Ari wrote: > > I'm having this problem too, build is failing: > > > > Invalid absolute R_X86_64_32S relocation: _etext > > > > I stayed on the 4.14 branch to help prevent these kind of breakages, > > so much for that idea. Gentoo GCC 8.3.0. > > It seems to be a problem with the Gold linker. Using ld.bfd appears to > work. I haven't narrowed down the problem, unfortunately. > > Greg, given that this change was only for special situations (Clang > CFI), can you revert this for the stable trees? Turns out that Android required it to be reverted too, so no one needs this :( I'll go revert this, thanks. greg k-h