From: Greg KH <gregkh@linuxfoundation.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Talel Shenhar <talel@amazon.com>,
nicolas.ferre@microchip.com, jason@lakedaemon.net,
marc.zyngier@arm.com, mark.rutland@arm.com,
mchehab+samsung@kernel.org, robh+dt@kernel.org,
davem@davemloft.net, shawn.lin@rock-chips.com,
tglx@linutronix.de, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dwmw@amazon.co.uk,
jonnyc@amazon.com, hhhawa@amazon.com, ronenk@amazon.com,
hanochu@amazon.com, barakw@amazon.com
Subject: Re: [PATCH 2/3] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver
Date: Thu, 6 Jun 2019 08:37:41 +0200 [thread overview]
Message-ID: <20190606063741.GA23305@kroah.com> (raw)
In-Reply-To: <a81a46ef13273aa8c6ea87c8d3550e33650e27b6.camel@kernel.crashing.org>
On Thu, Jun 06, 2019 at 07:55:43AM +1000, Benjamin Herrenschmidt wrote:
> On Wed, 2019-06-05 at 09:59 +0200, Greg KH wrote:
> >
> > > +struct irq_domain *al_fic_wire_get_domain(struct al_fic *fic);
> > > +
> > > +struct al_fic *al_fic_wire_init(struct device_node *node,
> > > + void __iomem *base,
> > > + const char *name,
> > > + unsigned int parent_irq);
> > > +int al_fic_cleanup(struct al_fic *fic);
> >
> > Who is using these new functions? We don't add new apis that no one
> > uses :(
>
> They will be used by subsequent driver submissions but those aren't
> quite ready yet, so we can hold onto patch 3 for now until they are.
Patch 2 also should have these removed :)
You know we don't add new apis until we have a real, in-kernel user for
them...
thanks,
greg k-h
next prev parent reply other threads:[~2019-06-06 6:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 6:54 [PATCH 0/3] Amazon's Annapurna Labs Fabric Interrupt Controller Talel Shenhar
2019-06-05 6:54 ` Talel Shenhar
2019-06-05 6:54 ` [PATCH 1/3] dt-bindings: interrupt-controller: Amazon's Annapurna Labs FIC Talel Shenhar
2019-06-05 6:54 ` Talel Shenhar
2019-06-05 6:54 ` [PATCH 2/3] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver Talel Shenhar
2019-06-05 6:54 ` Talel Shenhar
2019-06-05 7:59 ` Greg KH
2019-06-05 21:55 ` Benjamin Herrenschmidt
2019-06-06 6:37 ` Greg KH [this message]
2019-06-06 6:47 ` Benjamin Herrenschmidt
2019-06-06 7:04 ` Benjamin Herrenschmidt
2019-06-05 6:54 ` [PATCH 3/3] irqchip: al-fic: Introducing support for MSI-X Talel Shenhar
2019-06-05 6:54 ` Talel Shenhar
2019-06-05 7:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606063741.GA23305@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=barakw@amazon.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=jason@lakedaemon.net \
--cc=jonnyc@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
--cc=ronenk@amazon.com \
--cc=shawn.lin@rock-chips.com \
--cc=talel@amazon.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.