All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [RFC PATCH V6 3/3] nvmet: introduce target-side trace
Date: Thu, 6 Jun 2019 08:51:53 +0200	[thread overview]
Message-ID: <20190606065153.GH27033@lst.de> (raw)
In-Reply-To: <20190606063229.17258-4-minwoo.im.dev@gmail.com>

> +#define nvme_admin_opcode_name(opcode)	{ opcode, #opcode }
> +#define show_admin_opcode_name(val)					\

All these bits can probably just move to nvme.h, next to the actual
definitions.

> +		__assign_disk_name(__entry->disk, req->ns ?
> +					req->ns->bdev->bd_disk : NULL);

Tis looks it will crash badly when using the file backend.  I think we
need to put a neutral identifier in, e.g. the uuid or something.

  reply	other threads:[~2019-06-06  6:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-06  6:32 [RFC PATCH V6 0/3] nvme-trace: Add support for fabrics command Minwoo Im
2019-06-06  6:32 ` [RFC PATCH V6 1/3] nvmet: introduce nvmet_req_to_ctrl to get ctrl instance Minwoo Im
2019-06-06  6:48   ` Christoph Hellwig
2019-06-06  8:43     ` Minwoo Im
2019-06-06  6:32 ` [RFC PATCH V6 2/3] nvme: trace: do not EXPORT_SYMBOL for a trace function Minwoo Im
2019-06-06  6:48   ` Christoph Hellwig
2019-06-06 15:37   ` Chaitanya Kulkarni
2019-06-06  6:32 ` [RFC PATCH V6 3/3] nvmet: introduce target-side trace Minwoo Im
2019-06-06  6:51   ` Christoph Hellwig [this message]
2019-06-06  8:45     ` Minwoo Im

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190606065153.GH27033@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.