From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE727C04AB5 for ; Thu, 6 Jun 2019 06:58:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A9C7520883 for ; Thu, 6 Jun 2019 06:58:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559804306; bh=/AotUYAn81Yvabr0QOuYw3tgELf9Sx7jAvd3vMMU3kY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=nQcwSo14z3YKv2o7lzCJv7p31QhSEMU7U8Nd2i4qjhYbdPljQsLfhzy7OIJKVC5Tu b5ldr3UPLraj0AFDcXCXDn6fHhhsMOHTrERy0Aqn+57PJybNiLCS6LusYXwp+S0y5B +YGr6Lil2QmvtoO15Gfgs7k1ABknGCW197/TiPe0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726777AbfFFG60 (ORCPT ); Thu, 6 Jun 2019 02:58:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:38186 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725267AbfFFG6Z (ORCPT ); Thu, 6 Jun 2019 02:58:25 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A8752207E0; Thu, 6 Jun 2019 06:58:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559804305; bh=/AotUYAn81Yvabr0QOuYw3tgELf9Sx7jAvd3vMMU3kY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=loi3rC5hpwqc/ItwOijTJjtZsZuRbo9pg0ZFutYYR/BfAfq7OxiyuXfyiod69OYcM ykyNP7GpIsHdSWwKHqY4ppeG7Kya1j5n+9jllVJz6BFPiB17yIxD5L300a0TaTn8Sz ijLeZZ+AGRzmaXxhGzDwgga8F1Q3++6lFMxc6ZqI= Date: Thu, 6 Jun 2019 08:58:22 +0200 From: Greg Kroah-Hartman To: Chunfeng Yun Cc: Felipe Balbi , Matthias Brugger , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v3] USB: move usb debugfs directory creation to the usb common core Message-ID: <20190606065822.GA29436@kroah.com> References: <20190605092816.GA23758@kroah.com> <20190605124440.GD17558@kroah.com> <1559788368.8487.109.camel@mhfsdcap03> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1559788368.8487.109.camel@mhfsdcap03> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 06, 2019 at 10:32:48AM +0800, Chunfeng Yun wrote: > On Wed, 2019-06-05 at 14:44 +0200, Greg Kroah-Hartman wrote: > > The USB gadget subsystem wants to use the USB debugfs root directory, so > > move it to the common "core" USB code so that it is properly initialized > > and removed as needed. > > > > In order to properly do this, we need to load the common code before the > > usb core code, when everything is linked into the kernel, so reorder the > > link order of the code. > > > > Also as the usb common code has the possibility of the led trigger logic > > to be merged into it, handle the build option properly by only having > > one module init/exit function and have the common code initialize the > > led trigger if needed. > > > > Reported-by: Chunfeng Yun > > Cc: Felipe Balbi > > Signed-off-by: Greg Kroah-Hartman > > --- > > Chunfeng, can you try testing this again? > > Tested-by: Chunfeng Yun > > Thank you, Greg, Felipe Thanks for the review, and all of the different iterations for this. For something so "simple" it sure took us all a number of tries :) I'll go queue it up now so that your future work can rely on it. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D3A1C04AB5 for ; Thu, 6 Jun 2019 06:58:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A63E207E0 for ; Thu, 6 Jun 2019 06:58:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MjdWBCVp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="loi3rC5h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A63E207E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hc2JAbzGei5IqT2R9+CvB/0VW24CZO1VT84Un+Q3jRc=; b=MjdWBCVpxe4BH/ b1Q/YQiI1AGnM5FH8kS0zCu9q1HpNcWjdfjNv8HLf5Edh6mbiajAvBzT+o6jbapBnZw1qfWlDHeF0 w51Wx0frjuTG4MPsmm7BVoUOwmTOxqGLNjLq2HToTHkZPgAVvACT2KFeZg/93m1q6xKAUo+ET8uFN 8Y4SIPXg7t8y/HIpkUNIKx26OkZyPZhv16cYamB+D9VqUnBV00hfyotOxImvtAfJaZ4QuNtZ5+0vi Yj3FREDDFZsMsSX1o98wKjpziarCLXHqOtdtBuxks78SWCKEpZxCuqmI094BLsonux1v+P91dhNo+ e9yrso2+KF2r0QUURxew==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYmM4-0003q3-09; Thu, 06 Jun 2019 06:58:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYmLz-0003p4-5G; Thu, 06 Jun 2019 06:58:29 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A8752207E0; Thu, 6 Jun 2019 06:58:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559804305; bh=/AotUYAn81Yvabr0QOuYw3tgELf9Sx7jAvd3vMMU3kY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=loi3rC5hpwqc/ItwOijTJjtZsZuRbo9pg0ZFutYYR/BfAfq7OxiyuXfyiod69OYcM ykyNP7GpIsHdSWwKHqY4ppeG7Kya1j5n+9jllVJz6BFPiB17yIxD5L300a0TaTn8Sz ijLeZZ+AGRzmaXxhGzDwgga8F1Q3++6lFMxc6ZqI= Date: Thu, 6 Jun 2019 08:58:22 +0200 From: Greg Kroah-Hartman To: Chunfeng Yun Subject: Re: [PATCH v3] USB: move usb debugfs directory creation to the usb common core Message-ID: <20190606065822.GA29436@kroah.com> References: <20190605092816.GA23758@kroah.com> <20190605124440.GD17558@kroah.com> <1559788368.8487.109.camel@mhfsdcap03> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1559788368.8487.109.camel@mhfsdcap03> User-Agent: Mutt/1.12.0 (2019-05-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190605_235827_220335_33547244 X-CRM114-Status: GOOD ( 14.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 06, 2019 at 10:32:48AM +0800, Chunfeng Yun wrote: > On Wed, 2019-06-05 at 14:44 +0200, Greg Kroah-Hartman wrote: > > The USB gadget subsystem wants to use the USB debugfs root directory, so > > move it to the common "core" USB code so that it is properly initialized > > and removed as needed. > > > > In order to properly do this, we need to load the common code before the > > usb core code, when everything is linked into the kernel, so reorder the > > link order of the code. > > > > Also as the usb common code has the possibility of the led trigger logic > > to be merged into it, handle the build option properly by only having > > one module init/exit function and have the common code initialize the > > led trigger if needed. > > > > Reported-by: Chunfeng Yun > > Cc: Felipe Balbi > > Signed-off-by: Greg Kroah-Hartman > > --- > > Chunfeng, can you try testing this again? > > Tested-by: Chunfeng Yun > > Thank you, Greg, Felipe Thanks for the review, and all of the different iterations for this. For something so "simple" it sure took us all a number of tries :) I'll go queue it up now so that your future work can rely on it. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel