From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC7F8C28EB4 for ; Thu, 6 Jun 2019 15:27:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 965272083E for ; Thu, 6 Jun 2019 15:27:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="QxBi4qVw"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Y7AV8mb3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729346AbfFFP1u (ORCPT ); Thu, 6 Jun 2019 11:27:50 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:47449 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728565AbfFFP1u (ORCPT ); Thu, 6 Jun 2019 11:27:50 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 5D1AB220C9; Thu, 6 Jun 2019 11:27:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 06 Jun 2019 11:27:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=xYXa16oaIxYe9YeoyZG2PW5G95x +tUDhZwJ3LaMVdZU=; b=QxBi4qVwNfyPBfX7SYAwBMBXUBRSIDHODyOjpUsbsi9 TB92ihsGC86WXd4iQbJKn7Y3G9MFs99FB65yqW6vho9E/EkaxQoio5d33REJWjDZ Rg/KrgFCzU4P23ibKsgpIRuSCbpYqio/jpsXrZH6LQN/a5eJNKPnliVnPvtq9668 +3HD1XalprI5yGHLpQQqqDOLxHA9C5Jz/Itt7b58NBkFUr9ktUwj3211uhBETHtR f1oaNt5Z76AQs1FfT4cdRwA49qgZufY5EKz8tk5xRpIpzJbkp0LySz2BXglB4QIe ej3V9FDeiAQXmdBrAYkhTwLIV8phbi0tEd/Spt/5LwA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=xYXa16 oaIxYe9YeoyZG2PW5G95x+tUDhZwJ3LaMVdZU=; b=Y7AV8mb33I7EHfAoYkhvCA OV9CvDvwxaJiD5Wd/idFXvO4D5AQhBBOjq0wu+L1KnQtZdZN1ZxtWLllYWCiVvuI ATh4SnuPbk67MPf3HXRKA48wKZa9Q+enFoNenQwlCZxC78dL77tluVFcD6TfK4zq ahCwQ5ZKgyGnK8gG/8ZAYdAJpfk9OzEf0q1iKLYLqxgVMh9Z0lJZRXR4qHsp4lyf 18n1HHVmDoSqC51Ib8u0nmD08aSUWUKkBrQkYkncEEhnAytT9QlibLyc4uz0AEZv qoqyrHx6g3BUlojLPxAZzjoJTOLP6WwAJKHOX2059JRdjBVt5QZiPRA0+nQiIQjQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudeggedgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjfgesthdtredttdervdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecukfhppeekfedrkeeirdekledrud dtjeenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhmnecu vehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 9198F8005A; Thu, 6 Jun 2019 11:27:48 -0400 (EDT) Date: Thu, 6 Jun 2019 17:27:46 +0200 From: Greg KH To: Rolf Eike Beer Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, Miguel Ojeda Subject: Re: Linux 4.9.180 build fails =?utf-8?Q?wi?= =?utf-8?Q?th_gcc_9_and_'cleanup=5Fmodule'_specifies_less_restrictive_attr?= =?utf-8?Q?ibute_than_its_target_=E2=80=A6?= Message-ID: <20190606152746.GB21921@kroah.com> References: <259986242.BvXPX32bHu@devpool35> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <259986242.BvXPX32bHu@devpool35> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 06, 2019 at 03:16:03PM +0200, Rolf Eike Beer wrote: > I have at least these 2 instances: > > > In file included from /tmp/e2/build/linux-4.9.180/include/drm/drm_vma_manager.h:28, > from /tmp/e2/build/linux-4.9.180/include/drm/drmP.h:78, > from /tmp/e2/build/linux-4.9.180/include/drm/drm_modeset_helper.h:26, > from /tmp/e2/build/linux-4.9.180/include/drm/drm_atomic_helper.h:33, > from /tmp/e2/build/linux-4.9.180/drivers/gpu/drm/tilcdc/tilcdc_drv.c:24: > /tmp/e2/build/linux-4.9.180/include/linux/module.h:138:7: error: 'cleanup_module' specifies less restrictive attribute than its target 'tilcdc_drm_fini': 'cold' [-Werror=missing-attributes] > 138 | void cleanup_module(void) __attribute__((alias(#exitfn))); > | ^~~~~~~~~~~~~~ > /tmp/e2/build/linux-4.9.180/drivers/gpu/drm/tilcdc/tilcdc_drv.c:757:1: note: in expansion of macro 'module_exit' > 757 | module_exit(tilcdc_drm_fini); > | ^~~~~~~~~~~ > /tmp/e2/build/linux-4.9.180/drivers/gpu/drm/tilcdc/tilcdc_drv.c:748:20: note: 'cleanup_module' target declared here > 748 | static void __exit tilcdc_drm_fini(void) > | ^~~~~~~~~~~~~~~ > In file included from /tmp/e2/build/linux-4.9.180/include/drm/drm_vma_manager.h:28, > from /tmp/e2/build/linux-4.9.180/include/drm/drmP.h:78, > from /tmp/e2/build/linux-4.9.180/include/drm/drm_modeset_helper.h:26, > from /tmp/e2/build/linux-4.9.180/include/drm/drm_atomic_helper.h:33, > from /tmp/e2/build/linux-4.9.180/drivers/gpu/drm/tilcdc/tilcdc_drv.c:24: > /tmp/e2/build/linux-4.9.180/include/linux/module.h:132:6: error: 'init_module' specifies less restrictive attribute than its target 'tilcdc_drm_init': 'cold' [-Werror=missing-attributes] > 132 | int init_module(void) __attribute__((alias(#initfn))); > | ^~~~~~~~~~~ > /tmp/e2/build/linux-4.9.180/drivers/gpu/drm/tilcdc/tilcdc_drv.c:756:1: note: in expansion of macro 'module_init' > 756 | module_init(tilcdc_drm_init); > | ^~~~~~~~~~~ > /tmp/e2/build/linux-4.9.180/drivers/gpu/drm/tilcdc/tilcdc_drv.c:740:19: note: 'init_module' target declared here > 740 | static int __init tilcdc_drm_init(void) > | ^~~~~~~~~~~~~~~ > > > > In file included from /tmp/e2/build/linux-4.9.180/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c:17: > /tmp/e2/build/linux-4.9.180/include/linux/module.h:138:7: error: 'cleanup_module' specifies less restrictive attribute than its target 'mpc52xx_lpbfifo_driver_exit': 'cold' [-Werror=missing-attributes] > 138 | void cleanup_module(void) __attribute__((alias(#exitfn))); > | ^~~~~~~~~~~~~~ > /tmp/e2/build/linux-4.9.180/include/linux/device.h:1360:1: note: in expansion of macro 'module_exit' > 1360 | module_exit(__driver##_exit); > | ^~~~~~~~~~~ > /tmp/e2/build/linux-4.9.180/include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver' > 228 | module_driver(__platform_driver, platform_driver_register, \ > | ^~~~~~~~~~~~~ > /tmp/e2/build/linux-4.9.180/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c:581:1: note: in expansion of macro 'module_platform_driver' > 581 | module_platform_driver(mpc52xx_lpbfifo_driver); > | ^~~~~~~~~~~~~~~~~~~~~~ > In file included from /tmp/e2/build/linux-4.9.180/arch/powerpc/include/asm/io.h:27, > from /tmp/e2/build/linux-4.9.180/include/linux/io.h:25, > from /tmp/e2/build/linux-4.9.180/include/linux/irq.h:24, > from /tmp/e2/build/linux-4.9.180/arch/powerpc/include/asm/hardirq.h:5, > from /tmp/e2/build/linux-4.9.180/include/linux/hardirq.h:8, > from /tmp/e2/build/linux-4.9.180/include/linux/interrupt.h:12, > from /tmp/e2/build/linux-4.9.180/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c:12: > /tmp/e2/build/linux-4.9.180/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c:581:24: note: 'cleanup_module' target declared here > 581 | module_platform_driver(mpc52xx_lpbfifo_driver); > | ^~~~~~~~~~~~~~~~~~~~~~ > /tmp/e2/build/linux-4.9.180/include/linux/device.h:1356:20: note: in definition of macro 'module_driver' > 1356 | static void __exit __driver##_exit(void) \ > | ^~~~~~~~ > /tmp/e2/build/linux-4.9.180/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c:581:1: note: in expansion of macro 'module_platform_driver' > 581 | module_platform_driver(mpc52xx_lpbfifo_driver); > | ^~~~~~~~~~~~~~~~~~~~~~ > In file included from /tmp/e2/build/linux-4.9.180/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c:17: > /tmp/e2/build/linux-4.9.180/include/linux/module.h:132:6: error: 'init_module' specifies less restrictive attribute than its target 'mpc52xx_lpbfifo_driver_init': 'cold' [-Werror=missing-attributes] > 132 | int init_module(void) __attribute__((alias(#initfn))); > | ^~~~~~~~~~~ > /tmp/e2/build/linux-4.9.180/include/linux/device.h:1355:1: note: in expansion of macro 'module_init' > 1355 | module_init(__driver##_init); \ > | ^~~~~~~~~~~ > /tmp/e2/build/linux-4.9.180/include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver' > 228 | module_driver(__platform_driver, platform_driver_register, \ > | ^~~~~~~~~~~~~ > /tmp/e2/build/linux-4.9.180/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c:581:1: note: in expansion of macro 'module_platform_driver' > 581 | module_platform_driver(mpc52xx_lpbfifo_driver); > | ^~~~~~~~~~~~~~~~~~~~~~ > In file included from /tmp/e2/build/linux-4.9.180/arch/powerpc/include/asm/io.h:27, > from /tmp/e2/build/linux-4.9.180/include/linux/io.h:25, > from /tmp/e2/build/linux-4.9.180/include/linux/irq.h:24, > from /tmp/e2/build/linux-4.9.180/arch/powerpc/include/asm/hardirq.h:5, > from /tmp/e2/build/linux-4.9.180/include/linux/hardirq.h:8, > from /tmp/e2/build/linux-4.9.180/include/linux/interrupt.h:12, > from /tmp/e2/build/linux-4.9.180/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c:12: > /tmp/e2/build/linux-4.9.180/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c:581:24: note: 'init_module' target declared here > 581 | module_platform_driver(mpc52xx_lpbfifo_driver); > | ^~~~~~~~~~~~~~~~~~~~~~ > /tmp/e2/build/linux-4.9.180/include/linux/device.h:1351:19: note: in definition of macro 'module_driver' > 1351 | static int __init __driver##_init(void) \ > | ^~~~~~~~ > /tmp/e2/build/linux-4.9.180/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c:581:1: note: in expansion of macro 'module_platform_driver' > 581 | module_platform_driver(mpc52xx_lpbfifo_driver); > | ^~~~~~~~~~~~~~~~~~~~~~ > > > So this needs a6e60d84989fa0e91db7f236eda40453b0e44afa, which needs > c0d9782f5b6d7157635ae2fd782a4b27d55a6013, which can't be applied cleanly > because a3f8a30f3f0079c7edfc72e329eee8594fb3e3cb is missing in 4.9. > > I have applied a6e60d84989fa0e91db7f236eda40453b0e44afa and modified it to > directly use __attribute__((__copy__(initfn))) and (exitfn), which fixes the > build for me. I just added some patches for gcc9 to 4.14 and 4.19, are you really going to want to build it on 4.9? If so, I can try to fix this up... thanks, greg k-h