All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] aspeed/watchdog: Correct timeout value
Date: Fri, 7 Jun 2019 10:57:31 -0400	[thread overview]
Message-ID: <20190607145731.GO10942@bill-the-cat> (raw)
In-Reply-To: <20190606073845.15890-1-joel@jms.id.au>

On Thu, Jun 06, 2019 at 05:08:45PM +0930, Joel Stanley wrote:

> The driver was using milliseconds and programming it into a register
> which takes ticks of the watchdog clock, which runs at 1MHz. This meant
> we were off by 1000 with the desired value.
> 
> When 06985289d452 ("watchdog: Implement generic watchdog_reset()
> version") was added the aspeed board would leave the watchdog running,
> causing it to bite before u-boot was done.
> 
> Discovered by booting in qemu:
> 
>   $ qemu-system-arm -M ast2500-evb -drive file=test.img,format=raw,if=mtd -nographic -no-reboot -d cpu_reset
> 
>   U-Boot 2019.07-rc3-00091-g2253e40caef5 (Jun 06 2019 - 16:53:23 +0930)
> 
>   Model: Aspeed BMC
>   DRAM:  496 MiB
>   WDT:   Started with servicing (60s timeout)
>   MMC:   
>   In:    serial at 1e784000
>   Out:   serial at 1e784000
>   Err:   serial at 1e784000
>   Watchdog timer expired.
> 
> Fixes: 06985289d452 ("watchdog: Implement generic watchdog_reset() version")
> Signed-off-by: Joel Stanley <joel@jms.id.au>

Thanks for finding this.  Any chance you could take a look at what we
have in .travis.yml today for running QEMU platforms and add this one?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190607/82f7de5f/attachment.sig>

  reply	other threads:[~2019-06-07 14:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-06  7:38 [U-Boot] [PATCH] aspeed/watchdog: Correct timeout value Joel Stanley
2019-06-07 14:57 ` Tom Rini [this message]
2019-06-17  5:55   ` Joel Stanley
2019-06-21  1:54 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190607145731.GO10942@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.