All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Chen-Yu Tsai <wens@kernel.org>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Michael Turquette <mturquette@baylibre.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
	linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/25] clk: Add CLK_HW_INIT_* macros using .parent_hws
Date: Fri, 07 Jun 2019 11:17:24 -0700	[thread overview]
Message-ID: <20190607181725.0086E20868@mail.kernel.org> (raw)
In-Reply-To: <20190520080421.12575-3-wens@kernel.org>

Quoting Chen-Yu Tsai (2019-05-20 01:03:58)
> A special CLK_HW_INIT_HWS macro is included, which takes an array of
> struct clk_hw *, but sets .num_parents to 1. This variant is to allow
> the reuse of the array, instead of having a compound literal allocated
> for each clk sharing the same parent.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
[...]
> diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> index bb6118f79784..0c241b43a802 100644
> --- a/include/linux/clk-provider.h
> +++ b/include/linux/clk-provider.h
> @@ -904,6 +904,24 @@ extern struct of_device_id __clk_of_table;
>                 .ops            = _ops,                         \
>         })
>  
> +#define CLK_HW_INIT_HW(_name, _parent, _ops, _flags)                   \
> +       (&(struct clk_init_data) {                                      \
> +               .flags          = _flags,                               \
> +               .name           = _name,                                \
> +               .parent_hws     = (const struct clk_hw*[]) { _parent }, \
> +               .num_parents    = 1,                                    \
> +               .ops            = _ops,                                 \
> +       })
> +
> +#define CLK_HW_INIT_HWS(_name, _parent, _ops, _flags)                  \

Minor nitpick, please add a comment here to indicate that this is here
to share the same compound literal between multiple clks using the same
parent.

> +       (&(struct clk_init_data) {                                      \
> +               .flags          = _flags,                               \
> +               .name           = _name,                                \
> +               .parent_hws     = _parent,                              \
> +               .num_parents    = 1,                                    \
> +               .ops            = _ops,                                 \
> +       })

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Chen-Yu Tsai <wens@kernel.org>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Michael Turquette <mturquette@baylibre.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/25] clk: Add CLK_HW_INIT_* macros using .parent_hws
Date: Fri, 07 Jun 2019 11:17:24 -0700	[thread overview]
Message-ID: <20190607181725.0086E20868@mail.kernel.org> (raw)
In-Reply-To: <20190520080421.12575-3-wens@kernel.org>

Quoting Chen-Yu Tsai (2019-05-20 01:03:58)
> A special CLK_HW_INIT_HWS macro is included, which takes an array of
> struct clk_hw *, but sets .num_parents to 1. This variant is to allow
> the reuse of the array, instead of having a compound literal allocated
> for each clk sharing the same parent.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
[...]
> diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> index bb6118f79784..0c241b43a802 100644
> --- a/include/linux/clk-provider.h
> +++ b/include/linux/clk-provider.h
> @@ -904,6 +904,24 @@ extern struct of_device_id __clk_of_table;
>                 .ops            = _ops,                         \
>         })
>  
> +#define CLK_HW_INIT_HW(_name, _parent, _ops, _flags)                   \
> +       (&(struct clk_init_data) {                                      \
> +               .flags          = _flags,                               \
> +               .name           = _name,                                \
> +               .parent_hws     = (const struct clk_hw*[]) { _parent }, \
> +               .num_parents    = 1,                                    \
> +               .ops            = _ops,                                 \
> +       })
> +
> +#define CLK_HW_INIT_HWS(_name, _parent, _ops, _flags)                  \

Minor nitpick, please add a comment here to indicate that this is here
to share the same compound literal between multiple clks using the same
parent.

> +       (&(struct clk_init_data) {                                      \
> +               .flags          = _flags,                               \
> +               .name           = _name,                                \
> +               .parent_hws     = _parent,                              \
> +               .num_parents    = 1,                                    \
> +               .ops            = _ops,                                 \
> +       })

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-06-07 18:17 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20  8:03 [PATCH 00/25] clk: sunxi-ng: clk parent rewrite part 1 Chen-Yu Tsai
2019-05-20  8:03 ` Chen-Yu Tsai
2019-05-20  8:03 ` [PATCH 01/25] clk: Fix debugfs clk_possible_parents for clks without parent string names Chen-Yu Tsai
2019-05-20  8:03   ` Chen-Yu Tsai
2019-06-07 18:14   ` Stephen Boyd
2019-06-07 18:14     ` Stephen Boyd
2019-05-20  8:03 ` [PATCH 02/25] clk: Add CLK_HW_INIT_* macros using .parent_hws Chen-Yu Tsai
2019-05-20  8:03   ` Chen-Yu Tsai
2019-06-07 18:17   ` Stephen Boyd [this message]
2019-06-07 18:17     ` Stephen Boyd
2019-05-20  8:03 ` [PATCH 03/25] clk: Add CLK_HW_INIT_FW_NAME macro using .fw_name in .parent_data Chen-Yu Tsai
2019-05-20  8:03   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 04/25] clk: Add CLK_HW_INIT_PARENT_DATA macro using .parent_data Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 05/25] clk: fixed-factor: Add CLK_FIXED_FACTOR_HW which takes clk_hw pointer as parent Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 06/25] clk: fixed-factor: Add CLK_FIXED_FACTOR_HWS which takes list of struct clk_hw * Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 07/25] clk: fixed-factor: Add CLK_FIXED_FACTOR_FW_NAME for DT clock-names parent Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 08/25] clk: sunxi-ng: switch to of_clk_hw_register() for registering clks Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 09/25] clk: sunxi-ng: sun8i-r: Use local parent references for CLK_HW_INIT_* Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 10/25] clk: sunxi-ng: a10: Use local parent references for CLK_FIXED_FACTOR Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 11/25] clk: sunxi-ng: sun5i: " Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 12/25] clk: sunxi-ng: a31: " Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 13/25] clk: sunxi-ng: a23: " Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 14/25] clk: sunxi-ng: a33: " Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 15/25] clk: sunxi-ng: h3: " Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 16/25] clk: sunxi-ng: r40: " Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 17/25] clk: sunxi-ng: v3s: " Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 18/25] clk: sunxi-ng: sun8i-r: " Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 19/25] clk: sunxi-ng: f1c100s: " Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 20/25] clk: sunxi-ng: a64: " Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 21/25] clk: sunxi-ng: h6: " Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 22/25] clk: sunxi-ng: h6-r: " Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 23/25] clk: sunxi-ng: gate: Add macros for referencing local clock parents Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 24/25] clk: sunxi-ng: a80-usb: Use local parent references for SUNXI_CCU_GATE Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  8:04 ` [PATCH 25/25] clk: sunxi-ng: sun8i-r: " Chen-Yu Tsai
2019-05-20  8:04   ` Chen-Yu Tsai
2019-05-20  9:03 ` [PATCH 00/25] clk: sunxi-ng: clk parent rewrite part 1 Maxime Ripard
2019-05-20  9:03   ` Maxime Ripard
2019-06-03 16:38   ` Chen-Yu Tsai
2019-06-03 16:38     ` Chen-Yu Tsai
2019-06-07 18:46     ` Stephen Boyd
2019-06-07 18:46       ` Stephen Boyd
2019-06-11  5:34       ` Chen-Yu Tsai
2019-06-11  5:34         ` Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190607181725.0086E20868@mail.kernel.org \
    --to=sboyd@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@bootlin.com \
    --cc=mturquette@baylibre.com \
    --cc=wens@csie.org \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.