From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8569C28CC5 for ; Sat, 8 Jun 2019 13:40:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B683216C4 for ; Sat, 8 Jun 2019 13:40:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560001212; bh=J92X63eJnF4/ZVdxVIzn3vP2M1eHZgcHuOyotC/SU70=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=QEFFzgeE7O6pOvSOLoWjVsy/86UUYScdzOpZ1Khk6IfcXvB/b8jdZABpLTGvSGvqy gzWb+wAYTsEXUv93HEgYusjR0AFJBiLn+nCmTqGfkauPB0d23pSfMEXOO+yfJRsgYs yhDAEiiqE43wnmi20jMBAl/EoIbgV7A0qxNtp6d4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727223AbfFHNkM (ORCPT ); Sat, 8 Jun 2019 09:40:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:56536 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726227AbfFHNkL (ORCPT ); Sat, 8 Jun 2019 09:40:11 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E242D214C6; Sat, 8 Jun 2019 13:40:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560001210; bh=J92X63eJnF4/ZVdxVIzn3vP2M1eHZgcHuOyotC/SU70=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m73bra1Z+41F0rgW/uhg+IO5K040f0AtsUsJDeViRz2rbmwBQHi02yq9+vforBjdz McI+37imngbfGlmpzulh2QG7T5hy9uGJCLBinLya2e6DcmT+M0SRJCe5BLMJuNgylf O3SlY3L1djbLQDYAsNPNro2UzNxTEWRYVUHcHg6E= Date: Sat, 8 Jun 2019 15:40:08 +0200 From: Greg KH To: Pawel Laszczak Cc: devicetree@vger.kernel.org, felipe.balbi@linux.intel.com, linux-usb@vger.kernel.org, hdegoede@redhat.com, heikki.krogerus@linux.intel.com, robh+dt@kernel.org, rogerq@ti.com, linux-kernel@vger.kernel.org, jbergsagel@ti.com, nsekhar@ti.com, nm@ti.com, sureshp@cadence.com, peter.chen@nxp.com, jpawar@cadence.com, kurahul@cadence.com Subject: Re: [PATCH v7 2/6] usb:common Separated decoding functions from dwc3 driver. Message-ID: <20190608134008.GB11489@kroah.com> References: <1559729030-16390-1-git-send-email-pawell@cadence.com> <1559729030-16390-3-git-send-email-pawell@cadence.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1559729030-16390-3-git-send-email-pawell@cadence.com> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 05, 2019 at 11:03:46AM +0100, Pawel Laszczak wrote: > Patch moves some decoding functions from driver/usb/dwc3/debug.h driver > to driver/usb/common/debug.c file. These moved functions include: > dwc3_decode_get_status > dwc3_decode_set_clear_feature > dwc3_decode_set_address > dwc3_decode_get_set_descriptor > dwc3_decode_get_configuration > dwc3_decode_set_configuration > dwc3_decode_get_intf > dwc3_decode_set_intf > dwc3_decode_synch_frame > dwc3_decode_set_sel > dwc3_decode_set_isoch_delay > dwc3_decode_ctrl > > These functions are used also in inroduced cdns3 driver. > > All functions prefixes were changed from dwc3 to usb. > Also, function's parameters has been extended according to the name > of fields in standard SETUP packet. > Additionally, patch adds usb_decode_ctrl function to > include/linux/usb/ch9.h file.i > > Signed-off-by: Pawel Laszczak > --- > drivers/usb/common/Makefile | 2 +- > drivers/usb/common/debug.c | 273 ++++++++++++++++++++++++++++++++++++ > drivers/usb/dwc3/debug.h | 252 --------------------------------- > drivers/usb/dwc3/trace.h | 2 +- > include/linux/usb/ch9.h | 25 ++++ > 5 files changed, 300 insertions(+), 254 deletions(-) > create mode 100644 drivers/usb/common/debug.c > > diff --git a/drivers/usb/common/Makefile b/drivers/usb/common/Makefile > index 0a7c45e85481..02eb01666289 100644 > --- a/drivers/usb/common/Makefile > +++ b/drivers/usb/common/Makefile > @@ -4,7 +4,7 @@ > # > > obj-$(CONFIG_USB_COMMON) += usb-common.o > -usb-common-y += common.o > +usb-common-y += common.o debug.o > usb-common-$(CONFIG_USB_LED_TRIG) += led.o > > obj-$(CONFIG_USB_OTG_FSM) += usb-otg-fsm.o > diff --git a/drivers/usb/common/debug.c b/drivers/usb/common/debug.c > new file mode 100644 > index 000000000000..f7218d794aa6 > --- /dev/null > +++ b/drivers/usb/common/debug.c > @@ -0,0 +1,273 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/** > + * Common USB debugging functions > + * > + * Copyright (C) 2010-2011 Texas Instruments Incorporated - http://www.ti.com > + * > + * Authors: Felipe Balbi , > + * Sebastian Andrzej Siewior > + */ > + > +#ifndef __LINUX_USB_COMMON_DEBUG > +#define __LINUX_USB_COMMON_DEBUG Why are you doing thsi in a .c file? thanks, greg k-h