From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3073C31E43 for ; Mon, 10 Jun 2019 16:48:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8416320820 for ; Mon, 10 Jun 2019 16:48:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560185286; bh=oFtb1o3AXLUr4k9TH9OD5ZZ8qF8S9a/ouxAXF91MYh0=; h=In-Reply-To:References:To:From:Cc:Subject:Date:List-ID:From; b=jrheFi51jOuCXBb6uJ9/4zkK4VVdv9XBRJ/wqVNb9acQjir9ounkg2T+y24ThGOc4 ZRFxFxYTZj0axBYFadx7EEliZbbctiuyzyQ2/1o8HBn931L+CyxUMp8bxGDVQ+vBCE W9XcwltauxVo2lf+yhpDmo76dFk/YjTcmT2sh+Ho= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727709AbfFJQsG (ORCPT ); Mon, 10 Jun 2019 12:48:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:53110 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726217AbfFJQsF (ORCPT ); Mon, 10 Jun 2019 12:48:05 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 18D15206C3; Mon, 10 Jun 2019 16:48:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560185285; bh=oFtb1o3AXLUr4k9TH9OD5ZZ8qF8S9a/ouxAXF91MYh0=; h=In-Reply-To:References:To:From:Cc:Subject:Date:From; b=tBcMESXBdsEGjobi+BHjlGd2RIqXKwu6aeRyd10RYmRrXjQpm69IIqrxRkhXkEUGP AQyCw2PvGkD4ULELPPRFasXJIN7qpaewJiXRuwPJDsMS6aGgFogx+c/GJwb3W3C3dm dVV/fDf3akooB5cM5Lom0XOdDCSitrtzKqlGPfuY= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <048a25c0-3a2c-3906-84d4-5eb67f3ce2ef@codeaurora.org> References: <1559754961-26783-1-git-send-email-sricharan@codeaurora.org> <1559754961-26783-6-git-send-email-sricharan@codeaurora.org> <20190608034835.GH24059@builder> <048a25c0-3a2c-3906-84d4-5eb67f3ce2ef@codeaurora.org> To: Bjorn Andersson , Sricharan R From: Stephen Boyd Cc: robh+dt@kernel.org, sboyd@codeaurora.org, linus.walleij@linaro.org, agross@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support User-Agent: alot/0.8.1 Date: Mon, 10 Jun 2019 09:48:04 -0700 Message-Id: <20190610164805.18D15206C3@mail.kernel.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Sricharan R (2019-06-10 08:45:22) > On 6/8/2019 9:18 AM, Bjorn Andersson wrote: > > On Wed 05 Jun 10:16 PDT 2019, Sricharan R wrote: > >> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/d= ts/qcom/ipq6018.dtsi > >> new file mode 100644 > >> index 0000000..79cccdd > >> --- /dev/null > >> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > >> + compatible =3D "fixed-clock"; > >> + clock-frequency =3D <32000>; > >> + #clock-cells =3D <0>; > >> + }; > >> + > >> + xo: xo { > >> + compatible =3D "fixed-clock"; > >> + clock-frequency =3D <24000000>; > >> + #clock-cells =3D <0>; > >> + }; > >> + > >> + bias_pll_cc_clk { > >=20 > > Please give this a label and reference it from the node that uses it > > (regardless of the implementation matching by clock name). > >=20 > ok, in that case, so might have to remove these for now, till we add > the corresponding users. Yes, please remove them. They don't look like board clks, instead they're SoC level details that need to be created by some clk driver like GCC. >=20 > >> + compatible =3D "fixed-clock"; > >> + clock-frequency =3D <300000000>; > >> + #clock-cells =3D <0>; > >> + }; > >> + > >> + bias_pll_nss_noc_clk { > >> + compatible =3D "fixed-clock"; > >> + clock-frequency =3D <416500000>; > >> + #clock-cells =3D <0>; > >> + }; > >> + From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD0C9C31E40 for ; Mon, 10 Jun 2019 16:48:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A627920820 for ; Mon, 10 Jun 2019 16:48:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RfhcfAem"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="tBcMESXB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A627920820 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:From:To: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7HwCSpL3zT8PCnccPx2fKKvdboRwpI5ZZawEjCzR0lw=; b=RfhcfAemromi6V 8hSCdauehtqKj/FqsNJC87MEYHEzZlPfKT+0qC+Vc7q3J+QAQBlSivueMCuJswcApyT03y+GP4tow yv//OFu05PEkI4WlM6hPZy/x3odcEEdWJSK8exChx0KLVdevewdNk2S+aI2iago7/yUPn3UwOOBys 3kdHuWnJRNWrTg2gvm/UQdhAz6AuDE8bnxEeAHBFwcfof0Tpb6+vEjhwsUWMQprhT+clvfdEU/Xlq 3OvdDhyDkygQWDw1Q6d83K534VwntVhR6cmiceumiG1DuqE+V4kAQowc30owi2nrKMMsH/Y+MF318 uC9mbNY6Uv7cnCl9Ul4Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1haNSq-00059z-AE; Mon, 10 Jun 2019 16:48:08 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1haNSn-00059e-NM for linux-arm-kernel@lists.infradead.org; Mon, 10 Jun 2019 16:48:06 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 18D15206C3; Mon, 10 Jun 2019 16:48:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560185285; bh=oFtb1o3AXLUr4k9TH9OD5ZZ8qF8S9a/ouxAXF91MYh0=; h=In-Reply-To:References:To:From:Cc:Subject:Date:From; b=tBcMESXBdsEGjobi+BHjlGd2RIqXKwu6aeRyd10RYmRrXjQpm69IIqrxRkhXkEUGP AQyCw2PvGkD4ULELPPRFasXJIN7qpaewJiXRuwPJDsMS6aGgFogx+c/GJwb3W3C3dm dVV/fDf3akooB5cM5Lom0XOdDCSitrtzKqlGPfuY= MIME-Version: 1.0 In-Reply-To: <048a25c0-3a2c-3906-84d4-5eb67f3ce2ef@codeaurora.org> References: <1559754961-26783-1-git-send-email-sricharan@codeaurora.org> <1559754961-26783-6-git-send-email-sricharan@codeaurora.org> <20190608034835.GH24059@builder> <048a25c0-3a2c-3906-84d4-5eb67f3ce2ef@codeaurora.org> To: Bjorn Andersson , Sricharan R From: Stephen Boyd Subject: Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support User-Agent: alot/0.8.1 Date: Mon, 10 Jun 2019 09:48:04 -0700 Message-Id: <20190610164805.18D15206C3@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190610_094805_780312_3690989D X-CRM114-Status: GOOD ( 12.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linus.walleij@linaro.org, sboyd@codeaurora.org, agross@kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, robh+dt@kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Sricharan R (2019-06-10 08:45:22) > On 6/8/2019 9:18 AM, Bjorn Andersson wrote: > > On Wed 05 Jun 10:16 PDT 2019, Sricharan R wrote: > >> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > >> new file mode 100644 > >> index 0000000..79cccdd > >> --- /dev/null > >> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > >> + compatible = "fixed-clock"; > >> + clock-frequency = <32000>; > >> + #clock-cells = <0>; > >> + }; > >> + > >> + xo: xo { > >> + compatible = "fixed-clock"; > >> + clock-frequency = <24000000>; > >> + #clock-cells = <0>; > >> + }; > >> + > >> + bias_pll_cc_clk { > > > > Please give this a label and reference it from the node that uses it > > (regardless of the implementation matching by clock name). > > > ok, in that case, so might have to remove these for now, till we add > the corresponding users. Yes, please remove them. They don't look like board clks, instead they're SoC level details that need to be created by some clk driver like GCC. > > >> + compatible = "fixed-clock"; > >> + clock-frequency = <300000000>; > >> + #clock-cells = <0>; > >> + }; > >> + > >> + bias_pll_nss_noc_clk { > >> + compatible = "fixed-clock"; > >> + clock-frequency = <416500000>; > >> + #clock-cells = <0>; > >> + }; > >> + _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel