From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A239C4321A for ; Tue, 11 Jun 2019 08:57:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E739320657 for ; Tue, 11 Jun 2019 08:57:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E739320657 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53048 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hacaZ-0008KV-7V for qemu-devel@archiver.kernel.org; Tue, 11 Jun 2019 04:57:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56549) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hacUz-0002pw-7Z for qemu-devel@nongnu.org; Tue, 11 Jun 2019 04:51:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hacUw-0005Sr-AU for qemu-devel@nongnu.org; Tue, 11 Jun 2019 04:51:20 -0400 Received: from mga01.intel.com ([192.55.52.88]:31704) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hacUu-0005MU-I3 for qemu-devel@nongnu.org; Tue, 11 Jun 2019 04:51:18 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jun 2019 01:51:07 -0700 X-ExtLoop1: 1 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga002.jf.intel.com with ESMTP; 11 Jun 2019 01:51:05 -0700 Date: Tue, 11 Jun 2019 16:50:41 +0800 From: Wei Yang To: Juan Quintela Message-ID: <20190611085040.GA28950@richard> References: <20190402003106.17614-1-richardw.yang@linux.intel.com> <20190611082520.GA11125@richard> <87zhmottba.fsf@trasno.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zhmottba.fsf@trasno.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.88 Subject: Re: [Qemu-devel] [PATCH] migration: remove unused field bytes_xfer X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Wei Yang Cc: Wei Yang , dgilbert@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jun 11, 2019 at 10:33:29AM +0200, Juan Quintela wrote: >Wei Yang wrote: >> On Tue, Apr 02, 2019 at 08:31:06AM +0800, Wei Yang wrote: >>>MigrationState->bytes_xfer is only set to 0 in migrate_init(). >>> >>>Remove this unnecessary field. >>> >>>Signed-off-by: Wei Yang >> >> Hi, David > >Hi > >I am on duty this week, will get it. Thanks :-) > >> >> Are you willing to pick up this one? >> >>>--- >>> migration/migration.c | 1 - >>> migration/migration.h | 1 - >>> 2 files changed, 2 deletions(-) >>> >>>diff --git a/migration/migration.c b/migration/migration.c >>>index dea7078bf4..c929cf8d0f 100644 >>>--- a/migration/migration.c >>>+++ b/migration/migration.c >>>@@ -1681,7 +1681,6 @@ void migrate_init(MigrationState *s) >>> * parameters/capabilities that the user set, and >>> * locks. >>> */ >>>- s->bytes_xfer = 0; >>> s->cleanup_bh = 0; >>> s->to_dst_file = NULL; >>> s->rp_state.from_dst_file = NULL; >>>diff --git a/migration/migration.h b/migration/migration.h >>>index 852eb3c4e9..b9efbe9168 100644 >>>--- a/migration/migration.h >>>+++ b/migration/migration.h >>>@@ -116,7 +116,6 @@ struct MigrationState >>> DeviceState parent_obj; >>> >>> /*< public >*/ >>>- size_t bytes_xfer; >>> QemuThread thread; >>> QEMUBH *cleanup_bh; >>> QEMUFile *to_dst_file; >>>-- >>>2.19.1 -- Wei Yang Help you, Help me