From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42468C43218 for ; Tue, 11 Jun 2019 10:19:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 175FD208E3 for ; Tue, 11 Jun 2019 10:19:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560248346; bh=ECxRPjnnyOauLHhaZ2dGgISLKOhjT/mVaqEpGjVMnh0=; h=From:To:Cc:Subject:Date:List-ID:From; b=nOQgIl7cGQt8HWtP2O8xdRd/q6RaRYR0mwn4YSjKhqreDvjfRXGy4eyqXNgoqEhMc wmdiaMP5QIn4HFOhhmUol5ihU8ZHqI1IHobaiKlxRTRQODjyMsqB2RCIy7iOmaV2IT hvnaOV0qfJfMVV2mSQBRv0qAvADhxp+tVxUlqoZI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405613AbfFKKTF (ORCPT ); Tue, 11 Jun 2019 06:19:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:45566 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405104AbfFKKRW (ORCPT ); Tue, 11 Jun 2019 06:17:22 -0400 Received: from wens.tw (mirror2.csie.ntu.edu.tw [140.112.30.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 26ED72146E; Tue, 11 Jun 2019 10:17:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560248241; bh=ECxRPjnnyOauLHhaZ2dGgISLKOhjT/mVaqEpGjVMnh0=; h=From:To:Cc:Subject:Date:From; b=K/6bUhwaYp9/MWjk2zZJtPZ8uEqONxLXgvGkOchuijFaSBSSr0b38F6VzmafLosY4 NNHC8feiwpsi1pFLMlGJ88Kcl37Ht2W+yGRhGa5L+yTDweHtJ5XH/kaH4QYEPtPRtY e6C3Xo32z1ZqyJSL3c2n+7t2hiLliYvdYMQMjRVQ= Received: by wens.tw (Postfix, from userid 1000) id 0A2275FBB7; Tue, 11 Jun 2019 18:17:18 +0800 (CST) From: Chen-Yu Tsai To: Maxime Ripard , Stephen Boyd , Michael Turquette Cc: Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 00/25] clk: sunxi-ng: clk parent rewrite part 1 Date: Tue, 11 Jun 2019 18:16:33 +0800 Message-Id: <20190611101658.23855-1-wens@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chen-Yu Tsai Hi everyone, This is v2 of the sunxi-ng clk parent rewrite part 1. Changes since v1: - Collected Maxime's Acked-by for sunxi patches - Expanded possible_parents_show() to cover most cases - Added comment to CLK_HW_INIT_HWS detailing usage for sharing compound literal As mentioned in my reply to the cover letter of v1, I can merge all the patches through the sunxi tree and send a combined (with other sunxi stuff) PR, or as an independent branch, whichever is preferred. Excerpt from original cover letter follows: This is series is the first part of a large series (I haven't done the rest) of patches to rewrite the clk parent relationship handling within the sunxi-ng clk driver. This is based on Stephen's recent work allowing clk drivers to specify clk parents using struct clk_hw * or parsing DT phandles in the clk node. This series can be split into a few major parts: 1) The first patch is a small fix for clk debugfs representation. This was done before commit 1a079560b145 ("clk: Cache core in clk_fetch_parent_index() without names") was posted, so it might or might not be needed. Found this when checking my work using clk_possible_parents. 2) A bunch of CLK_HW_INIT_* helper macros are added. These cover the situations I encountered, or assume I will encounter, such as single internal (struct clk_hw *) parent, single DT (struct clk_parent_data .fw_name), multiple internal parents, and multiple mixed (internal + DT) parents. A special variant for just an internal single parent is added, CLK_HW_INIT_HWS, which lets the driver share the singular list, instead of having the compiler create a compound literal every time. It might even make sense to only keep this variant. 3) A bunch of CLK_FIXED_FACTOR_* helper macros are added. The rationale is the same as the single parent CLK_HW_INIT_* helpers. 4) Bulk conversion of CLK_FIXED_FACTOR to use local parent references, either struct clk_hw * or DT .fw_name types, whichever the hardware requires. 5) The beginning of SUNXI_CCU_GATE conversion to local parent references. This part is not done. They are included as justification and examples for the shared list of clk parents case. Thanks ChenYu Chen-Yu Tsai (25): clk: Fix debugfs clk_possible_parents for clks without parent string names clk: Add CLK_HW_INIT_* macros using .parent_hws clk: Add CLK_HW_INIT_FW_NAME macro using .fw_name in .parent_data clk: Add CLK_HW_INIT_PARENT_DATA macro using .parent_data clk: fixed-factor: Add CLK_FIXED_FACTOR_HW which takes clk_hw pointer as parent clk: fixed-factor: Add CLK_FIXED_FACTOR_HWS which takes list of struct clk_hw * clk: fixed-factor: Add CLK_FIXED_FACTOR_FW_NAME for DT clock-names parent clk: sunxi-ng: switch to of_clk_hw_register() for registering clks clk: sunxi-ng: sun8i-r: Use local parent references for CLK_HW_INIT_* clk: sunxi-ng: a10: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: sun5i: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: a31: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: a23: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: a33: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: h3: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: r40: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: v3s: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: sun8i-r: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: f1c100s: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: a64: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: h6: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: h6-r: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: gate: Add macros for referencing local clock parents clk: sunxi-ng: a80-usb: Use local parent references for SUNXI_CCU_GATE clk: sunxi-ng: sun8i-r: Use local parent references for SUNXI_CCU_GATE drivers/clk/clk.c | 44 +++++++++- drivers/clk/sunxi-ng/ccu-sun4i-a10.c | 39 ++++++--- drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 41 +++++---- drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c | 2 +- drivers/clk/sunxi-ng/ccu-sun50i-h6.c | 69 +++++++++------ drivers/clk/sunxi-ng/ccu-sun5i.c | 34 +++++--- drivers/clk/sunxi-ng/ccu-sun6i-a31.c | 39 ++++++--- drivers/clk/sunxi-ng/ccu-sun8i-a23.c | 34 +++++--- drivers/clk/sunxi-ng/ccu-sun8i-a33.c | 34 +++++--- drivers/clk/sunxi-ng/ccu-sun8i-h3.c | 29 ++++--- drivers/clk/sunxi-ng/ccu-sun8i-r.c | 104 +++++++++++------------ drivers/clk/sunxi-ng/ccu-sun8i-r40.c | 46 ++++++---- drivers/clk/sunxi-ng/ccu-sun8i-v3s.c | 29 ++++--- drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c | 32 ++++--- drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c | 29 ++++--- drivers/clk/sunxi-ng/ccu_common.c | 2 +- drivers/clk/sunxi-ng/ccu_gate.h | 53 ++++++++++++ include/linux/clk-provider.h | 89 +++++++++++++++++++ 18 files changed, 526 insertions(+), 223 deletions(-) -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FE57C43218 for ; Tue, 11 Jun 2019 10:18:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E688E205F4 for ; Tue, 11 Jun 2019 10:18:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UY8T0I2F"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="K/6bUhwa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E688E205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=C1BcgYck3ZQSlLcgMQ5Uc5AfvmpgF4EXGwmyXPxmpP8=; b=UY8T0I2FcZ6Dcd XlaQ05PSPpcevFCMdZ+FZMXYZ3PDrQ4Vyehz439O5Qi2WGf2ZA786WvPGX+c9ldp1RMfMcVZrvFOe z98zyMmb8yGoKjZG0GDyMutmb1LxpYH98zI6qYR1VC1OfSXdaBzQuHRnkclHeRBxCuiETEBsFIotV 4E0UKn6k1swhjjLChh/it96Izb0Iu1sdrAi2FUDNaaA0C0jMehZQ/ZDpa/kb10cInpisKWu+TV2FG rTh0igyp1ek7mewG8nRGVA4k8XN2ikyxA3yijJNvwuNqns1oAVZmEckporWgcHnsr1OXR7Y1N1Ann kJQ+1NYnDjkEoHU7TXMA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hadrd-0002h8-Aa; Tue, 11 Jun 2019 10:18:49 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hadqD-0001WT-Nj for linux-arm-kernel@lists.infradead.org; Tue, 11 Jun 2019 10:17:24 +0000 Received: from wens.tw (mirror2.csie.ntu.edu.tw [140.112.30.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 26ED72146E; Tue, 11 Jun 2019 10:17:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560248241; bh=ECxRPjnnyOauLHhaZ2dGgISLKOhjT/mVaqEpGjVMnh0=; h=From:To:Cc:Subject:Date:From; b=K/6bUhwaYp9/MWjk2zZJtPZ8uEqONxLXgvGkOchuijFaSBSSr0b38F6VzmafLosY4 NNHC8feiwpsi1pFLMlGJ88Kcl37Ht2W+yGRhGa5L+yTDweHtJ5XH/kaH4QYEPtPRtY e6C3Xo32z1ZqyJSL3c2n+7t2hiLliYvdYMQMjRVQ= Received: by wens.tw (Postfix, from userid 1000) id 0A2275FBB7; Tue, 11 Jun 2019 18:17:18 +0800 (CST) From: Chen-Yu Tsai To: Maxime Ripard , Stephen Boyd , Michael Turquette Subject: [PATCH v2 00/25] clk: sunxi-ng: clk parent rewrite part 1 Date: Tue, 11 Jun 2019 18:16:33 +0800 Message-Id: <20190611101658.23855-1-wens@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190611_031721_814212_C3A06762 X-CRM114-Status: GOOD ( 11.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chen-Yu Tsai , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Chen-Yu Tsai Hi everyone, This is v2 of the sunxi-ng clk parent rewrite part 1. Changes since v1: - Collected Maxime's Acked-by for sunxi patches - Expanded possible_parents_show() to cover most cases - Added comment to CLK_HW_INIT_HWS detailing usage for sharing compound literal As mentioned in my reply to the cover letter of v1, I can merge all the patches through the sunxi tree and send a combined (with other sunxi stuff) PR, or as an independent branch, whichever is preferred. Excerpt from original cover letter follows: This is series is the first part of a large series (I haven't done the rest) of patches to rewrite the clk parent relationship handling within the sunxi-ng clk driver. This is based on Stephen's recent work allowing clk drivers to specify clk parents using struct clk_hw * or parsing DT phandles in the clk node. This series can be split into a few major parts: 1) The first patch is a small fix for clk debugfs representation. This was done before commit 1a079560b145 ("clk: Cache core in clk_fetch_parent_index() without names") was posted, so it might or might not be needed. Found this when checking my work using clk_possible_parents. 2) A bunch of CLK_HW_INIT_* helper macros are added. These cover the situations I encountered, or assume I will encounter, such as single internal (struct clk_hw *) parent, single DT (struct clk_parent_data .fw_name), multiple internal parents, and multiple mixed (internal + DT) parents. A special variant for just an internal single parent is added, CLK_HW_INIT_HWS, which lets the driver share the singular list, instead of having the compiler create a compound literal every time. It might even make sense to only keep this variant. 3) A bunch of CLK_FIXED_FACTOR_* helper macros are added. The rationale is the same as the single parent CLK_HW_INIT_* helpers. 4) Bulk conversion of CLK_FIXED_FACTOR to use local parent references, either struct clk_hw * or DT .fw_name types, whichever the hardware requires. 5) The beginning of SUNXI_CCU_GATE conversion to local parent references. This part is not done. They are included as justification and examples for the shared list of clk parents case. Thanks ChenYu Chen-Yu Tsai (25): clk: Fix debugfs clk_possible_parents for clks without parent string names clk: Add CLK_HW_INIT_* macros using .parent_hws clk: Add CLK_HW_INIT_FW_NAME macro using .fw_name in .parent_data clk: Add CLK_HW_INIT_PARENT_DATA macro using .parent_data clk: fixed-factor: Add CLK_FIXED_FACTOR_HW which takes clk_hw pointer as parent clk: fixed-factor: Add CLK_FIXED_FACTOR_HWS which takes list of struct clk_hw * clk: fixed-factor: Add CLK_FIXED_FACTOR_FW_NAME for DT clock-names parent clk: sunxi-ng: switch to of_clk_hw_register() for registering clks clk: sunxi-ng: sun8i-r: Use local parent references for CLK_HW_INIT_* clk: sunxi-ng: a10: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: sun5i: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: a31: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: a23: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: a33: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: h3: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: r40: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: v3s: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: sun8i-r: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: f1c100s: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: a64: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: h6: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: h6-r: Use local parent references for CLK_FIXED_FACTOR clk: sunxi-ng: gate: Add macros for referencing local clock parents clk: sunxi-ng: a80-usb: Use local parent references for SUNXI_CCU_GATE clk: sunxi-ng: sun8i-r: Use local parent references for SUNXI_CCU_GATE drivers/clk/clk.c | 44 +++++++++- drivers/clk/sunxi-ng/ccu-sun4i-a10.c | 39 ++++++--- drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 41 +++++---- drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c | 2 +- drivers/clk/sunxi-ng/ccu-sun50i-h6.c | 69 +++++++++------ drivers/clk/sunxi-ng/ccu-sun5i.c | 34 +++++--- drivers/clk/sunxi-ng/ccu-sun6i-a31.c | 39 ++++++--- drivers/clk/sunxi-ng/ccu-sun8i-a23.c | 34 +++++--- drivers/clk/sunxi-ng/ccu-sun8i-a33.c | 34 +++++--- drivers/clk/sunxi-ng/ccu-sun8i-h3.c | 29 ++++--- drivers/clk/sunxi-ng/ccu-sun8i-r.c | 104 +++++++++++------------ drivers/clk/sunxi-ng/ccu-sun8i-r40.c | 46 ++++++---- drivers/clk/sunxi-ng/ccu-sun8i-v3s.c | 29 ++++--- drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c | 32 ++++--- drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c | 29 ++++--- drivers/clk/sunxi-ng/ccu_common.c | 2 +- drivers/clk/sunxi-ng/ccu_gate.h | 53 ++++++++++++ include/linux/clk-provider.h | 89 +++++++++++++++++++ 18 files changed, 526 insertions(+), 223 deletions(-) -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel