All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
	"Yoshinori Sato" <ysato@users.sourceforge.jp>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [Qemu-devel] [PATCH v19 07/21] target/rx: Use prt_ldmi for XCHG_mr disassembly
Date: Tue, 11 Jun 2019 13:37:17 +0200	[thread overview]
Message-ID: <20190611113731.16940-8-philmd@redhat.com> (raw)
In-Reply-To: <20190611113731.16940-1-philmd@redhat.com>

From: Richard Henderson <richard.henderson@linaro.org>

Note that the ld == 3 case handled by prt_ldmi is decoded as
XCHG_rr and cannot appear here.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Message-Id: <20190607091116.49044-21-ysato@users.sourceforge.jp>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/rx/disas.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/target/rx/disas.c b/target/rx/disas.c
index 515b365528..db10385fd0 100644
--- a/target/rx/disas.c
+++ b/target/rx/disas.c
@@ -366,13 +366,7 @@ static bool trans_XCHG_rr(DisasContext *ctx, arg_XCHG_rr *a)
 /* xchg dsp[rs].<mi>,rd */
 static bool trans_XCHG_mr(DisasContext *ctx, arg_XCHG_mr *a)
 {
-    static const char msize[][4] = {
-        "b", "w", "l", "ub", "uw",
-    };
-    char dsp[8];
-
-    rx_index_addr(ctx, dsp, a->ld, a->mi);
-    prt("xchg\t%s[r%d].%s, r%d", dsp, a->rs, msize[a->mi], a->rd);
+    prt_ldmi(ctx, "xchg", a->ld, a->mi, a->rs, a->rd);
     return true;
 }
 
-- 
2.20.1



  parent reply	other threads:[~2019-06-11 12:05 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-11 11:37 [Qemu-devel] [PATCH v19 00/21] Add RX archtecture support Philippe Mathieu-Daudé
2019-06-11 11:37 ` [Qemu-devel] [PATCH v19 01/21] target/rx: TCG translation Philippe Mathieu-Daudé
2019-06-11 11:37 ` [Qemu-devel] [PATCH v19 02/21] target/rx: TCG helper Philippe Mathieu-Daudé
2019-06-11 11:37 ` [Qemu-devel] [PATCH v19 03/21] target/rx: CPU definition Philippe Mathieu-Daudé
2019-06-11 13:12   ` Igor Mammedov
2019-06-11 11:37 ` [Qemu-devel] [PATCH v19 04/21] target/rx: RX disassembler Philippe Mathieu-Daudé
2019-06-11 11:37 ` [Qemu-devel] [PATCH v19 05/21] target/rx: Disassemble rx_index_addr into a string Philippe Mathieu-Daudé
2019-06-11 11:37 ` [Qemu-devel] [PATCH v19 06/21] target/rx: Replace operand with prt_ldmi in disassembler Philippe Mathieu-Daudé
2019-06-11 11:37 ` Philippe Mathieu-Daudé [this message]
2019-06-11 11:37 ` [Qemu-devel] [PATCH v19 08/21] target/rx: Emit all disassembly in one prt() Philippe Mathieu-Daudé
2019-06-11 11:37 ` [Qemu-devel] [PATCH v19 09/21] target/rx: Collect all bytes during disassembly Philippe Mathieu-Daudé
2019-06-11 11:37 ` [Qemu-devel] [PATCH v19 10/21] target/rx: Dump bytes for each insn " Philippe Mathieu-Daudé
2019-06-11 11:37 ` [Qemu-devel] [PATCH v19 11/21] hw/intc: RX62N interrupt controller (ICUa) Philippe Mathieu-Daudé
2019-06-11 11:37 ` [Qemu-devel] [PATCH v19 12/21] hw/timer: RX62N internal timer modules Philippe Mathieu-Daudé
2019-06-11 11:37 ` [Qemu-devel] [PATCH v19 13/21] hw/char: RX62N serial communication interface (SCI) Philippe Mathieu-Daudé
2019-06-11 11:37 ` [Qemu-devel] [PATCH v19 14/21] hw/rx: RX Target hardware definition Philippe Mathieu-Daudé
2019-06-11 11:37 ` [Qemu-devel] [PATCH v19 15/21] hw/rx: Honor -accel qtest Philippe Mathieu-Daudé
2019-06-11 11:37 ` [Qemu-devel] [PATCH v19 16/21] hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core Philippe Mathieu-Daudé
2019-06-11 13:21   ` Yoshinori Sato
2019-06-11 11:37 ` [Qemu-devel] [PATCH v19 17/21] qemu/bitops.h: Add extract8 and extract16 Philippe Mathieu-Daudé
2019-06-11 11:37 ` [Qemu-devel] [PATCH v19 18/21] hw/registerfields.h: Add 8bit and 16bit register macros Philippe Mathieu-Daudé
2019-06-11 11:37 ` [Qemu-devel] [PATCH v19 19/21] Add rx-softmmu Philippe Mathieu-Daudé
2019-06-11 11:37 ` [Qemu-devel] [PATCH v19 20/21] MAINTAINERS: Add RX Philippe Mathieu-Daudé
2019-06-11 11:37 ` [Qemu-devel] [PATCH v19 21/21] BootLinuxConsoleTest: Test the RX-Virt machine Philippe Mathieu-Daudé
2019-06-11 12:59 ` [Qemu-devel] [PATCH v19 00/21] Add RX archtecture support no-reply
2019-06-11 13:19 ` no-reply
2019-06-11 13:21 ` no-reply
2019-06-11 13:39 ` no-reply
2019-06-11 13:42 ` no-reply
2019-06-11 13:51 ` no-reply
2019-06-11 14:16 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190611113731.16940-8-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.