From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAE1DC4321A for ; Tue, 11 Jun 2019 12:46:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 760502089E for ; Tue, 11 Jun 2019 12:46:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389023AbfFKMqq (ORCPT ); Tue, 11 Jun 2019 08:46:46 -0400 Received: from foss.arm.com ([217.140.110.172]:60506 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387593AbfFKMqq (ORCPT ); Tue, 11 Jun 2019 08:46:46 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9E1EA344; Tue, 11 Jun 2019 05:46:45 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2D29B3F557; Tue, 11 Jun 2019 05:46:44 -0700 (PDT) Date: Tue, 11 Jun 2019 13:46:42 +0100 From: Mark Rutland To: Julien Thierry Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, marc.zyngier@arm.com, yuzenghui@huawei.com, wanghaibin.wang@huawei.com, james.morse@arm.com, will.deacon@arm.com, catalin.marinas@arm.com, liwei391@huawei.com Subject: Re: [PATCH v4 2/8] arm64: irqflags: Pass flags as readonly operand to restore instruction Message-ID: <20190611124641.GB29008@lakrids.cambridge.arm.com> References: <1560245893-46998-1-git-send-email-julien.thierry@arm.com> <1560245893-46998-3-git-send-email-julien.thierry@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1560245893-46998-3-git-send-email-julien.thierry@arm.com> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 11, 2019 at 10:38:07AM +0100, Julien Thierry wrote: > Flags are only read by the instructions doing the irqflags restore > operation. Pass the operand as read only to the asm inline instead of > read-write. > > Signed-off-by: Julien Thierry > Cc: Catalin Marinas > Cc: Will Deacon Acked-by: Mark Rutland Mark. > --- > arch/arm64/include/asm/irqflags.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/irqflags.h b/arch/arm64/include/asm/irqflags.h > index 62996318..9c93152 100644 > --- a/arch/arm64/include/asm/irqflags.h > +++ b/arch/arm64/include/asm/irqflags.h > @@ -119,8 +119,8 @@ static inline void arch_local_irq_restore(unsigned long flags) > __msr_s(SYS_ICC_PMR_EL1, "%0") > "dsb sy", > ARM64_HAS_IRQ_PRIO_MASKING) > - : "+r" (flags) > : > + : "r" (flags) > : "memory"); > } > > -- > 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9573C43218 for ; Tue, 11 Jun 2019 12:47:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 808062089E for ; Tue, 11 Jun 2019 12:47:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IiVhg1Y7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 808062089E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dlJQWyVQoh+4FtthY25GPgORjgVnw0wD9/ePlnIH2Ds=; b=IiVhg1Y7QZ8okG mH2GZcX/5afNsXbp6oEwDTdpN/zwA0hXfe6YqgZTxQdDEHqWnPAVufDYU47CtmsNzExHPZLJU8ezp YS2vxragrZ5Q2u/WWt9vfQYoDSVqc579qbV6Z3wDq3jouhqRUDCytXpj94cnCJPvubr1CqgPj79sc /jLrvU62pXpwj/nQGqlC31QyjdFVOwtcxr2uP4jtgmONCiZHi8ubvYEXTyU9SXao1ipbIXKmroDl+ CLZgizVm78tp8uyu1vSIfsIm2Ps6i+/xw+VT5Gwp3gvtwC5fFokkcTkEbewq7qKbozyvr0X/xGYOL 9TOreZsyvwZeSXbTnkkA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hagBA-0008D9-Te; Tue, 11 Jun 2019 12:47:09 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hagAo-000812-Hj for linux-arm-kernel@lists.infradead.org; Tue, 11 Jun 2019 12:46:51 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9E1EA344; Tue, 11 Jun 2019 05:46:45 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2D29B3F557; Tue, 11 Jun 2019 05:46:44 -0700 (PDT) Date: Tue, 11 Jun 2019 13:46:42 +0100 From: Mark Rutland To: Julien Thierry Subject: Re: [PATCH v4 2/8] arm64: irqflags: Pass flags as readonly operand to restore instruction Message-ID: <20190611124641.GB29008@lakrids.cambridge.arm.com> References: <1560245893-46998-1-git-send-email-julien.thierry@arm.com> <1560245893-46998-3-git-send-email-julien.thierry@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1560245893-46998-3-git-send-email-julien.thierry@arm.com> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190611_054646_632481_9C1F0BEE X-CRM114-Status: GOOD ( 13.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marc.zyngier@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, rostedt@goodmis.org, james.morse@arm.com, yuzenghui@huawei.com, wanghaibin.wang@huawei.com, liwei391@huawei.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 11, 2019 at 10:38:07AM +0100, Julien Thierry wrote: > Flags are only read by the instructions doing the irqflags restore > operation. Pass the operand as read only to the asm inline instead of > read-write. > > Signed-off-by: Julien Thierry > Cc: Catalin Marinas > Cc: Will Deacon Acked-by: Mark Rutland Mark. > --- > arch/arm64/include/asm/irqflags.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/irqflags.h b/arch/arm64/include/asm/irqflags.h > index 62996318..9c93152 100644 > --- a/arch/arm64/include/asm/irqflags.h > +++ b/arch/arm64/include/asm/irqflags.h > @@ -119,8 +119,8 @@ static inline void arch_local_irq_restore(unsigned long flags) > __msr_s(SYS_ICC_PMR_EL1, "%0") > "dsb sy", > ARM64_HAS_IRQ_PRIO_MASKING) > - : "+r" (flags) > : > + : "r" (flags) > : "memory"); > } > > -- > 1.9.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel