From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E971C4321B for ; Tue, 11 Jun 2019 13:52:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CC9B20673 for ; Tue, 11 Jun 2019 13:52:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="MrxNbxyw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390554AbfFKNwT (ORCPT ); Tue, 11 Jun 2019 09:52:19 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:35734 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728344AbfFKNwT (ORCPT ); Tue, 11 Jun 2019 09:52:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=IWz7rmxRuciLtbVGhKXAvWnIWoY/90SUiu16s3M1vAk=; b=MrxNbxywR2iqrcOnj6vuLsTEy tWldvXIf6cyAQENNln9VVSR4c4dc4mq9iq0ZiBlYqT+NEXj/xa2UBqMPcPTLee2+C1rZtOmresAMd 9gGkT6gOur2Qc6RC+Oxa6POW7rdb4t5F07I3FrP1nk6PNjviQYoLtMO4pfbJnHjbndylgNxjBNurw AW8ZdUfhyZCpgV3/X7hjLOpVeYJql4oqa8e7bCRgEFkzPOA1gkLqJbkH4EBK9DX3TjF+x/y7s3Wq6 UklaPdSaF7ZwsqIR9r/B9v1l2jotkzYTvPMQ9ns3I4dTNnupm+/2zKFMW5t3SNRyWF4o8pIOBGPYF lu39j1wOQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1hahC8-0003JG-TH; Tue, 11 Jun 2019 13:52:12 +0000 Date: Tue, 11 Jun 2019 06:52:12 -0700 From: Christoph Hellwig To: Pingfan Liu Cc: John Hubbard , Andrew Morton , linux-mm@kvack.org, Ira Weiny , Mike Rapoport , Dan Williams , Matthew Wilcox , "Aneesh Kumar K.V" , Keith Busch , Christoph Hellwig , LKML Subject: Re: [PATCHv3 1/2] mm/gup: fix omission of check on FOLL_LONGTERM in get_user_pages_fast() Message-ID: <20190611135212.GA4591@infradead.org> References: <1559725820-26138-1-git-send-email-kernelfans@gmail.com> <20190605144912.f0059d4bd13c563ddb37877e@linux-foundation.org> <2b0a65ec-4fb0-430e-3e6a-b713fb5bb28f@nvidia.com> <20190611122935.GA9919@dhcp-128-55.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190611122935.GA9919@dhcp-128-55.nay.redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 11, 2019 at 08:29:35PM +0800, Pingfan Liu wrote: > Unable to get a NVME device to have a test. And when testing fio on the How would a nvme test help? FOLL_LONGTERM isn't used by any performance critical path to start with, so I don't see how this patch could be a problem.