From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 248B8C4321A for ; Tue, 11 Jun 2019 17:39:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E84FD21734 for ; Tue, 11 Jun 2019 17:39:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fbkUKMkb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406403AbfFKRjC (ORCPT ); Tue, 11 Jun 2019 13:39:02 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:38493 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406386AbfFKRjB (ORCPT ); Tue, 11 Jun 2019 13:39:01 -0400 Received: by mail-wm1-f66.google.com with SMTP id s15so3832659wmj.3; Tue, 11 Jun 2019 10:38:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bT/SURAK35o6rlNBFscK2GtT4WEX3vtArRsrjCNbd3o=; b=fbkUKMkbL4rKolh+H6Zal00nm38cLO4RqX/6JfUHS//nmghe9YsT8w3GqLjV01ujzK Ja/TeK9eFGlCaqD09aoW7CZk2UBaJbnGzfRZvnxCVPh3dBILWB4RpNKlzWXeSDD4LqSu 9S0pC3fJrx48Kh1dD6zV3L9TjPBTxHZuRC8KFsmfZOB7avkFpwnRNKE+OkMZptSyeUKd u9Nfi9R3luE9uc4zNKl16o1B1kFgcvfXz6qUCMg4vLX1NI0wCgzb/K0E5/hPmequ47Yx H7QsqMlq9nwQGSlNhs/7pFjlT/YBrCmOd1QHgPvoGkkYB99dc2CRBSsz9id3jlfkMkVZ 7yIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bT/SURAK35o6rlNBFscK2GtT4WEX3vtArRsrjCNbd3o=; b=R0TmQR4Aa6YCuS/lWMDC7iZDaehRevX9z5Ux+I9jhDMVKALNi4jILzJ3/0hfWYJMKg Wxbkg2N66gTsnkcp7dx/LG68iztGUqUoDieaB3Gg89RUNy63ecRRGOqWi6mBqBwWoGvM ub8NvbX/TUcijAmPl9uOkQyPMPY0PEncA6TGi8YP3oiHDjBFYh8FF75sxp+RDS7Oa62j ZC6NsWYFfUjYcJXh9ZSMlhuP0hi+GJ90CoTm9KKU3axvF+P5Umz/pDOh4e+t0E3gtrWv 9yjaJvjBwNgqtqrnsyxQ2lTK2ZvaUYaC9UDKrq9HhuTDNwxsg+fQHofuof6lZiy26oUY qHJA== X-Gm-Message-State: APjAAAV8UphQaek19Goo8UT6VcVWiOTPqQ6ox7KsbTqm4IkBM325+Szf 5gC5JXdTCNimlmA7NRd+M+sfIDIf50s= X-Google-Smtp-Source: APXvYqxRbtK8ZvyftubGjL1JPUZ7qy2dzavP7dEMUigC4PCODPP8d9EMAMTOZaudrFsoYwTyM3Twow== X-Received: by 2002:a1c:f70f:: with SMTP id v15mr18349105wmh.102.1560274738728; Tue, 11 Jun 2019 10:38:58 -0700 (PDT) Received: from pali ([2a02:2b88:2:1::5cc6:2f]) by smtp.gmail.com with ESMTPSA id c5sm2866373wma.19.2019.06.11.10.38.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Jun 2019 10:38:57 -0700 (PDT) Date: Tue, 11 Jun 2019 19:38:56 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: "dmitry.torokhov@gmail.com" Cc: Hui Wang , Xiaoxiao Liu , XiaoXiao Liu , "peter.hutterer@who-t.net" , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Xiaojian Cao , "zhangfp1@lenovo.com" , Naoki Saito , Hideo Kawase Subject: Re: =?utf-8?B?562U5aSNOiDnrZTlpI06IOetlA==?= =?utf-8?B?5aSNOiBbUEFUQ0g=?= =?utf-8?Q?=5D?= input: alps-fix the issue alps cs19 trackstick do not work. Message-ID: <20190611173856.jjwoagud6doxvpy3@pali> References: <20190610104310.qa5snt7jpcljodfv@pali> <5587ddb9-fb5f-03db-ac11-a696c85c5f2f@canonical.com> <20190611072333.nd4va4q2m5epmukc@pali> <20190611170707.GA143729@dtor-ws> <20190611171707.tydk7rsmtzmjohky@pali> <20190611173228.GD143729@dtor-ws> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nhhnn4h6g22jo3tq" Content-Disposition: inline In-Reply-To: <20190611173228.GD143729@dtor-ws> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nhhnn4h6g22jo3tq Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tuesday 11 June 2019 10:32:28 dmitry.torokhov@gmail.com wrote: > On Tue, Jun 11, 2019 at 07:17:07PM +0200, Pali Roh=C3=A1r wrote: > > On Tuesday 11 June 2019 10:07:07 dmitry.torokhov@gmail.com wrote: > > > On Tue, Jun 11, 2019 at 09:23:33AM +0200, Pali Roh=C3=A1r wrote: > > > > On Tuesday 11 June 2019 12:32:33 Hui Wang wrote: > > > > > On 2019/6/11 =E4=B8=8A=E5=8D=8811:23, Hui Wang wrote: > > > > > > On 2019/6/11 =E4=B8=8A=E5=8D=8811:05, Xiaoxiao Liu wrote: > > > > > > > Hi Pali, > > > > > > >=20 > > > > > > > I discussed with our FW team about this problem. > > > > > > > We think the V8 method means a touchpad feature=C2=A0 and doe= s not fit > > > > > > > the CS19 trackpoint device. > > > > > > > CS19 TrackPoint needn't=C2=A0 use any Absolute (Raw) mode and= is usually > > > > > > > use standard mouse data. > > > > > > > CS19 TrackPoint device is a completely different device with > > > > > > > DualPoint device of Dell/HP. > > > > > > > CS19 TrackPoint device is independent=C2=A0 of Touchpad. (Tou= chpad is > > > > > > > connecting by I2C, TrackPoint is directly connecting with PS2= port.) > > > > > > > And it has completely another FW. > > > > > > >=20 > > > > > > > So we think it is better to use the mouse mode for CS19 track= point. > > > > > >=20 > > > > > > Maybe here is some mis-understanding,=C2=A0 the mouse mode here= doesn't mean > > > > > > we use psmouse-base.c for cs19 (bare ps/2 mouse), we plan to use > > > > > > trackpoint.c to drive this HW, so this trackpoint has all featu= res a > > > > > > trackpoint should have. > > > > > >=20 > > > > > And I sent a patch one month ago to let the the trackpoint.c to d= rive this > > > > > HW: https://www.spinics.net/lists/linux-input/msg61341.html, mayb= e that > > > > > patch is reference. > > > >=20 > > > > So instead of creating blacklist, you should check for TP_VARIANT_A= LPS > > > > in alps.c and disallow its usage. > > > >=20 > > > > Or maybe better, move trackpoint.c detect code before alsp.c detect= code > > > > in psmouse-base. And no changes in alps.c are needed. > > >=20 > > > I'd be very cautions of moving around the protocol detection. It is v= ery > > > fragile, so if we can detect trackpoint-only case in alps.c and skip = on > > > to trackpoint I would prefer it. > >=20 > > The main problem is that proposed trackpoint-only check in alps.c is > > basically what trackpoint.c is doing for checking if device is > > trackpoint (via function trackpoint_start_protocol()). > >=20 > > So I'm not sure now what is the best solution... >=20 > Unfortunately currently trackpoint is being probed only after we tried > Elan, Genius, and Logitech PS2++ protocols, and I am not sure if moving > trackpoint around will disturb them or not. >=20 > I do not think there is much code duplication by pulling limited version > of trackpoint detection code into alps.c and then have it bail out when > it sees trackpoint-only device so trackpoint.c can handle it properly. Ok. Seems that it is the best solution. The last question is, should be use ALPS or Trackpoint protocol? Because it looks like that device can be configured to one or other. What are pros and cons of these two protocols? --=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nhhnn4h6g22jo3tq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQS4VrIQdKium2krgIWL8Mk9A+RDUgUCXP/nLgAKCRCL8Mk9A+RD UlS8AJ9d2OJ7bEOyR2EISL6cAJHuEyOWTwCeNFKW8SW1I3A9ULkHDMOmxBsOzDM= =rNXl -----END PGP SIGNATURE----- --nhhnn4h6g22jo3tq--