All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [autobuild.buildroot.net] Build results for 2019-06-10
Date: Wed, 12 Jun 2019 08:49:27 +0200	[thread overview]
Message-ID: <20190612084927.4e224933@windsurf> (raw)
In-Reply-To: <20190612053352.GA6981@tungsten.ozlabs.ibm.com>

Hello Sam,

First of all, thanks for the investigation. Adding Atharva, Arnout and
Yann in Cc, since the issue is due to BR2_REPRODUCIBLE=y.

On Wed, 12 Jun 2019 15:33:53 +1000
Sam Bobroff <sbobroff@linux.ibm.com> wrote:

> >  powerpc64le |                    cups-2.2.10 | NOK | http://autobuild.buildroot.net/results/c4e0f6a3c79c9cb083a08f811b7d4838efef50f9 |       
> 
> [snip]
> 
> This failure building cups seems to be caused by an interaction between
> buildroot and the cups package:
> 
> a) Buildroot setting the environment variable "GZIP" to "-n", and
> b) the cups package internally using a Make variable "GZIP" for the path to
> the gzip binary (i.e. "/bin/gzip").
> 
> So, when Make executes the rules for "install-data", the existance of
> GZIP in Make's environment causes it to export it's value of GZIP into
> the environment for the rules. Unfortunately for gzip, which is
> expecting to see command line arguments in $GZIP, it now sees it's own
> path as a command line option and the build fails with:
> 
> gzip: /bin/gzip.gz: Permission denied
> 
> I think the real fix should be in cups, because I *think* what all this
> means is that it's always a bad idea to use a Make variable called
> 'GZIP' and they should rename it there. It fails the same way on the
> master branch of cups so I've filed a bug report on their github issue
> tracker.
> 
> However, it's easy to work around on the buildroot side with a hack in
> the package file:
> CUPS_MAKE_ENV = env -u GZIP
> ... but it does seem a bit cheeky to sneak a call to "env" in there. Is
> there a better way to remove a variable from make's environment?

Dropping the GZIP environment variable is maybe not going to work well
either: the reason why GZIP = -n is because of BR2_REPRODUCIBLE=y. The
-n option of gzip tells gzip to not store the file name and timestamp,
which is necessary for reproducible builds. Of course, it all depends
if the files that are being compressed by the cups build end up on the
target. If they don't, we can live without the -n option. However, if
they end up on the target, we really need to keep the -n option.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-06-12  6:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-11  6:00 [Buildroot] [autobuild.buildroot.net] Build results for 2019-06-10 Thomas Petazzoni
2019-06-12  5:33 ` Sam Bobroff
2019-06-12  6:49   ` Thomas Petazzoni [this message]
2019-06-12  7:02     ` Sam Bobroff
2019-06-12  7:06       ` Thomas Petazzoni
2019-06-12  8:26         ` Arnout Vandecappelle
2019-06-12 10:04           ` Atharva Lele
2019-06-12 15:35           ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190612084927.4e224933@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.