From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD707C31E46 for ; Wed, 12 Jun 2019 18:55:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9E612208CA for ; Wed, 12 Jun 2019 18:55:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727443AbfFLSzv (ORCPT ); Wed, 12 Jun 2019 14:55:51 -0400 Received: from mga09.intel.com ([134.134.136.24]:22517 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726454AbfFLSzu (ORCPT ); Wed, 12 Jun 2019 14:55:50 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jun 2019 11:55:50 -0700 X-ExtLoop1: 1 Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by fmsmga008.fm.intel.com with ESMTP; 12 Jun 2019 11:55:49 -0700 Date: Wed, 12 Jun 2019 11:58:58 -0700 From: Jacob Pan To: Joerg Roedel Cc: Jean-Philippe Brucker , "alex.williamson@redhat.com" , "eric.auger@redhat.com" , "ashok.raj@intel.com" , "yi.l.liu@intel.com" , "robdclark@gmail.com" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux-foundation.org" , Robin Murphy , jacob.jun.pan@linux.intel.com Subject: Re: [PATCH v2 0/4] iommu: Add device fault reporting API Message-ID: <20190612115858.733edacc@jacob-builder> In-Reply-To: <20190612131143.GF21613@8bytes.org> References: <20190603145749.46347-1-jean-philippe.brucker@arm.com> <20190612081944.GB17505@8bytes.org> <0f21e1b2-837f-87ba-6cf3-f6490d9e2a57@arm.com> <20190612131143.GF21613@8bytes.org> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 12 Jun 2019 15:11:43 +0200 Joerg Roedel wrote: > On Wed, Jun 12, 2019 at 12:54:51PM +0100, Jean-Philippe Brucker wrote: > > Thanks! As discussed I think we need to add padding into the > > iommu_fault structure before this reaches mainline, to make the > > UAPI easier to extend in the future. It's already possible to > > extend but requires introducing a new ABI version number and > > support two structures. Adding some padding would only require > > introducing new flags. If there is no objection I'll send a > > one-line patch bumping the structure size to 64 bytes (currently > > 48) > > Sounds good, please submit the patch. > Could you also add padding to page response per our discussion here? https://lkml.org/lkml/2019/6/12/1131 > Regards, > > Joerg [Jacob Pan] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F18E9C31E46 for ; Wed, 12 Jun 2019 18:57:21 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C7450208CA for ; Wed, 12 Jun 2019 18:57:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7450208CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 70C1B2299; Wed, 12 Jun 2019 18:57:21 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 28C6C224F for ; Wed, 12 Jun 2019 18:55:51 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id BD334E6 for ; Wed, 12 Jun 2019 18:55:50 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jun 2019 11:55:50 -0700 X-ExtLoop1: 1 Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by fmsmga008.fm.intel.com with ESMTP; 12 Jun 2019 11:55:49 -0700 Date: Wed, 12 Jun 2019 11:58:58 -0700 From: Jacob Pan To: Joerg Roedel Subject: Re: [PATCH v2 0/4] iommu: Add device fault reporting API Message-ID: <20190612115858.733edacc@jacob-builder> In-Reply-To: <20190612131143.GF21613@8bytes.org> References: <20190603145749.46347-1-jean-philippe.brucker@arm.com> <20190612081944.GB17505@8bytes.org> <0f21e1b2-837f-87ba-6cf3-f6490d9e2a57@arm.com> <20190612131143.GF21613@8bytes.org> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Cc: "ashok.raj@intel.com" , Jean-Philippe Brucker , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "alex.williamson@redhat.com" , Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On Wed, 12 Jun 2019 15:11:43 +0200 Joerg Roedel wrote: > On Wed, Jun 12, 2019 at 12:54:51PM +0100, Jean-Philippe Brucker wrote: > > Thanks! As discussed I think we need to add padding into the > > iommu_fault structure before this reaches mainline, to make the > > UAPI easier to extend in the future. It's already possible to > > extend but requires introducing a new ABI version number and > > support two structures. Adding some padding would only require > > introducing new flags. If there is no objection I'll send a > > one-line patch bumping the structure size to 64 bytes (currently > > 48) > > Sounds good, please submit the patch. > Could you also add padding to page response per our discussion here? https://lkml.org/lkml/2019/6/12/1131 > Regards, > > Joerg [Jacob Pan] _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu