* [PATCH v2 1/2] dt-bindings: i2c: sun6i-p2wi: Add YAML schemas
@ 2019-06-05 12:29 ` Maxime Ripard
0 siblings, 0 replies; 13+ messages in thread
From: Maxime Ripard @ 2019-06-05 12:29 UTC (permalink / raw)
To: Wolfram Sang, Mark Rutland, Rob Herring, Frank Rowand,
Chen-Yu Tsai, Maxime Ripard, Gregory Clement
Cc: devicetree, linux-i2c, linux-arm-kernel
Switch the DT binding to a YAML schema to enable the DT validation.
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
.../i2c/allwinner,sun6i-a31-p2wi.yaml | 71 +++++++++++++++++++
.../bindings/i2c/i2c-sun6i-p2wi.txt | 41 -----------
2 files changed, 71 insertions(+), 41 deletions(-)
create mode 100644 Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml
delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-sun6i-p2wi.txt
diff --git a/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml b/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml
new file mode 100644
index 000000000000..780a33080140
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml
@@ -0,0 +1,71 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/allwinner,sun6i-a31-p2wi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Allwinner A31 P2WI (Push/Pull 2 Wires Interface) Device Tree Bindings
+
+maintainers:
+ - Chen-Yu Tsai <wens@csie.org>
+ - Maxime Ripard <maxime.ripard@bootlin.com>
+
+allOf:
+ - $ref: /schemas/i2c/i2c-controller.yaml#
+
+properties:
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+ compatible:
+ const: allwinner,sun6i-a31-p2wi
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ resets:
+ maxItems: 1
+
+ clock-frequency:
+ minimum: 1
+ maximum: 6000000
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - resets
+
+# FIXME: We should set it, but it would report all the generic
+# properties as additional properties.
+# additionalProperties: false
+
+examples:
+ - |
+ p2wi@1f03400 {
+ compatible = "allwinner,sun6i-a31-p2wi";
+ reg = <0x01f03400 0x400>;
+ interrupts = <0 39 4>;
+ clocks = <&apb0_gates 3>;
+ clock-frequency = <6000000>;
+ resets = <&apb0_rst 3>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ axp221: pmic@68 {
+ compatible = "x-powers,axp221";
+ reg = <0x68>;
+ };
+ };
+
+...
diff --git a/Documentation/devicetree/bindings/i2c/i2c-sun6i-p2wi.txt b/Documentation/devicetree/bindings/i2c/i2c-sun6i-p2wi.txt
deleted file mode 100644
index 49df0053347a..000000000000
--- a/Documentation/devicetree/bindings/i2c/i2c-sun6i-p2wi.txt
+++ /dev/null
@@ -1,41 +0,0 @@
-
-* Allwinner P2WI (Push/Pull 2 Wire Interface) controller
-
-Required properties :
-
- - reg : Offset and length of the register set for the device.
- - compatible : Should one of the following:
- - "allwinner,sun6i-a31-p2wi"
- - interrupts : The interrupt line connected to the P2WI peripheral.
- - clocks : The gate clk connected to the P2WI peripheral.
- - resets : The reset line connected to the P2WI peripheral.
-
-Optional properties :
-
- - clock-frequency : Desired P2WI bus clock frequency in Hz. If not set the
-default frequency is 100kHz
-
-A P2WI may contain one child node encoding a P2WI slave device.
-
-Slave device properties:
- Required properties:
- - reg : the I2C slave address used during the initialization
- process to switch from I2C to P2WI mode
-
-Example:
-
- p2wi@1f03400 {
- compatible = "allwinner,sun6i-a31-p2wi";
- reg = <0x01f03400 0x400>;
- interrupts = <0 39 4>;
- clocks = <&apb0_gates 3>;
- clock-frequency = <6000000>;
- resets = <&apb0_rst 3>;
-
- axp221: pmic@68 {
- compatible = "x-powers,axp221";
- reg = <0x68>;
-
- /* ... */
- };
- };
--
2.21.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v2 1/2] dt-bindings: i2c: sun6i-p2wi: Add YAML schemas
@ 2019-06-05 12:29 ` Maxime Ripard
0 siblings, 0 replies; 13+ messages in thread
From: Maxime Ripard @ 2019-06-05 12:29 UTC (permalink / raw)
To: Wolfram Sang, Mark Rutland, Rob Herring, Frank Rowand,
Chen-Yu Tsai, Maxime Ripard, Gregory Clement
Cc: devicetree, linux-i2c, linux-arm-kernel
Switch the DT binding to a YAML schema to enable the DT validation.
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
.../i2c/allwinner,sun6i-a31-p2wi.yaml | 71 +++++++++++++++++++
.../bindings/i2c/i2c-sun6i-p2wi.txt | 41 -----------
2 files changed, 71 insertions(+), 41 deletions(-)
create mode 100644 Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml
delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-sun6i-p2wi.txt
diff --git a/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml b/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml
new file mode 100644
index 000000000000..780a33080140
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml
@@ -0,0 +1,71 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/allwinner,sun6i-a31-p2wi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Allwinner A31 P2WI (Push/Pull 2 Wires Interface) Device Tree Bindings
+
+maintainers:
+ - Chen-Yu Tsai <wens@csie.org>
+ - Maxime Ripard <maxime.ripard@bootlin.com>
+
+allOf:
+ - $ref: /schemas/i2c/i2c-controller.yaml#
+
+properties:
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+ compatible:
+ const: allwinner,sun6i-a31-p2wi
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ resets:
+ maxItems: 1
+
+ clock-frequency:
+ minimum: 1
+ maximum: 6000000
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - resets
+
+# FIXME: We should set it, but it would report all the generic
+# properties as additional properties.
+# additionalProperties: false
+
+examples:
+ - |
+ p2wi@1f03400 {
+ compatible = "allwinner,sun6i-a31-p2wi";
+ reg = <0x01f03400 0x400>;
+ interrupts = <0 39 4>;
+ clocks = <&apb0_gates 3>;
+ clock-frequency = <6000000>;
+ resets = <&apb0_rst 3>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ axp221: pmic@68 {
+ compatible = "x-powers,axp221";
+ reg = <0x68>;
+ };
+ };
+
+...
diff --git a/Documentation/devicetree/bindings/i2c/i2c-sun6i-p2wi.txt b/Documentation/devicetree/bindings/i2c/i2c-sun6i-p2wi.txt
deleted file mode 100644
index 49df0053347a..000000000000
--- a/Documentation/devicetree/bindings/i2c/i2c-sun6i-p2wi.txt
+++ /dev/null
@@ -1,41 +0,0 @@
-
-* Allwinner P2WI (Push/Pull 2 Wire Interface) controller
-
-Required properties :
-
- - reg : Offset and length of the register set for the device.
- - compatible : Should one of the following:
- - "allwinner,sun6i-a31-p2wi"
- - interrupts : The interrupt line connected to the P2WI peripheral.
- - clocks : The gate clk connected to the P2WI peripheral.
- - resets : The reset line connected to the P2WI peripheral.
-
-Optional properties :
-
- - clock-frequency : Desired P2WI bus clock frequency in Hz. If not set the
-default frequency is 100kHz
-
-A P2WI may contain one child node encoding a P2WI slave device.
-
-Slave device properties:
- Required properties:
- - reg : the I2C slave address used during the initialization
- process to switch from I2C to P2WI mode
-
-Example:
-
- p2wi@1f03400 {
- compatible = "allwinner,sun6i-a31-p2wi";
- reg = <0x01f03400 0x400>;
- interrupts = <0 39 4>;
- clocks = <&apb0_gates 3>;
- clock-frequency = <6000000>;
- resets = <&apb0_rst 3>;
-
- axp221: pmic@68 {
- compatible = "x-powers,axp221";
- reg = <0x68>;
-
- /* ... */
- };
- };
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v2 2/2] dt-bindings: i2c: mv64xxx: Add YAML schemas
2019-06-05 12:29 ` Maxime Ripard
@ 2019-06-05 12:29 ` Maxime Ripard
-1 siblings, 0 replies; 13+ messages in thread
From: Maxime Ripard @ 2019-06-05 12:29 UTC (permalink / raw)
To: Wolfram Sang, Mark Rutland, Rob Herring, Frank Rowand,
Chen-Yu Tsai, Maxime Ripard, Gregory Clement
Cc: devicetree, linux-i2c, linux-arm-kernel
Switch the DT binding to a YAML schema to enable the DT validation.
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
Changes from v1:
- Fix the maintainers
---
.../devicetree/bindings/i2c/i2c-mv64xxx.txt | 64 -----------
.../bindings/i2c/marvell,mv64xxx-i2c.yaml | 105 ++++++++++++++++++
2 files changed, 105 insertions(+), 64 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
create mode 100644 Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
deleted file mode 100644
index 0ffe65a316ae..000000000000
--- a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
+++ /dev/null
@@ -1,64 +0,0 @@
-
-* Marvell MV64XXX I2C controller
-
-Required properties :
-
- - reg : Offset and length of the register set for the device
- - compatible : Should be either:
- - "allwinner,sun4i-a10-i2c"
- - "allwinner,sun6i-a31-i2c"
- - "marvell,mv64xxx-i2c"
- - "marvell,mv78230-i2c"
- - "marvell,mv78230-a0-i2c"
- * Note: Only use "marvell,mv78230-a0-i2c" for a
- very rare, initial version of the SoC which
- had broken offload support. Linux
- auto-detects this and sets it appropriately.
- - interrupts : The interrupt number
-
-Optional properties :
-
- - clock-frequency : Desired I2C bus clock frequency in Hz. If not set the
-default frequency is 100kHz
-
- - resets : phandle to the parent reset controller. Mandatory
- whenever you're using the "allwinner,sun6i-a31-i2c"
- compatible.
-
- - clocks: : pointers to the reference clocks for this device, the
- first one is the one used for the clock on the i2c bus,
- the second one is the clock used to acces the registers
- of the controller
-
- - clock-names : names of used clocks, mandatory if the second clock is
- used, the name must be "core", and "reg" (the latter is
- only for Armada 7K/8K).
-
-Examples:
-
- i2c@11000 {
- compatible = "marvell,mv64xxx-i2c";
- reg = <0x11000 0x20>;
- interrupts = <29>;
- clock-frequency = <100000>;
- };
-
-For the Armada XP:
-
- i2c@11000 {
- compatible = "marvell,mv78230-i2c", "marvell,mv64xxx-i2c";
- reg = <0x11000 0x100>;
- interrupts = <29>;
- clock-frequency = <100000>;
- };
-
-For the Armada 7040:
-
- i2c@701000 {
- compatible = "marvell,mv78230-i2c";
- reg = <0x701000 0x20>;
- interrupts = <29>;
- clock-frequency = <100000>;
- clock-names = "core", "reg";
- clocks = <&core_clock>, <®_clock>;
- };
diff --git a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
new file mode 100644
index 000000000000..a1c631eaeafd
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
@@ -0,0 +1,105 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/marvell,mv64xxx-i2c.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell MV64XXX I2C Controller Device Tree Bindings
+
+maintainers:
+ - Gregory CLEMENT <gregory.clement@bootlin.com>
+
+properties:
+ compatible:
+ oneOf:
+ - const: allwinner,sun4i-a10-i2c
+ - items:
+ - const: allwinner,sun7i-a20-i2c
+ - const: allwinner,sun4i-a10-i2c
+ - const: allwinner,sun6i-a31-i2c
+ - items:
+ - const: allwinner,sun8i-a23-i2c
+ - const: allwinner,sun6i-a31-i2c
+ - items:
+ - const: allwinner,sun8i-a83t-i2c
+ - const: allwinner,sun6i-a31-i2c
+ - items:
+ - const: allwinner,sun50i-a64-i2c
+ - const: allwinner,sun6i-a31-i2c
+
+ - const: marvell,mv64xxx-i2c
+ - const: marvell,mv78230-i2c
+ - const: marvell,mv78230-a0-i2c
+
+ description:
+ Only use "marvell,mv78230-a0-i2c" for a very rare, initial
+ version of the SoC which had broken offload support. Linux
+ auto-detects this and sets it appropriately.
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ minItems: 1
+ maxItems: 2
+ items:
+ - description: Reference clock for the I2C bus
+ - description: Bus clock (Only for Armada 7K/8K)
+
+ clock-names:
+ minItems: 1
+ maxItems: 2
+ items:
+ - const: core
+ - const: reg
+ description:
+ Mandatory if two clocks are used (only for Armada 7k and 8k).
+
+ resets:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+allOf:
+ - $ref: /schemas/i2c/i2c-controller.yaml#
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - allwinner,sun4i-a10-i2c
+ - allwinner,sun6i-a31-i2c
+
+ then:
+ required:
+ - clocks
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: allwinner,sun6i-a31-i2c
+
+ then:
+ required:
+ - resets
+
+# FIXME: We should set it, but it would report all the generic
+# properties as additional properties.
+# additionalProperties: false
+
+examples:
+ - |
+ timer {
+ compatible = "allwinner,sun4i-a10-timer";
+ reg = <0x01c20c00 0x400>;
+ interrupts = <22>;
+ clocks = <&osc>;
+ };
+...
--
2.21.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v2 2/2] dt-bindings: i2c: mv64xxx: Add YAML schemas
@ 2019-06-05 12:29 ` Maxime Ripard
0 siblings, 0 replies; 13+ messages in thread
From: Maxime Ripard @ 2019-06-05 12:29 UTC (permalink / raw)
To: Wolfram Sang, Mark Rutland, Rob Herring, Frank Rowand,
Chen-Yu Tsai, Maxime Ripard, Gregory Clement
Cc: devicetree, linux-i2c, linux-arm-kernel
Switch the DT binding to a YAML schema to enable the DT validation.
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
Changes from v1:
- Fix the maintainers
---
.../devicetree/bindings/i2c/i2c-mv64xxx.txt | 64 -----------
.../bindings/i2c/marvell,mv64xxx-i2c.yaml | 105 ++++++++++++++++++
2 files changed, 105 insertions(+), 64 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
create mode 100644 Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
deleted file mode 100644
index 0ffe65a316ae..000000000000
--- a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
+++ /dev/null
@@ -1,64 +0,0 @@
-
-* Marvell MV64XXX I2C controller
-
-Required properties :
-
- - reg : Offset and length of the register set for the device
- - compatible : Should be either:
- - "allwinner,sun4i-a10-i2c"
- - "allwinner,sun6i-a31-i2c"
- - "marvell,mv64xxx-i2c"
- - "marvell,mv78230-i2c"
- - "marvell,mv78230-a0-i2c"
- * Note: Only use "marvell,mv78230-a0-i2c" for a
- very rare, initial version of the SoC which
- had broken offload support. Linux
- auto-detects this and sets it appropriately.
- - interrupts : The interrupt number
-
-Optional properties :
-
- - clock-frequency : Desired I2C bus clock frequency in Hz. If not set the
-default frequency is 100kHz
-
- - resets : phandle to the parent reset controller. Mandatory
- whenever you're using the "allwinner,sun6i-a31-i2c"
- compatible.
-
- - clocks: : pointers to the reference clocks for this device, the
- first one is the one used for the clock on the i2c bus,
- the second one is the clock used to acces the registers
- of the controller
-
- - clock-names : names of used clocks, mandatory if the second clock is
- used, the name must be "core", and "reg" (the latter is
- only for Armada 7K/8K).
-
-Examples:
-
- i2c@11000 {
- compatible = "marvell,mv64xxx-i2c";
- reg = <0x11000 0x20>;
- interrupts = <29>;
- clock-frequency = <100000>;
- };
-
-For the Armada XP:
-
- i2c@11000 {
- compatible = "marvell,mv78230-i2c", "marvell,mv64xxx-i2c";
- reg = <0x11000 0x100>;
- interrupts = <29>;
- clock-frequency = <100000>;
- };
-
-For the Armada 7040:
-
- i2c@701000 {
- compatible = "marvell,mv78230-i2c";
- reg = <0x701000 0x20>;
- interrupts = <29>;
- clock-frequency = <100000>;
- clock-names = "core", "reg";
- clocks = <&core_clock>, <®_clock>;
- };
diff --git a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
new file mode 100644
index 000000000000..a1c631eaeafd
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
@@ -0,0 +1,105 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/marvell,mv64xxx-i2c.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell MV64XXX I2C Controller Device Tree Bindings
+
+maintainers:
+ - Gregory CLEMENT <gregory.clement@bootlin.com>
+
+properties:
+ compatible:
+ oneOf:
+ - const: allwinner,sun4i-a10-i2c
+ - items:
+ - const: allwinner,sun7i-a20-i2c
+ - const: allwinner,sun4i-a10-i2c
+ - const: allwinner,sun6i-a31-i2c
+ - items:
+ - const: allwinner,sun8i-a23-i2c
+ - const: allwinner,sun6i-a31-i2c
+ - items:
+ - const: allwinner,sun8i-a83t-i2c
+ - const: allwinner,sun6i-a31-i2c
+ - items:
+ - const: allwinner,sun50i-a64-i2c
+ - const: allwinner,sun6i-a31-i2c
+
+ - const: marvell,mv64xxx-i2c
+ - const: marvell,mv78230-i2c
+ - const: marvell,mv78230-a0-i2c
+
+ description:
+ Only use "marvell,mv78230-a0-i2c" for a very rare, initial
+ version of the SoC which had broken offload support. Linux
+ auto-detects this and sets it appropriately.
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ minItems: 1
+ maxItems: 2
+ items:
+ - description: Reference clock for the I2C bus
+ - description: Bus clock (Only for Armada 7K/8K)
+
+ clock-names:
+ minItems: 1
+ maxItems: 2
+ items:
+ - const: core
+ - const: reg
+ description:
+ Mandatory if two clocks are used (only for Armada 7k and 8k).
+
+ resets:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+allOf:
+ - $ref: /schemas/i2c/i2c-controller.yaml#
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - allwinner,sun4i-a10-i2c
+ - allwinner,sun6i-a31-i2c
+
+ then:
+ required:
+ - clocks
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: allwinner,sun6i-a31-i2c
+
+ then:
+ required:
+ - resets
+
+# FIXME: We should set it, but it would report all the generic
+# properties as additional properties.
+# additionalProperties: false
+
+examples:
+ - |
+ timer {
+ compatible = "allwinner,sun4i-a10-timer";
+ reg = <0x01c20c00 0x400>;
+ interrupts = <22>;
+ clocks = <&osc>;
+ };
+...
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: i2c: sun6i-p2wi: Add YAML schemas
2019-06-05 12:29 ` Maxime Ripard
@ 2019-06-10 21:34 ` Rob Herring
-1 siblings, 0 replies; 13+ messages in thread
From: Rob Herring @ 2019-06-10 21:34 UTC (permalink / raw)
To: Maxime Ripard
Cc: Mark Rutland, devicetree, Wolfram Sang, Gregory Clement,
Chen-Yu Tsai, Linux I2C, Frank Rowand,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Wed, Jun 5, 2019 at 6:29 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> Switch the DT binding to a YAML schema to enable the DT validation.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> ---
> .../i2c/allwinner,sun6i-a31-p2wi.yaml | 71 +++++++++++++++++++
> .../bindings/i2c/i2c-sun6i-p2wi.txt | 41 -----------
> 2 files changed, 71 insertions(+), 41 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml
> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-sun6i-p2wi.txt
>
> diff --git a/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml b/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml
> new file mode 100644
> index 000000000000..780a33080140
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/allwinner,sun6i-a31-p2wi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Allwinner A31 P2WI (Push/Pull 2 Wires Interface) Device Tree Bindings
> +
> +maintainers:
> + - Chen-Yu Tsai <wens@csie.org>
> + - Maxime Ripard <maxime.ripard@bootlin.com>
> +
> +allOf:
> + - $ref: /schemas/i2c/i2c-controller.yaml#
> +
> +properties:
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
These 2 are covered by i2c-controller.yaml, right?
> +
> + compatible:
> + const: allwinner,sun6i-a31-p2wi
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> + clock-frequency:
> + minimum: 1
> + maximum: 6000000
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - resets
> +
> +# FIXME: We should set it, but it would report all the generic
> +# properties as additional properties.
> +# additionalProperties: false
> +
> +examples:
> + - |
> + p2wi@1f03400 {
i2c@...
That should fail on the schema (I need to get the schema checking of
examples finished.)
> + compatible = "allwinner,sun6i-a31-p2wi";
> + reg = <0x01f03400 0x400>;
> + interrupts = <0 39 4>;
> + clocks = <&apb0_gates 3>;
> + clock-frequency = <6000000>;
> + resets = <&apb0_rst 3>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + axp221: pmic@68 {
> + compatible = "x-powers,axp221";
> + reg = <0x68>;
> + };
> + };
> +
> +...
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: i2c: sun6i-p2wi: Add YAML schemas
@ 2019-06-10 21:34 ` Rob Herring
0 siblings, 0 replies; 13+ messages in thread
From: Rob Herring @ 2019-06-10 21:34 UTC (permalink / raw)
To: Maxime Ripard
Cc: Mark Rutland, devicetree, Wolfram Sang, Gregory Clement,
Chen-Yu Tsai, Linux I2C, Frank Rowand,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Wed, Jun 5, 2019 at 6:29 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> Switch the DT binding to a YAML schema to enable the DT validation.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> ---
> .../i2c/allwinner,sun6i-a31-p2wi.yaml | 71 +++++++++++++++++++
> .../bindings/i2c/i2c-sun6i-p2wi.txt | 41 -----------
> 2 files changed, 71 insertions(+), 41 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml
> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-sun6i-p2wi.txt
>
> diff --git a/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml b/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml
> new file mode 100644
> index 000000000000..780a33080140
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/allwinner,sun6i-a31-p2wi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Allwinner A31 P2WI (Push/Pull 2 Wires Interface) Device Tree Bindings
> +
> +maintainers:
> + - Chen-Yu Tsai <wens@csie.org>
> + - Maxime Ripard <maxime.ripard@bootlin.com>
> +
> +allOf:
> + - $ref: /schemas/i2c/i2c-controller.yaml#
> +
> +properties:
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
These 2 are covered by i2c-controller.yaml, right?
> +
> + compatible:
> + const: allwinner,sun6i-a31-p2wi
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> + clock-frequency:
> + minimum: 1
> + maximum: 6000000
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - resets
> +
> +# FIXME: We should set it, but it would report all the generic
> +# properties as additional properties.
> +# additionalProperties: false
> +
> +examples:
> + - |
> + p2wi@1f03400 {
i2c@...
That should fail on the schema (I need to get the schema checking of
examples finished.)
> + compatible = "allwinner,sun6i-a31-p2wi";
> + reg = <0x01f03400 0x400>;
> + interrupts = <0 39 4>;
> + clocks = <&apb0_gates 3>;
> + clock-frequency = <6000000>;
> + resets = <&apb0_rst 3>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + axp221: pmic@68 {
> + compatible = "x-powers,axp221";
> + reg = <0x68>;
> + };
> + };
> +
> +...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: i2c: mv64xxx: Add YAML schemas
2019-06-05 12:29 ` Maxime Ripard
@ 2019-06-10 21:37 ` Rob Herring
-1 siblings, 0 replies; 13+ messages in thread
From: Rob Herring @ 2019-06-10 21:37 UTC (permalink / raw)
To: Maxime Ripard
Cc: Mark Rutland, devicetree, Wolfram Sang, Gregory Clement,
Chen-Yu Tsai, Linux I2C, Frank Rowand,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Wed, Jun 5, 2019 at 6:29 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> Switch the DT binding to a YAML schema to enable the DT validation.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
>
> ---
>
> Changes from v1:
> - Fix the maintainers
> ---
> .../devicetree/bindings/i2c/i2c-mv64xxx.txt | 64 -----------
> .../bindings/i2c/marvell,mv64xxx-i2c.yaml | 105 ++++++++++++++++++
> 2 files changed, 105 insertions(+), 64 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> create mode 100644 Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> diff --git a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> new file mode 100644
> index 000000000000..a1c631eaeafd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> @@ -0,0 +1,105 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/marvell,mv64xxx-i2c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell MV64XXX I2C Controller Device Tree Bindings
> +
> +maintainers:
> + - Gregory CLEMENT <gregory.clement@bootlin.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: allwinner,sun4i-a10-i2c
> + - items:
> + - const: allwinner,sun7i-a20-i2c
> + - const: allwinner,sun4i-a10-i2c
> + - const: allwinner,sun6i-a31-i2c
> + - items:
> + - const: allwinner,sun8i-a23-i2c
> + - const: allwinner,sun6i-a31-i2c
> + - items:
> + - const: allwinner,sun8i-a83t-i2c
> + - const: allwinner,sun6i-a31-i2c
> + - items:
> + - const: allwinner,sun50i-a64-i2c
> + - const: allwinner,sun6i-a31-i2c
> +
> + - const: marvell,mv64xxx-i2c
> + - const: marvell,mv78230-i2c
> + - const: marvell,mv78230-a0-i2c
> +
> + description:
> + Only use "marvell,mv78230-a0-i2c" for a very rare, initial
> + version of the SoC which had broken offload support. Linux
> + auto-detects this and sets it appropriately.
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + minItems: 1
> + maxItems: 2
> + items:
> + - description: Reference clock for the I2C bus
> + - description: Bus clock (Only for Armada 7K/8K)
> +
> + clock-names:
> + minItems: 1
> + maxItems: 2
> + items:
> + - const: core
> + - const: reg
> + description:
> + Mandatory if two clocks are used (only for Armada 7k and 8k).
> +
> + resets:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +allOf:
> + - $ref: /schemas/i2c/i2c-controller.yaml#
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - allwinner,sun4i-a10-i2c
> + - allwinner,sun6i-a31-i2c
> +
> + then:
> + required:
> + - clocks
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: allwinner,sun6i-a31-i2c
> +
> + then:
> + required:
> + - resets
> +
> +# FIXME: We should set it, but it would report all the generic
> +# properties as additional properties.
> +# additionalProperties: false
> +
> +examples:
> + - |
> + timer {
timer?
(and missing unit-address)
> + compatible = "allwinner,sun4i-a10-timer";
> + reg = <0x01c20c00 0x400>;
> + interrupts = <22>;
> + clocks = <&osc>;
> + };
> +...
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: i2c: mv64xxx: Add YAML schemas
@ 2019-06-10 21:37 ` Rob Herring
0 siblings, 0 replies; 13+ messages in thread
From: Rob Herring @ 2019-06-10 21:37 UTC (permalink / raw)
To: Maxime Ripard
Cc: Mark Rutland, devicetree, Wolfram Sang, Gregory Clement,
Chen-Yu Tsai, Linux I2C, Frank Rowand,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Wed, Jun 5, 2019 at 6:29 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> Switch the DT binding to a YAML schema to enable the DT validation.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
>
> ---
>
> Changes from v1:
> - Fix the maintainers
> ---
> .../devicetree/bindings/i2c/i2c-mv64xxx.txt | 64 -----------
> .../bindings/i2c/marvell,mv64xxx-i2c.yaml | 105 ++++++++++++++++++
> 2 files changed, 105 insertions(+), 64 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> create mode 100644 Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> diff --git a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> new file mode 100644
> index 000000000000..a1c631eaeafd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> @@ -0,0 +1,105 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/marvell,mv64xxx-i2c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell MV64XXX I2C Controller Device Tree Bindings
> +
> +maintainers:
> + - Gregory CLEMENT <gregory.clement@bootlin.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: allwinner,sun4i-a10-i2c
> + - items:
> + - const: allwinner,sun7i-a20-i2c
> + - const: allwinner,sun4i-a10-i2c
> + - const: allwinner,sun6i-a31-i2c
> + - items:
> + - const: allwinner,sun8i-a23-i2c
> + - const: allwinner,sun6i-a31-i2c
> + - items:
> + - const: allwinner,sun8i-a83t-i2c
> + - const: allwinner,sun6i-a31-i2c
> + - items:
> + - const: allwinner,sun50i-a64-i2c
> + - const: allwinner,sun6i-a31-i2c
> +
> + - const: marvell,mv64xxx-i2c
> + - const: marvell,mv78230-i2c
> + - const: marvell,mv78230-a0-i2c
> +
> + description:
> + Only use "marvell,mv78230-a0-i2c" for a very rare, initial
> + version of the SoC which had broken offload support. Linux
> + auto-detects this and sets it appropriately.
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + minItems: 1
> + maxItems: 2
> + items:
> + - description: Reference clock for the I2C bus
> + - description: Bus clock (Only for Armada 7K/8K)
> +
> + clock-names:
> + minItems: 1
> + maxItems: 2
> + items:
> + - const: core
> + - const: reg
> + description:
> + Mandatory if two clocks are used (only for Armada 7k and 8k).
> +
> + resets:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +allOf:
> + - $ref: /schemas/i2c/i2c-controller.yaml#
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - allwinner,sun4i-a10-i2c
> + - allwinner,sun6i-a31-i2c
> +
> + then:
> + required:
> + - clocks
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: allwinner,sun6i-a31-i2c
> +
> + then:
> + required:
> + - resets
> +
> +# FIXME: We should set it, but it would report all the generic
> +# properties as additional properties.
> +# additionalProperties: false
> +
> +examples:
> + - |
> + timer {
timer?
(and missing unit-address)
> + compatible = "allwinner,sun4i-a10-timer";
> + reg = <0x01c20c00 0x400>;
> + interrupts = <22>;
> + clocks = <&osc>;
> + };
> +...
> --
> 2.21.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: i2c: sun6i-p2wi: Add YAML schemas
2019-06-10 21:34 ` Rob Herring
(?)
@ 2019-06-11 9:06 ` Maxime Ripard
2019-06-11 14:50 ` Rob Herring
-1 siblings, 1 reply; 13+ messages in thread
From: Maxime Ripard @ 2019-06-11 9:06 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Rutland, devicetree, Wolfram Sang, Gregory Clement,
Chen-Yu Tsai, Linux I2C, Frank Rowand,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
[-- Attachment #1.1: Type: text/plain, Size: 942 bytes --]
Hi Rob,
On Mon, Jun 10, 2019 at 03:34:18PM -0600, Rob Herring wrote:
> On Wed, Jun 5, 2019 at 6:29 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > +properties:
> > + "#address-cells":
> > + const: 1
> > +
> > + "#size-cells":
> > + const: 0
>
> These 2 are covered by i2c-controller.yaml, right?
Indeed, I've removed them.
> > +examples:
> > + - |
> > + p2wi@1f03400 {
>
> i2c@...
>
> That should fail on the schema (I need to get the schema checking of
> examples finished.)
That would be great :) The compilation of the examples alone already
caught a good number of examples that weren't even compiling.
Speaking of examples, one thing that would be great too would be to
allow the usage of our C headers. It's not supported at the moment,
and this often ends up with an example that is less readable than the
actual DT.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: i2c: mv64xxx: Add YAML schemas
2019-06-10 21:37 ` Rob Herring
(?)
@ 2019-06-11 9:07 ` Maxime Ripard
-1 siblings, 0 replies; 13+ messages in thread
From: Maxime Ripard @ 2019-06-11 9:07 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Rutland, devicetree, Wolfram Sang, Gregory Clement,
Chen-Yu Tsai, Linux I2C, Frank Rowand,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
[-- Attachment #1.1: Type: text/plain, Size: 316 bytes --]
On Mon, Jun 10, 2019 at 03:37:17PM -0600, Rob Herring wrote:
> > +examples:
> > + - |
> > + timer {
>
> timer?
>
> (and missing unit-address)
Yeah, sorry, this is a copy and paste issue..
I've fixed it in v3.
Thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: i2c: sun6i-p2wi: Add YAML schemas
2019-06-11 9:06 ` Maxime Ripard
@ 2019-06-11 14:50 ` Rob Herring
0 siblings, 0 replies; 13+ messages in thread
From: Rob Herring @ 2019-06-11 14:50 UTC (permalink / raw)
To: Maxime Ripard
Cc: Mark Rutland, devicetree, Wolfram Sang, Gregory Clement,
Chen-Yu Tsai, Linux I2C, Frank Rowand,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Tue, Jun 11, 2019 at 3:06 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> Hi Rob,
>
> On Mon, Jun 10, 2019 at 03:34:18PM -0600, Rob Herring wrote:
> > On Wed, Jun 5, 2019 at 6:29 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > +properties:
> > > + "#address-cells":
> > > + const: 1
> > > +
> > > + "#size-cells":
> > > + const: 0
> >
> > These 2 are covered by i2c-controller.yaml, right?
>
> Indeed, I've removed them.
>
> > > +examples:
> > > + - |
> > > + p2wi@1f03400 {
> >
> > i2c@...
> >
> > That should fail on the schema (I need to get the schema checking of
> > examples finished.)
>
> That would be great :) The compilation of the examples alone already
> caught a good number of examples that weren't even compiling.
I'm primarily waiting on a dtc change to be accepted[1]. Feel free to
review/ack.
> Speaking of examples, one thing that would be great too would be to
> allow the usage of our C headers. It's not supported at the moment,
> and this often ends up with an example that is less readable than the
> actual DT.
It should be. You just have to add them. See
Documentation/devicetree/bindings/timer/intel,ixp4xx-timer.yaml for
example.
Maybe the common interrupt and gpio ones should be added by default.
Rob
[1] https://www.spinics.net/lists/devicetree-compiler/msg02709.html
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: i2c: sun6i-p2wi: Add YAML schemas
@ 2019-06-11 14:50 ` Rob Herring
0 siblings, 0 replies; 13+ messages in thread
From: Rob Herring @ 2019-06-11 14:50 UTC (permalink / raw)
To: Maxime Ripard
Cc: Mark Rutland, devicetree, Wolfram Sang, Gregory Clement,
Chen-Yu Tsai, Linux I2C, Frank Rowand,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Tue, Jun 11, 2019 at 3:06 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> Hi Rob,
>
> On Mon, Jun 10, 2019 at 03:34:18PM -0600, Rob Herring wrote:
> > On Wed, Jun 5, 2019 at 6:29 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > +properties:
> > > + "#address-cells":
> > > + const: 1
> > > +
> > > + "#size-cells":
> > > + const: 0
> >
> > These 2 are covered by i2c-controller.yaml, right?
>
> Indeed, I've removed them.
>
> > > +examples:
> > > + - |
> > > + p2wi@1f03400 {
> >
> > i2c@...
> >
> > That should fail on the schema (I need to get the schema checking of
> > examples finished.)
>
> That would be great :) The compilation of the examples alone already
> caught a good number of examples that weren't even compiling.
I'm primarily waiting on a dtc change to be accepted[1]. Feel free to
review/ack.
> Speaking of examples, one thing that would be great too would be to
> allow the usage of our C headers. It's not supported at the moment,
> and this often ends up with an example that is less readable than the
> actual DT.
It should be. You just have to add them. See
Documentation/devicetree/bindings/timer/intel,ixp4xx-timer.yaml for
example.
Maybe the common interrupt and gpio ones should be added by default.
Rob
[1] https://www.spinics.net/lists/devicetree-compiler/msg02709.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: i2c: sun6i-p2wi: Add YAML schemas
2019-06-11 14:50 ` Rob Herring
(?)
@ 2019-06-12 15:38 ` Maxime Ripard
-1 siblings, 0 replies; 13+ messages in thread
From: Maxime Ripard @ 2019-06-12 15:38 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Rutland, devicetree, Wolfram Sang, Gregory Clement,
Chen-Yu Tsai, Linux I2C, Frank Rowand,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
[-- Attachment #1.1: Type: text/plain, Size: 1639 bytes --]
Hi,
On Tue, Jun 11, 2019 at 08:50:37AM -0600, Rob Herring wrote:
> On Tue, Jun 11, 2019 at 3:06 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >
> > Hi Rob,
> >
> > On Mon, Jun 10, 2019 at 03:34:18PM -0600, Rob Herring wrote:
> > > On Wed, Jun 5, 2019 at 6:29 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > > +properties:
> > > > + "#address-cells":
> > > > + const: 1
> > > > +
> > > > + "#size-cells":
> > > > + const: 0
> > >
> > > These 2 are covered by i2c-controller.yaml, right?
> >
> > Indeed, I've removed them.
> >
> > > > +examples:
> > > > + - |
> > > > + p2wi@1f03400 {
> > >
> > > i2c@...
> > >
> > > That should fail on the schema (I need to get the schema checking of
> > > examples finished.)
> >
> > That would be great :) The compilation of the examples alone already
> > caught a good number of examples that weren't even compiling.
>
> I'm primarily waiting on a dtc change to be accepted[1]. Feel free to
> review/ack.
I guess it's too late now :)
> > Speaking of examples, one thing that would be great too would be to
> > allow the usage of our C headers. It's not supported at the moment,
> > and this often ends up with an example that is less readable than the
> > actual DT.
>
> It should be. You just have to add them. See
> Documentation/devicetree/bindings/timer/intel,ixp4xx-timer.yaml for
> example.
Hmmm, I'm pretty sure I tried this before. I'll try again.
> Maybe the common interrupt and gpio ones should be added by default.
I guess so, yeah. The GIC too is pretty common
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2019-06-12 15:38 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-05 12:29 [PATCH v2 1/2] dt-bindings: i2c: sun6i-p2wi: Add YAML schemas Maxime Ripard
2019-06-05 12:29 ` Maxime Ripard
2019-06-05 12:29 ` [PATCH v2 2/2] dt-bindings: i2c: mv64xxx: " Maxime Ripard
2019-06-05 12:29 ` Maxime Ripard
2019-06-10 21:37 ` Rob Herring
2019-06-10 21:37 ` Rob Herring
2019-06-11 9:07 ` Maxime Ripard
2019-06-10 21:34 ` [PATCH v2 1/2] dt-bindings: i2c: sun6i-p2wi: " Rob Herring
2019-06-10 21:34 ` Rob Herring
2019-06-11 9:06 ` Maxime Ripard
2019-06-11 14:50 ` Rob Herring
2019-06-11 14:50 ` Rob Herring
2019-06-12 15:38 ` Maxime Ripard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.