From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3731BC31E45 for ; Thu, 13 Jun 2019 15:09:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0363D21473 for ; Thu, 13 Jun 2019 15:09:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733296AbfFMPJL (ORCPT ); Thu, 13 Jun 2019 11:09:11 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:35703 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732366AbfFMN6e (ORCPT ); Thu, 13 Jun 2019 09:58:34 -0400 Received: from localhost (aaubervilliers-681-1-40-246.w90-88.abo.wanadoo.fr [90.88.159.246]) (Authenticated sender: maxime.ripard@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 7B341240018; Thu, 13 Jun 2019 13:58:29 +0000 (UTC) Date: Thu, 13 Jun 2019 15:16:26 +0200 From: Maxime Ripard To: Jagan Teki Cc: David Airlie , Daniel Vetter , Chen-Yu Tsai , dri-devel , linux-arm-kernel , linux-kernel , Bhushan Shah , Vasily Khoruzhick , =?utf-8?B?5Z2a5a6a5YmN6KGM?= , Michael Trimarchi , linux-amarula , linux-sunxi Subject: Re: [linux-sunxi] Re: [PATCH v10 04/11] drm/sun4i: tcon: Compute DCLK dividers based on format, lanes Message-ID: <20190613131626.7zbwvrvd4e7eafrc@flea> References: <20190520090318.27570-1-jagan@amarulasolutions.com> <20190520090318.27570-5-jagan@amarulasolutions.com> <20190523204823.mx7l4ozklzdh7npn@flea> <20190604143016.fcx3ezmga244xakp@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d5j2vvukhnlirhvf" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --d5j2vvukhnlirhvf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 05, 2019 at 01:11:44PM +0530, Jagan Teki wrote: > On Tue, Jun 4, 2019 at 8:00 PM Maxime Ripard wrote: > > > > On Fri, May 24, 2019 at 03:37:36PM +0530, Jagan Teki wrote: > > > On Fri, May 24, 2019 at 2:18 AM Maxime Ripard wrote: > > > > > > > > On Mon, May 20, 2019 at 02:33:11PM +0530, Jagan Teki wrote: > > > > > pll-video => pll-mipi => tcon0 => tcon0-pixel-clock is the typical > > > > > MIPI clock topology in Allwinner DSI controller. > > > > > > > > > > TCON dotclock driver is computing the desired DCLK divider based on > > > > > panel pixel clock along with input DCLK min, max divider values from > > > > > tcon driver and that would eventually set the pll-mipi clock rate. > > > > > > > > > > The current code is passing dsi min and max divider value as 4 via > > > > > tcon driver which would ended-up triggering below vblank wait timed out > > > > > warning on "bananapi,s070wv20-ct16" panel. > > > > > > > > > > WARNING: CPU: 0 PID: 31 at drivers/gpu/drm/drm_atomic_helper.c:1429 drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0 > > > > > [CRTC:46:crtc-0] vblank wait timed out > > > > > Modules linked in: > > > > > CPU: 0 PID: 31 Comm: kworker/0:1 Not tainted 5.1.0-next-20190514-00025-g5186cdf10757-dirty #6 > > > > > Hardware name: Allwinner sun8i Family > > > > > Workqueue: events deferred_probe_work_func > > > > > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > > > > > [] (show_stack) from [] (dump_stack+0x84/0x98) > > > > > [] (dump_stack) from [] (__warn+0xfc/0x114) > > > > > [] (__warn) from [] (warn_slowpath_fmt+0x44/0x68) > > > > > [] (warn_slowpath_fmt) from [] (drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0) > > > > > [] (drm_atomic_helper_wait_for_vblanks.part.1) from [] (drm_atomic_helper_commit_tail_rpm+0x5c/0x6c) > > > > > [] (drm_atomic_helper_commit_tail_rpm) from [] (commit_tail+0x40/0x6c) > > > > > [] (commit_tail) from [] (drm_atomic_helper_commit+0xbc/0x128) > > > > > [] (drm_atomic_helper_commit) from [] (restore_fbdev_mode_atomic+0x1cc/0x1dc) > > > > > [] (restore_fbdev_mode_atomic) from [] (drm_fb_helper_restore_fbdev_mode_unlocked+0x54/0xa0) > > > > > [] (drm_fb_helper_restore_fbdev_mode_unlocked) from [] (drm_fb_helper_set_par+0x30/0x54) > > > > > [] (drm_fb_helper_set_par) from [] (fbcon_init+0x560/0x5ac) > > > > > [] (fbcon_init) from [] (visual_init+0xbc/0x104) > > > > > [] (visual_init) from [] (do_bind_con_driver+0x1b0/0x390) > > > > > [] (do_bind_con_driver) from [] (do_take_over_console+0x13c/0x1c4) > > > > > [] (do_take_over_console) from [] (do_fbcon_takeover+0x74/0xcc) > > > > > [] (do_fbcon_takeover) from [] (notifier_call_chain+0x44/0x84) > > > > > [] (notifier_call_chain) from [] (__blocking_notifier_call_chain+0x48/0x60) > > > > > [] (__blocking_notifier_call_chain) from [] (blocking_notifier_call_chain+0x18/0x20) > > > > > [] (blocking_notifier_call_chain) from [] (register_framebuffer+0x1e0/0x2f8) > > > > > [] (register_framebuffer) from [] (__drm_fb_helper_initial_config_and_unlock+0x2fc/0x50c) > > > > > [] (__drm_fb_helper_initial_config_and_unlock) from [] (drm_fbdev_client_hotplug+0xe8/0x1b8) > > > > > [] (drm_fbdev_client_hotplug) from [] (drm_fbdev_generic_setup+0x88/0x118) > > > > > [] (drm_fbdev_generic_setup) from [] (sun4i_drv_bind+0x128/0x160) > > > > > [] (sun4i_drv_bind) from [] (try_to_bring_up_master+0x164/0x1a0) > > > > > [] (try_to_bring_up_master) from [] (__component_add+0x94/0x140) > > > > > [] (__component_add) from [] (sun6i_dsi_probe+0x144/0x234) > > > > > [] (sun6i_dsi_probe) from [] (platform_drv_probe+0x48/0x9c) > > > > > [] (platform_drv_probe) from [] (really_probe+0x1dc/0x2c8) > > > > > [] (really_probe) from [] (driver_probe_device+0x60/0x160) > > > > > [] (driver_probe_device) from [] (bus_for_each_drv+0x74/0xb8) > > > > > [] (bus_for_each_drv) from [] (__device_attach+0xd0/0x13c) > > > > > [] (__device_attach) from [] (bus_probe_device+0x84/0x8c) > > > > > [] (bus_probe_device) from [] (deferred_probe_work_func+0x64/0x90) > > > > > [] (deferred_probe_work_func) from [] (process_one_work+0x204/0x420) > > > > > [] (process_one_work) from [] (worker_thread+0x274/0x5a0) > > > > > [] (worker_thread) from [] (kthread+0x11c/0x14c) > > > > > [] (kthread) from [] (ret_from_fork+0x14/0x2c) > > > > > Exception stack(0xde539fb0 to 0xde539ff8) > > > > > 9fa0: 00000000 00000000 00000000 00000000 > > > > > 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > > > > > 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 > > > > > ---[ end trace 4017fea4906ab391 ]--- > > > > > > > > > > But accordingly to Allwinner A33, A64 BSP codes [1] [2] this divider > > > > > is clearly using 'format/lanes' for dsi divider value, dsi_clk.clk_div > > > > > > > > > > Which would compute the pll_freq and set a clock rate for it in > > > > > [3] and [4] respectively. > > > > > > > > > > The same issue has reproduced in A33, A64 with 4-lane and 2-lane devices > > > > > and got fixed with this computation logic 'format/lanes', so this patch > > > > > using dclk min and max dividers as per BSP. > > > > > > > > > > [1] https://github.com/BPI-SINOVOIP/BPI-M2M-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp/de/disp_lcd.c#L1106 > > > > > [2] https://github.com/BPI-SINOVOIP/BPI-M64-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/disp_al.c#L213 > > > > > [3] https://github.com/BPI-SINOVOIP/BPI-M2M-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp/de/disp_lcd.c#L1127 > > > > > [4] https://github.com/BPI-SINOVOIP/BPI-M2M-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp/de/disp_lcd.c#L1161 > > > > > > > > In that mail, I've pointed out that clk_div isn't used for the TCON dclk divider: > > > > http://lists.infradead.org/pipermail/linux-arm-kernel/2019-February/629596.html > > > > > > > > The only reply you've sent is that you indeed see that the divider is > > > > set to 4 in the BSP, but you're now saying that the BSP can change > > > > it. If so, then please point exactly the flaw in the explanation in > > > > that mail. > > > > > > Frankly, I have explained these details in commit message and previous > > > version patch[1] with print messages on the code. > > > > > > BSP has tcon_div and dsi_div. dsi_div is dynamic which depends on > > > bpp/lanes and it indeed depends on PLL computation (not tcon_div), > > > anyway I have explained again on this initial link you mentioned. > > > Please have a look and get back. > > > > I'll have a look, thanks. > > > > I've given your patches a try on my setup though, and this patch > > breaks it with vblank timeouts and some horizontal lines that looks > > like what should be displayed, but blinking and on the right of the > > display. The previous ones are fine though. > > Would you please send me the link of panel driver. It's drivers/gpu/drm/panel/panel-ronbo-rb070d30.c Maximey -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --d5j2vvukhnlirhvf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXQJMqgAKCRDj7w1vZxhR xRG3AP9n+1pCjBcPrRsDr1o7h97ThO8ebt5vlC4/MVvIIycKCwD/VU98+wn1USHB 92fNUkmfqy5nkiflXspg5losBrEDnQM= =mign -----END PGP SIGNATURE----- --d5j2vvukhnlirhvf-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECE9CC31E45 for ; Thu, 13 Jun 2019 13:58:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3B9720673 for ; Thu, 13 Jun 2019 13:58:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ro4R3wJH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3B9720673 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+PrDQFbMfvCec1aEZEt1fO+Xaa3a2JFJi29bbp+dOos=; b=ro4R3wJH8frUtaeHJ/j+91llW aI/+olDCsTy3sh6O5ei9V0uWUX/MDkctZVvKkcJkTjGPSNynY9fpmZPKpZzGZBvxpTryreK2YhaM/ hSqQH92xTXErM2mfp31AkTIu+YFaTt/4SiSJeQltaPujcmDNON7bZRBiuHqMYKvS3zFy//h6UyfJD whrX93dtcF3tLGmFrcpZ60LW8lHUDUxPR/4XINsw3U8a44Ql/w/vSs9wQCzHyWYXBG9DdQMiojXod iRFnVUO7oO5uGhKRsVu8rrSbrs/BgJIeW3l8KJYu2G5j32rqICoX1nPBXgLvlgAAGf+4eoXUlvkNq YqlKTWrVw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbQFZ-0006D3-NI; Thu, 13 Jun 2019 13:58:45 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hbQFN-000634-Ms for linux-arm-kernel@lists.infradead.org; Thu, 13 Jun 2019 13:58:36 +0000 Received: from localhost (aaubervilliers-681-1-40-246.w90-88.abo.wanadoo.fr [90.88.159.246]) (Authenticated sender: maxime.ripard@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 7B341240018; Thu, 13 Jun 2019 13:58:29 +0000 (UTC) Date: Thu, 13 Jun 2019 15:16:26 +0200 From: Maxime Ripard To: Jagan Teki Subject: Re: [linux-sunxi] Re: [PATCH v10 04/11] drm/sun4i: tcon: Compute DCLK dividers based on format, lanes Message-ID: <20190613131626.7zbwvrvd4e7eafrc@flea> References: <20190520090318.27570-1-jagan@amarulasolutions.com> <20190520090318.27570-5-jagan@amarulasolutions.com> <20190523204823.mx7l4ozklzdh7npn@flea> <20190604143016.fcx3ezmga244xakp@flea> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190613_065834_185542_C626462D X-CRM114-Status: GOOD ( 23.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bhushan Shah , David Airlie , linux-sunxi , linux-kernel , dri-devel , =?utf-8?B?5Z2a5a6a5YmN6KGM?= , Chen-Yu Tsai , Daniel Vetter , Michael Trimarchi , linux-amarula , linux-arm-kernel Content-Type: multipart/mixed; boundary="===============8843713076358783273==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8843713076358783273== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d5j2vvukhnlirhvf" Content-Disposition: inline --d5j2vvukhnlirhvf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 05, 2019 at 01:11:44PM +0530, Jagan Teki wrote: > On Tue, Jun 4, 2019 at 8:00 PM Maxime Ripard wrote: > > > > On Fri, May 24, 2019 at 03:37:36PM +0530, Jagan Teki wrote: > > > On Fri, May 24, 2019 at 2:18 AM Maxime Ripard wrote: > > > > > > > > On Mon, May 20, 2019 at 02:33:11PM +0530, Jagan Teki wrote: > > > > > pll-video => pll-mipi => tcon0 => tcon0-pixel-clock is the typical > > > > > MIPI clock topology in Allwinner DSI controller. > > > > > > > > > > TCON dotclock driver is computing the desired DCLK divider based on > > > > > panel pixel clock along with input DCLK min, max divider values from > > > > > tcon driver and that would eventually set the pll-mipi clock rate. > > > > > > > > > > The current code is passing dsi min and max divider value as 4 via > > > > > tcon driver which would ended-up triggering below vblank wait timed out > > > > > warning on "bananapi,s070wv20-ct16" panel. > > > > > > > > > > WARNING: CPU: 0 PID: 31 at drivers/gpu/drm/drm_atomic_helper.c:1429 drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0 > > > > > [CRTC:46:crtc-0] vblank wait timed out > > > > > Modules linked in: > > > > > CPU: 0 PID: 31 Comm: kworker/0:1 Not tainted 5.1.0-next-20190514-00025-g5186cdf10757-dirty #6 > > > > > Hardware name: Allwinner sun8i Family > > > > > Workqueue: events deferred_probe_work_func > > > > > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > > > > > [] (show_stack) from [] (dump_stack+0x84/0x98) > > > > > [] (dump_stack) from [] (__warn+0xfc/0x114) > > > > > [] (__warn) from [] (warn_slowpath_fmt+0x44/0x68) > > > > > [] (warn_slowpath_fmt) from [] (drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0) > > > > > [] (drm_atomic_helper_wait_for_vblanks.part.1) from [] (drm_atomic_helper_commit_tail_rpm+0x5c/0x6c) > > > > > [] (drm_atomic_helper_commit_tail_rpm) from [] (commit_tail+0x40/0x6c) > > > > > [] (commit_tail) from [] (drm_atomic_helper_commit+0xbc/0x128) > > > > > [] (drm_atomic_helper_commit) from [] (restore_fbdev_mode_atomic+0x1cc/0x1dc) > > > > > [] (restore_fbdev_mode_atomic) from [] (drm_fb_helper_restore_fbdev_mode_unlocked+0x54/0xa0) > > > > > [] (drm_fb_helper_restore_fbdev_mode_unlocked) from [] (drm_fb_helper_set_par+0x30/0x54) > > > > > [] (drm_fb_helper_set_par) from [] (fbcon_init+0x560/0x5ac) > > > > > [] (fbcon_init) from [] (visual_init+0xbc/0x104) > > > > > [] (visual_init) from [] (do_bind_con_driver+0x1b0/0x390) > > > > > [] (do_bind_con_driver) from [] (do_take_over_console+0x13c/0x1c4) > > > > > [] (do_take_over_console) from [] (do_fbcon_takeover+0x74/0xcc) > > > > > [] (do_fbcon_takeover) from [] (notifier_call_chain+0x44/0x84) > > > > > [] (notifier_call_chain) from [] (__blocking_notifier_call_chain+0x48/0x60) > > > > > [] (__blocking_notifier_call_chain) from [] (blocking_notifier_call_chain+0x18/0x20) > > > > > [] (blocking_notifier_call_chain) from [] (register_framebuffer+0x1e0/0x2f8) > > > > > [] (register_framebuffer) from [] (__drm_fb_helper_initial_config_and_unlock+0x2fc/0x50c) > > > > > [] (__drm_fb_helper_initial_config_and_unlock) from [] (drm_fbdev_client_hotplug+0xe8/0x1b8) > > > > > [] (drm_fbdev_client_hotplug) from [] (drm_fbdev_generic_setup+0x88/0x118) > > > > > [] (drm_fbdev_generic_setup) from [] (sun4i_drv_bind+0x128/0x160) > > > > > [] (sun4i_drv_bind) from [] (try_to_bring_up_master+0x164/0x1a0) > > > > > [] (try_to_bring_up_master) from [] (__component_add+0x94/0x140) > > > > > [] (__component_add) from [] (sun6i_dsi_probe+0x144/0x234) > > > > > [] (sun6i_dsi_probe) from [] (platform_drv_probe+0x48/0x9c) > > > > > [] (platform_drv_probe) from [] (really_probe+0x1dc/0x2c8) > > > > > [] (really_probe) from [] (driver_probe_device+0x60/0x160) > > > > > [] (driver_probe_device) from [] (bus_for_each_drv+0x74/0xb8) > > > > > [] (bus_for_each_drv) from [] (__device_attach+0xd0/0x13c) > > > > > [] (__device_attach) from [] (bus_probe_device+0x84/0x8c) > > > > > [] (bus_probe_device) from [] (deferred_probe_work_func+0x64/0x90) > > > > > [] (deferred_probe_work_func) from [] (process_one_work+0x204/0x420) > > > > > [] (process_one_work) from [] (worker_thread+0x274/0x5a0) > > > > > [] (worker_thread) from [] (kthread+0x11c/0x14c) > > > > > [] (kthread) from [] (ret_from_fork+0x14/0x2c) > > > > > Exception stack(0xde539fb0 to 0xde539ff8) > > > > > 9fa0: 00000000 00000000 00000000 00000000 > > > > > 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > > > > > 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 > > > > > ---[ end trace 4017fea4906ab391 ]--- > > > > > > > > > > But accordingly to Allwinner A33, A64 BSP codes [1] [2] this divider > > > > > is clearly using 'format/lanes' for dsi divider value, dsi_clk.clk_div > > > > > > > > > > Which would compute the pll_freq and set a clock rate for it in > > > > > [3] and [4] respectively. > > > > > > > > > > The same issue has reproduced in A33, A64 with 4-lane and 2-lane devices > > > > > and got fixed with this computation logic 'format/lanes', so this patch > > > > > using dclk min and max dividers as per BSP. > > > > > > > > > > [1] https://github.com/BPI-SINOVOIP/BPI-M2M-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp/de/disp_lcd.c#L1106 > > > > > [2] https://github.com/BPI-SINOVOIP/BPI-M64-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/disp_al.c#L213 > > > > > [3] https://github.com/BPI-SINOVOIP/BPI-M2M-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp/de/disp_lcd.c#L1127 > > > > > [4] https://github.com/BPI-SINOVOIP/BPI-M2M-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp/de/disp_lcd.c#L1161 > > > > > > > > In that mail, I've pointed out that clk_div isn't used for the TCON dclk divider: > > > > http://lists.infradead.org/pipermail/linux-arm-kernel/2019-February/629596.html > > > > > > > > The only reply you've sent is that you indeed see that the divider is > > > > set to 4 in the BSP, but you're now saying that the BSP can change > > > > it. If so, then please point exactly the flaw in the explanation in > > > > that mail. > > > > > > Frankly, I have explained these details in commit message and previous > > > version patch[1] with print messages on the code. > > > > > > BSP has tcon_div and dsi_div. dsi_div is dynamic which depends on > > > bpp/lanes and it indeed depends on PLL computation (not tcon_div), > > > anyway I have explained again on this initial link you mentioned. > > > Please have a look and get back. > > > > I'll have a look, thanks. > > > > I've given your patches a try on my setup though, and this patch > > breaks it with vblank timeouts and some horizontal lines that looks > > like what should be displayed, but blinking and on the right of the > > display. The previous ones are fine though. > > Would you please send me the link of panel driver. It's drivers/gpu/drm/panel/panel-ronbo-rb070d30.c Maximey -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --d5j2vvukhnlirhvf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXQJMqgAKCRDj7w1vZxhR xRG3AP9n+1pCjBcPrRsDr1o7h97ThO8ebt5vlC4/MVvIIycKCwD/VU98+wn1USHB 92fNUkmfqy5nkiflXspg5losBrEDnQM= =mign -----END PGP SIGNATURE----- --d5j2vvukhnlirhvf-- --===============8843713076358783273== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8843713076358783273==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: Re: [PATCH v10 04/11] drm/sun4i: tcon: Compute DCLK dividers based on format, lanes Date: Thu, 13 Jun 2019 15:16:26 +0200 Message-ID: <20190613131626.7zbwvrvd4e7eafrc@flea> References: <20190520090318.27570-1-jagan@amarulasolutions.com> <20190520090318.27570-5-jagan@amarulasolutions.com> <20190523204823.mx7l4ozklzdh7npn@flea> <20190604143016.fcx3ezmga244xakp@flea> Reply-To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d5j2vvukhnlirhvf" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Jagan Teki Cc: David Airlie , Daniel Vetter , Chen-Yu Tsai , dri-devel , linux-arm-kernel , linux-kernel , Bhushan Shah , Vasily Khoruzhick , =?utf-8?B?5Z2a5a6a5YmN6KGM?= , Michael Trimarchi , linux-amarula , linux-sunxi List-Id: dri-devel@lists.freedesktop.org --d5j2vvukhnlirhvf Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline On Wed, Jun 05, 2019 at 01:11:44PM +0530, Jagan Teki wrote: > On Tue, Jun 4, 2019 at 8:00 PM Maxime Ripard wrote: > > > > On Fri, May 24, 2019 at 03:37:36PM +0530, Jagan Teki wrote: > > > On Fri, May 24, 2019 at 2:18 AM Maxime Ripard wrote: > > > > > > > > On Mon, May 20, 2019 at 02:33:11PM +0530, Jagan Teki wrote: > > > > > pll-video => pll-mipi => tcon0 => tcon0-pixel-clock is the typical > > > > > MIPI clock topology in Allwinner DSI controller. > > > > > > > > > > TCON dotclock driver is computing the desired DCLK divider based on > > > > > panel pixel clock along with input DCLK min, max divider values from > > > > > tcon driver and that would eventually set the pll-mipi clock rate. > > > > > > > > > > The current code is passing dsi min and max divider value as 4 via > > > > > tcon driver which would ended-up triggering below vblank wait timed out > > > > > warning on "bananapi,s070wv20-ct16" panel. > > > > > > > > > > WARNING: CPU: 0 PID: 31 at drivers/gpu/drm/drm_atomic_helper.c:1429 drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0 > > > > > [CRTC:46:crtc-0] vblank wait timed out > > > > > Modules linked in: > > > > > CPU: 0 PID: 31 Comm: kworker/0:1 Not tainted 5.1.0-next-20190514-00025-g5186cdf10757-dirty #6 > > > > > Hardware name: Allwinner sun8i Family > > > > > Workqueue: events deferred_probe_work_func > > > > > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > > > > > [] (show_stack) from [] (dump_stack+0x84/0x98) > > > > > [] (dump_stack) from [] (__warn+0xfc/0x114) > > > > > [] (__warn) from [] (warn_slowpath_fmt+0x44/0x68) > > > > > [] (warn_slowpath_fmt) from [] (drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0) > > > > > [] (drm_atomic_helper_wait_for_vblanks.part.1) from [] (drm_atomic_helper_commit_tail_rpm+0x5c/0x6c) > > > > > [] (drm_atomic_helper_commit_tail_rpm) from [] (commit_tail+0x40/0x6c) > > > > > [] (commit_tail) from [] (drm_atomic_helper_commit+0xbc/0x128) > > > > > [] (drm_atomic_helper_commit) from [] (restore_fbdev_mode_atomic+0x1cc/0x1dc) > > > > > [] (restore_fbdev_mode_atomic) from [] (drm_fb_helper_restore_fbdev_mode_unlocked+0x54/0xa0) > > > > > [] (drm_fb_helper_restore_fbdev_mode_unlocked) from [] (drm_fb_helper_set_par+0x30/0x54) > > > > > [] (drm_fb_helper_set_par) from [] (fbcon_init+0x560/0x5ac) > > > > > [] (fbcon_init) from [] (visual_init+0xbc/0x104) > > > > > [] (visual_init) from [] (do_bind_con_driver+0x1b0/0x390) > > > > > [] (do_bind_con_driver) from [] (do_take_over_console+0x13c/0x1c4) > > > > > [] (do_take_over_console) from [] (do_fbcon_takeover+0x74/0xcc) > > > > > [] (do_fbcon_takeover) from [] (notifier_call_chain+0x44/0x84) > > > > > [] (notifier_call_chain) from [] (__blocking_notifier_call_chain+0x48/0x60) > > > > > [] (__blocking_notifier_call_chain) from [] (blocking_notifier_call_chain+0x18/0x20) > > > > > [] (blocking_notifier_call_chain) from [] (register_framebuffer+0x1e0/0x2f8) > > > > > [] (register_framebuffer) from [] (__drm_fb_helper_initial_config_and_unlock+0x2fc/0x50c) > > > > > [] (__drm_fb_helper_initial_config_and_unlock) from [] (drm_fbdev_client_hotplug+0xe8/0x1b8) > > > > > [] (drm_fbdev_client_hotplug) from [] (drm_fbdev_generic_setup+0x88/0x118) > > > > > [] (drm_fbdev_generic_setup) from [] (sun4i_drv_bind+0x128/0x160) > > > > > [] (sun4i_drv_bind) from [] (try_to_bring_up_master+0x164/0x1a0) > > > > > [] (try_to_bring_up_master) from [] (__component_add+0x94/0x140) > > > > > [] (__component_add) from [] (sun6i_dsi_probe+0x144/0x234) > > > > > [] (sun6i_dsi_probe) from [] (platform_drv_probe+0x48/0x9c) > > > > > [] (platform_drv_probe) from [] (really_probe+0x1dc/0x2c8) > > > > > [] (really_probe) from [] (driver_probe_device+0x60/0x160) > > > > > [] (driver_probe_device) from [] (bus_for_each_drv+0x74/0xb8) > > > > > [] (bus_for_each_drv) from [] (__device_attach+0xd0/0x13c) > > > > > [] (__device_attach) from [] (bus_probe_device+0x84/0x8c) > > > > > [] (bus_probe_device) from [] (deferred_probe_work_func+0x64/0x90) > > > > > [] (deferred_probe_work_func) from [] (process_one_work+0x204/0x420) > > > > > [] (process_one_work) from [] (worker_thread+0x274/0x5a0) > > > > > [] (worker_thread) from [] (kthread+0x11c/0x14c) > > > > > [] (kthread) from [] (ret_from_fork+0x14/0x2c) > > > > > Exception stack(0xde539fb0 to 0xde539ff8) > > > > > 9fa0: 00000000 00000000 00000000 00000000 > > > > > 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > > > > > 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 > > > > > ---[ end trace 4017fea4906ab391 ]--- > > > > > > > > > > But accordingly to Allwinner A33, A64 BSP codes [1] [2] this divider > > > > > is clearly using 'format/lanes' for dsi divider value, dsi_clk.clk_div > > > > > > > > > > Which would compute the pll_freq and set a clock rate for it in > > > > > [3] and [4] respectively. > > > > > > > > > > The same issue has reproduced in A33, A64 with 4-lane and 2-lane devices > > > > > and got fixed with this computation logic 'format/lanes', so this patch > > > > > using dclk min and max dividers as per BSP. > > > > > > > > > > [1] https://github.com/BPI-SINOVOIP/BPI-M2M-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp/de/disp_lcd.c#L1106 > > > > > [2] https://github.com/BPI-SINOVOIP/BPI-M64-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/disp_al.c#L213 > > > > > [3] https://github.com/BPI-SINOVOIP/BPI-M2M-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp/de/disp_lcd.c#L1127 > > > > > [4] https://github.com/BPI-SINOVOIP/BPI-M2M-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp/de/disp_lcd.c#L1161 > > > > > > > > In that mail, I've pointed out that clk_div isn't used for the TCON dclk divider: > > > > http://lists.infradead.org/pipermail/linux-arm-kernel/2019-February/629596.html > > > > > > > > The only reply you've sent is that you indeed see that the divider is > > > > set to 4 in the BSP, but you're now saying that the BSP can change > > > > it. If so, then please point exactly the flaw in the explanation in > > > > that mail. > > > > > > Frankly, I have explained these details in commit message and previous > > > version patch[1] with print messages on the code. > > > > > > BSP has tcon_div and dsi_div. dsi_div is dynamic which depends on > > > bpp/lanes and it indeed depends on PLL computation (not tcon_div), > > > anyway I have explained again on this initial link you mentioned. > > > Please have a look and get back. > > > > I'll have a look, thanks. > > > > I've given your patches a try on my setup though, and this patch > > breaks it with vblank timeouts and some horizontal lines that looks > > like what should be displayed, but blinking and on the right of the > > display. The previous ones are fine though. > > Would you please send me the link of panel driver. It's drivers/gpu/drm/panel/panel-ronbo-rb070d30.c Maximey -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --d5j2vvukhnlirhvf--