From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH V12 2/4] drivers/perf: imx_ddr: Add ddr performance counter support Date: Thu, 13 Jun 2019 18:44:36 +0100 Message-ID: <20190613174436.GG18966@fuggles.cambridge.arm.com> References: <1556736193-29411-1-git-send-email-Frank.Li@nxp.com> <1556736193-29411-2-git-send-email-Frank.Li@nxp.com> <20190613112320.GA18966@fuggles.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Zhi Li Cc: "mark.rutland@arm.com" , Aisheng Dong , "devicetree@vger.kernel.org" , "andrew.smirnov@gmail.com" , "festevam@gmail.com" , "s.hauer@pengutronix.de" , Frank Li , "robh+dt@kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Thu, Jun 13, 2019 at 12:04:37PM -0500, Zhi Li wrote: > On Thu, Jun 13, 2019 at 6:23 AM Will Deacon wrote: > > > > On Wed, May 01, 2019 at 06:43:29PM +0000, Frank Li wrote: > > > Add ddr performance monitor support for iMX8QXP > > > > > > There are 4 counters for ddr perfomance events. > > > counter 0 is dedicated for cycles. > > > you choose any up to 3 no cycles events. > > > > > > for example: > > > > > > perf stat -a -e imx8_ddr0/read-cycles/,imx8_ddr0/write-cycles/,imx8_ddr0/precharge/ ls > > > perf stat -a -e imx8_ddr0/cycles/,imx8_ddr0/read-access/,imx8_ddr0/write-access/ ls > > > > I've pushed patches 1, 2 and 4 out with some minor tweaks to: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git/log/?h=for-next/perf > > > > I'll leave the actual .dts change to go via the soc tree, since last time > > I took one of those it just resulted in conflicts. > > > > Frank, Andrey: Please could you try to run the perf fuzzer on this before > > it lands in mainline? It has a good track record of finding nasty PMU driver > > bugs, but it obviously requires access to hardware which implements the PMU: > > > > http://web.eece.maine.edu/~vweaver/projects/perf_events/fuzzer/ > > Okay, how long should be run generally? > I need make sure it can pass without my patches at our platform. As you long as you can really, but if it survives a few hours that's usually a good sign. Overnight is even better. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD764C31E45 for ; Thu, 13 Jun 2019 17:44:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A72442175B for ; Thu, 13 Jun 2019 17:44:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rI3sbYhS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A72442175B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TnIPnML1T4bfJW137LyjkBo9wtNuVbTJURJtTVsKFms=; b=rI3sbYhSucdHML LYxaGBx6rG417GEQVdxfy/XfyfTJ7c8qdBZC+8kswX2NMlfTLiDhUCa7xhmDZ8PdpBDEFwncUkeva cTWnGcZYSRrHlOlizbSNpZjgzK6+Zoha5IXQ6Kbo53L1NObBa7o9P9watf5NYSuvqMPUHKhZpFD0h u7XFNfFHOpwEMUBCORo5JYjkbFWlkm3nvZBdbkkbrGj2ZEAHMMXyXaq9ZdnJsjT5+EVhuWGnGpDtX utN3eChv7epwSanmdVjKE5UhKHQE5f9KD/s6+1vyDbTrO4lT8mg0JwGn+vgQUB+hHb9hDY63qLUt3 T1fcaLBVRQGvM4mbNLtQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbTmI-0002IH-Pe; Thu, 13 Jun 2019 17:44:46 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbTmF-0002HB-Hy for linux-arm-kernel@lists.infradead.org; Thu, 13 Jun 2019 17:44:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6041E367; Thu, 13 Jun 2019 10:44:40 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A52BF3F694; Thu, 13 Jun 2019 10:44:38 -0700 (PDT) Date: Thu, 13 Jun 2019 18:44:36 +0100 From: Will Deacon To: Zhi Li Subject: Re: [PATCH V12 2/4] drivers/perf: imx_ddr: Add ddr performance counter support Message-ID: <20190613174436.GG18966@fuggles.cambridge.arm.com> References: <1556736193-29411-1-git-send-email-Frank.Li@nxp.com> <1556736193-29411-2-git-send-email-Frank.Li@nxp.com> <20190613112320.GA18966@fuggles.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190613_104443_643447_6675A4F7 X-CRM114-Status: GOOD ( 15.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , Aisheng Dong , "devicetree@vger.kernel.org" , "andrew.smirnov@gmail.com" , "festevam@gmail.com" , "s.hauer@pengutronix.de" , Frank Li , "robh+dt@kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 13, 2019 at 12:04:37PM -0500, Zhi Li wrote: > On Thu, Jun 13, 2019 at 6:23 AM Will Deacon wrote: > > > > On Wed, May 01, 2019 at 06:43:29PM +0000, Frank Li wrote: > > > Add ddr performance monitor support for iMX8QXP > > > > > > There are 4 counters for ddr perfomance events. > > > counter 0 is dedicated for cycles. > > > you choose any up to 3 no cycles events. > > > > > > for example: > > > > > > perf stat -a -e imx8_ddr0/read-cycles/,imx8_ddr0/write-cycles/,imx8_ddr0/precharge/ ls > > > perf stat -a -e imx8_ddr0/cycles/,imx8_ddr0/read-access/,imx8_ddr0/write-access/ ls > > > > I've pushed patches 1, 2 and 4 out with some minor tweaks to: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git/log/?h=for-next/perf > > > > I'll leave the actual .dts change to go via the soc tree, since last time > > I took one of those it just resulted in conflicts. > > > > Frank, Andrey: Please could you try to run the perf fuzzer on this before > > it lands in mainline? It has a good track record of finding nasty PMU driver > > bugs, but it obviously requires access to hardware which implements the PMU: > > > > http://web.eece.maine.edu/~vweaver/projects/perf_events/fuzzer/ > > Okay, how long should be run generally? > I need make sure it can pass without my patches at our platform. As you long as you can really, but if it survives a few hours that's usually a good sign. Overnight is even better. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel