From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAE8AC31E45 for ; Thu, 13 Jun 2019 18:42:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C346721473 for ; Thu, 13 Jun 2019 18:42:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728327AbfFMSm1 (ORCPT ); Thu, 13 Jun 2019 14:42:27 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:50856 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725851AbfFMSm1 (ORCPT ); Thu, 13 Jun 2019 14:42:27 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 5943E20024; Thu, 13 Jun 2019 20:42:23 +0200 (CEST) Date: Thu, 13 Jun 2019 20:42:17 +0200 From: Sam Ravnborg To: Alex Deucher Cc: Hariprasad Kelam , LKML , Yongqiang Sun , Charlene Liu , Leo Li , Bhawanpreet Lakha , Gloria Li , amd-gfx list , Nicholas Kazlauskas , David Airlie , Dmytro Laktyushkin , Tony Cheng , Maling list - DRI developers , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , Anthony Koo Subject: Re: [PATCH] drm/amd/display: fix compilation error Message-ID: <20190613184217.GA2385@ravnborg.org> References: <20190613023208.GA29690@hari-Inspiron-1545> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=pGLkceISAAAA:8 a=4PFS9l_RyDpw6E2KiyoA:9 a=QEXdDO2ut3YA:10 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alex. On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote: > On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam > wrote: > > > > this patch fixes below compilation error > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In > > function ‘dcn10_apply_ctx_for_surface’: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3: > > error: implicit declaration of function ‘udelay’ > > [-Werror=implicit-function-declaration] > > udelay(underflow_check_delay_us); > > > > Signed-off-by: Hariprasad Kelam Am I right in assuming you took this patch? I expect that new code using udelay was added to the amd tree, and when merged with drm-misc-next it failed, because drm-misc-next no longer had drmP.h included so no implicit include of delay.h The root cause was that my original patchset should have been based on the amd tree, and applied there :-( Sam From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH] drm/amd/display: fix compilation error Date: Thu, 13 Jun 2019 20:42:17 +0200 Message-ID: <20190613184217.GA2385@ravnborg.org> References: <20190613023208.GA29690@hari-Inspiron-1545> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Alex Deucher Cc: Charlene Liu , Hariprasad Kelam , Dmytro Laktyushkin , Christian =?iso-8859-1?Q?K=F6nig?= , Leo Li , Tony Cheng , LKML , amd-gfx list , Gloria Li , David Airlie , Yongqiang Sun , Maling list - DRI developers , Alex Deucher , Bhawanpreet Lakha , Nicholas Kazlauskas , Anthony Koo List-Id: dri-devel@lists.freedesktop.org SGkgQWxleC4KCk9uIFdlZCwgSnVuIDEyLCAyMDE5IGF0IDEwOjM1OjI2UE0gLTA0MDAsIEFsZXgg RGV1Y2hlciB3cm90ZToKPiBPbiBXZWQsIEp1biAxMiwgMjAxOSBhdCAxMDozNCBQTSBIYXJpcHJh c2FkIEtlbGFtCj4gPGhhcmlwcmFzYWQua2VsYW1AZ21haWwuY29tPiB3cm90ZToKPiA+Cj4gPiB0 aGlzIHBhdGNoIGZpeGVzIGJlbG93IGNvbXBpbGF0aW9uIGVycm9yCj4gPgo+ID4gZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvLi4vZGlzcGxheS9kYy9kY24xMC9kY24xMF9od19zZXF1ZW5jZXIu YzogSW4KPiA+IGZ1bmN0aW9uIOKAmGRjbjEwX2FwcGx5X2N0eF9mb3Jfc3VyZmFjZeKAmToKPiA+ IGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1Ly4uL2Rpc3BsYXkvZGMvZGNuMTAvZGNuMTBfaHdf c2VxdWVuY2VyLmM6MjM3ODozOgo+ID4gZXJyb3I6IGltcGxpY2l0IGRlY2xhcmF0aW9uIG9mIGZ1 bmN0aW9uIOKAmHVkZWxheeKAmQo+ID4gWy1XZXJyb3I9aW1wbGljaXQtZnVuY3Rpb24tZGVjbGFy YXRpb25dCj4gPiAgICB1ZGVsYXkodW5kZXJmbG93X2NoZWNrX2RlbGF5X3VzKTsKPiA+Cj4gPiBT aWduZWQtb2ZmLWJ5OiBIYXJpcHJhc2FkIEtlbGFtIDxoYXJpcHJhc2FkLmtlbGFtQGdtYWlsLmNv bT4KCkFtIEkgcmlnaHQgaW4gYXNzdW1pbmcgeW91IHRvb2sgdGhpcyBwYXRjaD8KCkkgZXhwZWN0 IHRoYXQgbmV3IGNvZGUgdXNpbmcgdWRlbGF5IHdhcyBhZGRlZCB0byB0aGUgYW1kIHRyZWUsCmFu ZCB3aGVuIG1lcmdlZCB3aXRoIGRybS1taXNjLW5leHQgaXQgZmFpbGVkLCBiZWNhdXNlIGRybS1t aXNjLW5leHQgbm8KbG9uZ2VyIGhhZCBkcm1QLmggaW5jbHVkZWQgc28gbm8gaW1wbGljaXQgaW5j bHVkZSBvZiBkZWxheS5oCgpUaGUgcm9vdCBjYXVzZSB3YXMgdGhhdCBteSBvcmlnaW5hbCBwYXRj aHNldCBzaG91bGQgaGF2ZSBiZWVuIGJhc2VkCm9uIHRoZSBhbWQgdHJlZSwgYW5kIGFwcGxpZWQg dGhlcmUgOi0oCgoJU2FtCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeA==