From: Stefan Hajnoczi <stefanha@gmail.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH qemu] loader: Trace loaded images
Date: Fri, 14 Jun 2019 10:33:06 +0100 [thread overview]
Message-ID: <20190614093306.GG10957@stefanha-x1.localdomain> (raw)
In-Reply-To: <d20e26db-7157-d9bd-c707-d7f4443396c0@ozlabs.ru>
[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]
On Fri, Jun 14, 2019 at 10:13:04AM +1000, Alexey Kardashevskiy wrote:
>
>
> On 13/06/2019 23:08, Philippe Mathieu-Daudé wrote:
> > Hi Alexey,
> >
> > On 6/13/19 7:09 AM, Alexey Kardashevskiy wrote:
> >> This adds a trace point which prints every loaded image. This includes
> >> bios/firmware/kernel/initradmdisk/pcirom.
> >>
> >> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> >> ---
> >>
> >> The example for a pseries guest:
> >>
> >> loader_write_rom slof.bin: @0x0 size=0xe22e0 ROM=0
> >> loader_write_rom phdr #0: /home/aik/t/vml4120le: @0x400000 size=0x13df000 ROM=0
> >> loader_write_rom /home/aik/t/le.cpio: @0x1ad0000 size=0x9463a00 ROM=0
> >
> > I find the "ROM=0" part confuse, maybe you can change to "ROM:false".
>
> How? I mean I can do that in the code as rom->isrom?"true":"false" and
> make trace point accept "%s" but it is quite ugly and others seem to
> just use %d for bool.
Yes, %d is the convention for bool. Perhaps you can name it "is_rom"
instead of "ROM". That way the name communicates that this is a boolean
value.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-06-14 9:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 5:09 [Qemu-devel] [PATCH qemu] loader: Trace loaded images Alexey Kardashevskiy
2019-06-13 5:59 ` no-reply
2019-06-13 13:08 ` Philippe Mathieu-Daudé
2019-06-14 0:13 ` Alexey Kardashevskiy
2019-06-14 9:33 ` Stefan Hajnoczi [this message]
2019-06-14 10:10 ` Philippe Mathieu-Daudé
2019-06-28 9:21 ` Stefan Hajnoczi
2019-06-17 1:25 ` Alexey Kardashevskiy
2019-06-17 4:56 ` Philippe Mathieu-Daudé
2019-06-20 5:50 ` Alexey Kardashevskiy
2019-06-20 8:53 ` Philippe Mathieu-Daudé
2019-09-12 15:09 ` Philippe Mathieu-Daudé
2019-09-16 15:50 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614093306.GG10957@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.