All of lore.kernel.org
 help / color / mirror / Atom feed
From: Coly Li <colyli@suse.de>
To: linux-bcache@vger.kernel.org
Cc: linux-block@vger.kernel.org, Coly Li <colyli@suse.de>
Subject: [PATCH 05/29] bcache: remove retry_flush_write from struct cache_set
Date: Fri, 14 Jun 2019 21:13:34 +0800	[thread overview]
Message-ID: <20190614131358.2771-6-colyli@suse.de> (raw)
In-Reply-To: <20190614131358.2771-1-colyli@suse.de>

In struct cache_set, retry_flush_write is added for commit c4dc2497d50d
("bcache: fix high CPU occupancy during journal") which is reverted in
previous patch.

Now it is useless anymore, and this patch removes it from bcache code.

Signed-off-by: Coly Li <colyli@suse.de>
---
 drivers/md/bcache/bcache.h | 1 -
 drivers/md/bcache/sysfs.c  | 5 -----
 2 files changed, 6 deletions(-)

diff --git a/drivers/md/bcache/bcache.h b/drivers/md/bcache/bcache.h
index e30a983a68cd..ae87cb01401e 100644
--- a/drivers/md/bcache/bcache.h
+++ b/drivers/md/bcache/bcache.h
@@ -706,7 +706,6 @@ struct cache_set {
 
 	atomic_long_t		reclaim;
 	atomic_long_t		flush_write;
-	atomic_long_t		retry_flush_write;
 
 	enum			{
 		ON_ERROR_UNREGISTER,
diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
index 6cd44d3cf906..a67e1e57ea68 100644
--- a/drivers/md/bcache/sysfs.c
+++ b/drivers/md/bcache/sysfs.c
@@ -85,7 +85,6 @@ read_attribute(state);
 read_attribute(cache_read_races);
 read_attribute(reclaim);
 read_attribute(flush_write);
-read_attribute(retry_flush_write);
 read_attribute(writeback_keys_done);
 read_attribute(writeback_keys_failed);
 read_attribute(io_errors);
@@ -691,9 +690,6 @@ SHOW(__bch_cache_set)
 	sysfs_print(flush_write,
 		    atomic_long_read(&c->flush_write));
 
-	sysfs_print(retry_flush_write,
-		    atomic_long_read(&c->retry_flush_write));
-
 	sysfs_print(writeback_keys_done,
 		    atomic_long_read(&c->writeback_keys_done));
 	sysfs_print(writeback_keys_failed,
@@ -910,7 +906,6 @@ static struct attribute *bch_cache_set_internal_files[] = {
 	&sysfs_cache_read_races,
 	&sysfs_reclaim,
 	&sysfs_flush_write,
-	&sysfs_retry_flush_write,
 	&sysfs_writeback_keys_done,
 	&sysfs_writeback_keys_failed,
 
-- 
2.16.4


  parent reply	other threads:[~2019-06-14 13:14 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 13:13 [PATCH 00/29] bcache candidate patches for Linux v5.3 Coly Li
2019-06-14 13:13 ` [PATCH 01/29] bcache: Revert "bcache: fix high CPU occupancy during journal" Coly Li
2019-06-14 13:13 ` [PATCH 02/29] bcache: Revert "bcache: free heap cache_set->flush_btree in bch_journal_free" Coly Li
2019-06-14 13:13 ` [PATCH 03/29] bcache: add code comments for journal_read_bucket() Coly Li
2019-06-14 13:13 ` [PATCH 04/29] bcache: set largest seq to ja->seq[bucket_index] in journal_read_bucket() Coly Li
2019-06-14 13:13 ` Coly Li [this message]
2019-06-14 13:13 ` [PATCH 06/29] bcache: fix race in btree_flush_write() Coly Li
2019-06-27  9:16   ` Yaowei Bai
2019-06-27 11:47     ` Coly Li
2019-06-27 12:45       ` Coly Li
2019-06-14 13:13 ` [PATCH 07/29] bcache: add reclaimed_journal_buckets to struct cache_set Coly Li
2019-06-14 13:13 ` [PATCH 08/29] bcache: fix return value error in bch_journal_read() Coly Li
2019-06-14 13:13 ` [PATCH 09/29] Revert "bcache: set CACHE_SET_IO_DISABLE in bch_cached_dev_error()" Coly Li
2019-06-14 13:13 ` [PATCH 10/29] bcache: avoid flushing btree node in cache_set_flush() if io disabled Coly Li
2019-06-14 13:13 ` [PATCH 11/29] bcache: ignore read-ahead request failure on backing device Coly Li
2019-06-14 13:13 ` [PATCH 12/29] bcache: add io error counting in write_bdev_super_endio() Coly Li
2019-06-14 13:13 ` [PATCH 13/29] bcache: remove "XXX:" comment line from run_cache_set() Coly Li
2019-06-14 13:13 ` [PATCH 14/29] bcache: remove unnecessary prefetch() in bset_search_tree() Coly Li
2019-06-14 13:13 ` [PATCH 15/29] bcache: use sysfs_match_string() instead of __sysfs_match_string() Coly Li
2019-06-14 13:13 ` [PATCH 16/29] bcache: add return value check to bch_cached_dev_run() Coly Li
2019-06-14 13:13 ` [PATCH 17/29] bcache: remove unncessary code in bch_btree_keys_init() Coly Li
2019-06-14 13:13 ` [PATCH 18/29] bcache: check CACHE_SET_IO_DISABLE in allocator code Coly Li
2019-06-14 13:13 ` [PATCH 19/29] bcache: check CACHE_SET_IO_DISABLE bit in bch_journal() Coly Li
2019-06-14 13:13 ` [PATCH 20/29] bcache: more detailed error message to bcache_device_link() Coly Li
2019-06-14 13:13 ` [PATCH 21/29] bcache: add more error message in bch_cached_dev_attach() Coly Li
2019-06-14 13:13 ` [PATCH 22/29] bcache: shrink btree node cache after bch_btree_check() Coly Li
2019-06-14 13:13 ` [PATCH 23/29] bcache: improve error message in bch_cached_dev_run() Coly Li
2019-06-14 13:13 ` [PATCH 24/29] bcache: make bset_search_tree() be more understandable Coly Li
2019-06-14 13:13 ` [PATCH 25/29] bcache: add pendings_cleanup to stop pending bcache device Coly Li
2019-06-14 13:13 ` [PATCH 26/29] bcache: avoid a deadlock in bcache_reboot() Coly Li
2019-06-14 13:13 ` [PATCH 27/29] bcache: acquire bch_register_lock later in cached_dev_detach_finish() Coly Li
2019-06-14 13:13 ` [PATCH 28/29] bcache: acquire bch_register_lock later in cached_dev_free() Coly Li
2019-06-14 13:13 ` [PATCH 29/29] bcache: fix potential deadlock in cached_def_free() Coly Li
2019-06-20  9:34 ` [PATCH 00/29] bcache candidate patches for Linux v5.3 Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190614131358.2771-6-colyli@suse.de \
    --to=colyli@suse.de \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.