From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=TKbG=UN=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id E4B9EC31E4D
	for <linux-kernel@archiver.kernel.org>; Fri, 14 Jun 2019 15:10:28 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id B2AF020866
	for <linux-kernel@archiver.kernel.org>; Fri, 14 Jun 2019 15:10:28 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726209AbfFNPK0 (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Fri, 14 Jun 2019 11:10:26 -0400
Received: from asavdk3.altibox.net ([109.247.116.14]:36811 "EHLO
        asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725825AbfFNPK0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 14 Jun 2019 11:10:26 -0400
Received: from ravnborg.org (unknown [158.248.194.18])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by asavdk3.altibox.net (Postfix) with ESMTPS id 081442002E;
        Fri, 14 Jun 2019 17:10:19 +0200 (CEST)
Date:   Fri, 14 Jun 2019 17:10:18 +0200
From:   Sam Ravnborg <sam@ravnborg.org>
To:     Robert Chiras <robert.chiras@nxp.com>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-imx@nxp.com
Subject: Re: [PATCH 2/2] drm/panel: Add support for Raydium RM67191 panel
 driver
Message-ID: <20190614151018.GA28829@ravnborg.org>
References: <1560513063-24995-1-git-send-email-robert.chiras@nxp.com>
 <1560513063-24995-3-git-send-email-robert.chiras@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1560513063-24995-3-git-send-email-robert.chiras@nxp.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-CMAE-Score: 0
X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0
        a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17
        a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=8AirrxEcAAAA:8
        a=mzydPrOCeu2ZGRC9EbsA:9 a=CjuIK1q_8ugA:10 a=ST-jHhOKWsTCqRlWije3:22
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Robert.

On top of the feedback from Fabio here is a bit more.

> +
> +#include <drm/drmP.h>
> +#include <drm/drm_crtc.h>
> +#include <drm/drm_mipi_dsi.h>
> +#include <drm/drm_panel.h>
> +#include <linux/gpio/consumer.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/regulator/consumer.h>
> +#include <video/mipi_display.h>
> +#include <video/of_videomode.h>
> +#include <video/videomode.h>

Divide include up in block in following order:

#include <linux/*>

#include <video/*>

#incude <drm/*>

Within each block sort alphabetically.
Do not use the deprecated drmP.h - replace it with the necessary
includes.
Use an empty line between each include block.

> +
> +/* Write Manufacture Command Set Control */
> +#define WRMAUCCTR 0xFE
> +
> +/* Manufacturer Command Set pages (CMD2) */
> +struct cmd_set_entry {
> +	u8 cmd;
> +	u8 param;
> +};
> +
> +/*
> + * There is no description in the Reference Manual about these commands.
> + * We received them from vendor, so just use them as is.
> + */
> +static const struct cmd_set_entry manufacturer_cmd_set[] = {
> +	{0xFE, 0x0B},
> +	{0x28, 0x40},
> +	{0x29, 0x4F},
...
> +	{0x51, 0x04},
> +};
> +
> +static const u32 rad_bus_formats[] = {
> +	MEDIA_BUS_FMT_RGB888_1X24,
> +	MEDIA_BUS_FMT_RGB666_1X18,
> +	MEDIA_BUS_FMT_RGB565_1X16,
> +};
> +
> +struct rad_panel {
> +	struct drm_panel base;
In the other raydium driver we name this "panel", which is a more
descriptive name.

> +	struct mipi_dsi_device *dsi;
> +
> +	struct gpio_desc *reset;
> +	struct backlight_device *backlight;
> +
> +	bool prepared;
> +	bool enabled;
> +
> +	struct videomode vm;
> +	u32 width_mm;
> +	u32 height_mm;
> +};
> +
> +static int rad_panel_prepare(struct drm_panel *panel)
> +{
> +	struct rad_panel *rad = to_rad_panel(panel);
> +
> +	if (rad->prepared)
> +		return 0;
> +
> +	if (rad->reset) {
> +		gpiod_set_value(rad->reset, 0);
> +		usleep_range(5000, 10000);
> +		gpiod_set_value(rad->reset, 1);
> +		usleep_range(20000, 25000);
> +	}
> +
> +	rad->prepared = true;
> +
> +	return 0;
> +}
> +
> +static int rad_panel_unprepare(struct drm_panel *panel)
> +{
> +	struct rad_panel *rad = to_rad_panel(panel);
> +	struct device *dev = &rad->dsi->dev;
> +
> +	if (!rad->prepared)
> +		return 0;
> +
> +	if (rad->enabled) {
> +		DRM_DEV_ERROR(dev, "Panel still enabled!\n");
> +		return -EPERM;
> +	}
This seems like overkill, what should trigger this?

> +
> +	if (rad->reset) {
> +		gpiod_set_value(rad->reset, 0);
> +		usleep_range(15000, 17000);
> +		gpiod_set_value(rad->reset, 1);
> +	}
> +
> +	rad->prepared = false;
> +
> +	return 0;
> +}
> +
> +static int rad_panel_enable(struct drm_panel *panel)
> +{
> +	struct rad_panel *rad = to_rad_panel(panel);
> +	struct mipi_dsi_device *dsi = rad->dsi;
> +	struct device *dev = &dsi->dev;
> +	int color_format = color_format_from_dsi_format(dsi->format);
> +	u16 brightness;
> +	int ret;
> +
> +	if (rad->enabled)
> +		return 0;
> +
> +	if (!rad->prepared) {
> +		DRM_DEV_ERROR(dev, "Panel not prepared!\n");
> +		return -EPERM;
> +	}
Seems like overkill.

> +
> +	dsi->mode_flags |= MIPI_DSI_MODE_LPM;
> +
> +	ret = rad_panel_push_cmd_list(dsi);
> +	if (ret < 0) {
> +		DRM_DEV_ERROR(dev, "Failed to send MCS (%d)\n", ret);
> +		goto fail;
> +	}
> +
> +	/* Select User Command Set table (CMD1) */
> +	ret = mipi_dsi_generic_write(dsi, (u8[]){ WRMAUCCTR, 0x00 }, 2);
> +	if (ret < 0)
> +		goto fail;
> +
> +	/* Software reset */
> +	ret = mipi_dsi_dcs_soft_reset(dsi);
> +	if (ret < 0) {
> +		DRM_DEV_ERROR(dev, "Failed to do Software Reset (%d)\n", ret);
> +		goto fail;
> +	}
> +
> +	usleep_range(15000, 17000);
> +
> +	/* Set DSI mode */
> +	ret = mipi_dsi_generic_write(dsi, (u8[]){ 0xC2, 0x0B }, 2);
> +	if (ret < 0) {
> +		DRM_DEV_ERROR(dev, "Failed to set DSI mode (%d)\n", ret);
> +		goto fail;
> +	}
> +	/* Set tear ON */
> +	ret = mipi_dsi_dcs_set_tear_on(dsi, MIPI_DSI_DCS_TEAR_MODE_VBLANK);
> +	if (ret < 0) {
> +		DRM_DEV_ERROR(dev, "Failed to set tear ON (%d)\n", ret);
> +		goto fail;
> +	}
> +	/* Set tear scanline */
> +	ret = mipi_dsi_dcs_set_tear_scanline(dsi, 0x380);
> +	if (ret < 0) {
> +		DRM_DEV_ERROR(dev, "Failed to set tear scanline (%d)\n", ret);
> +		goto fail;
> +	}
> +	/* Set pixel format */
> +	ret = mipi_dsi_dcs_set_pixel_format(dsi, color_format);
> +	DRM_DEV_DEBUG_DRIVER(dev, "Interface color format set to 0x%x\n",
> +			     color_format);
> +	if (ret < 0) {
> +		DRM_DEV_ERROR(dev, "Failed to set pixel format (%d)\n", ret);
> +		goto fail;
> +	}
> +	/* Set display brightness */
> +	brightness = rad->backlight->props.brightness;
> +	ret = mipi_dsi_dcs_set_display_brightness(dsi, brightness);
> +	if (ret < 0) {
> +		DRM_DEV_ERROR(dev, "Failed to set display brightness (%d)\n",
> +			      ret);
> +		goto fail;
> +	}
brightness is written to again when you enable backlight below.
Seems redundant to do so twice.


> +	/* Exit sleep mode */
> +	ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
> +	if (ret < 0) {
> +		DRM_DEV_ERROR(dev, "Failed to exit sleep mode (%d)\n", ret);
> +		goto fail;
> +	}
> +
> +	usleep_range(5000, 10000);
> +
> +	ret = mipi_dsi_dcs_set_display_on(dsi);
> +	if (ret < 0) {
> +		DRM_DEV_ERROR(dev, "Failed to set display ON (%d)\n", ret);
> +		goto fail;
> +	}
> +
> +	backlight_enable(rad->backlight);
> +
> +	rad->enabled = true;
> +
> +	return 0;
> +
> +fail:
> +	if (rad->reset)
> +		gpiod_set_value(rad->reset, 0);
> +
> +	return ret;
> +}
> +
> +static int rad_panel_disable(struct drm_panel *panel)
> +{
> +	struct rad_panel *rad = to_rad_panel(panel);
> +	struct mipi_dsi_device *dsi = rad->dsi;
> +	struct device *dev = &dsi->dev;
> +	int ret;
> +
> +	if (!rad->enabled)
> +		return 0;
> +
> +	dsi->mode_flags |= MIPI_DSI_MODE_LPM;
> +
> +	backlight_disable(rad->backlight);
> +
> +	usleep_range(10000, 15000);
> +
> +	ret = mipi_dsi_dcs_set_display_off(dsi);
> +	if (ret < 0) {
> +		DRM_DEV_ERROR(dev, "Failed to set display OFF (%d)\n", ret);
> +		return ret;
> +	}
> +
> +	usleep_range(5000, 10000);
> +
> +	ret = mipi_dsi_dcs_enter_sleep_mode(dsi);
> +	if (ret < 0) {
> +		DRM_DEV_ERROR(dev, "Failed to enter sleep mode (%d)\n", ret);
> +		return ret;
> +	}
> +
> +	rad->enabled = false;
> +
> +	return 0;
> +}
> +
> +static int rad_panel_get_modes(struct drm_panel *panel)
> +{
> +	struct rad_panel *rad = to_rad_panel(panel);
> +	struct device *dev = &rad->dsi->dev;
> +	struct drm_connector *connector = panel->connector;
> +	struct drm_display_mode *mode;
> +	u32 *bus_flags = &connector->display_info.bus_flags;
> +	int ret;
> +
> +	mode = drm_mode_create(connector->dev);
> +	if (!mode) {
> +		DRM_DEV_ERROR(dev, "Failed to create display mode!\n");
> +		return 0;
> +	}
> +
> +	drm_display_mode_from_videomode(&rad->vm, mode);
> +	mode->width_mm = rad->width_mm;
> +	mode->height_mm = rad->height_mm;
> +	connector->display_info.width_mm = rad->width_mm;
> +	connector->display_info.height_mm = rad->height_mm;
> +	mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
> +
> +	if (rad->vm.flags & DISPLAY_FLAGS_DE_HIGH)
> +		*bus_flags |= DRM_BUS_FLAG_DE_HIGH;
> +	if (rad->vm.flags & DISPLAY_FLAGS_DE_LOW)
> +		*bus_flags |= DRM_BUS_FLAG_DE_LOW;
> +	if (rad->vm.flags & DISPLAY_FLAGS_PIXDATA_NEGEDGE)
> +		*bus_flags |= DRM_BUS_FLAG_PIXDATA_NEGEDGE;
> +	if (rad->vm.flags & DISPLAY_FLAGS_PIXDATA_POSEDGE)
> +		*bus_flags |= DRM_BUS_FLAG_PIXDATA_POSEDGE;
> +
> +	ret = drm_display_info_set_bus_formats(&connector->display_info,
> +					       rad_bus_formats,
> +					       ARRAY_SIZE(rad_bus_formats));
> +	if (ret)
> +		return ret;
> +
> +	drm_mode_probed_add(panel->connector, mode);
> +
> +	return 1;
> +}
> +
> +static int rad_bl_get_brightness(struct backlight_device *bl)
> +{
> +	struct mipi_dsi_device *dsi = bl_get_data(bl);
> +	struct rad_panel *rad = mipi_dsi_get_drvdata(dsi);
> +	struct device *dev = &dsi->dev;
> +	u16 brightness;
> +	int ret;
> +
> +	if (!rad->prepared)
> +		return 0;
> +
> +	DRM_DEV_DEBUG_DRIVER(dev, "\n");
> +
> +	dsi->mode_flags &= ~MIPI_DSI_MODE_LPM;
> +
> +	ret = mipi_dsi_dcs_get_display_brightness(dsi, &brightness);
> +	if (ret < 0)
> +		return ret;
> +
> +	bl->props.brightness = brightness;
> +
> +	return brightness & 0xff;
> +}
> +
> +static int rad_bl_update_status(struct backlight_device *bl)
> +{
> +	struct mipi_dsi_device *dsi = bl_get_data(bl);
> +	struct rad_panel *rad = mipi_dsi_get_drvdata(dsi);
> +	struct device *dev = &dsi->dev;
> +	int ret = 0;
> +
> +	if (!rad->prepared)
> +		return 0;
> +
> +	DRM_DEV_DEBUG_DRIVER(dev, "New brightness: %d\n", bl->props.brightness);
> +
> +	dsi->mode_flags &= ~MIPI_DSI_MODE_LPM;
> +
> +	ret = mipi_dsi_dcs_set_display_brightness(dsi, bl->props.brightness);
> +	if (ret < 0)
> +		return ret;
> +
> +	return 0;
> +}
> +
> +static const struct backlight_ops rad_bl_ops = {
> +	.update_status = rad_bl_update_status,
> +	.get_brightness = rad_bl_get_brightness,
> +};
> +
> +static const struct drm_panel_funcs rad_panel_funcs = {
> +	.prepare = rad_panel_prepare,
> +	.unprepare = rad_panel_unprepare,
> +	.enable = rad_panel_enable,
> +	.disable = rad_panel_disable,
> +	.get_modes = rad_panel_get_modes,
> +};
> +
> +/*
> + * The clock might range from 66MHz (30Hz refresh rate)
> + * to 132MHz (60Hz refresh rate)
> + */
> +static const struct display_timing rad_default_timing = {
> +	.pixelclock = { 66000000, 132000000, 132000000 },
> +	.hactive = { 1080, 1080, 1080 },
> +	.hfront_porch = { 20, 20, 20 },
> +	.hsync_len = { 2, 2, 2 },
> +	.hback_porch = { 34, 34, 34 },
> +	.vactive = { 1920, 1920, 1920 },
> +	.vfront_porch = { 10, 10, 10 },
> +	.vsync_len = { 2, 2, 2 },
> +	.vback_porch = { 4, 4, 4 },
> +	.flags = DISPLAY_FLAGS_HSYNC_LOW |
> +		 DISPLAY_FLAGS_VSYNC_LOW |
> +		 DISPLAY_FLAGS_DE_LOW |
> +		 DISPLAY_FLAGS_PIXDATA_NEGEDGE,
> +};
> +
> +static int rad_panel_probe(struct mipi_dsi_device *dsi)
> +{
> +	struct device *dev = &dsi->dev;
> +	struct device_node *np = dev->of_node;
> +	struct device_node *timings;
> +	struct rad_panel *panel;
> +	struct backlight_properties bl_props;
> +	int ret;
> +	u32 video_mode;
> +
> +	panel = devm_kzalloc(&dsi->dev, sizeof(*panel), GFP_KERNEL);
> +	if (!panel)
> +		return -ENOMEM;
> +
> +	mipi_dsi_set_drvdata(dsi, panel);
> +
> +	panel->dsi = dsi;
> +
> +	dsi->format = MIPI_DSI_FMT_RGB888;
> +	dsi->mode_flags =  MIPI_DSI_MODE_VIDEO_HSE | MIPI_DSI_MODE_VIDEO |
> +			   MIPI_DSI_CLOCK_NON_CONTINUOUS;
> +
> +	ret = of_property_read_u32(np, "video-mode", &video_mode);
> +	if (!ret) {
> +		switch (video_mode) {
> +		case 0:
> +			/* burst mode */
> +			dsi->mode_flags |= MIPI_DSI_MODE_VIDEO_BURST;
> +			break;
> +		case 1:
> +			/* non-burst mode with sync event */
> +			break;
> +		case 2:
> +			/* non-burst mode with sync pulse */
> +			dsi->mode_flags |= MIPI_DSI_MODE_VIDEO_SYNC_PULSE;
> +			break;
> +		default:
> +			dev_warn(dev, "invalid video mode %d\n", video_mode);
> +			break;
> +		}
> +	}
> +
> +	ret = of_property_read_u32(np, "dsi-lanes", &dsi->lanes);
> +	if (ret < 0) {
> +		dev_err(dev, "Failed to get dsi-lanes property (%d)\n", ret);
> +		return ret;
> +	}
> +
> +	/*
> +	 * 'display-timings' is optional, so verify if the node is present
> +	 * before calling of_get_videomode so we won't get console error
> +	 * messages
> +	 */
> +	timings = of_get_child_by_name(np, "display-timings");
> +	if (timings) {
> +		of_node_put(timings);
> +		ret = of_get_videomode(np, &panel->vm, 0);
> +	} else {
> +		videomode_from_timing(&rad_default_timing, &panel->vm);
> +	}
> +	if (ret < 0)
> +		return ret;
> +
> +	of_property_read_u32(np, "width-mm", &panel->width_mm);
> +	of_property_read_u32(np, "height-mm", &panel->height_mm);
> +
> +	panel->reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
> +
> +	if (IS_ERR(panel->reset))
> +		panel->reset = NULL;
> +	else
> +		gpiod_set_value(panel->reset, 0);
> +
> +	memset(&bl_props, 0, sizeof(bl_props));
> +	bl_props.type = BACKLIGHT_RAW;
> +	bl_props.brightness = 255;
> +	bl_props.max_brightness = 255;
> +
> +	panel->backlight = devm_backlight_device_register(dev, dev_name(dev),
> +							  dev, dsi,
> +							  &rad_bl_ops,
> +							  &bl_props);
> +	if (IS_ERR(panel->backlight)) {
> +		ret = PTR_ERR(panel->backlight);
> +		dev_err(dev, "Failed to register backlight (%d)\n", ret);
> +		return ret;
> +	}
> +
> +	drm_panel_init(&panel->base);
> +	panel->base.funcs = &rad_panel_funcs;
> +	panel->base.dev = dev;
> +	dev_set_drvdata(dev, panel);
> +
> +	ret = drm_panel_add(&panel->base);
> +
> +	if (ret < 0)
> +		return ret;
> +
> +	ret = mipi_dsi_attach(dsi);
> +	if (ret < 0)
> +		drm_panel_remove(&panel->base);
> +
> +	return ret;
> +}
> +
> +static int rad_panel_remove(struct mipi_dsi_device *dsi)
> +{
> +	struct rad_panel *rad = mipi_dsi_get_drvdata(dsi);
> +	struct device *dev = &dsi->dev;
> +	int ret;
> +
> +	ret = mipi_dsi_detach(dsi);
> +	if (ret < 0)
> +		DRM_DEV_ERROR(dev, "Failed to detach from host (%d)\n",
> +			      ret);
> +
> +	drm_panel_remove(&rad->base);
> +
> +	return 0;
> +}
> +
> +static void rad_panel_shutdown(struct mipi_dsi_device *dsi)
> +{
> +	struct rad_panel *rad = mipi_dsi_get_drvdata(dsi);
> +
> +	rad_panel_disable(&rad->base);
> +	rad_panel_unprepare(&rad->base);
> +}
> +
> +#ifdef CONFIG_PM
> +static int rad_panel_suspend(struct device *dev)
> +{
> +	struct rad_panel *rad = dev_get_drvdata(dev);
> +
> +	if (!rad->reset)
> +		return 0;
> +
> +	devm_gpiod_put(dev, rad->reset);
> +	rad->reset = NULL;
> +
> +	return 0;
> +}
> +
> +static int rad_panel_resume(struct device *dev)
> +{
> +	struct rad_panel *rad = dev_get_drvdata(dev);
> +
> +	if (rad->reset)
> +		return 0;
> +
> +	rad->reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
> +	if (IS_ERR(rad->reset))
> +		rad->reset = NULL;
> +
> +	return PTR_ERR_OR_ZERO(rad->reset);
> +}
> +
> +#endif
No other panels have suspend/resume.
Is it relevant?


> +
> +static const struct dev_pm_ops rad_pm_ops = {
> +	SET_RUNTIME_PM_OPS(rad_panel_suspend, rad_panel_resume, NULL)
> +	SET_SYSTEM_SLEEP_PM_OPS(rad_panel_suspend, rad_panel_resume)
> +};
> +
> +static const struct of_device_id rad_of_match[] = {
> +	{ .compatible = "raydium,rm67191", },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, rad_of_match);
> +
> +static struct mipi_dsi_driver rad_panel_driver = {
> +	.driver = {
> +		.name = "panel-raydium-rm67191",
> +		.of_match_table = rad_of_match,
> +		.pm	= &rad_pm_ops,
> +	},
> +	.probe = rad_panel_probe,
> +	.remove = rad_panel_remove,
> +	.shutdown = rad_panel_shutdown,
> +};
> +module_mipi_dsi_driver(rad_panel_driver);
> +
> +MODULE_AUTHOR("Robert Chiras <robert.chiras@nxp.com>");
> +MODULE_DESCRIPTION("DRM Driver for Raydium RM67191 MIPI DSI panel");
> +MODULE_LICENSE("GPL v2");


	Sam

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH 2/2] drm/panel: Add support for Raydium RM67191 panel
 driver
Date: Fri, 14 Jun 2019 17:10:18 +0200
Message-ID: <20190614151018.GA28829@ravnborg.org>
References: <1560513063-24995-1-git-send-email-robert.chiras@nxp.com>
 <1560513063-24995-3-git-send-email-robert.chiras@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <1560513063-24995-3-git-send-email-robert.chiras@nxp.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Robert Chiras <robert.chiras@nxp.com>
Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, linux-imx@nxp.com
List-Id: devicetree@vger.kernel.org

SGkgUm9iZXJ0LgoKT24gdG9wIG9mIHRoZSBmZWVkYmFjayBmcm9tIEZhYmlvIGhlcmUgaXMgYSBi
aXQgbW9yZS4KCj4gKwo+ICsjaW5jbHVkZSA8ZHJtL2RybVAuaD4KPiArI2luY2x1ZGUgPGRybS9k
cm1fY3J0Yy5oPgo+ICsjaW5jbHVkZSA8ZHJtL2RybV9taXBpX2RzaS5oPgo+ICsjaW5jbHVkZSA8
ZHJtL2RybV9wYW5lbC5oPgo+ICsjaW5jbHVkZSA8bGludXgvZ3Bpby9jb25zdW1lci5oPgo+ICsj
aW5jbHVkZSA8bGludXgvbW9kdWxlLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9vZi5oPgo+ICsjaW5j
bHVkZSA8bGludXgvcmVndWxhdG9yL2NvbnN1bWVyLmg+Cj4gKyNpbmNsdWRlIDx2aWRlby9taXBp
X2Rpc3BsYXkuaD4KPiArI2luY2x1ZGUgPHZpZGVvL29mX3ZpZGVvbW9kZS5oPgo+ICsjaW5jbHVk
ZSA8dmlkZW8vdmlkZW9tb2RlLmg+CgpEaXZpZGUgaW5jbHVkZSB1cCBpbiBibG9jayBpbiBmb2xs
b3dpbmcgb3JkZXI6CgojaW5jbHVkZSA8bGludXgvKj4KCiNpbmNsdWRlIDx2aWRlby8qPgoKI2lu
Y3VkZSA8ZHJtLyo+CgpXaXRoaW4gZWFjaCBibG9jayBzb3J0IGFscGhhYmV0aWNhbGx5LgpEbyBu
b3QgdXNlIHRoZSBkZXByZWNhdGVkIGRybVAuaCAtIHJlcGxhY2UgaXQgd2l0aCB0aGUgbmVjZXNz
YXJ5CmluY2x1ZGVzLgpVc2UgYW4gZW1wdHkgbGluZSBiZXR3ZWVuIGVhY2ggaW5jbHVkZSBibG9j
ay4KCj4gKwo+ICsvKiBXcml0ZSBNYW51ZmFjdHVyZSBDb21tYW5kIFNldCBDb250cm9sICovCj4g
KyNkZWZpbmUgV1JNQVVDQ1RSIDB4RkUKPiArCj4gKy8qIE1hbnVmYWN0dXJlciBDb21tYW5kIFNl
dCBwYWdlcyAoQ01EMikgKi8KPiArc3RydWN0IGNtZF9zZXRfZW50cnkgewo+ICsJdTggY21kOwo+
ICsJdTggcGFyYW07Cj4gK307Cj4gKwo+ICsvKgo+ICsgKiBUaGVyZSBpcyBubyBkZXNjcmlwdGlv
biBpbiB0aGUgUmVmZXJlbmNlIE1hbnVhbCBhYm91dCB0aGVzZSBjb21tYW5kcy4KPiArICogV2Ug
cmVjZWl2ZWQgdGhlbSBmcm9tIHZlbmRvciwgc28ganVzdCB1c2UgdGhlbSBhcyBpcy4KPiArICov
Cj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgY21kX3NldF9lbnRyeSBtYW51ZmFjdHVyZXJfY21kX3Nl
dFtdID0gewo+ICsJezB4RkUsIDB4MEJ9LAo+ICsJezB4MjgsIDB4NDB9LAo+ICsJezB4MjksIDB4
NEZ9LAouLi4KPiArCXsweDUxLCAweDA0fSwKPiArfTsKPiArCj4gK3N0YXRpYyBjb25zdCB1MzIg
cmFkX2J1c19mb3JtYXRzW10gPSB7Cj4gKwlNRURJQV9CVVNfRk1UX1JHQjg4OF8xWDI0LAo+ICsJ
TUVESUFfQlVTX0ZNVF9SR0I2NjZfMVgxOCwKPiArCU1FRElBX0JVU19GTVRfUkdCNTY1XzFYMTYs
Cj4gK307Cj4gKwo+ICtzdHJ1Y3QgcmFkX3BhbmVsIHsKPiArCXN0cnVjdCBkcm1fcGFuZWwgYmFz
ZTsKSW4gdGhlIG90aGVyIHJheWRpdW0gZHJpdmVyIHdlIG5hbWUgdGhpcyAicGFuZWwiLCB3aGlj
aCBpcyBhIG1vcmUKZGVzY3JpcHRpdmUgbmFtZS4KCj4gKwlzdHJ1Y3QgbWlwaV9kc2lfZGV2aWNl
ICpkc2k7Cj4gKwo+ICsJc3RydWN0IGdwaW9fZGVzYyAqcmVzZXQ7Cj4gKwlzdHJ1Y3QgYmFja2xp
Z2h0X2RldmljZSAqYmFja2xpZ2h0Owo+ICsKPiArCWJvb2wgcHJlcGFyZWQ7Cj4gKwlib29sIGVu
YWJsZWQ7Cj4gKwo+ICsJc3RydWN0IHZpZGVvbW9kZSB2bTsKPiArCXUzMiB3aWR0aF9tbTsKPiAr
CXUzMiBoZWlnaHRfbW07Cj4gK307Cj4gKwo+ICtzdGF0aWMgaW50IHJhZF9wYW5lbF9wcmVwYXJl
KHN0cnVjdCBkcm1fcGFuZWwgKnBhbmVsKQo+ICt7Cj4gKwlzdHJ1Y3QgcmFkX3BhbmVsICpyYWQg
PSB0b19yYWRfcGFuZWwocGFuZWwpOwo+ICsKPiArCWlmIChyYWQtPnByZXBhcmVkKQo+ICsJCXJl
dHVybiAwOwo+ICsKPiArCWlmIChyYWQtPnJlc2V0KSB7Cj4gKwkJZ3Bpb2Rfc2V0X3ZhbHVlKHJh
ZC0+cmVzZXQsIDApOwo+ICsJCXVzbGVlcF9yYW5nZSg1MDAwLCAxMDAwMCk7Cj4gKwkJZ3Bpb2Rf
c2V0X3ZhbHVlKHJhZC0+cmVzZXQsIDEpOwo+ICsJCXVzbGVlcF9yYW5nZSgyMDAwMCwgMjUwMDAp
Owo+ICsJfQo+ICsKPiArCXJhZC0+cHJlcGFyZWQgPSB0cnVlOwo+ICsKPiArCXJldHVybiAwOwo+
ICt9Cj4gKwo+ICtzdGF0aWMgaW50IHJhZF9wYW5lbF91bnByZXBhcmUoc3RydWN0IGRybV9wYW5l
bCAqcGFuZWwpCj4gK3sKPiArCXN0cnVjdCByYWRfcGFuZWwgKnJhZCA9IHRvX3JhZF9wYW5lbChw
YW5lbCk7Cj4gKwlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAmcmFkLT5kc2ktPmRldjsKPiArCj4gKwlp
ZiAoIXJhZC0+cHJlcGFyZWQpCj4gKwkJcmV0dXJuIDA7Cj4gKwo+ICsJaWYgKHJhZC0+ZW5hYmxl
ZCkgewo+ICsJCURSTV9ERVZfRVJST1IoZGV2LCAiUGFuZWwgc3RpbGwgZW5hYmxlZCFcbiIpOwo+
ICsJCXJldHVybiAtRVBFUk07Cj4gKwl9ClRoaXMgc2VlbXMgbGlrZSBvdmVya2lsbCwgd2hhdCBz
aG91bGQgdHJpZ2dlciB0aGlzPwoKPiArCj4gKwlpZiAocmFkLT5yZXNldCkgewo+ICsJCWdwaW9k
X3NldF92YWx1ZShyYWQtPnJlc2V0LCAwKTsKPiArCQl1c2xlZXBfcmFuZ2UoMTUwMDAsIDE3MDAw
KTsKPiArCQlncGlvZF9zZXRfdmFsdWUocmFkLT5yZXNldCwgMSk7Cj4gKwl9Cj4gKwo+ICsJcmFk
LT5wcmVwYXJlZCA9IGZhbHNlOwo+ICsKPiArCXJldHVybiAwOwo+ICt9Cj4gKwo+ICtzdGF0aWMg
aW50IHJhZF9wYW5lbF9lbmFibGUoc3RydWN0IGRybV9wYW5lbCAqcGFuZWwpCj4gK3sKPiArCXN0
cnVjdCByYWRfcGFuZWwgKnJhZCA9IHRvX3JhZF9wYW5lbChwYW5lbCk7Cj4gKwlzdHJ1Y3QgbWlw
aV9kc2lfZGV2aWNlICpkc2kgPSByYWQtPmRzaTsKPiArCXN0cnVjdCBkZXZpY2UgKmRldiA9ICZk
c2ktPmRldjsKPiArCWludCBjb2xvcl9mb3JtYXQgPSBjb2xvcl9mb3JtYXRfZnJvbV9kc2lfZm9y
bWF0KGRzaS0+Zm9ybWF0KTsKPiArCXUxNiBicmlnaHRuZXNzOwo+ICsJaW50IHJldDsKPiArCj4g
KwlpZiAocmFkLT5lbmFibGVkKQo+ICsJCXJldHVybiAwOwo+ICsKPiArCWlmICghcmFkLT5wcmVw
YXJlZCkgewo+ICsJCURSTV9ERVZfRVJST1IoZGV2LCAiUGFuZWwgbm90IHByZXBhcmVkIVxuIik7
Cj4gKwkJcmV0dXJuIC1FUEVSTTsKPiArCX0KU2VlbXMgbGlrZSBvdmVya2lsbC4KCj4gKwo+ICsJ
ZHNpLT5tb2RlX2ZsYWdzIHw9IE1JUElfRFNJX01PREVfTFBNOwo+ICsKPiArCXJldCA9IHJhZF9w
YW5lbF9wdXNoX2NtZF9saXN0KGRzaSk7Cj4gKwlpZiAocmV0IDwgMCkgewo+ICsJCURSTV9ERVZf
RVJST1IoZGV2LCAiRmFpbGVkIHRvIHNlbmQgTUNTICglZClcbiIsIHJldCk7Cj4gKwkJZ290byBm
YWlsOwo+ICsJfQo+ICsKPiArCS8qIFNlbGVjdCBVc2VyIENvbW1hbmQgU2V0IHRhYmxlIChDTUQx
KSAqLwo+ICsJcmV0ID0gbWlwaV9kc2lfZ2VuZXJpY193cml0ZShkc2ksICh1OFtdKXsgV1JNQVVD
Q1RSLCAweDAwIH0sIDIpOwo+ICsJaWYgKHJldCA8IDApCj4gKwkJZ290byBmYWlsOwo+ICsKPiAr
CS8qIFNvZnR3YXJlIHJlc2V0ICovCj4gKwlyZXQgPSBtaXBpX2RzaV9kY3Nfc29mdF9yZXNldChk
c2kpOwo+ICsJaWYgKHJldCA8IDApIHsKPiArCQlEUk1fREVWX0VSUk9SKGRldiwgIkZhaWxlZCB0
byBkbyBTb2Z0d2FyZSBSZXNldCAoJWQpXG4iLCByZXQpOwo+ICsJCWdvdG8gZmFpbDsKPiArCX0K
PiArCj4gKwl1c2xlZXBfcmFuZ2UoMTUwMDAsIDE3MDAwKTsKPiArCj4gKwkvKiBTZXQgRFNJIG1v
ZGUgKi8KPiArCXJldCA9IG1pcGlfZHNpX2dlbmVyaWNfd3JpdGUoZHNpLCAodThbXSl7IDB4QzIs
IDB4MEIgfSwgMik7Cj4gKwlpZiAocmV0IDwgMCkgewo+ICsJCURSTV9ERVZfRVJST1IoZGV2LCAi
RmFpbGVkIHRvIHNldCBEU0kgbW9kZSAoJWQpXG4iLCByZXQpOwo+ICsJCWdvdG8gZmFpbDsKPiAr
CX0KPiArCS8qIFNldCB0ZWFyIE9OICovCj4gKwlyZXQgPSBtaXBpX2RzaV9kY3Nfc2V0X3RlYXJf
b24oZHNpLCBNSVBJX0RTSV9EQ1NfVEVBUl9NT0RFX1ZCTEFOSyk7Cj4gKwlpZiAocmV0IDwgMCkg
ewo+ICsJCURSTV9ERVZfRVJST1IoZGV2LCAiRmFpbGVkIHRvIHNldCB0ZWFyIE9OICglZClcbiIs
IHJldCk7Cj4gKwkJZ290byBmYWlsOwo+ICsJfQo+ICsJLyogU2V0IHRlYXIgc2NhbmxpbmUgKi8K
PiArCXJldCA9IG1pcGlfZHNpX2Rjc19zZXRfdGVhcl9zY2FubGluZShkc2ksIDB4MzgwKTsKPiAr
CWlmIChyZXQgPCAwKSB7Cj4gKwkJRFJNX0RFVl9FUlJPUihkZXYsICJGYWlsZWQgdG8gc2V0IHRl
YXIgc2NhbmxpbmUgKCVkKVxuIiwgcmV0KTsKPiArCQlnb3RvIGZhaWw7Cj4gKwl9Cj4gKwkvKiBT
ZXQgcGl4ZWwgZm9ybWF0ICovCj4gKwlyZXQgPSBtaXBpX2RzaV9kY3Nfc2V0X3BpeGVsX2Zvcm1h
dChkc2ksIGNvbG9yX2Zvcm1hdCk7Cj4gKwlEUk1fREVWX0RFQlVHX0RSSVZFUihkZXYsICJJbnRl
cmZhY2UgY29sb3IgZm9ybWF0IHNldCB0byAweCV4XG4iLAo+ICsJCQkgICAgIGNvbG9yX2Zvcm1h
dCk7Cj4gKwlpZiAocmV0IDwgMCkgewo+ICsJCURSTV9ERVZfRVJST1IoZGV2LCAiRmFpbGVkIHRv
IHNldCBwaXhlbCBmb3JtYXQgKCVkKVxuIiwgcmV0KTsKPiArCQlnb3RvIGZhaWw7Cj4gKwl9Cj4g
KwkvKiBTZXQgZGlzcGxheSBicmlnaHRuZXNzICovCj4gKwlicmlnaHRuZXNzID0gcmFkLT5iYWNr
bGlnaHQtPnByb3BzLmJyaWdodG5lc3M7Cj4gKwlyZXQgPSBtaXBpX2RzaV9kY3Nfc2V0X2Rpc3Bs
YXlfYnJpZ2h0bmVzcyhkc2ksIGJyaWdodG5lc3MpOwo+ICsJaWYgKHJldCA8IDApIHsKPiArCQlE
Uk1fREVWX0VSUk9SKGRldiwgIkZhaWxlZCB0byBzZXQgZGlzcGxheSBicmlnaHRuZXNzICglZClc
biIsCj4gKwkJCSAgICAgIHJldCk7Cj4gKwkJZ290byBmYWlsOwo+ICsJfQpicmlnaHRuZXNzIGlz
IHdyaXR0ZW4gdG8gYWdhaW4gd2hlbiB5b3UgZW5hYmxlIGJhY2tsaWdodCBiZWxvdy4KU2VlbXMg
cmVkdW5kYW50IHRvIGRvIHNvIHR3aWNlLgoKCj4gKwkvKiBFeGl0IHNsZWVwIG1vZGUgKi8KPiAr
CXJldCA9IG1pcGlfZHNpX2Rjc19leGl0X3NsZWVwX21vZGUoZHNpKTsKPiArCWlmIChyZXQgPCAw
KSB7Cj4gKwkJRFJNX0RFVl9FUlJPUihkZXYsICJGYWlsZWQgdG8gZXhpdCBzbGVlcCBtb2RlICgl
ZClcbiIsIHJldCk7Cj4gKwkJZ290byBmYWlsOwo+ICsJfQo+ICsKPiArCXVzbGVlcF9yYW5nZSg1
MDAwLCAxMDAwMCk7Cj4gKwo+ICsJcmV0ID0gbWlwaV9kc2lfZGNzX3NldF9kaXNwbGF5X29uKGRz
aSk7Cj4gKwlpZiAocmV0IDwgMCkgewo+ICsJCURSTV9ERVZfRVJST1IoZGV2LCAiRmFpbGVkIHRv
IHNldCBkaXNwbGF5IE9OICglZClcbiIsIHJldCk7Cj4gKwkJZ290byBmYWlsOwo+ICsJfQo+ICsK
PiArCWJhY2tsaWdodF9lbmFibGUocmFkLT5iYWNrbGlnaHQpOwo+ICsKPiArCXJhZC0+ZW5hYmxl
ZCA9IHRydWU7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gKwo+ICtmYWlsOgo+ICsJaWYgKHJhZC0+cmVz
ZXQpCj4gKwkJZ3Bpb2Rfc2V0X3ZhbHVlKHJhZC0+cmVzZXQsIDApOwo+ICsKPiArCXJldHVybiBy
ZXQ7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgcmFkX3BhbmVsX2Rpc2FibGUoc3RydWN0IGRybV9w
YW5lbCAqcGFuZWwpCj4gK3sKPiArCXN0cnVjdCByYWRfcGFuZWwgKnJhZCA9IHRvX3JhZF9wYW5l
bChwYW5lbCk7Cj4gKwlzdHJ1Y3QgbWlwaV9kc2lfZGV2aWNlICpkc2kgPSByYWQtPmRzaTsKPiAr
CXN0cnVjdCBkZXZpY2UgKmRldiA9ICZkc2ktPmRldjsKPiArCWludCByZXQ7Cj4gKwo+ICsJaWYg
KCFyYWQtPmVuYWJsZWQpCj4gKwkJcmV0dXJuIDA7Cj4gKwo+ICsJZHNpLT5tb2RlX2ZsYWdzIHw9
IE1JUElfRFNJX01PREVfTFBNOwo+ICsKPiArCWJhY2tsaWdodF9kaXNhYmxlKHJhZC0+YmFja2xp
Z2h0KTsKPiArCj4gKwl1c2xlZXBfcmFuZ2UoMTAwMDAsIDE1MDAwKTsKPiArCj4gKwlyZXQgPSBt
aXBpX2RzaV9kY3Nfc2V0X2Rpc3BsYXlfb2ZmKGRzaSk7Cj4gKwlpZiAocmV0IDwgMCkgewo+ICsJ
CURSTV9ERVZfRVJST1IoZGV2LCAiRmFpbGVkIHRvIHNldCBkaXNwbGF5IE9GRiAoJWQpXG4iLCBy
ZXQpOwo+ICsJCXJldHVybiByZXQ7Cj4gKwl9Cj4gKwo+ICsJdXNsZWVwX3JhbmdlKDUwMDAsIDEw
MDAwKTsKPiArCj4gKwlyZXQgPSBtaXBpX2RzaV9kY3NfZW50ZXJfc2xlZXBfbW9kZShkc2kpOwo+
ICsJaWYgKHJldCA8IDApIHsKPiArCQlEUk1fREVWX0VSUk9SKGRldiwgIkZhaWxlZCB0byBlbnRl
ciBzbGVlcCBtb2RlICglZClcbiIsIHJldCk7Cj4gKwkJcmV0dXJuIHJldDsKPiArCX0KPiArCj4g
KwlyYWQtPmVuYWJsZWQgPSBmYWxzZTsKPiArCj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiArc3Rh
dGljIGludCByYWRfcGFuZWxfZ2V0X21vZGVzKHN0cnVjdCBkcm1fcGFuZWwgKnBhbmVsKQo+ICt7
Cj4gKwlzdHJ1Y3QgcmFkX3BhbmVsICpyYWQgPSB0b19yYWRfcGFuZWwocGFuZWwpOwo+ICsJc3Ry
dWN0IGRldmljZSAqZGV2ID0gJnJhZC0+ZHNpLT5kZXY7Cj4gKwlzdHJ1Y3QgZHJtX2Nvbm5lY3Rv
ciAqY29ubmVjdG9yID0gcGFuZWwtPmNvbm5lY3RvcjsKPiArCXN0cnVjdCBkcm1fZGlzcGxheV9t
b2RlICptb2RlOwo+ICsJdTMyICpidXNfZmxhZ3MgPSAmY29ubmVjdG9yLT5kaXNwbGF5X2luZm8u
YnVzX2ZsYWdzOwo+ICsJaW50IHJldDsKPiArCj4gKwltb2RlID0gZHJtX21vZGVfY3JlYXRlKGNv
bm5lY3Rvci0+ZGV2KTsKPiArCWlmICghbW9kZSkgewo+ICsJCURSTV9ERVZfRVJST1IoZGV2LCAi
RmFpbGVkIHRvIGNyZWF0ZSBkaXNwbGF5IG1vZGUhXG4iKTsKPiArCQlyZXR1cm4gMDsKPiArCX0K
PiArCj4gKwlkcm1fZGlzcGxheV9tb2RlX2Zyb21fdmlkZW9tb2RlKCZyYWQtPnZtLCBtb2RlKTsK
PiArCW1vZGUtPndpZHRoX21tID0gcmFkLT53aWR0aF9tbTsKPiArCW1vZGUtPmhlaWdodF9tbSA9
IHJhZC0+aGVpZ2h0X21tOwo+ICsJY29ubmVjdG9yLT5kaXNwbGF5X2luZm8ud2lkdGhfbW0gPSBy
YWQtPndpZHRoX21tOwo+ICsJY29ubmVjdG9yLT5kaXNwbGF5X2luZm8uaGVpZ2h0X21tID0gcmFk
LT5oZWlnaHRfbW07Cj4gKwltb2RlLT50eXBlID0gRFJNX01PREVfVFlQRV9EUklWRVIgfCBEUk1f
TU9ERV9UWVBFX1BSRUZFUlJFRDsKPiArCj4gKwlpZiAocmFkLT52bS5mbGFncyAmIERJU1BMQVlf
RkxBR1NfREVfSElHSCkKPiArCQkqYnVzX2ZsYWdzIHw9IERSTV9CVVNfRkxBR19ERV9ISUdIOwo+
ICsJaWYgKHJhZC0+dm0uZmxhZ3MgJiBESVNQTEFZX0ZMQUdTX0RFX0xPVykKPiArCQkqYnVzX2Zs
YWdzIHw9IERSTV9CVVNfRkxBR19ERV9MT1c7Cj4gKwlpZiAocmFkLT52bS5mbGFncyAmIERJU1BM
QVlfRkxBR1NfUElYREFUQV9ORUdFREdFKQo+ICsJCSpidXNfZmxhZ3MgfD0gRFJNX0JVU19GTEFH
X1BJWERBVEFfTkVHRURHRTsKPiArCWlmIChyYWQtPnZtLmZsYWdzICYgRElTUExBWV9GTEFHU19Q
SVhEQVRBX1BPU0VER0UpCj4gKwkJKmJ1c19mbGFncyB8PSBEUk1fQlVTX0ZMQUdfUElYREFUQV9Q
T1NFREdFOwo+ICsKPiArCXJldCA9IGRybV9kaXNwbGF5X2luZm9fc2V0X2J1c19mb3JtYXRzKCZj
b25uZWN0b3ItPmRpc3BsYXlfaW5mbywKPiArCQkJCQkgICAgICAgcmFkX2J1c19mb3JtYXRzLAo+
ICsJCQkJCSAgICAgICBBUlJBWV9TSVpFKHJhZF9idXNfZm9ybWF0cykpOwo+ICsJaWYgKHJldCkK
PiArCQlyZXR1cm4gcmV0Owo+ICsKPiArCWRybV9tb2RlX3Byb2JlZF9hZGQocGFuZWwtPmNvbm5l
Y3RvciwgbW9kZSk7Cj4gKwo+ICsJcmV0dXJuIDE7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgcmFk
X2JsX2dldF9icmlnaHRuZXNzKHN0cnVjdCBiYWNrbGlnaHRfZGV2aWNlICpibCkKPiArewo+ICsJ
c3RydWN0IG1pcGlfZHNpX2RldmljZSAqZHNpID0gYmxfZ2V0X2RhdGEoYmwpOwo+ICsJc3RydWN0
IHJhZF9wYW5lbCAqcmFkID0gbWlwaV9kc2lfZ2V0X2RydmRhdGEoZHNpKTsKPiArCXN0cnVjdCBk
ZXZpY2UgKmRldiA9ICZkc2ktPmRldjsKPiArCXUxNiBicmlnaHRuZXNzOwo+ICsJaW50IHJldDsK
PiArCj4gKwlpZiAoIXJhZC0+cHJlcGFyZWQpCj4gKwkJcmV0dXJuIDA7Cj4gKwo+ICsJRFJNX0RF
Vl9ERUJVR19EUklWRVIoZGV2LCAiXG4iKTsKPiArCj4gKwlkc2ktPm1vZGVfZmxhZ3MgJj0gfk1J
UElfRFNJX01PREVfTFBNOwo+ICsKPiArCXJldCA9IG1pcGlfZHNpX2Rjc19nZXRfZGlzcGxheV9i
cmlnaHRuZXNzKGRzaSwgJmJyaWdodG5lc3MpOwo+ICsJaWYgKHJldCA8IDApCj4gKwkJcmV0dXJu
IHJldDsKPiArCj4gKwlibC0+cHJvcHMuYnJpZ2h0bmVzcyA9IGJyaWdodG5lc3M7Cj4gKwo+ICsJ
cmV0dXJuIGJyaWdodG5lc3MgJiAweGZmOwo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50IHJhZF9ibF91
cGRhdGVfc3RhdHVzKHN0cnVjdCBiYWNrbGlnaHRfZGV2aWNlICpibCkKPiArewo+ICsJc3RydWN0
IG1pcGlfZHNpX2RldmljZSAqZHNpID0gYmxfZ2V0X2RhdGEoYmwpOwo+ICsJc3RydWN0IHJhZF9w
YW5lbCAqcmFkID0gbWlwaV9kc2lfZ2V0X2RydmRhdGEoZHNpKTsKPiArCXN0cnVjdCBkZXZpY2Ug
KmRldiA9ICZkc2ktPmRldjsKPiArCWludCByZXQgPSAwOwo+ICsKPiArCWlmICghcmFkLT5wcmVw
YXJlZCkKPiArCQlyZXR1cm4gMDsKPiArCj4gKwlEUk1fREVWX0RFQlVHX0RSSVZFUihkZXYsICJO
ZXcgYnJpZ2h0bmVzczogJWRcbiIsIGJsLT5wcm9wcy5icmlnaHRuZXNzKTsKPiArCj4gKwlkc2kt
Pm1vZGVfZmxhZ3MgJj0gfk1JUElfRFNJX01PREVfTFBNOwo+ICsKPiArCXJldCA9IG1pcGlfZHNp
X2Rjc19zZXRfZGlzcGxheV9icmlnaHRuZXNzKGRzaSwgYmwtPnByb3BzLmJyaWdodG5lc3MpOwo+
ICsJaWYgKHJldCA8IDApCj4gKwkJcmV0dXJuIHJldDsKPiArCj4gKwlyZXR1cm4gMDsKPiArfQo+
ICsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBiYWNrbGlnaHRfb3BzIHJhZF9ibF9vcHMgPSB7Cj4g
KwkudXBkYXRlX3N0YXR1cyA9IHJhZF9ibF91cGRhdGVfc3RhdHVzLAo+ICsJLmdldF9icmlnaHRu
ZXNzID0gcmFkX2JsX2dldF9icmlnaHRuZXNzLAo+ICt9Owo+ICsKPiArc3RhdGljIGNvbnN0IHN0
cnVjdCBkcm1fcGFuZWxfZnVuY3MgcmFkX3BhbmVsX2Z1bmNzID0gewo+ICsJLnByZXBhcmUgPSBy
YWRfcGFuZWxfcHJlcGFyZSwKPiArCS51bnByZXBhcmUgPSByYWRfcGFuZWxfdW5wcmVwYXJlLAo+
ICsJLmVuYWJsZSA9IHJhZF9wYW5lbF9lbmFibGUsCj4gKwkuZGlzYWJsZSA9IHJhZF9wYW5lbF9k
aXNhYmxlLAo+ICsJLmdldF9tb2RlcyA9IHJhZF9wYW5lbF9nZXRfbW9kZXMsCj4gK307Cj4gKwo+
ICsvKgo+ICsgKiBUaGUgY2xvY2sgbWlnaHQgcmFuZ2UgZnJvbSA2Nk1IeiAoMzBIeiByZWZyZXNo
IHJhdGUpCj4gKyAqIHRvIDEzMk1IeiAoNjBIeiByZWZyZXNoIHJhdGUpCj4gKyAqLwo+ICtzdGF0
aWMgY29uc3Qgc3RydWN0IGRpc3BsYXlfdGltaW5nIHJhZF9kZWZhdWx0X3RpbWluZyA9IHsKPiAr
CS5waXhlbGNsb2NrID0geyA2NjAwMDAwMCwgMTMyMDAwMDAwLCAxMzIwMDAwMDAgfSwKPiArCS5o
YWN0aXZlID0geyAxMDgwLCAxMDgwLCAxMDgwIH0sCj4gKwkuaGZyb250X3BvcmNoID0geyAyMCwg
MjAsIDIwIH0sCj4gKwkuaHN5bmNfbGVuID0geyAyLCAyLCAyIH0sCj4gKwkuaGJhY2tfcG9yY2gg
PSB7IDM0LCAzNCwgMzQgfSwKPiArCS52YWN0aXZlID0geyAxOTIwLCAxOTIwLCAxOTIwIH0sCj4g
KwkudmZyb250X3BvcmNoID0geyAxMCwgMTAsIDEwIH0sCj4gKwkudnN5bmNfbGVuID0geyAyLCAy
LCAyIH0sCj4gKwkudmJhY2tfcG9yY2ggPSB7IDQsIDQsIDQgfSwKPiArCS5mbGFncyA9IERJU1BM
QVlfRkxBR1NfSFNZTkNfTE9XIHwKPiArCQkgRElTUExBWV9GTEFHU19WU1lOQ19MT1cgfAo+ICsJ
CSBESVNQTEFZX0ZMQUdTX0RFX0xPVyB8Cj4gKwkJIERJU1BMQVlfRkxBR1NfUElYREFUQV9ORUdF
REdFLAo+ICt9Owo+ICsKPiArc3RhdGljIGludCByYWRfcGFuZWxfcHJvYmUoc3RydWN0IG1pcGlf
ZHNpX2RldmljZSAqZHNpKQo+ICt7Cj4gKwlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAmZHNpLT5kZXY7
Cj4gKwlzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wID0gZGV2LT5vZl9ub2RlOwo+ICsJc3RydWN0IGRl
dmljZV9ub2RlICp0aW1pbmdzOwo+ICsJc3RydWN0IHJhZF9wYW5lbCAqcGFuZWw7Cj4gKwlzdHJ1
Y3QgYmFja2xpZ2h0X3Byb3BlcnRpZXMgYmxfcHJvcHM7Cj4gKwlpbnQgcmV0Owo+ICsJdTMyIHZp
ZGVvX21vZGU7Cj4gKwo+ICsJcGFuZWwgPSBkZXZtX2t6YWxsb2MoJmRzaS0+ZGV2LCBzaXplb2Yo
KnBhbmVsKSwgR0ZQX0tFUk5FTCk7Cj4gKwlpZiAoIXBhbmVsKQo+ICsJCXJldHVybiAtRU5PTUVN
Owo+ICsKPiArCW1pcGlfZHNpX3NldF9kcnZkYXRhKGRzaSwgcGFuZWwpOwo+ICsKPiArCXBhbmVs
LT5kc2kgPSBkc2k7Cj4gKwo+ICsJZHNpLT5mb3JtYXQgPSBNSVBJX0RTSV9GTVRfUkdCODg4Owo+
ICsJZHNpLT5tb2RlX2ZsYWdzID0gIE1JUElfRFNJX01PREVfVklERU9fSFNFIHwgTUlQSV9EU0lf
TU9ERV9WSURFTyB8Cj4gKwkJCSAgIE1JUElfRFNJX0NMT0NLX05PTl9DT05USU5VT1VTOwo+ICsK
PiArCXJldCA9IG9mX3Byb3BlcnR5X3JlYWRfdTMyKG5wLCAidmlkZW8tbW9kZSIsICZ2aWRlb19t
b2RlKTsKPiArCWlmICghcmV0KSB7Cj4gKwkJc3dpdGNoICh2aWRlb19tb2RlKSB7Cj4gKwkJY2Fz
ZSAwOgo+ICsJCQkvKiBidXJzdCBtb2RlICovCj4gKwkJCWRzaS0+bW9kZV9mbGFncyB8PSBNSVBJ
X0RTSV9NT0RFX1ZJREVPX0JVUlNUOwo+ICsJCQlicmVhazsKPiArCQljYXNlIDE6Cj4gKwkJCS8q
IG5vbi1idXJzdCBtb2RlIHdpdGggc3luYyBldmVudCAqLwo+ICsJCQlicmVhazsKPiArCQljYXNl
IDI6Cj4gKwkJCS8qIG5vbi1idXJzdCBtb2RlIHdpdGggc3luYyBwdWxzZSAqLwo+ICsJCQlkc2kt
Pm1vZGVfZmxhZ3MgfD0gTUlQSV9EU0lfTU9ERV9WSURFT19TWU5DX1BVTFNFOwo+ICsJCQlicmVh
azsKPiArCQlkZWZhdWx0Ogo+ICsJCQlkZXZfd2FybihkZXYsICJpbnZhbGlkIHZpZGVvIG1vZGUg
JWRcbiIsIHZpZGVvX21vZGUpOwo+ICsJCQlicmVhazsKPiArCQl9Cj4gKwl9Cj4gKwo+ICsJcmV0
ID0gb2ZfcHJvcGVydHlfcmVhZF91MzIobnAsICJkc2ktbGFuZXMiLCAmZHNpLT5sYW5lcyk7Cj4g
KwlpZiAocmV0IDwgMCkgewo+ICsJCWRldl9lcnIoZGV2LCAiRmFpbGVkIHRvIGdldCBkc2ktbGFu
ZXMgcHJvcGVydHkgKCVkKVxuIiwgcmV0KTsKPiArCQlyZXR1cm4gcmV0Owo+ICsJfQo+ICsKPiAr
CS8qCj4gKwkgKiAnZGlzcGxheS10aW1pbmdzJyBpcyBvcHRpb25hbCwgc28gdmVyaWZ5IGlmIHRo
ZSBub2RlIGlzIHByZXNlbnQKPiArCSAqIGJlZm9yZSBjYWxsaW5nIG9mX2dldF92aWRlb21vZGUg
c28gd2Ugd29uJ3QgZ2V0IGNvbnNvbGUgZXJyb3IKPiArCSAqIG1lc3NhZ2VzCj4gKwkgKi8KPiAr
CXRpbWluZ3MgPSBvZl9nZXRfY2hpbGRfYnlfbmFtZShucCwgImRpc3BsYXktdGltaW5ncyIpOwo+
ICsJaWYgKHRpbWluZ3MpIHsKPiArCQlvZl9ub2RlX3B1dCh0aW1pbmdzKTsKPiArCQlyZXQgPSBv
Zl9nZXRfdmlkZW9tb2RlKG5wLCAmcGFuZWwtPnZtLCAwKTsKPiArCX0gZWxzZSB7Cj4gKwkJdmlk
ZW9tb2RlX2Zyb21fdGltaW5nKCZyYWRfZGVmYXVsdF90aW1pbmcsICZwYW5lbC0+dm0pOwo+ICsJ
fQo+ICsJaWYgKHJldCA8IDApCj4gKwkJcmV0dXJuIHJldDsKPiArCj4gKwlvZl9wcm9wZXJ0eV9y
ZWFkX3UzMihucCwgIndpZHRoLW1tIiwgJnBhbmVsLT53aWR0aF9tbSk7Cj4gKwlvZl9wcm9wZXJ0
eV9yZWFkX3UzMihucCwgImhlaWdodC1tbSIsICZwYW5lbC0+aGVpZ2h0X21tKTsKPiArCj4gKwlw
YW5lbC0+cmVzZXQgPSBkZXZtX2dwaW9kX2dldChkZXYsICJyZXNldCIsIEdQSU9EX09VVF9ISUdI
KTsKPiArCj4gKwlpZiAoSVNfRVJSKHBhbmVsLT5yZXNldCkpCj4gKwkJcGFuZWwtPnJlc2V0ID0g
TlVMTDsKPiArCWVsc2UKPiArCQlncGlvZF9zZXRfdmFsdWUocGFuZWwtPnJlc2V0LCAwKTsKPiAr
Cj4gKwltZW1zZXQoJmJsX3Byb3BzLCAwLCBzaXplb2YoYmxfcHJvcHMpKTsKPiArCWJsX3Byb3Bz
LnR5cGUgPSBCQUNLTElHSFRfUkFXOwo+ICsJYmxfcHJvcHMuYnJpZ2h0bmVzcyA9IDI1NTsKPiAr
CWJsX3Byb3BzLm1heF9icmlnaHRuZXNzID0gMjU1Owo+ICsKPiArCXBhbmVsLT5iYWNrbGlnaHQg
PSBkZXZtX2JhY2tsaWdodF9kZXZpY2VfcmVnaXN0ZXIoZGV2LCBkZXZfbmFtZShkZXYpLAo+ICsJ
CQkJCQkJICBkZXYsIGRzaSwKPiArCQkJCQkJCSAgJnJhZF9ibF9vcHMsCj4gKwkJCQkJCQkgICZi
bF9wcm9wcyk7Cj4gKwlpZiAoSVNfRVJSKHBhbmVsLT5iYWNrbGlnaHQpKSB7Cj4gKwkJcmV0ID0g
UFRSX0VSUihwYW5lbC0+YmFja2xpZ2h0KTsKPiArCQlkZXZfZXJyKGRldiwgIkZhaWxlZCB0byBy
ZWdpc3RlciBiYWNrbGlnaHQgKCVkKVxuIiwgcmV0KTsKPiArCQlyZXR1cm4gcmV0Owo+ICsJfQo+
ICsKPiArCWRybV9wYW5lbF9pbml0KCZwYW5lbC0+YmFzZSk7Cj4gKwlwYW5lbC0+YmFzZS5mdW5j
cyA9ICZyYWRfcGFuZWxfZnVuY3M7Cj4gKwlwYW5lbC0+YmFzZS5kZXYgPSBkZXY7Cj4gKwlkZXZf
c2V0X2RydmRhdGEoZGV2LCBwYW5lbCk7Cj4gKwo+ICsJcmV0ID0gZHJtX3BhbmVsX2FkZCgmcGFu
ZWwtPmJhc2UpOwo+ICsKPiArCWlmIChyZXQgPCAwKQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ICsJ
cmV0ID0gbWlwaV9kc2lfYXR0YWNoKGRzaSk7Cj4gKwlpZiAocmV0IDwgMCkKPiArCQlkcm1fcGFu
ZWxfcmVtb3ZlKCZwYW5lbC0+YmFzZSk7Cj4gKwo+ICsJcmV0dXJuIHJldDsKPiArfQo+ICsKPiAr
c3RhdGljIGludCByYWRfcGFuZWxfcmVtb3ZlKHN0cnVjdCBtaXBpX2RzaV9kZXZpY2UgKmRzaSkK
PiArewo+ICsJc3RydWN0IHJhZF9wYW5lbCAqcmFkID0gbWlwaV9kc2lfZ2V0X2RydmRhdGEoZHNp
KTsKPiArCXN0cnVjdCBkZXZpY2UgKmRldiA9ICZkc2ktPmRldjsKPiArCWludCByZXQ7Cj4gKwo+
ICsJcmV0ID0gbWlwaV9kc2lfZGV0YWNoKGRzaSk7Cj4gKwlpZiAocmV0IDwgMCkKPiArCQlEUk1f
REVWX0VSUk9SKGRldiwgIkZhaWxlZCB0byBkZXRhY2ggZnJvbSBob3N0ICglZClcbiIsCj4gKwkJ
CSAgICAgIHJldCk7Cj4gKwo+ICsJZHJtX3BhbmVsX3JlbW92ZSgmcmFkLT5iYXNlKTsKPiArCj4g
KwlyZXR1cm4gMDsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgcmFkX3BhbmVsX3NodXRkb3duKHN0
cnVjdCBtaXBpX2RzaV9kZXZpY2UgKmRzaSkKPiArewo+ICsJc3RydWN0IHJhZF9wYW5lbCAqcmFk
ID0gbWlwaV9kc2lfZ2V0X2RydmRhdGEoZHNpKTsKPiArCj4gKwlyYWRfcGFuZWxfZGlzYWJsZSgm
cmFkLT5iYXNlKTsKPiArCXJhZF9wYW5lbF91bnByZXBhcmUoJnJhZC0+YmFzZSk7Cj4gK30KPiAr
Cj4gKyNpZmRlZiBDT05GSUdfUE0KPiArc3RhdGljIGludCByYWRfcGFuZWxfc3VzcGVuZChzdHJ1
Y3QgZGV2aWNlICpkZXYpCj4gK3sKPiArCXN0cnVjdCByYWRfcGFuZWwgKnJhZCA9IGRldl9nZXRf
ZHJ2ZGF0YShkZXYpOwo+ICsKPiArCWlmICghcmFkLT5yZXNldCkKPiArCQlyZXR1cm4gMDsKPiAr
Cj4gKwlkZXZtX2dwaW9kX3B1dChkZXYsIHJhZC0+cmVzZXQpOwo+ICsJcmFkLT5yZXNldCA9IE5V
TEw7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgcmFkX3BhbmVsX3Jl
c3VtZShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gK3sKPiArCXN0cnVjdCByYWRfcGFuZWwgKnJhZCA9
IGRldl9nZXRfZHJ2ZGF0YShkZXYpOwo+ICsKPiArCWlmIChyYWQtPnJlc2V0KQo+ICsJCXJldHVy
biAwOwo+ICsKPiArCXJhZC0+cmVzZXQgPSBkZXZtX2dwaW9kX2dldChkZXYsICJyZXNldCIsIEdQ
SU9EX09VVF9ISUdIKTsKPiArCWlmIChJU19FUlIocmFkLT5yZXNldCkpCj4gKwkJcmFkLT5yZXNl
dCA9IE5VTEw7Cj4gKwo+ICsJcmV0dXJuIFBUUl9FUlJfT1JfWkVSTyhyYWQtPnJlc2V0KTsKPiAr
fQo+ICsKPiArI2VuZGlmCk5vIG90aGVyIHBhbmVscyBoYXZlIHN1c3BlbmQvcmVzdW1lLgpJcyBp
dCByZWxldmFudD8KCgo+ICsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBkZXZfcG1fb3BzIHJhZF9w
bV9vcHMgPSB7Cj4gKwlTRVRfUlVOVElNRV9QTV9PUFMocmFkX3BhbmVsX3N1c3BlbmQsIHJhZF9w
YW5lbF9yZXN1bWUsIE5VTEwpCj4gKwlTRVRfU1lTVEVNX1NMRUVQX1BNX09QUyhyYWRfcGFuZWxf
c3VzcGVuZCwgcmFkX3BhbmVsX3Jlc3VtZSkKPiArfTsKPiArCj4gK3N0YXRpYyBjb25zdCBzdHJ1
Y3Qgb2ZfZGV2aWNlX2lkIHJhZF9vZl9tYXRjaFtdID0gewo+ICsJeyAuY29tcGF0aWJsZSA9ICJy
YXlkaXVtLHJtNjcxOTEiLCB9LAo+ICsJeyB9Cj4gK307Cj4gK01PRFVMRV9ERVZJQ0VfVEFCTEUo
b2YsIHJhZF9vZl9tYXRjaCk7Cj4gKwo+ICtzdGF0aWMgc3RydWN0IG1pcGlfZHNpX2RyaXZlciBy
YWRfcGFuZWxfZHJpdmVyID0gewo+ICsJLmRyaXZlciA9IHsKPiArCQkubmFtZSA9ICJwYW5lbC1y
YXlkaXVtLXJtNjcxOTEiLAo+ICsJCS5vZl9tYXRjaF90YWJsZSA9IHJhZF9vZl9tYXRjaCwKPiAr
CQkucG0JPSAmcmFkX3BtX29wcywKPiArCX0sCj4gKwkucHJvYmUgPSByYWRfcGFuZWxfcHJvYmUs
Cj4gKwkucmVtb3ZlID0gcmFkX3BhbmVsX3JlbW92ZSwKPiArCS5zaHV0ZG93biA9IHJhZF9wYW5l
bF9zaHV0ZG93biwKPiArfTsKPiArbW9kdWxlX21pcGlfZHNpX2RyaXZlcihyYWRfcGFuZWxfZHJp
dmVyKTsKPiArCj4gK01PRFVMRV9BVVRIT1IoIlJvYmVydCBDaGlyYXMgPHJvYmVydC5jaGlyYXNA
bnhwLmNvbT4iKTsKPiArTU9EVUxFX0RFU0NSSVBUSU9OKCJEUk0gRHJpdmVyIGZvciBSYXlkaXVt
IFJNNjcxOTEgTUlQSSBEU0kgcGFuZWwiKTsKPiArTU9EVUxFX0xJQ0VOU0UoIkdQTCB2MiIpOwoK
CglTYW0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp
LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz
Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs