From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Subject: Re: [PATCH 1/5] sound: SoC: sof: no need to check return value of debugfs_create functions
Date: Fri, 14 Jun 2019 17:28:00 +0200 [thread overview]
Message-ID: <20190614152800.GC18049@kroah.com> (raw)
In-Reply-To: <20190614145933.GB5316@sirena.org.uk>
On Fri, Jun 14, 2019 at 03:59:33PM +0100, Mark Brown wrote:
> On Fri, Jun 14, 2019 at 11:47:52AM +0200, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value. The function can work or not, but the code logic should
> > never do something different based on this.
>
> Please use subject lines matching the style for the subsystem. This
> makes it easier for people to identify relevant patches.
Sorry about that, tough to catch when doing 100+ different patches all
across the kernel for this type of thing...
greg k-h
next prev parent reply other threads:[~2019-06-14 15:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 9:47 [PATCH 1/5] sound: SoC: sof: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-06-14 9:47 ` [PATCH 2/5] sound: soc: skylake: " Greg Kroah-Hartman
2019-06-22 19:57 ` Cezary Rojewski
2019-06-22 20:39 ` Takashi Iwai
[not found] ` <20190624105334.GJ5316@sirena.org.uk>
2019-06-24 13:15 ` Takashi Iwai
2019-06-24 13:33 ` Mark Brown
2019-06-27 0:23 ` Greg Kroah-Hartman
2019-06-23 4:57 ` Greg Kroah-Hartman
2019-06-23 15:18 ` Cezary Rojewski
2019-06-23 15:55 ` Greg Kroah-Hartman
2019-06-14 9:47 ` [PATCH 3/5] sound: soc: codecs: wm_adsp: " Greg Kroah-Hartman
2019-06-14 10:24 ` Richard Fitzgerald
2019-06-14 15:43 ` Applied "ASoC: wm_adsp: no need to check return value of debugfs_create functions" to the asoc tree Mark Brown
2019-06-14 9:47 ` [PATCH 4/5] sound: soc: fsl: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-06-14 15:43 ` Applied "ASoC: fsl: no need to check return value of debugfs_create functions" to the asoc tree Mark Brown
2019-06-14 9:47 ` [PATCH 5/5] sound: soc: core: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-06-14 15:34 ` Mark Brown
2019-06-14 16:13 ` Greg Kroah-Hartman
2019-06-14 17:41 ` Mark Brown
2019-06-14 14:59 ` [PATCH 1/5] sound: SoC: sof: " Mark Brown
2019-06-14 15:28 ` Greg Kroah-Hartman [this message]
2019-06-14 15:14 ` Mark Brown
2019-06-14 15:27 ` Greg Kroah-Hartman
2019-06-14 16:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614152800.GC18049@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.