From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=YJ55=UQ=vger.kernel.org=linux-arm-msm-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 27CC7C31E44
	for <linux-arm-msm@archiver.kernel.org>; Mon, 17 Jun 2019 06:25:12 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 0033E2189F
	for <linux-arm-msm@archiver.kernel.org>; Mon, 17 Jun 2019 06:25:11 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1560752712;
	bh=co4CH3+SDS8TMkRgK/NCJ9ECqQhqAHMJdhoNOGwoOuo=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From;
	b=jFLgiSHD+0Wdy0WlOEPS6Z/BLcikSPzJ+op0pxRs47JYEZdvxo6+QajnDceMeRnM1
	 vc4L5EQe+OBduxQo9NIwu9kbSicLvqDwa2rbjqtOA7dNRJNA37TRbljHZgQxE/LCHB
	 NxxdLVyXXzzv2obAQFMby1I+Qbfqw3UGpMAa3BwU=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1725826AbfFQGZH (ORCPT
        <rfc822;linux-arm-msm@archiver.kernel.org>);
        Mon, 17 Jun 2019 02:25:07 -0400
Received: from mail.kernel.org ([198.145.29.99]:49596 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725468AbfFQGZH (ORCPT <rfc822;linux-arm-msm@vger.kernel.org>);
        Mon, 17 Jun 2019 02:25:07 -0400
Received: from localhost (unknown [122.178.208.218])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id D14202189F;
        Mon, 17 Jun 2019 06:25:05 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1560752706;
        bh=co4CH3+SDS8TMkRgK/NCJ9ECqQhqAHMJdhoNOGwoOuo=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=X8Pfmd/rIU96IjvzY+RN4dwMfiLLpJtl74U3hxuwtuKX/aTl4lbPWXvaSFakH+RUi
         qzB5vRYtTNTN5ASjIF9dNN6HsKOMCJzQkTwiZEyN/jzyp/7Me3DJi6EuSi/Ywpm4en
         J8eG7dVIMlCWxnrBDNra6ZL/TyA0skTChyzI2CT4=
Date:   Mon, 17 Jun 2019 11:51:58 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Bjorn Andersson <bjorn.andersson@linaro.org>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        linux-arm-msm@vger.kernel.org,
        Prasad Sodagudi <psodagud@codeaurora.org>,
        Andy Gross <agross@kernel.org>,
        David Brown <david.brown@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        "Isaac J . Manjarres" <isaacm@codeaurora.org>
Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: Add SM8150 pinctrl
 binding
Message-ID: <20190617062158.GG2962@vkoul-mobl>
References: <20190614053032.24208-1-vkoul@kernel.org>
 <20190617042032.GE750@tuxbook-pro>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190617042032.GE750@tuxbook-pro>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-arm-msm-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-arm-msm.vger.kernel.org>
X-Mailing-List: linux-arm-msm@vger.kernel.org

On 16-06-19, 21:20, Bjorn Andersson wrote:
> On Thu 13 Jun 22:30 PDT 2019, Vinod Koul wrote:

> > +- reg:
> > +	Usage: required
> > +	Value type: <prop-encoded-array>
> > +	Definition: the base address and size of the north, south , west
> 
> Extra space after south.

Thanks will fix that

> > +- #gpio-cells:
> > +	Usage: required
> > +	Value type: <u32>
> > +	Definition: must be 2. Specifying the pin number and flags, as defined
> > +		    in <dt-bindings/gpio/gpio.h>
> > +
> 
> Please also document gpio-ranges and gpio-reserved-ranges.

Will add

> > +Example:
> > +
> > +	tlmm: pinctrl@3000000 {
> > +		compatible = "qcom,sm8150-pinctrl";
> > +		reg = <0x03100000 0x300000>,
> > +		      <0x03500000 0x300000>,
> > +		      <0x03900000 0x300000>,
> > +		      <0x03D00000 0x300000>;
> > +		reg-names = "west", "east", "north", "south";
> > +		interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> > +		gpio-controller;
> > +		#gpio-cells = <2>;
> > +		interrupt-controller;
> > +		#interrupt-cells = <2>;
> 
> You're missing the required gpio-ranges from the example, see e.g.
> msm8996 (and please send a patch to the binding you based this on).

I ported this from downstream but did look at existing upstream
examples so will do that

-- 
~Vinod