From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A901C31E44 for ; Mon, 17 Jun 2019 08:51:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5DDCA20848 for ; Mon, 17 Jun 2019 08:51:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727893AbfFQIvM (ORCPT ); Mon, 17 Jun 2019 04:51:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38822 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727323AbfFQIvM (ORCPT ); Mon, 17 Jun 2019 04:51:12 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 314743086235; Mon, 17 Jun 2019 08:51:06 +0000 (UTC) Received: from ming.t460p (ovpn-8-27.pek2.redhat.com [10.72.8.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 484AA4DA35; Mon, 17 Jun 2019 08:50:37 +0000 (UTC) Date: Mon, 17 Jun 2019 16:50:32 +0800 From: Ming Lei To: Christoph Hellwig Cc: linux-scsi@vger.kernel.org, "Martin K . Petersen" , James Bottomley , Bart Van Assche , Hannes Reinecke , Jim Gill , Cathy Avery , "Ewan D . Milne" , Brian King , James Smart , "Juergen E . Fischer" , Michael Schmitz , Finn Thain , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-usb@vger.kernel.org, Dan Carpenter , Benjamin Block Subject: Re: [PATCH V4 05/16] scsi: ipr: use sg helper to operate scatterlist Message-ID: <20190617085027.GA31002@ming.t460p> References: <20190617030349.26415-1-ming.lei@redhat.com> <20190617030349.26415-6-ming.lei@redhat.com> <20190617082423.GE7455@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190617082423.GE7455@lst.de> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Mon, 17 Jun 2019 08:51:11 +0000 (UTC) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Jun 17, 2019 at 10:24:23AM +0200, Christoph Hellwig wrote: > > - for (i = 0; i < (len / bsize_elem); i++, buffer += bsize_elem) { > > - struct page *page = sg_page(&scatterlist[i]); > > + for (i = 0; i < (len / bsize_elem); i++, sg = sg_next(sg), buffer += bsize_elem) { > > Please split the overly long line. Fine. > > > + struct page *page = sg_page(sg); > > > > kaddr = kmap(page); > > memcpy(kaddr, buffer, bsize_elem); > > kunmap(page); > > Not new in this patch, but this is buggy as scatterlists could have > offsets. This should probably use the scatterlist.c copy helper > eventually. This sglist is allocated by driver, see ipr_copy_ucode_buffer(), so offset for any element is zero. Thanks, Ming From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ming Lei Subject: Re: [PATCH V4 05/16] scsi: ipr: use sg helper to operate scatterlist Date: Mon, 17 Jun 2019 16:50:32 +0800 Message-ID: <20190617085027.GA31002@ming.t460p> References: <20190617030349.26415-1-ming.lei@redhat.com> <20190617030349.26415-6-ming.lei@redhat.com> <20190617082423.GE7455@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190617082423.GE7455@lst.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Christoph Hellwig Cc: Michael Schmitz , devel@driverdev.osuosl.org, Hannes Reinecke , Benjamin Block , linux-scsi@vger.kernel.org, "Martin K . Petersen" , Greg Kroah-Hartman , linux-usb@vger.kernel.org, James Smart , "Ewan D . Milne" , Jim Gill , James Bottomley , Brian King , Finn Thain , "Juergen E . Fischer" , Dan Carpenter , Bart Van Assche List-Id: linux-scsi@vger.kernel.org On Mon, Jun 17, 2019 at 10:24:23AM +0200, Christoph Hellwig wrote: > > - for (i = 0; i < (len / bsize_elem); i++, buffer += bsize_elem) { > > - struct page *page = sg_page(&scatterlist[i]); > > + for (i = 0; i < (len / bsize_elem); i++, sg = sg_next(sg), buffer += bsize_elem) { > > Please split the overly long line. Fine. > > > + struct page *page = sg_page(sg); > > > > kaddr = kmap(page); > > memcpy(kaddr, buffer, bsize_elem); > > kunmap(page); > > Not new in this patch, but this is buggy as scatterlists could have > offsets. This should probably use the scatterlist.c copy helper > eventually. This sglist is allocated by driver, see ipr_copy_ucode_buffer(), so offset for any element is zero. Thanks, Ming