From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C27DC31E59 for ; Mon, 17 Jun 2019 09:30:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F002212F5 for ; Mon, 17 Jun 2019 09:30:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728127AbfFQJap (ORCPT ); Mon, 17 Jun 2019 05:30:45 -0400 Received: from foss.arm.com ([217.140.110.172]:43036 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725962AbfFQJap (ORCPT ); Mon, 17 Jun 2019 05:30:45 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 79858344; Mon, 17 Jun 2019 02:30:44 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (unknown [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7761A3F246; Mon, 17 Jun 2019 02:30:42 -0700 (PDT) Date: Mon, 17 Jun 2019 10:30:40 +0100 From: Lorenzo Pieralisi To: "Z.q. Hou" Cc: "bhelgaas@google.com" , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "l.subrahmanya@mobiveil.co.in" , "shawnguo@kernel.org" , Leo Li , "catalin.marinas@arm.com" , "will.deacon@arm.com" , Mingkai Hu , "M.h. Lian" , Xiaowei Bao Subject: Re: [PATCHv5 18/20] PCI: mobiveil: Disable IB and OB windows set by bootloader Message-ID: <20190617093040.GC18020@e121166-lin.cambridge.arm.com> References: <20190412083635.33626-1-Zhiqiang.Hou@nxp.com> <20190412083635.33626-19-Zhiqiang.Hou@nxp.com> <20190612162347.GF15747@redmoon> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 15, 2019 at 05:03:33AM +0000, Z.q. Hou wrote: > Hi Lorenzo, > > > -----Original Message----- > > From: Lorenzo Pieralisi [mailto:lorenzo.pieralisi@arm.com] > > Sent: 2019年6月13日 0:24 > > To: Z.q. Hou ; bhelgaas@google.com > > Cc: linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > robh+dt@kernel.org; mark.rutland@arm.com; l.subrahmanya@mobiveil.co.in; > > shawnguo@kernel.org; Leo Li ; > > catalin.marinas@arm.com; will.deacon@arm.com; Mingkai Hu > > ; M.h. Lian ; Xiaowei Bao > > > > Subject: Re: [PATCHv5 18/20] PCI: mobiveil: Disable IB and OB windows set > > by bootloader > > > > On Fri, Apr 12, 2019 at 08:37:00AM +0000, Z.q. Hou wrote: > > > From: Hou Zhiqiang > > > > > > Disable all inbound and outbound windows before set up the windows in > > > kernel, in case transactions match the window set by bootloader. > > > > There must be no PCI transactions ongoing at bootloader<->OS handover. > > > > Yes, exact. > > > The bootloader needs fixing and this patch should be dropped, the host bridge > > driver assumes the host bridge state is disabled, > > The host bridge driver should not assumes the host state is disabled, > actually u-boot enable/initialize the host and without disabling it > when transfer the control to Linux. Fix the bootloader and drop this patch, I explain to you why. > > it will program the bridge > > apertures from scratch with no ongoing transactions, anything deviating from > > this behaviour is a bootloader bug and a recipe for disaster. > > The point of this patch is not to fix the ongoing transaction issue, > it is to avoid a potential issue which is caused by the outbound > window enabled by bootloader overlapping with Linux enabled. See above. Lorenzo > Thanks, > Zhiqiang > > > Lorenzo > > > > > Signed-off-by: Hou Zhiqiang > > > Reviewed-by: Minghuan Lian > > > Reviewed-by: Subrahmanya Lingappa > > > --- > > > V5: > > > - No functionality change. > > > > > > drivers/pci/controller/pcie-mobiveil.c | 25 +++++++++++++++++++++++++ > > > 1 file changed, 25 insertions(+) > > > > > > diff --git a/drivers/pci/controller/pcie-mobiveil.c > > > b/drivers/pci/controller/pcie-mobiveil.c > > > index 8dc87c7a600e..411e9779da12 100644 > > > --- a/drivers/pci/controller/pcie-mobiveil.c > > > +++ b/drivers/pci/controller/pcie-mobiveil.c > > > @@ -565,6 +565,24 @@ static int mobiveil_bringup_link(struct > > mobiveil_pcie *pcie) > > > return -ETIMEDOUT; > > > } > > > > > > +static void mobiveil_pcie_disable_ib_win(struct mobiveil_pcie *pcie, > > > +int idx) { > > > + u32 val; > > > + > > > + val = csr_readl(pcie, PAB_PEX_AMAP_CTRL(idx)); > > > + val &= ~(1 << AMAP_CTRL_EN_SHIFT); > > > + csr_writel(pcie, val, PAB_PEX_AMAP_CTRL(idx)); } > > > + > > > +static void mobiveil_pcie_disable_ob_win(struct mobiveil_pcie *pcie, > > > +int idx) { > > > + u32 val; > > > + > > > + val = csr_readl(pcie, PAB_AXI_AMAP_CTRL(idx)); > > > + val &= ~(1 << WIN_ENABLE_SHIFT); > > > + csr_writel(pcie, val, PAB_AXI_AMAP_CTRL(idx)); } > > > + > > > static void mobiveil_pcie_enable_msi(struct mobiveil_pcie *pcie) { > > > phys_addr_t msg_addr = pcie->pcie_reg_base; @@ -585,6 +603,13 @@ > > > static int mobiveil_host_init(struct mobiveil_pcie *pcie) { > > > u32 value, pab_ctrl, type; > > > struct resource_entry *win; > > > + int i; > > > + > > > + /* Disable all inbound/outbound windows */ > > > + for (i = 0; i < pcie->apio_wins; i++) > > > + mobiveil_pcie_disable_ob_win(pcie, i); > > > + for (i = 0; i < pcie->ppio_wins; i++) > > > + mobiveil_pcie_disable_ib_win(pcie, i); > > > > > > /* setup bus numbers */ > > > value = csr_readl(pcie, PCI_PRIMARY_BUS); > > > -- > > > 2.17.1 > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenzo Pieralisi Subject: Re: [PATCHv5 18/20] PCI: mobiveil: Disable IB and OB windows set by bootloader Date: Mon, 17 Jun 2019 10:30:40 +0100 Message-ID: <20190617093040.GC18020@e121166-lin.cambridge.arm.com> References: <20190412083635.33626-1-Zhiqiang.Hou@nxp.com> <20190412083635.33626-19-Zhiqiang.Hou@nxp.com> <20190612162347.GF15747@redmoon> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Z.q. Hou" Cc: "bhelgaas@google.com" , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "l.subrahmanya@mobiveil.co.in" , "shawnguo@kernel.org" , Leo Li , "catalin.marinas@arm.com" , "will.deacon@arm.com" , Mingkai Hu , "M.h. Lian" , Xiaowei Bao List-Id: devicetree@vger.kernel.org On Sat, Jun 15, 2019 at 05:03:33AM +0000, Z.q. Hou wrote: > Hi Lorenzo, > > > -----Original Message----- > > From: Lorenzo Pieralisi [mailto:lorenzo.pieralisi@arm.com] > > Sent: 2019年6月13日 0:24 > > To: Z.q. Hou ; bhelgaas@google.com > > Cc: linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > robh+dt@kernel.org; mark.rutland@arm.com; l.subrahmanya@mobiveil.co.in; > > shawnguo@kernel.org; Leo Li ; > > catalin.marinas@arm.com; will.deacon@arm.com; Mingkai Hu > > ; M.h. Lian ; Xiaowei Bao > > > > Subject: Re: [PATCHv5 18/20] PCI: mobiveil: Disable IB and OB windows set > > by bootloader > > > > On Fri, Apr 12, 2019 at 08:37:00AM +0000, Z.q. Hou wrote: > > > From: Hou Zhiqiang > > > > > > Disable all inbound and outbound windows before set up the windows in > > > kernel, in case transactions match the window set by bootloader. > > > > There must be no PCI transactions ongoing at bootloader<->OS handover. > > > > Yes, exact. > > > The bootloader needs fixing and this patch should be dropped, the host bridge > > driver assumes the host bridge state is disabled, > > The host bridge driver should not assumes the host state is disabled, > actually u-boot enable/initialize the host and without disabling it > when transfer the control to Linux. Fix the bootloader and drop this patch, I explain to you why. > > it will program the bridge > > apertures from scratch with no ongoing transactions, anything deviating from > > this behaviour is a bootloader bug and a recipe for disaster. > > The point of this patch is not to fix the ongoing transaction issue, > it is to avoid a potential issue which is caused by the outbound > window enabled by bootloader overlapping with Linux enabled. See above. Lorenzo > Thanks, > Zhiqiang > > > Lorenzo > > > > > Signed-off-by: Hou Zhiqiang > > > Reviewed-by: Minghuan Lian > > > Reviewed-by: Subrahmanya Lingappa > > > --- > > > V5: > > > - No functionality change. > > > > > > drivers/pci/controller/pcie-mobiveil.c | 25 +++++++++++++++++++++++++ > > > 1 file changed, 25 insertions(+) > > > > > > diff --git a/drivers/pci/controller/pcie-mobiveil.c > > > b/drivers/pci/controller/pcie-mobiveil.c > > > index 8dc87c7a600e..411e9779da12 100644 > > > --- a/drivers/pci/controller/pcie-mobiveil.c > > > +++ b/drivers/pci/controller/pcie-mobiveil.c > > > @@ -565,6 +565,24 @@ static int mobiveil_bringup_link(struct > > mobiveil_pcie *pcie) > > > return -ETIMEDOUT; > > > } > > > > > > +static void mobiveil_pcie_disable_ib_win(struct mobiveil_pcie *pcie, > > > +int idx) { > > > + u32 val; > > > + > > > + val = csr_readl(pcie, PAB_PEX_AMAP_CTRL(idx)); > > > + val &= ~(1 << AMAP_CTRL_EN_SHIFT); > > > + csr_writel(pcie, val, PAB_PEX_AMAP_CTRL(idx)); } > > > + > > > +static void mobiveil_pcie_disable_ob_win(struct mobiveil_pcie *pcie, > > > +int idx) { > > > + u32 val; > > > + > > > + val = csr_readl(pcie, PAB_AXI_AMAP_CTRL(idx)); > > > + val &= ~(1 << WIN_ENABLE_SHIFT); > > > + csr_writel(pcie, val, PAB_AXI_AMAP_CTRL(idx)); } > > > + > > > static void mobiveil_pcie_enable_msi(struct mobiveil_pcie *pcie) { > > > phys_addr_t msg_addr = pcie->pcie_reg_base; @@ -585,6 +603,13 @@ > > > static int mobiveil_host_init(struct mobiveil_pcie *pcie) { > > > u32 value, pab_ctrl, type; > > > struct resource_entry *win; > > > + int i; > > > + > > > + /* Disable all inbound/outbound windows */ > > > + for (i = 0; i < pcie->apio_wins; i++) > > > + mobiveil_pcie_disable_ob_win(pcie, i); > > > + for (i = 0; i < pcie->ppio_wins; i++) > > > + mobiveil_pcie_disable_ib_win(pcie, i); > > > > > > /* setup bus numbers */ > > > value = csr_readl(pcie, PCI_PRIMARY_BUS); > > > -- > > > 2.17.1 > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3B98C31E58 for ; Mon, 17 Jun 2019 09:30:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C2BE212F5 for ; Mon, 17 Jun 2019 09:30:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Loqq10wO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C2BE212F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jPBZHYx9w/B8vYdBTkMSsKhHU2bwc1q4+ONcAtnNcR0=; b=Loqq10wOX16atU +/OjfOLQdFOvvtNkrTd+lOw/Hv4JW27rkoSdpEOgg1BRaV/BgS67hk5lf+3XZ2HO4WGtko2bzbM8j PFsKsk2O8J5l6P3nvNdD5glJwRF0BxhetSEVIBf5OK1apNjYem3AZrcWYRE2YamBW0WcHFQ0clVRS 5hmF0l7KlNeraFZE7euLfEDnC3YV7tcbdAXXGM/KtzTr5VrOG/PjyUT3JuUVIuM6VYAv1QZ/X8Fx+ 6hRb61HHq2KsGtTN9kALhcROo4IabEyUiNc9CagBa8RIuFu8+AagkTpnt5guu/W8iZbeQZYyeWeDy T3w4a3c5tKJ7udc783ww==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hcnyW-0005Ec-62; Mon, 17 Jun 2019 09:30:52 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hcnyP-0005Dd-89 for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2019 09:30:49 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 79858344; Mon, 17 Jun 2019 02:30:44 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (unknown [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7761A3F246; Mon, 17 Jun 2019 02:30:42 -0700 (PDT) Date: Mon, 17 Jun 2019 10:30:40 +0100 From: Lorenzo Pieralisi To: "Z.q. Hou" Subject: Re: [PATCHv5 18/20] PCI: mobiveil: Disable IB and OB windows set by bootloader Message-ID: <20190617093040.GC18020@e121166-lin.cambridge.arm.com> References: <20190412083635.33626-1-Zhiqiang.Hou@nxp.com> <20190412083635.33626-19-Zhiqiang.Hou@nxp.com> <20190612162347.GF15747@redmoon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190617_023048_325731_FFB95DC4 X-CRM114-Status: GOOD ( 23.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , Xiaowei Bao , "linux-pci@vger.kernel.org" , "l.subrahmanya@mobiveil.co.in" , "will.deacon@arm.com" , "linux-kernel@vger.kernel.org" , Leo Li , "M.h. Lian" , "robh+dt@kernel.org" , Mingkai Hu , "catalin.marinas@arm.com" , "bhelgaas@google.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBKdW4gMTUsIDIwMTkgYXQgMDU6MDM6MzNBTSArMDAwMCwgWi5xLiBIb3Ugd3JvdGU6 Cj4gSGkgTG9yZW56bywKPiAKPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4gPiBGcm9t OiBMb3JlbnpvIFBpZXJhbGlzaSBbbWFpbHRvOmxvcmVuem8ucGllcmFsaXNpQGFybS5jb21dCj4g PiBTZW50OiAyMDE55bm0NuaciDEz5pelIDA6MjQKPiA+IFRvOiBaLnEuIEhvdSA8emhpcWlhbmcu aG91QG54cC5jb20+OyBiaGVsZ2Fhc0Bnb29nbGUuY29tCj4gPiBDYzogbGludXgtcGNpQHZnZXIu a2VybmVsLm9yZzsgbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnOwo+ID4gZGV2 aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7Cj4g PiByb2JoK2R0QGtlcm5lbC5vcmc7IG1hcmsucnV0bGFuZEBhcm0uY29tOyBsLnN1YnJhaG1hbnlh QG1vYml2ZWlsLmNvLmluOwo+ID4gc2hhd25ndW9Aa2VybmVsLm9yZzsgTGVvIExpIDxsZW95YW5n LmxpQG54cC5jb20+Owo+ID4gY2F0YWxpbi5tYXJpbmFzQGFybS5jb207IHdpbGwuZGVhY29uQGFy bS5jb207IE1pbmdrYWkgSHUKPiA+IDxtaW5na2FpLmh1QG54cC5jb20+OyBNLmguIExpYW4gPG1p bmdodWFuLmxpYW5AbnhwLmNvbT47IFhpYW93ZWkgQmFvCj4gPiA8eGlhb3dlaS5iYW9AbnhwLmNv bT4KPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0h2NSAxOC8yMF0gUENJOiBtb2JpdmVpbDogRGlzYWJs ZSBJQiBhbmQgT0Igd2luZG93cyBzZXQKPiA+IGJ5IGJvb3Rsb2FkZXIKPiA+IAo+ID4gT24gRnJp LCBBcHIgMTIsIDIwMTkgYXQgMDg6Mzc6MDBBTSArMDAwMCwgWi5xLiBIb3Ugd3JvdGU6Cj4gPiA+ IEZyb206IEhvdSBaaGlxaWFuZyA8WmhpcWlhbmcuSG91QG54cC5jb20+Cj4gPiA+Cj4gPiA+IERp c2FibGUgYWxsIGluYm91bmQgYW5kIG91dGJvdW5kIHdpbmRvd3MgYmVmb3JlIHNldCB1cCB0aGUg d2luZG93cyBpbgo+ID4gPiBrZXJuZWwsIGluIGNhc2UgdHJhbnNhY3Rpb25zIG1hdGNoIHRoZSB3 aW5kb3cgc2V0IGJ5IGJvb3Rsb2FkZXIuCj4gPiAKPiA+IFRoZXJlIG11c3QgYmUgbm8gUENJIHRy YW5zYWN0aW9ucyBvbmdvaW5nIGF0IGJvb3Rsb2FkZXI8LT5PUyBoYW5kb3Zlci4KPiA+Cj4gCj4g WWVzLCBleGFjdC4KPiAgCj4gPiBUaGUgYm9vdGxvYWRlciBuZWVkcyBmaXhpbmcgYW5kIHRoaXMg cGF0Y2ggc2hvdWxkIGJlIGRyb3BwZWQsIHRoZSBob3N0IGJyaWRnZQo+ID4gZHJpdmVyIGFzc3Vt ZXMgdGhlIGhvc3QgYnJpZGdlIHN0YXRlIGlzIGRpc2FibGVkLAo+IAo+IFRoZSBob3N0IGJyaWRn ZSBkcml2ZXIgc2hvdWxkIG5vdCBhc3N1bWVzIHRoZSBob3N0IHN0YXRlIGlzIGRpc2FibGVkLAo+ IGFjdHVhbGx5IHUtYm9vdCBlbmFibGUvaW5pdGlhbGl6ZSB0aGUgaG9zdCBhbmQgd2l0aG91dCBk aXNhYmxpbmcgaXQKPiB3aGVuIHRyYW5zZmVyIHRoZSBjb250cm9sIHRvIExpbnV4LgoKRml4IHRo ZSBib290bG9hZGVyIGFuZCBkcm9wIHRoaXMgcGF0Y2gsIEkgZXhwbGFpbiB0byB5b3Ugd2h5LgoK PiA+IGl0IHdpbGwgcHJvZ3JhbSB0aGUgYnJpZGdlCj4gPiBhcGVydHVyZXMgZnJvbSBzY3JhdGNo IHdpdGggbm8gb25nb2luZyB0cmFuc2FjdGlvbnMsIGFueXRoaW5nIGRldmlhdGluZyBmcm9tCj4g PiB0aGlzIGJlaGF2aW91ciBpcyBhIGJvb3Rsb2FkZXIgYnVnIGFuZCBhIHJlY2lwZSBmb3IgZGlz YXN0ZXIuCj4gCj4gVGhlIHBvaW50IG9mIHRoaXMgcGF0Y2ggaXMgbm90IHRvIGZpeCB0aGUgb25n b2luZyB0cmFuc2FjdGlvbiBpc3N1ZSwKPiBpdCBpcyB0byBhdm9pZCBhIHBvdGVudGlhbCBpc3N1 ZSB3aGljaCBpcyBjYXVzZWQgYnkgdGhlIG91dGJvdW5kCj4gd2luZG93IGVuYWJsZWQgYnkgYm9v dGxvYWRlciBvdmVybGFwcGluZyB3aXRoIExpbnV4IGVuYWJsZWQuCgpTZWUgYWJvdmUuCgpMb3Jl bnpvCgo+IFRoYW5rcywKPiBaaGlxaWFuZwo+ICAKPiA+IExvcmVuem8KPiA+IAo+ID4gPiBTaWdu ZWQtb2ZmLWJ5OiBIb3UgWmhpcWlhbmcgPFpoaXFpYW5nLkhvdUBueHAuY29tPgo+ID4gPiBSZXZp ZXdlZC1ieTogTWluZ2h1YW4gTGlhbiA8TWluZ2h1YW4uTGlhbkBueHAuY29tPgo+ID4gPiBSZXZp ZXdlZC1ieTogU3VicmFobWFueWEgTGluZ2FwcGEgPGwuc3VicmFobWFueWFAbW9iaXZlaWwuY28u aW4+Cj4gPiA+IC0tLQo+ID4gPiBWNToKPiA+ID4gIC0gTm8gZnVuY3Rpb25hbGl0eSBjaGFuZ2Uu Cj4gPiA+Cj4gPiA+ICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaWUtbW9iaXZlaWwuYyB8IDI1 ICsrKysrKysrKysrKysrKysrKysrKysrKysKPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyNSBpbnNl cnRpb25zKCspCj4gPiA+Cj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVy L3BjaWUtbW9iaXZlaWwuYwo+ID4gPiBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpZS1tb2Jp dmVpbC5jCj4gPiA+IGluZGV4IDhkYzg3YzdhNjAwZS4uNDExZTk3NzlkYTEyIDEwMDY0NAo+ID4g PiAtLS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaWUtbW9iaXZlaWwuYwo+ID4gPiArKysg Yi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaWUtbW9iaXZlaWwuYwo+ID4gPiBAQCAtNTY1LDYg KzU2NSwyNCBAQCBzdGF0aWMgaW50IG1vYml2ZWlsX2JyaW5ndXBfbGluayhzdHJ1Y3QKPiA+IG1v Yml2ZWlsX3BjaWUgKnBjaWUpCj4gPiA+ICAJcmV0dXJuIC1FVElNRURPVVQ7Cj4gPiA+ICB9Cj4g PiA+Cj4gPiA+ICtzdGF0aWMgdm9pZCBtb2JpdmVpbF9wY2llX2Rpc2FibGVfaWJfd2luKHN0cnVj dCBtb2JpdmVpbF9wY2llICpwY2llLAo+ID4gPiAraW50IGlkeCkgewo+ID4gPiArCXUzMiB2YWw7 Cj4gPiA+ICsKPiA+ID4gKwl2YWwgPSBjc3JfcmVhZGwocGNpZSwgUEFCX1BFWF9BTUFQX0NUUkwo aWR4KSk7Cj4gPiA+ICsJdmFsICY9IH4oMSA8PCBBTUFQX0NUUkxfRU5fU0hJRlQpOwo+ID4gPiAr CWNzcl93cml0ZWwocGNpZSwgdmFsLCBQQUJfUEVYX0FNQVBfQ1RSTChpZHgpKTsgfQo+ID4gPiAr Cj4gPiA+ICtzdGF0aWMgdm9pZCBtb2JpdmVpbF9wY2llX2Rpc2FibGVfb2Jfd2luKHN0cnVjdCBt b2JpdmVpbF9wY2llICpwY2llLAo+ID4gPiAraW50IGlkeCkgewo+ID4gPiArCXUzMiB2YWw7Cj4g PiA+ICsKPiA+ID4gKwl2YWwgPSBjc3JfcmVhZGwocGNpZSwgUEFCX0FYSV9BTUFQX0NUUkwoaWR4 KSk7Cj4gPiA+ICsJdmFsICY9IH4oMSA8PCBXSU5fRU5BQkxFX1NISUZUKTsKPiA+ID4gKwljc3Jf d3JpdGVsKHBjaWUsIHZhbCwgUEFCX0FYSV9BTUFQX0NUUkwoaWR4KSk7IH0KPiA+ID4gKwo+ID4g PiAgc3RhdGljIHZvaWQgbW9iaXZlaWxfcGNpZV9lbmFibGVfbXNpKHN0cnVjdCBtb2JpdmVpbF9w Y2llICpwY2llKSAgewo+ID4gPiAgCXBoeXNfYWRkcl90IG1zZ19hZGRyID0gcGNpZS0+cGNpZV9y ZWdfYmFzZTsgQEAgLTU4NSw2ICs2MDMsMTMgQEAKPiA+ID4gc3RhdGljIGludCBtb2JpdmVpbF9o b3N0X2luaXQoc3RydWN0IG1vYml2ZWlsX3BjaWUgKnBjaWUpICB7Cj4gPiA+ICAJdTMyIHZhbHVl LCBwYWJfY3RybCwgdHlwZTsKPiA+ID4gIAlzdHJ1Y3QgcmVzb3VyY2VfZW50cnkgKndpbjsKPiA+ ID4gKwlpbnQgaTsKPiA+ID4gKwo+ID4gPiArCS8qIERpc2FibGUgYWxsIGluYm91bmQvb3V0Ym91 bmQgd2luZG93cyAqLwo+ID4gPiArCWZvciAoaSA9IDA7IGkgPCBwY2llLT5hcGlvX3dpbnM7IGkr KykKPiA+ID4gKwkJbW9iaXZlaWxfcGNpZV9kaXNhYmxlX29iX3dpbihwY2llLCBpKTsKPiA+ID4g Kwlmb3IgKGkgPSAwOyBpIDwgcGNpZS0+cHBpb193aW5zOyBpKyspCj4gPiA+ICsJCW1vYml2ZWls X3BjaWVfZGlzYWJsZV9pYl93aW4ocGNpZSwgaSk7Cj4gPiA+Cj4gPiA+ICAJLyogc2V0dXAgYnVz IG51bWJlcnMgKi8KPiA+ID4gIAl2YWx1ZSA9IGNzcl9yZWFkbChwY2llLCBQQ0lfUFJJTUFSWV9C VVMpOwo+ID4gPiAtLQo+ID4gPiAyLjE3LjEKPiA+ID4KCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK