From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1062EC31E57 for ; Mon, 17 Jun 2019 09:33:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E1B262084D for ; Mon, 17 Jun 2019 09:33:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726871AbfFQJdm (ORCPT ); Mon, 17 Jun 2019 05:33:42 -0400 Received: from foss.arm.com ([217.140.110.172]:43130 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725919AbfFQJdm (ORCPT ); Mon, 17 Jun 2019 05:33:42 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A35D8344; Mon, 17 Jun 2019 02:33:41 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (unknown [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9CA903F246; Mon, 17 Jun 2019 02:33:39 -0700 (PDT) Date: Mon, 17 Jun 2019 10:33:37 +0100 From: Lorenzo Pieralisi To: "Z.q. Hou" Cc: "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bhelgaas@google.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "l.subrahmanya@mobiveil.co.in" , "shawnguo@kernel.org" , Leo Li , "catalin.marinas@arm.com" , "will.deacon@arm.com" , Mingkai Hu , "M.h. Lian" , Xiaowei Bao Subject: Re: [PATCHv5 04/20] PCI: mobiveil: Remove the flag MSI_FLAG_MULTI_PCI_MSI Message-ID: <20190617093337.GD18020@e121166-lin.cambridge.arm.com> References: <20190412083635.33626-1-Zhiqiang.Hou@nxp.com> <20190412083635.33626-5-Zhiqiang.Hou@nxp.com> <20190611165935.GA22836@redmoon> <20190612130813.GA15747@redmoon> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 15, 2019 at 01:30:39AM +0000, Z.q. Hou wrote: > Hi Lorenzo, > > > -----Original Message----- > > From: Lorenzo Pieralisi [mailto:lorenzo.pieralisi@arm.com] > > Sent: 2019年6月12日 21:08 > > To: Z.q. Hou > > Cc: linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > bhelgaas@google.com; robh+dt@kernel.org; mark.rutland@arm.com; > > l.subrahmanya@mobiveil.co.in; shawnguo@kernel.org; Leo Li > > ; catalin.marinas@arm.com; will.deacon@arm.com; > > Mingkai Hu ; M.h. Lian ; > > Xiaowei Bao > > Subject: Re: [PATCHv5 04/20] PCI: mobiveil: Remove the flag > > MSI_FLAG_MULTI_PCI_MSI > > > > On Wed, Jun 12, 2019 at 11:34:51AM +0000, Z.q. Hou wrote: > > > Hi Lorenzo, > > > > > > Thanks a lot for your comments! > > > > > > > -----Original Message----- > > > > From: Lorenzo Pieralisi > > > > Sent: 2019年6月12日 1:00 > > > > To: Z.q. Hou > > > > Cc: linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > > > bhelgaas@google.com; robh+dt@kernel.org; mark.rutland@arm.com; > > > > l.subrahmanya@mobiveil.co.in; shawnguo@kernel.org; Leo Li > > > > ; catalin.marinas@arm.com; > > will.deacon@arm.com; > > > > Mingkai Hu ; M.h. Lian > > ; > > > > Xiaowei Bao > > > > Subject: Re: [PATCHv5 04/20] PCI: mobiveil: Remove the flag > > > > MSI_FLAG_MULTI_PCI_MSI > > > > > > > > On Fri, Apr 12, 2019 at 08:35:36AM +0000, Z.q. Hou wrote: > > > > > From: Hou Zhiqiang > > > > > > > > > > The current code does not support multiple MSIs, so remove the > > > > > corresponding flag from the msi_domain_info structure. > > > > > > > > Please explain me what's the problem before removing multi MSI support. > > > > > > NXP LX2 PCIe use the GIC-ITS instead of Mobiveil IP internal MSI > > > controller, so, I didn't encounter problem. > > > > Well, you sent a patch to fix an issue, explain me the issue you are fixing then, > > aka what have you sent this patch for ? > > I did not face issue, as I have explained NXP does not use the > Mobiveil IP's MSI controller. But obviously the MSI allocate function > does not support multiple MSI, so I submitted this patch. There is nothing obvious. Write what you are fixing in the commit log and I will apply the patch, I won't write the commit log for you. Anyone should be able to understand why a patch was needed by reading the commit log, it is as important as writing the code itself. Thanks, Lorenzo > Thanks, > Zhiqiang > > > > > Lorenzo > > > > > Subbu, did you test with Endpoint supporting multi MSI? > > > > > > Thanks, > > > Zhiqiang > > > > > > > > > > > Thanks, > > > > Lorenzo > > > > > > > > > Fixes: 1e913e58335f ("PCI: mobiveil: Add MSI support") > > > > > Signed-off-by: Hou Zhiqiang > > > > > Reviewed-by: Minghuan Lian > > > > > --- > > > > > V5: > > > > > - Corrected the subject. > > > > > > > > > > drivers/pci/controller/pcie-mobiveil.c | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/pci/controller/pcie-mobiveil.c > > > > > b/drivers/pci/controller/pcie-mobiveil.c > > > > > index 563210e731d3..a0dd337c6214 100644 > > > > > --- a/drivers/pci/controller/pcie-mobiveil.c > > > > > +++ b/drivers/pci/controller/pcie-mobiveil.c > > > > > @@ -703,7 +703,7 @@ static struct irq_chip mobiveil_msi_irq_chip = > > > > > { > > > > > > > > > > static struct msi_domain_info mobiveil_msi_domain_info = { > > > > > .flags = (MSI_FLAG_USE_DEF_DOM_OPS | > > > > MSI_FLAG_USE_DEF_CHIP_OPS | > > > > > - MSI_FLAG_MULTI_PCI_MSI | MSI_FLAG_PCI_MSIX), > > > > > + MSI_FLAG_PCI_MSIX), > > > > > .chip = &mobiveil_msi_irq_chip, > > > > > }; > > > > > > > > > > -- > > > > > 2.17.1 > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenzo Pieralisi Subject: Re: [PATCHv5 04/20] PCI: mobiveil: Remove the flag MSI_FLAG_MULTI_PCI_MSI Date: Mon, 17 Jun 2019 10:33:37 +0100 Message-ID: <20190617093337.GD18020@e121166-lin.cambridge.arm.com> References: <20190412083635.33626-1-Zhiqiang.Hou@nxp.com> <20190412083635.33626-5-Zhiqiang.Hou@nxp.com> <20190611165935.GA22836@redmoon> <20190612130813.GA15747@redmoon> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Z.q. Hou" Cc: "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bhelgaas@google.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "l.subrahmanya@mobiveil.co.in" , "shawnguo@kernel.org" , Leo Li , "catalin.marinas@arm.com" , "will.deacon@arm.com" , Mingkai Hu , "M.h. Lian" , Xiaowei Bao List-Id: devicetree@vger.kernel.org On Sat, Jun 15, 2019 at 01:30:39AM +0000, Z.q. Hou wrote: > Hi Lorenzo, > > > -----Original Message----- > > From: Lorenzo Pieralisi [mailto:lorenzo.pieralisi@arm.com] > > Sent: 2019年6月12日 21:08 > > To: Z.q. Hou > > Cc: linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > bhelgaas@google.com; robh+dt@kernel.org; mark.rutland@arm.com; > > l.subrahmanya@mobiveil.co.in; shawnguo@kernel.org; Leo Li > > ; catalin.marinas@arm.com; will.deacon@arm.com; > > Mingkai Hu ; M.h. Lian ; > > Xiaowei Bao > > Subject: Re: [PATCHv5 04/20] PCI: mobiveil: Remove the flag > > MSI_FLAG_MULTI_PCI_MSI > > > > On Wed, Jun 12, 2019 at 11:34:51AM +0000, Z.q. Hou wrote: > > > Hi Lorenzo, > > > > > > Thanks a lot for your comments! > > > > > > > -----Original Message----- > > > > From: Lorenzo Pieralisi > > > > Sent: 2019年6月12日 1:00 > > > > To: Z.q. Hou > > > > Cc: linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > > > bhelgaas@google.com; robh+dt@kernel.org; mark.rutland@arm.com; > > > > l.subrahmanya@mobiveil.co.in; shawnguo@kernel.org; Leo Li > > > > ; catalin.marinas@arm.com; > > will.deacon@arm.com; > > > > Mingkai Hu ; M.h. Lian > > ; > > > > Xiaowei Bao > > > > Subject: Re: [PATCHv5 04/20] PCI: mobiveil: Remove the flag > > > > MSI_FLAG_MULTI_PCI_MSI > > > > > > > > On Fri, Apr 12, 2019 at 08:35:36AM +0000, Z.q. Hou wrote: > > > > > From: Hou Zhiqiang > > > > > > > > > > The current code does not support multiple MSIs, so remove the > > > > > corresponding flag from the msi_domain_info structure. > > > > > > > > Please explain me what's the problem before removing multi MSI support. > > > > > > NXP LX2 PCIe use the GIC-ITS instead of Mobiveil IP internal MSI > > > controller, so, I didn't encounter problem. > > > > Well, you sent a patch to fix an issue, explain me the issue you are fixing then, > > aka what have you sent this patch for ? > > I did not face issue, as I have explained NXP does not use the > Mobiveil IP's MSI controller. But obviously the MSI allocate function > does not support multiple MSI, so I submitted this patch. There is nothing obvious. Write what you are fixing in the commit log and I will apply the patch, I won't write the commit log for you. Anyone should be able to understand why a patch was needed by reading the commit log, it is as important as writing the code itself. Thanks, Lorenzo > Thanks, > Zhiqiang > > > > > Lorenzo > > > > > Subbu, did you test with Endpoint supporting multi MSI? > > > > > > Thanks, > > > Zhiqiang > > > > > > > > > > > Thanks, > > > > Lorenzo > > > > > > > > > Fixes: 1e913e58335f ("PCI: mobiveil: Add MSI support") > > > > > Signed-off-by: Hou Zhiqiang > > > > > Reviewed-by: Minghuan Lian > > > > > --- > > > > > V5: > > > > > - Corrected the subject. > > > > > > > > > > drivers/pci/controller/pcie-mobiveil.c | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/pci/controller/pcie-mobiveil.c > > > > > b/drivers/pci/controller/pcie-mobiveil.c > > > > > index 563210e731d3..a0dd337c6214 100644 > > > > > --- a/drivers/pci/controller/pcie-mobiveil.c > > > > > +++ b/drivers/pci/controller/pcie-mobiveil.c > > > > > @@ -703,7 +703,7 @@ static struct irq_chip mobiveil_msi_irq_chip = > > > > > { > > > > > > > > > > static struct msi_domain_info mobiveil_msi_domain_info = { > > > > > .flags = (MSI_FLAG_USE_DEF_DOM_OPS | > > > > MSI_FLAG_USE_DEF_CHIP_OPS | > > > > > - MSI_FLAG_MULTI_PCI_MSI | MSI_FLAG_PCI_MSIX), > > > > > + MSI_FLAG_PCI_MSIX), > > > > > .chip = &mobiveil_msi_irq_chip, > > > > > }; > > > > > > > > > > -- > > > > > 2.17.1 > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9663BC31E57 for ; Mon, 17 Jun 2019 09:33:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5AD222084D for ; Mon, 17 Jun 2019 09:33:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mQ2raUG6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AD222084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nZf7olVGXDG1ktZ34E7OSkATG73khtdgs0kxNNZUm+E=; b=mQ2raUG6zY9FjO 3PVkhR0tGNMDEDS5oKSe2PYmOTlv8y4rgfGot8k3ZD/E4Mdp84aKE35S++ZFnNRpxFTKw+3GOo+Jy agspliuvTOrKsXx1fegeocZPlsqu2ha6dng/KUNdLDAiAEEWsThXDsvz/qwIWa2G2HaoNw4ldP5YD H1Bnx0q/ovC2yo44BaO2ncfFts4iGESYRzekRx4FiF06PZKIepg2aFS6AzmLyGvv2zVAB7a+BJJKA bLyGq3u2SvR/4enkWq3x6WZHj/uQrN2kLHeQaBgukZCDvmc1WtFhhBWscA3/FTMtlvXivVPdfbv2J h+J0ysxgZ6CCTMjaOLjQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hco1J-0006FG-Mb; Mon, 17 Jun 2019 09:33:45 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hco1G-0006Eq-Jf for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2019 09:33:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A35D8344; Mon, 17 Jun 2019 02:33:41 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (unknown [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9CA903F246; Mon, 17 Jun 2019 02:33:39 -0700 (PDT) Date: Mon, 17 Jun 2019 10:33:37 +0100 From: Lorenzo Pieralisi To: "Z.q. Hou" Subject: Re: [PATCHv5 04/20] PCI: mobiveil: Remove the flag MSI_FLAG_MULTI_PCI_MSI Message-ID: <20190617093337.GD18020@e121166-lin.cambridge.arm.com> References: <20190412083635.33626-1-Zhiqiang.Hou@nxp.com> <20190412083635.33626-5-Zhiqiang.Hou@nxp.com> <20190611165935.GA22836@redmoon> <20190612130813.GA15747@redmoon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190617_023342_738462_A181FDCE X-CRM114-Status: GOOD ( 26.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , Xiaowei Bao , "linux-pci@vger.kernel.org" , "l.subrahmanya@mobiveil.co.in" , "will.deacon@arm.com" , "linux-kernel@vger.kernel.org" , Leo Li , "M.h. Lian" , "robh+dt@kernel.org" , Mingkai Hu , "catalin.marinas@arm.com" , "bhelgaas@google.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBKdW4gMTUsIDIwMTkgYXQgMDE6MzA6MzlBTSArMDAwMCwgWi5xLiBIb3Ugd3JvdGU6 Cj4gSGkgTG9yZW56bywKPiAKPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4gPiBGcm9t OiBMb3JlbnpvIFBpZXJhbGlzaSBbbWFpbHRvOmxvcmVuem8ucGllcmFsaXNpQGFybS5jb21dCj4g PiBTZW50OiAyMDE55bm0NuaciDEy5pelIDIxOjA4Cj4gPiBUbzogWi5xLiBIb3UgPHpoaXFpYW5n LmhvdUBueHAuY29tPgo+ID4gQ2M6IGxpbnV4LXBjaUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZzsKPiA+IGRldmljZXRyZWVAdmdlci5rZXJuZWwu b3JnOyBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnOwo+ID4gYmhlbGdhYXNAZ29vZ2xlLmNv bTsgcm9iaCtkdEBrZXJuZWwub3JnOyBtYXJrLnJ1dGxhbmRAYXJtLmNvbTsKPiA+IGwuc3VicmFo bWFueWFAbW9iaXZlaWwuY28uaW47IHNoYXduZ3VvQGtlcm5lbC5vcmc7IExlbyBMaQo+ID4gPGxl b3lhbmcubGlAbnhwLmNvbT47IGNhdGFsaW4ubWFyaW5hc0Bhcm0uY29tOyB3aWxsLmRlYWNvbkBh cm0uY29tOwo+ID4gTWluZ2thaSBIdSA8bWluZ2thaS5odUBueHAuY29tPjsgTS5oLiBMaWFuIDxt aW5naHVhbi5saWFuQG54cC5jb20+Owo+ID4gWGlhb3dlaSBCYW8gPHhpYW93ZWkuYmFvQG54cC5j b20+Cj4gPiBTdWJqZWN0OiBSZTogW1BBVENIdjUgMDQvMjBdIFBDSTogbW9iaXZlaWw6IFJlbW92 ZSB0aGUgZmxhZwo+ID4gTVNJX0ZMQUdfTVVMVElfUENJX01TSQo+ID4gCj4gPiBPbiBXZWQsIEp1 biAxMiwgMjAxOSBhdCAxMTozNDo1MUFNICswMDAwLCBaLnEuIEhvdSB3cm90ZToKPiA+ID4gSGkg TG9yZW56bywKPiA+ID4KPiA+ID4gVGhhbmtzIGEgbG90IGZvciB5b3VyIGNvbW1lbnRzIQo+ID4g Pgo+ID4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4gPiA+ID4gRnJvbTogTG9yZW56 byBQaWVyYWxpc2kgPGxvcmVuem8ucGllcmFsaXNpQGFybS5jb20+Cj4gPiA+ID4gU2VudDogMjAx OeW5tDbmnIgxMuaXpSAxOjAwCj4gPiA+ID4gVG86IFoucS4gSG91IDx6aGlxaWFuZy5ob3VAbnhw LmNvbT4KPiA+ID4gPiBDYzogbGludXgtcGNpQHZnZXIua2VybmVsLm9yZzsgbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnOwo+ID4gPiA+IGRldmljZXRyZWVAdmdlci5rZXJuZWwu b3JnOyBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnOwo+ID4gPiA+IGJoZWxnYWFzQGdvb2ds ZS5jb207IHJvYmgrZHRAa2VybmVsLm9yZzsgbWFyay5ydXRsYW5kQGFybS5jb207Cj4gPiA+ID4g bC5zdWJyYWhtYW55YUBtb2JpdmVpbC5jby5pbjsgc2hhd25ndW9Aa2VybmVsLm9yZzsgTGVvIExp Cj4gPiA+ID4gPGxlb3lhbmcubGlAbnhwLmNvbT47IGNhdGFsaW4ubWFyaW5hc0Bhcm0uY29tOwo+ ID4gd2lsbC5kZWFjb25AYXJtLmNvbTsKPiA+ID4gPiBNaW5na2FpIEh1IDxtaW5na2FpLmh1QG54 cC5jb20+OyBNLmguIExpYW4KPiA+IDxtaW5naHVhbi5saWFuQG54cC5jb20+Owo+ID4gPiA+IFhp YW93ZWkgQmFvIDx4aWFvd2VpLmJhb0BueHAuY29tPgo+ID4gPiA+IFN1YmplY3Q6IFJlOiBbUEFU Q0h2NSAwNC8yMF0gUENJOiBtb2JpdmVpbDogUmVtb3ZlIHRoZSBmbGFnCj4gPiA+ID4gTVNJX0ZM QUdfTVVMVElfUENJX01TSQo+ID4gPiA+Cj4gPiA+ID4gT24gRnJpLCBBcHIgMTIsIDIwMTkgYXQg MDg6MzU6MzZBTSArMDAwMCwgWi5xLiBIb3Ugd3JvdGU6Cj4gPiA+ID4gPiBGcm9tOiBIb3UgWmhp cWlhbmcgPFpoaXFpYW5nLkhvdUBueHAuY29tPgo+ID4gPiA+ID4KPiA+ID4gPiA+IFRoZSBjdXJy ZW50IGNvZGUgZG9lcyBub3Qgc3VwcG9ydCBtdWx0aXBsZSBNU0lzLCBzbyByZW1vdmUgdGhlCj4g PiA+ID4gPiBjb3JyZXNwb25kaW5nIGZsYWcgZnJvbSB0aGUgbXNpX2RvbWFpbl9pbmZvIHN0cnVj dHVyZS4KPiA+ID4gPgo+ID4gPiA+IFBsZWFzZSBleHBsYWluIG1lIHdoYXQncyB0aGUgcHJvYmxl bSBiZWZvcmUgcmVtb3ZpbmcgbXVsdGkgTVNJIHN1cHBvcnQuCj4gPiA+Cj4gPiA+IE5YUCBMWDIg UENJZSB1c2UgdGhlIEdJQy1JVFMgaW5zdGVhZCBvZiBNb2JpdmVpbCBJUCBpbnRlcm5hbCBNU0kK PiA+ID4gY29udHJvbGxlciwgc28sIEkgZGlkbid0IGVuY291bnRlciBwcm9ibGVtLgo+ID4gCj4g PiBXZWxsLCB5b3Ugc2VudCBhIHBhdGNoIHRvIGZpeCBhbiBpc3N1ZSwgZXhwbGFpbiBtZSB0aGUg aXNzdWUgeW91IGFyZSBmaXhpbmcgdGhlbiwKPiA+IGFrYSB3aGF0IGhhdmUgeW91IHNlbnQgdGhp cyBwYXRjaCBmb3IgPwo+IAo+IEkgZGlkIG5vdCBmYWNlIGlzc3VlLCBhcyBJIGhhdmUgZXhwbGFp bmVkIE5YUCBkb2VzIG5vdCB1c2UgdGhlCj4gTW9iaXZlaWwgSVAncyBNU0kgY29udHJvbGxlci4g IEJ1dCBvYnZpb3VzbHkgdGhlIE1TSSBhbGxvY2F0ZSBmdW5jdGlvbgo+IGRvZXMgbm90IHN1cHBv cnQgbXVsdGlwbGUgTVNJLCBzbyBJIHN1Ym1pdHRlZCB0aGlzIHBhdGNoLgoKVGhlcmUgaXMgbm90 aGluZyBvYnZpb3VzLiBXcml0ZSB3aGF0IHlvdSBhcmUgZml4aW5nIGluIHRoZSBjb21taXQgbG9n CmFuZCBJIHdpbGwgYXBwbHkgdGhlIHBhdGNoLCBJIHdvbid0IHdyaXRlIHRoZSBjb21taXQgbG9n IGZvciB5b3UuIEFueW9uZQpzaG91bGQgYmUgYWJsZSB0byB1bmRlcnN0YW5kIHdoeSBhIHBhdGNo IHdhcyBuZWVkZWQgYnkgcmVhZGluZyB0aGUKY29tbWl0IGxvZywgaXQgaXMgYXMgaW1wb3J0YW50 IGFzIHdyaXRpbmcgdGhlIGNvZGUgaXRzZWxmLgoKVGhhbmtzLApMb3JlbnpvCgo+IFRoYW5rcywK PiBaaGlxaWFuZwo+IAo+ID4gCj4gPiBMb3JlbnpvCj4gPiAKPiA+ID4gU3ViYnUsIGRpZCB5b3Ug dGVzdCB3aXRoIEVuZHBvaW50IHN1cHBvcnRpbmcgbXVsdGkgTVNJPwo+ID4gPgo+ID4gPiBUaGFu a3MsCj4gPiA+IFpoaXFpYW5nCj4gPiA+Cj4gPiA+ID4KPiA+ID4gPiBUaGFua3MsCj4gPiA+ID4g TG9yZW56bwo+ID4gPiA+Cj4gPiA+ID4gPiBGaXhlczogMWU5MTNlNTgzMzVmICgiUENJOiBtb2Jp dmVpbDogQWRkIE1TSSBzdXBwb3J0IikKPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEhvdSBaaGlx aWFuZyA8WmhpcWlhbmcuSG91QG54cC5jb20+Cj4gPiA+ID4gPiBSZXZpZXdlZC1ieTogTWluZ2h1 YW4gTGlhbiA8TWluZ2h1YW4uTGlhbkBueHAuY29tPgo+ID4gPiA+ID4gLS0tCj4gPiA+ID4gPiBW NToKPiA+ID4gPiA+ICAtIENvcnJlY3RlZCB0aGUgc3ViamVjdC4KPiA+ID4gPiA+Cj4gPiA+ID4g PiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2llLW1vYml2ZWlsLmMgfCAyICstCj4gPiA+ID4g PiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gPiA+ID4g Pgo+ID4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpZS1tb2Jp dmVpbC5jCj4gPiA+ID4gPiBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpZS1tb2JpdmVpbC5j Cj4gPiA+ID4gPiBpbmRleCA1NjMyMTBlNzMxZDMuLmEwZGQzMzdjNjIxNCAxMDA2NDQKPiA+ID4g PiA+IC0tLSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpZS1tb2JpdmVpbC5jCj4gPiA+ID4g PiArKysgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaWUtbW9iaXZlaWwuYwo+ID4gPiA+ID4g QEAgLTcwMyw3ICs3MDMsNyBAQCBzdGF0aWMgc3RydWN0IGlycV9jaGlwIG1vYml2ZWlsX21zaV9p cnFfY2hpcCA9Cj4gPiA+ID4gPiB7Cj4gPiA+ID4gPgo+ID4gPiA+ID4gIHN0YXRpYyBzdHJ1Y3Qg bXNpX2RvbWFpbl9pbmZvIG1vYml2ZWlsX21zaV9kb21haW5faW5mbyA9IHsKPiA+ID4gPiA+ICAJ LmZsYWdzCT0gKE1TSV9GTEFHX1VTRV9ERUZfRE9NX09QUyB8Cj4gPiA+ID4gTVNJX0ZMQUdfVVNF X0RFRl9DSElQX09QUyB8Cj4gPiA+ID4gPiAtCQkgICBNU0lfRkxBR19NVUxUSV9QQ0lfTVNJIHwg TVNJX0ZMQUdfUENJX01TSVgpLAo+ID4gPiA+ID4gKwkJICAgTVNJX0ZMQUdfUENJX01TSVgpLAo+ ID4gPiA+ID4gIAkuY2hpcAk9ICZtb2JpdmVpbF9tc2lfaXJxX2NoaXAsCj4gPiA+ID4gPiAgfTsK PiA+ID4gPiA+Cj4gPiA+ID4gPiAtLQo+ID4gPiA+ID4gMi4xNy4xCj4gPiA+ID4gPgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=