All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Sudarsana Reddy Kalluru <skalluru@marvell.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
	<mkalderon@marvell.com>, <aelior@marvell.com>,
	Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next 4/4] qed: Add devlink support for configuration attributes.
Date: Mon, 17 Jun 2019 15:54:11 -0700	[thread overview]
Message-ID: <20190617155411.53cf07cf@cakuba.netronome.com> (raw)
In-Reply-To: <20190617114528.17086-5-skalluru@marvell.com>

On Mon, 17 Jun 2019 04:45:28 -0700, Sudarsana Reddy Kalluru wrote:
> This patch adds implementation for devlink callbacks for reading/
> configuring the device attributes.
> 
> Signed-off-by: Sudarsana Reddy Kalluru <skalluru@marvell.com>
> Signed-off-by: Ariel Elior <aelior@marvell.com>

You need to provide documentation for your parameters, plus some of
them look like they should potentially be port params, not device
params.

  reply	other threads:[~2019-06-17 22:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17 11:45 [PATCH net-next 0/4] qed: Devlink support for config attributes management Sudarsana Reddy Kalluru
2019-06-17 11:45 ` [PATCH net-next 1/4] qed: Add APIs for device attributes configuration Sudarsana Reddy Kalluru
2019-06-17 11:45 ` [PATCH net-next 2/4] qed: Perform devlink registration after the hardware init Sudarsana Reddy Kalluru
2019-06-17 11:45 ` [PATCH net-next 3/4] qed: Add new file for devlink implementation Sudarsana Reddy Kalluru
2019-06-17 11:45 ` [PATCH net-next 4/4] qed: Add devlink support for configuration attributes Sudarsana Reddy Kalluru
2019-06-17 22:54   ` Jakub Kicinski [this message]
2019-06-20 12:09     ` [EXT] " Sudarsana Reddy Kalluru
2019-06-20 13:37       ` Jiri Pirko
2019-06-26  6:46         ` Sudarsana Reddy Kalluru
2019-07-03 12:56         ` Sudarsana Reddy Kalluru
2019-07-03 17:42           ` Jakub Kicinski
2019-07-04  5:49             ` Sudarsana Reddy Kalluru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190617155411.53cf07cf@cakuba.netronome.com \
    --to=jakub.kicinski@netronome.com \
    --cc=aelior@marvell.com \
    --cc=davem@davemloft.net \
    --cc=jiri@resnulli.us \
    --cc=mkalderon@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=skalluru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.