From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7E99F21295CBF for ; Mon, 17 Jun 2019 13:10:28 -0700 (PDT) Date: Mon, 17 Jun 2019 22:09:57 +0200 From: Christoph Hellwig Subject: Re: [PATCH 08/25] memremap: move dev_pagemap callbacks into a separate structure Message-ID: <20190617200957.GA20645@lst.de> References: <20190617122733.22432-1-hch@lst.de> <20190617122733.22432-9-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Logan Gunthorpe Cc: linux-nvdimm@lists.01.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Jason Gunthorpe , Ben Skeggs , linux-pci@vger.kernel.org, Christoph Hellwig List-ID: On Mon, Jun 17, 2019 at 02:08:14PM -0600, Logan Gunthorpe wrote: > I just noticed this is missing a line to set pgmap->ops to > pci_p2pdma_pagemap_ops. I must have gotten confused by the other users > in my original review. Though I'm not sure how this compiles as the new > struct is static and unused. However, it is rendered moot in Patch 16 > when this is all removed. It probably was there in the original and got lost in the merge conflicts from the rebase. I should have dropped all the reviewed-bys for patches with non-trivial merge resolution, sorry. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8C1EC31E5B for ; Mon, 17 Jun 2019 20:10:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A13D5208C4 for ; Mon, 17 Jun 2019 20:10:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729138AbfFQUKd (ORCPT ); Mon, 17 Jun 2019 16:10:33 -0400 Received: from verein.lst.de ([213.95.11.211]:40726 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728932AbfFQUKa (ORCPT ); Mon, 17 Jun 2019 16:10:30 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 0673468B02; Mon, 17 Jun 2019 22:09:58 +0200 (CEST) Date: Mon, 17 Jun 2019 22:09:57 +0200 From: Christoph Hellwig To: Logan Gunthorpe Cc: Christoph Hellwig , Dan Williams , =?iso-8859-1?B?Suly9G1l?= Glisse , Jason Gunthorpe , Ben Skeggs , linux-mm@kvack.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-nvdimm@lists.01.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/25] memremap: move dev_pagemap callbacks into a separate structure Message-ID: <20190617200957.GA20645@lst.de> References: <20190617122733.22432-1-hch@lst.de> <20190617122733.22432-9-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 17, 2019 at 02:08:14PM -0600, Logan Gunthorpe wrote: > I just noticed this is missing a line to set pgmap->ops to > pci_p2pdma_pagemap_ops. I must have gotten confused by the other users > in my original review. Though I'm not sure how this compiles as the new > struct is static and unused. However, it is rendered moot in Patch 16 > when this is all removed. It probably was there in the original and got lost in the merge conflicts from the rebase. I should have dropped all the reviewed-bys for patches with non-trivial merge resolution, sorry. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 08/25] memremap: move dev_pagemap callbacks into a separate structure Date: Mon, 17 Jun 2019 22:09:57 +0200 Message-ID: <20190617200957.GA20645@lst.de> References: <20190617122733.22432-1-hch@lst.de> <20190617122733.22432-9-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Logan Gunthorpe Cc: linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Jason Gunthorpe , Ben Skeggs , linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Christoph Hellwig List-Id: nouveau.vger.kernel.org On Mon, Jun 17, 2019 at 02:08:14PM -0600, Logan Gunthorpe wrote: > I just noticed this is missing a line to set pgmap->ops to > pci_p2pdma_pagemap_ops. I must have gotten confused by the other users > in my original review. Though I'm not sure how this compiles as the new > struct is static and unused. However, it is rendered moot in Patch 16 > when this is all removed. It probably was there in the original and got lost in the merge conflicts from the rebase. I should have dropped all the reviewed-bys for patches with non-trivial merge resolution, sorry.