From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFDA7C31E51 for ; Tue, 18 Jun 2019 13:56:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 978FA2084B for ; Tue, 18 Jun 2019 13:56:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 978FA2084B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58250 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdEat-0001Hk-C4 for qemu-devel@archiver.kernel.org; Tue, 18 Jun 2019 09:56:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56018) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdEaB-0000sN-Vb for qemu-devel@nongnu.org; Tue, 18 Jun 2019 09:55:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hdEaA-0004FD-Ll for qemu-devel@nongnu.org; Tue, 18 Jun 2019 09:55:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36030) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hdEa8-00047e-NU for qemu-devel@nongnu.org; Tue, 18 Jun 2019 09:55:30 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 50DBC3082A49; Tue, 18 Jun 2019 13:55:25 +0000 (UTC) Received: from localhost (ovpn-116-76.gru2.redhat.com [10.97.116.76]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A20B2CE56; Tue, 18 Jun 2019 13:55:17 +0000 (UTC) Date: Tue, 18 Jun 2019 10:55:16 -0300 From: Eduardo Habkost To: Igor Mammedov Message-ID: <20190618135516.GH19178@habkost.net> References: <20180205135401.GA3300@localhost.localdomain> <20180205154202.7d1269a9@redhat.com> <20180205224205.GA3291@localhost.localdomain> <20180206154320.288acdc2@redhat.com> <62d7649e-e85d-43a2-2df8-85e2a0953e89@redhat.com> <20190617170106.48d776ca@redhat.com> <0a31228d-4d32-2c54-649b-6aef9953fffc@redhat.com> <20190617173343.68e3c9ec@redhat.com> <20190617162700.GC19178@habkost.net> <20190618133410.18b93bcd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20190618133410.18b93bcd@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Tue, 18 Jun 2019 13:55:25 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v5 1/6] machine: Convert the valid cpu types to use cpu_model X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marcel@redhat.com, peter.maydell@linaro.org, Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , qemu-devel@nongnu.org, alistair23@gmail.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jun 18, 2019 at 01:34:10PM +0200, Igor Mammedov wrote: > On Mon, 17 Jun 2019 13:27:00 -0300 > Eduardo Habkost wrote: >=20 > > On Mon, Jun 17, 2019 at 05:33:43PM +0200, Igor Mammedov wrote: > > > On Mon, 17 Jun 2019 17:15:21 +0200 > > > Philippe Mathieu-Daud=E9 wrote: =20 > > [...] > > > > Yes. Eduardo and you should write some lines to explain this, and= then > > > > we will follow :) =20 > > > Unfortunately I don't recall details anymore. One could check out a= ll > > > implementations of class_by_name callbacks to find out current stat= e. =20 > >=20 > > See this message for a summary of existing class_by_name quirks: > >=20 > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg615503.html > > Date: Wed, 08 May 2019 10:34:44 +0200 > > Message-ID: <877eb173a3.fsf@dusky.pond.sub.org> > > Subject: Re: [Qemu-devel] [PATCH 0/7] Delete 16 *_cpu_class_by_name= () functions > >=20 > > I'm unsure about Igor's suggestion to get rid of CPU model names > > and use only QOM type names in external interfaces. In either > > case, we can still simplify the rules rules and reduce the amount > > of arch-specific code. > as far as we have cpu_class_by_name, we have to watch over that > new patches/targets won't add some custom handling/fallbac/whatnot. We can get rid of CPUClass::cpu_class_by_name() without changing the external interfaces provided by QEMU. I don't have a strong opinion about using only QOM types at -cpu, yet. But first we need to get rid of the arch-specific CPU model name exceptions enumerated at the URL above (which would be very welcome). >=20 > On contrary -device works just with type names for all devices, > applying the same to -cpu which is basically translator > model->type[,-global type.foo,...] > would be consistent with -device and less confusing for everyone > (not counting significant code reduction). > It would certainly simplify contributing new targets as contributor > won't have to care about cpu model naming and do something about it. >=20 > This option wasn't considered before because we didn't have deprecation > back then, but now it opens possibility to simplify qemu and consolidat= e > naming. (we probably would be able to fold '-cpu help' into '-device he= lp' > as well). >=20 --=20 Eduardo