From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4960AC31E49 for ; Wed, 19 Jun 2019 09:28:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 240D72147A for ; Wed, 19 Jun 2019 09:28:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731460AbfFSJ2H (ORCPT ); Wed, 19 Jun 2019 05:28:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:50172 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726865AbfFSJ2H (ORCPT ); Wed, 19 Jun 2019 05:28:07 -0400 Received: from oasis.local.home (rrcs-50-75-126-20.nys.biz.rr.com [50.75.126.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8AEE0206E0; Wed, 19 Jun 2019 09:28:05 +0000 (UTC) Date: Wed, 19 Jun 2019 05:28:00 -0400 From: Steven Rostedt To: "Naveen N. Rao" Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Masami Hiramatsu , Ingo Molnar , Michael Ellerman , Nicholas Piggin Subject: Re: [PATCH 5/7] powerpc/ftrace: Update ftrace_location() for powerpc -mprofile-kernel Message-ID: <20190619052800.434ff6f0@oasis.local.home> In-Reply-To: <1560930937.j2vguryjp3.naveen@linux.ibm.com> References: <186656540d3e6225abd98374e791a13d10d86fab.1560868106.git.naveen.n.rao@linux.vnet.ibm.com> <20190618114509.5b1acbe5@gandalf.local.home> <1560881411.p0i6a1dkwk.naveen@linux.ibm.com> <1560881840.vz9llflvnf.naveen@linux.ibm.com> <20190618143234.78539805@gandalf.local.home> <1560930937.j2vguryjp3.naveen@linux.ibm.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Jun 2019 13:26:37 +0530 "Naveen N. Rao" wrote: > > In include/ftrace.h: > > > > #ifndef FTRACE_IP_EXTENSION > > # define FTRACE_IP_EXTENSION 0 > > #endif > > > > > > In arch/powerpc/include/asm/ftrace.h > > > > #define FTRACE_IP_EXTENSION MCOUNT_INSN_SIZE > > > > > > Then we can just have: > > > > unsigned long ftrace_location(unsigned long ip) > > { > > return ftrace_location_range(ip, ip + FTRACE_IP_EXTENSION); > > } > > Thanks, that's indeed nice. I hope you don't mind me adding your SOB for > that. Actually, it's best not to put a SOB by anyone other than yourself. It actually has legal meaning. In this case, please add: Suggested-by: Steven Rostedt (VMware) Thanks! -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB4A4C31E49 for ; Wed, 19 Jun 2019 09:29:58 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25EB9206E0 for ; Wed, 19 Jun 2019 09:29:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25EB9206E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45TKRR69rtzDql2 for ; Wed, 19 Jun 2019 19:29:55 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=srs0=jzn+=us=goodmis.org=rostedt@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=goodmis.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45TKPP4qj0zDqRP for ; Wed, 19 Jun 2019 19:28:09 +1000 (AEST) Received: from oasis.local.home (rrcs-50-75-126-20.nys.biz.rr.com [50.75.126.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8AEE0206E0; Wed, 19 Jun 2019 09:28:05 +0000 (UTC) Date: Wed, 19 Jun 2019 05:28:00 -0400 From: Steven Rostedt To: "Naveen N. Rao" Subject: Re: [PATCH 5/7] powerpc/ftrace: Update ftrace_location() for powerpc -mprofile-kernel Message-ID: <20190619052800.434ff6f0@oasis.local.home> In-Reply-To: <1560930937.j2vguryjp3.naveen@linux.ibm.com> References: <186656540d3e6225abd98374e791a13d10d86fab.1560868106.git.naveen.n.rao@linux.vnet.ibm.com> <20190618114509.5b1acbe5@gandalf.local.home> <1560881411.p0i6a1dkwk.naveen@linux.ibm.com> <1560881840.vz9llflvnf.naveen@linux.ibm.com> <20190618143234.78539805@gandalf.local.home> <1560930937.j2vguryjp3.naveen@linux.ibm.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Nicholas Piggin , Masami Hiramatsu , linuxppc-dev@lists.ozlabs.org, Ingo Molnar Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, 19 Jun 2019 13:26:37 +0530 "Naveen N. Rao" wrote: > > In include/ftrace.h: > > > > #ifndef FTRACE_IP_EXTENSION > > # define FTRACE_IP_EXTENSION 0 > > #endif > > > > > > In arch/powerpc/include/asm/ftrace.h > > > > #define FTRACE_IP_EXTENSION MCOUNT_INSN_SIZE > > > > > > Then we can just have: > > > > unsigned long ftrace_location(unsigned long ip) > > { > > return ftrace_location_range(ip, ip + FTRACE_IP_EXTENSION); > > } > > Thanks, that's indeed nice. I hope you don't mind me adding your SOB for > that. Actually, it's best not to put a SOB by anyone other than yourself. It actually has legal meaning. In this case, please add: Suggested-by: Steven Rostedt (VMware) Thanks! -- Steve