From: ben.hutchings@codethink.co.uk (Ben Hutchings) To: cip-dev@lists.cip-project.org Subject: [cip-dev] [PATCH 4.4-cip] spi: pxa2xx: Fix build error because of missing header Date: Thu, 20 Jun 2019 13:37:46 +0100 [thread overview] Message-ID: <20190620123746.4boosxdwr2vapgu4@xylophone.i.decadent.org.uk> (raw) From: Mika Westerberg <mika.westerberg@linux.intel.com> commit 089bd46d8bc1fe5a28351e82e4adcaa5a40121b5 upstream. Kbuild test robot reports: drivers/spi/spi-pxa2xx.c: In function ?setup_cs?: drivers/spi/spi-pxa2xx.c:1190:20: error: implicit declaration of function ?desc_to_gpio? ... Reason for this is the fact that those functions are declared in linux/gpio/consumer.h which is not included in the driver. Fix this by including it. Reported-by: kbuild test robot <fengguang.wu@intel.com> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk> --- This fixes a build regression for some configurations since I applied the backport of commit 3d3bc50700ba "spi: pxa2xx: Add support for GPIO descriptor chip selects". Ben. drivers/spi/spi-pxa2xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index 9233a1cb4dee..02685ccaa97b 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -28,6 +28,7 @@ #include <linux/spi/spi.h> #include <linux/delay.h> #include <linux/gpio.h> +#include <linux/gpio/consumer.h> #include <linux/slab.h> #include <linux/clk.h> #include <linux/pm_runtime.h> -- Ben Hutchings, Software Developer Codethink Ltd https://www.codethink.co.uk/ Dale House, 35 Dale Street Manchester, M1 2HF, United Kingdom
next reply other threads:[~2019-06-20 12:37 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-20 12:37 Ben Hutchings [this message] 2019-06-25 8:52 ` Pavel Machek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190620123746.4boosxdwr2vapgu4@xylophone.i.decadent.org.uk \ --to=ben.hutchings@codethink.co.uk \ --cc=cip-dev@lists.cip-project.org \ --subject='Re: [cip-dev] [PATCH 4.4-cip] spi: pxa2xx: Fix build error because of missing header' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.