From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92DC0C43613 for ; Thu, 20 Jun 2019 18:20:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61A68205F4 for ; Thu, 20 Jun 2019 18:20:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561054831; bh=xh82Oq10IAg2tIgfkxQvYdcJPdGAQ7vUAQhGRQWV0jA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=LHvmzFZZ6ZRxrLMkyY2ZNtwnYiUMPvLI2fUaLc2bJaPw3t4Aw6sHlpN9UaaggZscV OnH96Hhq0O86VWNIwjo/3MJor3O3PvIohhu44SO/pNRCV6QQRMgXILI3s8ipk4Dokl lX9KbNNyfi+i2JoC735CdjzHT0lv+3lt8vbpUe7w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728472AbfFTSUa (ORCPT ); Thu, 20 Jun 2019 14:20:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:41614 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728945AbfFTSNi (ORCPT ); Thu, 20 Jun 2019 14:13:38 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F02A02082C; Thu, 20 Jun 2019 18:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561054417; bh=xh82Oq10IAg2tIgfkxQvYdcJPdGAQ7vUAQhGRQWV0jA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S2TRAPyNd9U0rduaFRXv3er6hjmovaUstCeQWLTjxV13Ltmnek6VaIO9FWA6w5JFA AHJeMEHr3ZQiV0frcY6OVfBDaYUH2AGNHnsiO0pbGNeILoB4aZoWiIeaW2wvgwZCFK 2MN5RBa8nyg7hAXO6afbr0FcgAgq2zgZdLl8aYy8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+78fbe679c8ca8d264a8d@syzkaller.appspotmail.com, Xin Long , Ying Xue , "David S. Miller" Subject: [PATCH 5.1 14/98] tipc: purge deferredq list for each grp member in tipc_group_delete Date: Thu, 20 Jun 2019 19:56:41 +0200 Message-Id: <20190620174349.952997959@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190620174349.443386789@linuxfoundation.org> References: <20190620174349.443386789@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xin Long [ Upstream commit 5cf02612b33f104fe1015b2dfaf1758ad3675588 ] Syzbot reported a memleak caused by grp members' deferredq list not purged when the grp is be deleted. The issue occurs when more(msg_grp_bc_seqno(hdr), m->bc_rcv_nxt) in tipc_group_filter_msg() and the skb will stay in deferredq. So fix it by calling __skb_queue_purge for each member's deferredq in tipc_group_delete() when a tipc sk leaves the grp. Fixes: b87a5ea31c93 ("tipc: guarantee group unicast doesn't bypass group broadcast") Reported-by: syzbot+78fbe679c8ca8d264a8d@syzkaller.appspotmail.com Signed-off-by: Xin Long Acked-by: Ying Xue Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/tipc/group.c | 1 + 1 file changed, 1 insertion(+) --- a/net/tipc/group.c +++ b/net/tipc/group.c @@ -218,6 +218,7 @@ void tipc_group_delete(struct net *net, rbtree_postorder_for_each_entry_safe(m, tmp, tree, tree_node) { tipc_group_proto_xmit(grp, m, GRP_LEAVE_MSG, &xmitq); + __skb_queue_purge(&m->deferredq); list_del(&m->list); kfree(m); }