From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51AA7C43613 for ; Thu, 20 Jun 2019 18:16:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D4172089C for ; Thu, 20 Jun 2019 18:16:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561054609; bh=0oUtWq4O4No5YNWYN3+fa6+yvVT27mA2uuNIg2eMj9U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=f7K9LmQUjQf0Dxbpcd6CcOru13pfFPTIYbjOAabnIrvC9Yko2w+5hiOTgSKrCIkt0 nqLyTa/rE3j4ofTyYIQfMFiJZIuxeUHCtuKrhmvAnYqKjADdu6GvnCp+IyGP0QwF8u gxrpagwqFMthIPMRe3EwjBKyriNV+U2AOWErSLiw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729843AbfFTSQs (ORCPT ); Thu, 20 Jun 2019 14:16:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:45964 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726426AbfFTSQq (ORCPT ); Thu, 20 Jun 2019 14:16:46 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 476B12089C; Thu, 20 Jun 2019 18:16:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561054605; bh=0oUtWq4O4No5YNWYN3+fa6+yvVT27mA2uuNIg2eMj9U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YmNyGZr3p2T0DriQ6HHdU7uPcemN+Ksmd2ESyHg0pIlKJ4tjmZlmkK8E9WeKmRbxg iEdNJ+0fKL3MZSyUcP4Yep1rCQ4NIC9FJwtdBbuwa7Xswb3Ng0EQHGP9UO/cOFbyx/ elszpZtMQgmXDlcMrNWtWcave0c70SL09ePnlkGU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Max Uvarov , Florian Fainelli , "David S. Miller" , Sasha Levin Subject: [PATCH 5.1 87/98] net: phy: dp83867: Set up RGMII TX delay Date: Thu, 20 Jun 2019 19:57:54 +0200 Message-Id: <20190620174353.720858985@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190620174349.443386789@linuxfoundation.org> References: <20190620174349.443386789@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 2b892649254fec01678c64f16427622b41fa27f4 ] PHY_INTERFACE_MODE_RGMII_RXID is less then TXID so code to set tx delay is never called. Fixes: 2a10154abcb75 ("net: phy: dp83867: Add TI dp83867 phy") Signed-off-by: Max Uvarov Cc: Florian Fainelli Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/phy/dp83867.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index ffaf67bdb140..2995a1788ceb 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -255,10 +255,8 @@ static int dp83867_config_init(struct phy_device *phydev) ret = phy_write(phydev, MII_DP83867_PHYCTRL, val); if (ret) return ret; - } - if ((phydev->interface >= PHY_INTERFACE_MODE_RGMII_ID) && - (phydev->interface <= PHY_INTERFACE_MODE_RGMII_RXID)) { + /* Set up RGMII delays */ val = phy_read_mmd(phydev, DP83867_DEVADDR, DP83867_RGMIICTL); if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) -- 2.20.1