From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 620EBC48BE9 for ; Mon, 24 Jun 2019 10:03:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E3792145D for ; Mon, 24 Jun 2019 10:03:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561370588; bh=8p6CvQoZsI1qstbo/MkDljlgLADsxNqe5SQqKr0Q8wY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=XW+pq+eS+/9OlgQVSrMVvK3v31DQr7B41qUD5zNcuy5Ip5zeaEnjkXPC6HcialznP axltWqju+3y9y89Akaebn/8BuEOZBpHBKlmUfMC/sOzgHEMY64s8t3S8cLNFeEyBWV 5ilbhEdZmI48pbPrUDMdwq6cp5ZZ3faJ6uyvbfyM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729521AbfFXKDF (ORCPT ); Mon, 24 Jun 2019 06:03:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:34292 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729479AbfFXKDB (ORCPT ); Mon, 24 Jun 2019 06:03:01 -0400 Received: from localhost (f4.8f.5177.ip4.static.sl-reverse.com [119.81.143.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 865AF213F2; Mon, 24 Jun 2019 10:02:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561370580; bh=8p6CvQoZsI1qstbo/MkDljlgLADsxNqe5SQqKr0Q8wY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=M+QxH1IrGTpD9nG4j3DsJ+yOiMVCDnUuGpsu6YtApe96pN3P1zfShv9yHVS19T5+j QGdig9bdR8CklZrJQDMiga/CG7X299KxKyfv1Xln9T7KHGLl1ePCts/GW2U531kCDl bLLQmjhd9XL6dmDdfa0DSujk5bisHtx6Gn5d9cZI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Miklos Szeredi , Sasha Levin Subject: [PATCH 4.19 09/90] ovl: fix bogus -Wmaybe-unitialized warning Date: Mon, 24 Jun 2019 17:55:59 +0800 Message-Id: <20190624092314.600497388@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190624092313.788773607@linuxfoundation.org> References: <20190624092313.788773607@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 1dac6f5b0ed2601be21bb4e27a44b0c3e667b7f4 ] gcc gets a bit confused by the logic in ovl_setup_trap() and can't figure out whether the local 'trap' variable in the caller was initialized or not: fs/overlayfs/super.c: In function 'ovl_fill_super': fs/overlayfs/super.c:1333:4: error: 'trap' may be used uninitialized in this function [-Werror=maybe-uninitialized] iput(trap); ^~~~~~~~~~ fs/overlayfs/super.c:1312:17: note: 'trap' was declared here Reword slightly to make it easier for the compiler to understand. Fixes: 146d62e5a586 ("ovl: detect overlapping layers") Signed-off-by: Arnd Bergmann Signed-off-by: Miklos Szeredi Signed-off-by: Sasha Levin --- fs/overlayfs/super.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c index d6e60a7156a1..2d028c02621f 100644 --- a/fs/overlayfs/super.c +++ b/fs/overlayfs/super.c @@ -996,8 +996,8 @@ static int ovl_setup_trap(struct super_block *sb, struct dentry *dir, int err; trap = ovl_get_trap_inode(sb, dir); - err = PTR_ERR(trap); - if (IS_ERR(trap)) { + err = PTR_ERR_OR_ZERO(trap); + if (err) { if (err == -ELOOP) pr_err("overlayfs: conflicting %s path\n", name); return err; -- 2.20.1