From: Dave Martin <Dave.Martin@arm.com>
To: Andrew Jones <drjones@redhat.com>
Cc: "peter.maydell@linaro.org" <peter.maydell@linaro.org>,
"richard.henderson@linaro.org" <richard.henderson@linaro.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"armbru@redhat.com" <armbru@redhat.com>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"imammedo@redhat.com" <imammedo@redhat.com>,
"alex.bennee@linaro.org" <alex.bennee@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2 10/14] target/arm/kvm64: Add kvm_arch_get/put_sve
Date: Mon, 24 Jun 2019 17:09:00 +0100 [thread overview]
Message-ID: <20190624160859.GV2790@e103592.cambridge.arm.com> (raw)
In-Reply-To: <20190624115553.ef22fdempvxkzzog@kamzik.brq.redhat.com>
On Mon, Jun 24, 2019 at 12:55:53PM +0100, Andrew Jones wrote:
> On Mon, Jun 24, 2019 at 12:05:35PM +0100, Dave Martin wrote:
> > On Fri, Jun 21, 2019 at 05:34:18PM +0100, Andrew Jones wrote:
> > > These are the SVE equivalents to kvm_arch_get/put_fpsimd. Note, the
> > > swabbing is different than it is for fpsmid because the vector format
> > > is a little-endian stream of words.
> >
> > Note, on big-endian hosts the FPSIMD view Vn and the SVE view Zn[127:0]
> > of the FPSIMD/SVE common register bits has the opposite endianness for
> > SVE_{GET,SET}_ONE_REG.
> >
> > This only matters if mixing the two views: just from this patch I don't
> > know whether this is an issue for QEMU or not.
>
> I don't know either. My experience with the emulation side of QEMU is
> mostly the zcr_write tweak in this series. And, TBH, I didn't put too
> much thought into the endianness stuff, nor test this series with big
> endian.
Neither did I (at least beyond the "does it boot" level) -- hence the
bug ;)
And of course, few people are using big-endian, so nobody complained.
Just flagging it up so it doesn't get missed!
> Hopefully Richard can chime in on this.
It would be interesting to know whether you do hit this issue
somewhere, or whether you have a strong view about the clarification to
the KVM ABI.
Cheers
---Dave
next prev parent reply other threads:[~2019-06-24 16:23 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 16:34 [Qemu-devel] [PATCH v2 00/14] target/arm/kvm: enable SVE in guests Andrew Jones
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 01/14] target/arm/cpu64: Ensure kvm really supports aarch64=off Andrew Jones
2019-06-25 9:35 ` Auger Eric
2019-06-25 13:34 ` Andrew Jones
2019-07-24 12:51 ` Auger Eric
2019-07-24 13:52 ` Andrew Jones
2019-07-24 14:19 ` Auger Eric
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 02/14] target/arm/cpu: Ensure we can use the pmu with kvm Andrew Jones
2019-06-25 9:35 ` Auger Eric
2019-06-26 9:49 ` Richard Henderson
2019-06-26 13:11 ` Andrew Jones
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 03/14] target/arm/monitor: Introduce qmp_query_cpu_model_expansion Andrew Jones
2019-06-26 7:43 ` Auger Eric
2019-06-26 13:26 ` Andrew Jones
2019-07-24 12:51 ` Auger Eric
2019-07-24 14:05 ` Andrew Jones
2019-07-24 14:25 ` Auger Eric
2019-07-24 14:44 ` Andrew Jones
2019-07-24 12:55 ` Auger Eric
2019-07-24 14:13 ` Andrew Jones
2019-07-25 8:04 ` Auger Eric
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 04/14] tests: arm: Introduce cpu feature tests Andrew Jones
2019-07-25 7:54 ` Auger Eric
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 05/14] target/arm/helper: zcr: Add build bug next to value range assumption Andrew Jones
2019-06-24 11:05 ` Dave Martin
2019-06-24 11:30 ` Andrew Jones
2019-06-24 16:03 ` Dave Martin
2019-06-25 6:11 ` Andrew Jones
2019-06-25 6:14 ` Andrew Jones
2019-06-26 10:01 ` Auger Eric
2019-06-26 13:28 ` Andrew Jones
2019-06-26 13:40 ` Auger Eric
2019-06-26 13:58 ` Andrew Jones
2019-06-26 14:06 ` Auger Eric
2019-06-26 10:07 ` Richard Henderson
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 06/14] target/arm: Allow SVE to be disabled via a CPU property Andrew Jones
2019-06-21 16:55 ` Philippe Mathieu-Daudé
2019-06-21 17:11 ` Andrew Jones
2019-06-26 10:00 ` Auger Eric
2019-06-26 13:38 ` Andrew Jones
2019-06-26 10:20 ` Richard Henderson
2019-06-26 13:52 ` Andrew Jones
2019-07-17 15:43 ` Andrew Jones
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 07/14] target/arm/cpu64: max cpu: Introduce sve<vl-bits> properties Andrew Jones
2019-06-24 11:05 ` Dave Martin
2019-06-24 11:49 ` Andrew Jones
2019-06-24 12:10 ` Andrew Jones
2019-06-24 16:06 ` Dave Martin
2019-06-26 14:58 ` Auger Eric
2019-06-27 9:40 ` Andrew Jones
2019-06-27 10:51 ` Auger Eric
2019-06-27 11:43 ` Andrew Jones
2019-06-26 16:56 ` Auger Eric
2019-06-27 10:46 ` Andrew Jones
2019-06-27 11:00 ` Auger Eric
2019-06-27 11:47 ` Andrew Jones
2019-06-27 15:16 ` Dave Martin
2019-06-27 16:19 ` Richard Henderson
2019-06-27 16:49 ` Richard Henderson
2019-06-28 7:27 ` Andrew Jones
2019-06-28 8:31 ` Andrew Jones
2019-06-29 0:10 ` Richard Henderson
2019-07-17 8:13 ` Andrew Jones
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 08/14] target/arm/kvm64: Fix error returns Andrew Jones
2019-06-26 10:53 ` Richard Henderson
2019-06-26 11:50 ` Richard Henderson
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 09/14] target/arm/kvm64: Move the get/put of fpsimd registers out Andrew Jones
2019-06-26 10:35 ` Richard Henderson
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 10/14] target/arm/kvm64: Add kvm_arch_get/put_sve Andrew Jones
2019-06-24 11:05 ` Dave Martin
2019-06-24 11:55 ` Andrew Jones
2019-06-24 16:09 ` Dave Martin [this message]
2019-06-26 15:22 ` Richard Henderson
2019-06-27 10:59 ` Dave Martin
2019-06-27 11:26 ` Richard Henderson
2019-06-27 15:02 ` Dave Martin
2019-07-17 9:25 ` Andrew Jones
2019-07-17 9:35 ` Andrew Jones
2019-06-27 6:56 ` Auger Eric
2019-06-27 10:59 ` Andrew Jones
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 11/14] target/arm/kvm64: max cpu: Enable SVE when available Andrew Jones
2019-06-26 11:09 ` Richard Henderson
2019-06-27 11:56 ` Andrew Jones
2019-06-28 16:14 ` Auger Eric
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 12/14] target/arm/kvm: scratch vcpu: Preserve input kvm_vcpu_init features Andrew Jones
2019-06-26 11:11 ` Richard Henderson
2019-06-27 7:30 ` Auger Eric
2019-06-27 10:53 ` Andrew Jones
2019-06-27 11:01 ` Dave Martin
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 13/14] target/arm/cpu64: max cpu: Support sve properties with KVM Andrew Jones
2019-06-28 15:55 ` Auger Eric
2019-07-17 8:41 ` Andrew Jones
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 14/14] target/arm/kvm: host cpu: Add support for sve<vl-bits> properties Andrew Jones
2019-06-27 17:15 ` Auger Eric
2019-06-28 7:05 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190624160859.GV2790@e103592.cambridge.arm.com \
--to=dave.martin@arm.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=drjones@redhat.com \
--cc=eric.auger@redhat.com \
--cc=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.