Hi, On Mon, Jun 24, 2019 at 03:56:40PM -0600, Rob Herring wrote: > Convert the dlc,dlc0700yzg-1 panel binding to DT schema. > > Cc: Philipp Zabel > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: Maxime Ripard > Cc: Laurent Pinchart > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Rob Herring > --- > .../display/panel/dlc,dlc0700yzg-1.txt | 13 --------- > .../display/panel/dlc,dlc0700yzg-1.yaml | 28 +++++++++++++++++++ > 2 files changed, 28 insertions(+), 13 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.txt > create mode 100644 Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.txt b/Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.txt > deleted file mode 100644 > index bf06bb025b08..000000000000 > --- a/Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.txt > +++ /dev/null > @@ -1,13 +0,0 @@ > -DLC Display Co. DLC0700YZG-1 7.0" WSVGA TFT LCD panel > - > -Required properties: > -- compatible: should be "dlc,dlc0700yzg-1" > -- power-supply: See simple-panel.txt > - > -Optional properties: > -- reset-gpios: See panel-common.txt > -- enable-gpios: See simple-panel.txt > -- backlight: See simple-panel.txt > - > -This binding is compatible with the simple-panel binding, which is specified > -in simple-panel.txt in this directory. > diff --git a/Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml b/Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml > new file mode 100644 > index 000000000000..1b0b63d46f3e > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml > @@ -0,0 +1,28 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/dlc,dlc0700yzg-1.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: DLC Display Co. DLC0700YZG-1 7.0" WSVGA TFT LCD panel > + > +maintainers: > + - Philipp Zabel > + - Thierry Reding > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: dlc,dlc0700yzg-1 > + > + reset-gpios: true > + enable-gpios: true > + backlight: true Do we need to list them? Since we don't have additionalItems, it doesn't really change anything since it will be validated by panel-common. Either way, it should be consistent between your patches, and the previous patches in this series didn't list all the properties in the binding. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com