From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BB5DC48BD5 for ; Tue, 25 Jun 2019 08:00:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4023B20659 for ; Tue, 25 Jun 2019 08:00:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727984AbfFYIAW (ORCPT ); Tue, 25 Jun 2019 04:00:22 -0400 Received: from muru.com ([72.249.23.125]:53494 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726663AbfFYIAW (ORCPT ); Tue, 25 Jun 2019 04:00:22 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id BE11B80C8; Tue, 25 Jun 2019 08:00:44 +0000 (UTC) Date: Tue, 25 Jun 2019 01:00:19 -0700 From: Tony Lindgren To: Johannes Berg Cc: Kalle Valo , Eyal Reizer , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: nl80211 wlcore regression in next Message-ID: <20190625080019.GH5447@atomide.com> References: <20190625073837.GG5447@atomide.com> <2570f4087d6e3356df34635a0380ec8ce06c9159.camel@sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2570f4087d6e3356df34635a0380ec8ce06c9159.camel@sipsolutions.net> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi, * Johannes Berg [190625 07:47]: > On Tue, 2019-06-25 at 00:38 -0700, Tony Lindgren wrote: > > Hi, > > > > Looks like at least drivers/net/wireless/ti wlcore driver has stopped > > working in Linux next with commit 901bb9891855 ("nl80211: require and > > validate vendor command policy"). Reverting the commit above makes it > > work again. > > > > It fails with the warning below, any ideas what goes wrong? > > Oops. For some reason, I neglected to check the vendor command usage > beyond hwsim. > > The patch below should work? Yeah thanks that fixes the issue for me: Tested-by: Tony Lindgren From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: nl80211 wlcore regression in next Date: Tue, 25 Jun 2019 01:00:19 -0700 Message-ID: <20190625080019.GH5447@atomide.com> References: <20190625073837.GG5447@atomide.com> <2570f4087d6e3356df34635a0380ec8ce06c9159.camel@sipsolutions.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <2570f4087d6e3356df34635a0380ec8ce06c9159.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Johannes Berg Cc: Kalle Valo , Eyal Reizer , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-omap@vger.kernel.org Hi, * Johannes Berg [190625 07:47]: > On Tue, 2019-06-25 at 00:38 -0700, Tony Lindgren wrote: > > Hi, > > > > Looks like at least drivers/net/wireless/ti wlcore driver has stopped > > working in Linux next with commit 901bb9891855 ("nl80211: require and > > validate vendor command policy"). Reverting the commit above makes it > > work again. > > > > It fails with the warning below, any ideas what goes wrong? > > Oops. For some reason, I neglected to check the vendor command usage > beyond hwsim. > > The patch below should work? Yeah thanks that fixes the issue for me: Tested-by: Tony Lindgren