All of lore.kernel.org
 help / color / mirror / Atom feed
From: ming.lei@redhat.com (Ming Lei)
Subject: [nvme] Invalid SGL for payload:91648 nents:3
Date: Tue, 25 Jun 2019 21:29:02 +0800	[thread overview]
Message-ID: <20190625132900.GA22428@ming.t460p> (raw)
In-Reply-To: <336692273232ee2441e30e7e2a1c542201854010.camel@rohdewald.de>

On Tue, Jun 25, 2019@02:11:04PM +0200, Wolfgang Rohdewald wrote:
> On Di, 2019-06-25@11:50 +0200, Christoph Hellwig wrote:
> > On Tue, Jun 25, 2019@05:45:35PM +0800, Ming Lei wrote:
> > > On Tue, Jun 25, 2019@06:38:58PM +0900, Keith Busch wrote:
> > > > The first two sg elements should have been merged to one and would have
> > > > avoided the error. The bug is kernel, nothing to do with the device.
> > > 
> > > The default max segment size is 64k, so the first two can't be merged.
> > > 
> > > And the 1st sg should have been dispatched as single request.
> > 
> > Well, that is exactly what I fixed with my patches that went into
> > 5.2.  Looks like we need to backport those as well.
> > 
> > Wolfgang, can you try the latest 5.2-rc git tree?
> 
> 5.2.0-rc6 works fine.
> 
> Do you still want me to apply nvme_dump_rq() to 5.1 for finding the root cause?

Yeah, please dump the request, and maybe there is issue in merge code.
BTW, please replace the trace_printk with printk in the debug patch.

Also not sure if Christoph's patch can be backported safely, given there
is report wrt. too big max segment size recently.

Thanks,
Ming

  reply	other threads:[~2019-06-25 13:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25  7:51 [nvme] Invalid SGL for payload:91648 nents:3 Wolfgang Rohdewald
2019-06-25  9:17 ` Ming Lei
     [not found]   ` <CAOSXXT5PgPJqouD0G7qJjar5tmy-9z+wWdFMqpD2K1=5vQZ+HA@mail.gmail.com>
2019-06-25  9:45     ` Ming Lei
2019-06-25  9:50       ` Christoph Hellwig
2019-06-25 10:07         ` Ming Lei
2019-06-25 12:11         ` Wolfgang Rohdewald
2019-06-25 13:29           ` Ming Lei [this message]
2019-06-25 15:07             ` Wolfgang Rohdewald
2019-06-26  1:26               ` Ming Lei
2019-06-26 20:18                 ` Wolfgang Rohdewald
2019-07-04 12:09                 ` Wolfgang Rohdewald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190625132900.GA22428@ming.t460p \
    --to=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.