From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87A3EC48BD4 for ; Tue, 25 Jun 2019 14:10:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 60DAC215EA for ; Tue, 25 Jun 2019 14:10:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728877AbfFYOKb (ORCPT ); Tue, 25 Jun 2019 10:10:31 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:58235 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727251AbfFYOKb (ORCPT ); Tue, 25 Jun 2019 10:10:31 -0400 X-Originating-IP: 90.88.16.156 Received: from localhost (aaubervilliers-681-1-41-156.w90-88.abo.wanadoo.fr [90.88.16.156]) (Authenticated sender: maxime.ripard@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 6653940003; Tue, 25 Jun 2019 14:10:26 +0000 (UTC) Date: Tue, 25 Jun 2019 16:10:25 +0200 From: Maxime Ripard To: Linus Walleij Cc: Icenowy Zheng , Rob Herring , Chen-Yu Tsai , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , "linux-kernel@vger.kernel.org" , linux-clk , "open list:GPIO SUBSYSTEM" , linux-sunxi Subject: Re: [PATCH v3 1/9] pinctrl: sunxi: v3s: introduce support for V3 Message-ID: <20190625141025.uvewl7arnsz5grr3@flea> References: <20190623043801.14040-1-icenowy@aosc.io> <20190623043801.14040-2-icenowy@aosc.io> <20190624124019.o6acnnkjikekshl5@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uh3numobk6gzuc5u" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org --uh3numobk6gzuc5u Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 25, 2019 at 03:57:15PM +0200, Linus Walleij wrote: > On Mon, Jun 24, 2019 at 2:40 PM Maxime Ripard wrote: > > On Sun, Jun 23, 2019 at 12:37:53PM +0800, Icenowy Zheng wrote: > > > Introduce the GPIO pins that is only available on V3 (not on V3s) to the > > > V3s pinctrl driver. > > > > > > Signed-off-by: Icenowy Zheng > > > --- > > > Changes in v3: > > > - Fixed code alignment. > > > - Fixed LVDS function number. > > > > - SUNXI_FUNCTION(0x2, "uart2"), /* TX */ > > > - SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 0)), /* PB_EINT0 */ > > > + SUNXI_FUNCTION(0x2, "uart2"), /* TX */ > > > + SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 0)), /* PB_EINT0 */ > > > > I'm not sure why all that churn is needed. > > > > Looks good otherwise. > > Should I apply the patch or wait for a new version without the > whitespace fixes? I'd rather not have the indentation changes in that patch. And we've sent the changes for 5.3 already, so it's going to be 5.4 material anyway. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --uh3numobk6gzuc5u Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXRIrUQAKCRDj7w1vZxhR xUx/APwJxRclTo/OlevMmcYPGQ1p1ck7FN1SUXrdShcLFeCyjwD/Y20Bm5HFxJ74 8AikfrRhA+M905RT/a5BkSxvJYhOeg0= =yyVJ -----END PGP SIGNATURE----- --uh3numobk6gzuc5u-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v3 1/9] pinctrl: sunxi: v3s: introduce support for V3 Date: Tue, 25 Jun 2019 16:10:25 +0200 Message-ID: <20190625141025.uvewl7arnsz5grr3@flea> References: <20190623043801.14040-1-icenowy@aosc.io> <20190623043801.14040-2-icenowy@aosc.io> <20190624124019.o6acnnkjikekshl5@flea> Reply-To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uh3numobk6gzuc5u" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Linus Walleij Cc: Icenowy Zheng , Rob Herring , Chen-Yu Tsai , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-clk , "open list:GPIO SUBSYSTEM" , linux-sunxi List-Id: devicetree@vger.kernel.org --uh3numobk6gzuc5u Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline On Tue, Jun 25, 2019 at 03:57:15PM +0200, Linus Walleij wrote: > On Mon, Jun 24, 2019 at 2:40 PM Maxime Ripard wrote: > > On Sun, Jun 23, 2019 at 12:37:53PM +0800, Icenowy Zheng wrote: > > > Introduce the GPIO pins that is only available on V3 (not on V3s) to the > > > V3s pinctrl driver. > > > > > > Signed-off-by: Icenowy Zheng > > > --- > > > Changes in v3: > > > - Fixed code alignment. > > > - Fixed LVDS function number. > > > > - SUNXI_FUNCTION(0x2, "uart2"), /* TX */ > > > - SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 0)), /* PB_EINT0 */ > > > + SUNXI_FUNCTION(0x2, "uart2"), /* TX */ > > > + SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 0)), /* PB_EINT0 */ > > > > I'm not sure why all that churn is needed. > > > > Looks good otherwise. > > Should I apply the patch or wait for a new version without the > whitespace fixes? I'd rather not have the indentation changes in that patch. And we've sent the changes for 5.3 already, so it's going to be 5.4 material anyway. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --uh3numobk6gzuc5u-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BA1FC48BD4 for ; Tue, 25 Jun 2019 14:10:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7A90208E3 for ; Tue, 25 Jun 2019 14:10:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IxNutGlA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7A90208E3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zxcuLGXyRoZSFV1JPzwbyIZI5PMgeyjrw5TTbXXsa0U=; b=IxNutGlAia4JeLTgi3qO6TM1+ Q8Ut2F/DCzK1lmD3EHfO4BIS+Ccgahu39Ol/Yw1+e3UtlZeYBUOuR3n3ZwAcgPeW7tWw9w/vFecON FnOgQ7xQFQuh856IbignYxKII1/pIYMo1efetKpoUu8iWl4ejU/zhK6O6Dn+/PiK0LBfzN/eigMKi a/MI4yTe+V/nFy3DmQkUn44Z2/G8x0AzuRaNclc0U1Tvhp9z1O1YduQ/W9rGOoUj/CBg7ziK2kags 2kGTs9ADwoRhk1415ZX7OXOMLnR7ZY7DDvMWXupf1+AwmdjeLlsIxqYm5Bk2H4HU4ppYVcWjDofU1 dPVQ6++Tg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfm9Z-0002KW-HQ; Tue, 25 Jun 2019 14:10:33 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfm9W-0002Ji-SH for linux-arm-kernel@lists.infradead.org; Tue, 25 Jun 2019 14:10:32 +0000 X-Originating-IP: 90.88.16.156 Received: from localhost (aaubervilliers-681-1-41-156.w90-88.abo.wanadoo.fr [90.88.16.156]) (Authenticated sender: maxime.ripard@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 6653940003; Tue, 25 Jun 2019 14:10:26 +0000 (UTC) Date: Tue, 25 Jun 2019 16:10:25 +0200 From: Maxime Ripard To: Linus Walleij Subject: Re: [PATCH v3 1/9] pinctrl: sunxi: v3s: introduce support for V3 Message-ID: <20190625141025.uvewl7arnsz5grr3@flea> References: <20190623043801.14040-1-icenowy@aosc.io> <20190623043801.14040-2-icenowy@aosc.io> <20190624124019.o6acnnkjikekshl5@flea> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190625_071031_077471_0CC46441 X-CRM114-Status: GOOD ( 15.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-sunxi , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , Chen-Yu Tsai , Rob Herring , linux-clk , Linux ARM , Icenowy Zheng Content-Type: multipart/mixed; boundary="===============4536930674937577109==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4536930674937577109== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uh3numobk6gzuc5u" Content-Disposition: inline --uh3numobk6gzuc5u Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 25, 2019 at 03:57:15PM +0200, Linus Walleij wrote: > On Mon, Jun 24, 2019 at 2:40 PM Maxime Ripard wrote: > > On Sun, Jun 23, 2019 at 12:37:53PM +0800, Icenowy Zheng wrote: > > > Introduce the GPIO pins that is only available on V3 (not on V3s) to the > > > V3s pinctrl driver. > > > > > > Signed-off-by: Icenowy Zheng > > > --- > > > Changes in v3: > > > - Fixed code alignment. > > > - Fixed LVDS function number. > > > > - SUNXI_FUNCTION(0x2, "uart2"), /* TX */ > > > - SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 0)), /* PB_EINT0 */ > > > + SUNXI_FUNCTION(0x2, "uart2"), /* TX */ > > > + SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 0)), /* PB_EINT0 */ > > > > I'm not sure why all that churn is needed. > > > > Looks good otherwise. > > Should I apply the patch or wait for a new version without the > whitespace fixes? I'd rather not have the indentation changes in that patch. And we've sent the changes for 5.3 already, so it's going to be 5.4 material anyway. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --uh3numobk6gzuc5u Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXRIrUQAKCRDj7w1vZxhR xUx/APwJxRclTo/OlevMmcYPGQ1p1ck7FN1SUXrdShcLFeCyjwD/Y20Bm5HFxJ74 8AikfrRhA+M905RT/a5BkSxvJYhOeg0= =yyVJ -----END PGP SIGNATURE----- --uh3numobk6gzuc5u-- --===============4536930674937577109== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4536930674937577109==--