All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] linux/kernel.h: fix overflow for DIV_ROUND_UP_ULL
@ 2019-06-25 10:05 Vinod Koul
  2019-06-25 22:29 ` Andrew Morton
  0 siblings, 1 reply; 4+ messages in thread
From: Vinod Koul @ 2019-06-25 10:05 UTC (permalink / raw)
  To: Andrew Morton
  Cc: linux-arm-msm, Bjorn Andersson, Vinod Koul, Randy Dunlap, linux-kernel

DIV_ROUND_UP_ULL adds the two arguments and then invokes
DIV_ROUND_DOWN_ULL. But on a 32bit system the addition of two 32 bit
values can overflow. DIV_ROUND_DOWN_ULL does it correctly and stashes
the addition into a unsigned long long so cast the result to unsigned
long long here to avoid the overflow condition.

Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 include/linux/kernel.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index 74b1ee9027f5..1214fb48cfc8 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -93,7 +93,8 @@
 #define DIV_ROUND_DOWN_ULL(ll, d) \
 	({ unsigned long long _tmp = (ll); do_div(_tmp, d); _tmp; })
 
-#define DIV_ROUND_UP_ULL(ll, d)		DIV_ROUND_DOWN_ULL((ll) + (d) - 1, (d))
+#define DIV_ROUND_UP_ULL(ll, d) \
+	({ DIV_ROUND_DOWN_ULL((unsigned long long)(ll) + (d) - 1, (d)) })
 
 #if BITS_PER_LONG == 32
 # define DIV_ROUND_UP_SECTOR_T(ll,d) DIV_ROUND_UP_ULL(ll, d)
-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-06-26  3:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-25 10:05 [PATCH] linux/kernel.h: fix overflow for DIV_ROUND_UP_ULL Vinod Koul
2019-06-25 22:29 ` Andrew Morton
2019-06-25 22:32   ` Andrew Morton
2019-06-26  3:55     ` Vinod Koul

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.