From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E096C48BD5 for ; Tue, 25 Jun 2019 22:14:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 19CDB2086D for ; Tue, 25 Jun 2019 22:14:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561500858; bh=ZcG6s2SVVPlQMCLBl239NuNMjuljQYUwEP8YAEKAtsQ=; h=In-Reply-To:References:To:From:Subject:Cc:Date:List-ID:From; b=KgvNkdQM8dXI3HOppqKrW2CXZj3TExsvwXQ3SYx7ly+sCZhblr6C+gQ9WQAYs7L2M wVUAO2kewqR8Zp6757SnjXt4RT9+RrAsJmAOtf1ZmMcm2b01J4dvv52FGa1ZaOvA3u F8D7s3G+EJOUslI4aU1yQfyxvW756GscUgxnhUoI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726675AbfFYWOR (ORCPT ); Tue, 25 Jun 2019 18:14:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:53882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725782AbfFYWOQ (ORCPT ); Tue, 25 Jun 2019 18:14:16 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B0DC22086D; Tue, 25 Jun 2019 22:14:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561500855; bh=ZcG6s2SVVPlQMCLBl239NuNMjuljQYUwEP8YAEKAtsQ=; h=In-Reply-To:References:To:From:Subject:Cc:Date:From; b=Ydzac1ENQGs8JHN5EL5E+CkJH82B6XZ3c9ps/ajN91KLrj3uAj/+VpNZmZCdy27gF j+kmQ0rJLpj2ZbPXomZ68FzknKOIshM5pYbIqyrdhTjjiWWhao81hbRMTErmFENX0n gDVC1TZk2QIFCy7IUZZGjEqeE/telP1NRjhfAJ2M= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1560138293-4163-1-git-send-email-weiyi.lu@mediatek.com> References: <1560138293-4163-1-git-send-email-weiyi.lu@mediatek.com> To: Matthias Brugger , Weiyi Lu From: Stephen Boyd Subject: Re: [RFC v1] clk: core: support clocks that need to be enabled during re-parent Cc: James Liao , Fan Chen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, srv_heupstream@mediatek.com, stable@vger.kernel.org, Weiyi Lu , Biao Huang User-Agent: alot/0.8.1 Date: Tue, 25 Jun 2019 15:14:14 -0700 Message-Id: <20190625221415.B0DC22086D@mail.kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Weiyi Lu (2019-06-09 20:44:53) > When using property assigned-clock-parents to assign parent clocks, > core clocks might still be disabled during re-parent. > Add flag 'CLK_OPS_CORE_ENABLE' for those clocks must be enabled > during re-parent. >=20 > Signed-off-by: Weiyi Lu Can you further describe the scenario where this is a problem? Is it some sort of clk that is enabled by default out of the bootloader and is then configured to have an 'assigned-clock-parents' property to change the parent, but that clk needs to be "enabled" so that the framework turns on the parents for the parent switch? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [RFC v1] clk: core: support clocks that need to be enabled during re-parent Date: Tue, 25 Jun 2019 15:14:14 -0700 Message-ID: <20190625221415.B0DC22086D@mail.kernel.org> References: <1560138293-4163-1-git-send-email-weiyi.lu@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1560138293-4163-1-git-send-email-weiyi.lu@mediatek.com> Sender: stable-owner@vger.kernel.org To: Matthias Brugger Cc: James Liao , Fan Chen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, srv_heupstream@mediatek.com, stable@vger.kernel.org, Weiyi Lu , Biao Huang List-Id: linux-mediatek@lists.infradead.org Quoting Weiyi Lu (2019-06-09 20:44:53) > When using property assigned-clock-parents to assign parent clocks, > core clocks might still be disabled during re-parent. > Add flag 'CLK_OPS_CORE_ENABLE' for those clocks must be enabled > during re-parent. >=20 > Signed-off-by: Weiyi Lu Can you further describe the scenario where this is a problem? Is it some sort of clk that is enabled by default out of the bootloader and is then configured to have an 'assigned-clock-parents' property to change the parent, but that clk needs to be "enabled" so that the framework turns on the parents for the parent switch? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91113C48BD5 for ; Tue, 25 Jun 2019 22:14:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 642C8208CA for ; Tue, 25 Jun 2019 22:14:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Vd/RmYZK"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ydzac1EN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 642C8208CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:From:To: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EHZratylrTfOp7t9l/j37RBKioDfbDhC5Wlv3p6nyE0=; b=Vd/RmYZKAlWLRH Ae+mK+GdgY+tw+ypvqM6aYcXV2LKGsMNlf7+OFX5+z9v8K9lG2nSyPNDreKJVuM7id6BnFZxlUIPq cd/hS5jf9KDBx6EoFBzZ7lmGj8mEnXcTh6+V1eMJLf3Q7HQUbZgtNXQ/Uc/lW1lNr+6C2O/4NM0yc iF8HScpzxMvl1TS2mtIITRUrtbBa6W8iZR/Qz0AsuIiMkjpsABVX88lpTWCQLifZ7A0gu6bNfHLkn uJ+A8+2B41uLTdbe9jOVxSfZefY6j1IGuM0B0ayYiBGOMb8C34brk+MxJss5eVk9gY7uESAthX0ua BX0m5DYLXSfzwvCFTNYQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfthk-0000Sq-GK; Tue, 25 Jun 2019 22:14:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfthg-0000Rs-6o; Tue, 25 Jun 2019 22:14:17 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B0DC22086D; Tue, 25 Jun 2019 22:14:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561500855; bh=ZcG6s2SVVPlQMCLBl239NuNMjuljQYUwEP8YAEKAtsQ=; h=In-Reply-To:References:To:From:Subject:Cc:Date:From; b=Ydzac1ENQGs8JHN5EL5E+CkJH82B6XZ3c9ps/ajN91KLrj3uAj/+VpNZmZCdy27gF j+kmQ0rJLpj2ZbPXomZ68FzknKOIshM5pYbIqyrdhTjjiWWhao81hbRMTErmFENX0n gDVC1TZk2QIFCy7IUZZGjEqeE/telP1NRjhfAJ2M= MIME-Version: 1.0 In-Reply-To: <1560138293-4163-1-git-send-email-weiyi.lu@mediatek.com> References: <1560138293-4163-1-git-send-email-weiyi.lu@mediatek.com> To: Matthias Brugger , Weiyi Lu From: Stephen Boyd Subject: Re: [RFC v1] clk: core: support clocks that need to be enabled during re-parent User-Agent: alot/0.8.1 Date: Tue, 25 Jun 2019 15:14:14 -0700 Message-Id: <20190625221415.B0DC22086D@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190625_151416_266550_6FA05503 X-CRM114-Status: UNSURE ( 8.27 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: James Liao , Weiyi Lu , srv_heupstream@mediatek.com, Biao Huang , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Fan Chen , linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Weiyi Lu (2019-06-09 20:44:53) > When using property assigned-clock-parents to assign parent clocks, > core clocks might still be disabled during re-parent. > Add flag 'CLK_OPS_CORE_ENABLE' for those clocks must be enabled > during re-parent. > > Signed-off-by: Weiyi Lu Can you further describe the scenario where this is a problem? Is it some sort of clk that is enabled by default out of the bootloader and is then configured to have an 'assigned-clock-parents' property to change the parent, but that clk needs to be "enabled" so that the framework turns on the parents for the parent switch? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel