From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 818A1C48BD5 for ; Tue, 25 Jun 2019 22:15:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 546C620883 for ; Tue, 25 Jun 2019 22:15:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561500917; bh=8qTkfS/4sezfPP01RsGhg7FS4aonLn9/wHCnef6132A=; h=In-Reply-To:References:To:From:Subject:Cc:Date:List-ID:From; b=EhighWkyOvYEGIItCVAJu0f0pSr0mILxR6auoZQiJVo5oeZoW3RkwXDYGX3z/08w6 fbHbPpNYgkdUzYzCDPCn/7nF96k3L/Y7TkykNO9dN/UCKyvhJc7MomrX9c1zv7Pwuq JfBE4liYbQkl7ubxjDNuNCTj4kPBYhVQVRXV6yeU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726599AbfFYWPQ (ORCPT ); Tue, 25 Jun 2019 18:15:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:55274 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726329AbfFYWPN (ORCPT ); Tue, 25 Jun 2019 18:15:13 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B691620883; Tue, 25 Jun 2019 22:15:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561500912; bh=8qTkfS/4sezfPP01RsGhg7FS4aonLn9/wHCnef6132A=; h=In-Reply-To:References:To:From:Subject:Cc:Date:From; b=IMLS8thwDC59JuDZtM/8G3qRVOM2sezntC8PHj1xZ0qDsIiNEj84uIQyOEmW2cpW/ HMh1Mjwkz1NCiK5UiJs6gquxhP6o2hX7S6LK0zbxrQU8KMtmWfn+6VxPDogxO4d6qS FIu9kLNyG2yKp/5PnHIt5OVkYflxji5DYbW1kuKI= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1560132969-1960-1-git-send-email-weiyi.lu@mediatek.com> References: <1560132969-1960-1-git-send-email-weiyi.lu@mediatek.com> To: Matthias Brugger , Nicolas Boichat , Rob Herring , Weiyi Lu From: Stephen Boyd Subject: Re: [PATCH v2] clk: mediatek: mt8183: Register 13MHz clock earlier for clocksource Cc: James Liao , Fan Chen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, srv_heupstream@mediatek.com, stable@vger.kernel.org, Weiyi Lu , Dehui Sun User-Agent: alot/0.8.1 Date: Tue, 25 Jun 2019 15:15:12 -0700 Message-Id: <20190625221512.B691620883@mail.kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Weiyi Lu (2019-06-09 19:16:09) > The 13MHz clock should be registered before clocksource driver is > initialized. Use CLK_OF_DECLARE_DRIVER() to guarantee. >=20 > Signed-off-by: Weiyi Lu Do you have a Fixes: tag in mind? Otherwise, the patch looks OK to me. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v2] clk: mediatek: mt8183: Register 13MHz clock earlier for clocksource Date: Tue, 25 Jun 2019 15:15:12 -0700 Message-ID: <20190625221512.B691620883@mail.kernel.org> References: <1560132969-1960-1-git-send-email-weiyi.lu@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1560132969-1960-1-git-send-email-weiyi.lu@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org To: Matthias Brugger , Nicolas Boichat , Rob Herring Cc: James Liao , Fan Chen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, srv_heupstream@mediatek.com, stable@vger.kernel.org, Weiyi Lu , Dehui Sun List-Id: linux-mediatek@lists.infradead.org Quoting Weiyi Lu (2019-06-09 19:16:09) > The 13MHz clock should be registered before clocksource driver is > initialized. Use CLK_OF_DECLARE_DRIVER() to guarantee. >=20 > Signed-off-by: Weiyi Lu Do you have a Fixes: tag in mind? Otherwise, the patch looks OK to me. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9496CC48BD5 for ; Tue, 25 Jun 2019 22:15:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 653AC208CA for ; Tue, 25 Jun 2019 22:15:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UE15O5Wb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="IMLS8thw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 653AC208CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:From:To: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qV3Riz9QvY30XAyi+gfORSwDkUji2qIcWxfgkBJzR7Q=; b=UE15O5WbYm0T59 30UADdfezktjoUbY1GilZHWimpzdl9ZZWgwujaL416YvdILHmal4dA9AZAr2dVxJvx4BucrDISqSh HCEV8PJDuCdinun5zshs2si3jHsAfwGJtpQ82qXRSF9qPjvx0hKe8P5gZWKeaCfwCWCHXUxXNK9oe c8qZYVRosbl7GgIn27Mxh+UxKzTcFyViw/PQrkjBZHUP62ZqjewvAyacYXjDYnWthAbWxm75zPyFz iY/uuF1EJs0rHJ2olKCgxXQy7Txrnhbw1BZIW+kRs0M9b3blwbA8VkO5Qte/67wey+7NBpikINEaD 7hmCL5ZOjJO1oKFH/qMQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hftio-00024Z-9V; Tue, 25 Jun 2019 22:15:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hftib-00020G-8B; Tue, 25 Jun 2019 22:15:16 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B691620883; Tue, 25 Jun 2019 22:15:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561500912; bh=8qTkfS/4sezfPP01RsGhg7FS4aonLn9/wHCnef6132A=; h=In-Reply-To:References:To:From:Subject:Cc:Date:From; b=IMLS8thwDC59JuDZtM/8G3qRVOM2sezntC8PHj1xZ0qDsIiNEj84uIQyOEmW2cpW/ HMh1Mjwkz1NCiK5UiJs6gquxhP6o2hX7S6LK0zbxrQU8KMtmWfn+6VxPDogxO4d6qS FIu9kLNyG2yKp/5PnHIt5OVkYflxji5DYbW1kuKI= MIME-Version: 1.0 In-Reply-To: <1560132969-1960-1-git-send-email-weiyi.lu@mediatek.com> References: <1560132969-1960-1-git-send-email-weiyi.lu@mediatek.com> To: Matthias Brugger , Nicolas Boichat , Rob Herring , Weiyi Lu From: Stephen Boyd Subject: Re: [PATCH v2] clk: mediatek: mt8183: Register 13MHz clock earlier for clocksource User-Agent: alot/0.8.1 Date: Tue, 25 Jun 2019 15:15:12 -0700 Message-Id: <20190625221512.B691620883@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190625_151514_116271_B82377CF X-CRM114-Status: UNSURE ( 6.17 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dehui Sun , James Liao , Weiyi Lu , srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Fan Chen , linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Weiyi Lu (2019-06-09 19:16:09) > The 13MHz clock should be registered before clocksource driver is > initialized. Use CLK_OF_DECLARE_DRIVER() to guarantee. > > Signed-off-by: Weiyi Lu Do you have a Fixes: tag in mind? Otherwise, the patch looks OK to me. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel